Subject: [bug#28594] nototools (required for building Noto from source)

From: ng0 <[email-masked]>
Date: Fri, 13 Oct 2017 08:23:19 +0000

Christopher Baines transcribed 4.7K bytes:
> On Sun, 1 Oct 2017 18:47:37 +0000
> ng0 <[email-masked]> wrote:
> 
> > * gnu/packages/fontutils.scm (nototools): New variable.
> > ---
> >  gnu/packages/fontutils.scm | 44
> > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> > insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> > index 15401f652..ca10c10b0 100644
> > --- a/gnu/packages/fontutils.scm
> > +++ b/gnu/packages/fontutils.scm
> > @@ -5,6 +5,7 @@
> >  ;;; Copyright © 2016, 2017 Efraim Flashner <[email-masked]>
> >  ;;; Copyright © 2017 Rene Saavedra <[email-masked]>
> >  ;;; Copyright © 2017 Leo Famulari <[email-masked]>
> > +;;; Copyright © 2017 ng0 <[email-masked]>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -44,7 +45,8 @@
> >    #:use-module (guix svn-download)
> >    #:use-module (guix git-download)
> >    #:use-module (guix build-system cmake)
> > -  #:use-module (guix build-system gnu))
> > +  #:use-module (guix build-system gnu)
> > +  #:use-module (guix build-system python))
> >  
> >  (define-public freetype
> >    (package
> > @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> > different outline formats, and generate bitmaps.")
> >     (license license:gpl3+)
> >     (home-page "https://fontforge.github.io/en-US/")))
> > +
> > +(define-public nototools
> > +  (package
> > +    (name "nototools")
> > +    (version "20170925")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "https://github.com/googlei18n/nototools/"
> > +                           "archive/v2017-09-25-tooling-for-phase3-"
> > +                           "update.tar.gz"))
> > +       (file-name (string-append name "-" version ".tar.gz"))
> > +       (sha256
> > +        (base32
> > +         "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2))
> > +    (propagated-inputs
> > +     `(("python2-booleanoperations" ,python2-booleanoperations)
> > +       ("python2-defcon" ,python2-defcon)
> > +       ("python2-fonttools" ,python2-fonttools)
> > +       ("python2-pillow" ,python2-pillow)
> > +       ("python2-pyclipper" ,python2-pyclipper)
> > +       ("python2-ufolib" ,python2-ufolib)))
> > +    (home-page "https://github.com/googlei18n/nototools")
> > +    (synopsis "Noto fonts support tools and scripts")
> > +    (description
> > +     "Nototools is a python package containing python scripts used to
> > +maintain the Noto Fonts project.")
> > +    (license (list license:asl2.0
> > +                   ;; Sample texts are attributed to UN and OHCHR.
> > +                   ;; The permissions on the UDHR are pretty lax:
> > +                   ;;
> > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> > +                   ;; "If UDHR translations or materials are
> > reproduced, users
> > +                   ;; should make reference to this website as a
> > source by
> > +                   ;; providing a link."
> > +                   license:public-domain
> > +                   license:non-copyleft
> > "file://sample_texts/attributions.txt"
> > +                   "See sample_texts/attributions.txt in the
> > distribution."))))
> 
> This whole patchset looks pretty good to me. I've built all the
> packages, but haven't tested them.
> 
> guix lint has one complaint here about the license:
> 
> gnu/packages/fontutils.scm:591:13: nototools@20170925: invalid license
> field
> 
> I'm not quite sure what this means.

I think I know it, the non-copyleft needs to be adjusted to the list.
Thanks. I really should run lint for longer patchseries. I admit I do
this not very often.
Thanks for your review.

> I think it would be good to fix at least the linting issues, then this
> can be merged.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org