From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 06:49:16 2017 Received: (at submit) by debbugs.gnu.org; 25 Sep 2017 10:49:16 +0000 Received: from localhost ([127.0.0.1]:57344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwQwu-0006Kw-FB for submit@debbugs.gnu.org; Mon, 25 Sep 2017 06:49:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwQwr-0006Kj-Mn for submit@debbugs.gnu.org; Mon, 25 Sep 2017 06:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwQwh-000788-3y for submit@debbugs.gnu.org; Mon, 25 Sep 2017 06:49:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwQwh-00077y-0V for submit@debbugs.gnu.org; Mon, 25 Sep 2017 06:49:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwQwf-0004ym-SH for guix-patches@gnu.org; Mon, 25 Sep 2017 06:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwQwf-00076e-6O for guix-patches@gnu.org; Mon, 25 Sep 2017 06:49:01 -0400 Received: from serenity.mcc.ac.uk ([130.88.200.93]:16447) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwQwa-00056U-6e; Mon, 25 Sep 2017 06:48:56 -0400 Received: from albion.it.manchester.ac.uk ([130.88.138.79] helo=albion.its.manchester.ac.uk) by serenity.mcc.ac.uk with esmtp (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dwQt8-000I6g-Kg; Mon, 25 Sep 2017 11:45:22 +0100 Received: by albion.its.manchester.ac.uk (Postfix, from userid 1000) id 4B8BD68CE; Mon, 25 Sep 2017 11:45:01 +0100 (BST) From: Dave Love To: guix-patches@gnu.org Subject: [PATCH] gnu: openfoam: Clean up to reduce closure. Date: Mon, 25 Sep 2017 11:44:59 +0100 Message-Id: <20170925104459.17798-1-fx@gnu.org> X-Mailer: git-send-email 2.11.0 X-SA-Exim-Connect-IP: 130.88.138.79 X-SA-Exim-Mail-From: mdehsdl3@ds.man.ac.uk X-SA-Exim-Scanned: No (on serenity.mcc.ac.uk); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Dave Love X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This saves ~1GB. * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. [arguments]: Clean up .o and src after build. --- gnu/packages/simulation.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm index de07b6844..fef80a1ac 100644 --- a/gnu/packages/simulation.scm +++ b/gnu/packages/simulation.scm @@ -84,6 +84,10 @@ `(("gzip" ,gzip) ("gnuplot" ,gnuplot) ("openmpi" ,openmpi))) + ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc + ;; (8MB) + (outputs '("debug" ;~60MB + "out")) (arguments `( ;; Executable files and shared libraries are located in the 'platforms' ;; subdirectory. @@ -171,6 +175,15 @@ (("lockDir=.*$") "lockDir=$HOME/.$WM_PROJECT/.wmake\n")) #t)) + (add-after 'build 'cleanup + ;; Avoid lots of junk installed + (lambda _ + (delete-file-recursively + "platforms/linux64GccDPInt32Opt/src") + (delete-file-recursively + "platforms/linux64GccDPInt32OptSYSTEMOPENMPI/src") + (zero? + (system* "find" "-name" "*.o" "-delete")))) (replace 'install (lambda _ ;; use 'OpenFOAM-version' convention -- 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 08:52:52 2017 Received: (at 28593) by debbugs.gnu.org; 25 Sep 2017 12:52:52 +0000 Received: from localhost ([127.0.0.1]:57468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwSsW-0002gm-1E for submit@debbugs.gnu.org; Mon, 25 Sep 2017 08:52:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwSsU-0002gW-VS for 28593@debbugs.gnu.org; Mon, 25 Sep 2017 08:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwSsL-0000NA-Pb for 28593@debbugs.gnu.org; Mon, 25 Sep 2017 08:52:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwSsA-0000I4-Gi; Mon, 25 Sep 2017 08:52:30 -0400 Received: from [193.50.110.164] (port=43890 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dwSs9-0005Fu-V9; Mon, 25 Sep 2017 08:52:30 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Sep 2017 14:52:28 +0200 In-Reply-To: <20170925104459.17798-1-fx@gnu.org> (Dave Love's message of "Mon, 25 Sep 2017 11:44:59 +0100") Message-ID: <87fubbj5yr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Dave, Dave Love skribis: > This saves ~1GB. > > * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. > [arguments]: Clean up .o and src after build. [...] > gnu/packages/simulation.scm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm > index de07b6844..fef80a1ac 100644 > --- a/gnu/packages/simulation.scm > +++ b/gnu/packages/simulation.scm > @@ -84,6 +84,10 @@ > `(("gzip" ,gzip) > ("gnuplot" ,gnuplot) > ("openmpi" ,openmpi))) > + ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also = doc > + ;; (8MB) > + (outputs '("debug" ;~60MB > + "out")) Normally the =E2=80=98strip=E2=80=99 phase would strip things. I guess the= problem here is that libraries are not in lib/, so nothing gets stripped. This would be worked around by simply passing something like: #:strip-directories '("OpenFOAM-1.2.3/lib") > + (add-after 'build 'cleanup > + ;; Avoid lots of junk installed > + (lambda _ > + (delete-file-recursively > + "platforms/linux64GccDPInt32Opt/src") > + (delete-file-recursively > + "platforms/linux64GccDPInt32OptSYSTEMOPENMPI/src") > + (zero? > + (system* "find" "-name" "*.o" "-delete")))) Rather: (for-each delete-file (find-files "." "\\.o$")) Paul can you confirm that this is OK? If it is, could you update the patch accordingly, Dave? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 07:40:46 2017 Received: (at 28593) by debbugs.gnu.org; 26 Sep 2017 11:40:46 +0000 Received: from localhost ([127.0.0.1]:59787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwoEI-0002wc-CC for submit@debbugs.gnu.org; Tue, 26 Sep 2017 07:40:46 -0400 Received: from smtp.hosts.co.uk ([85.233.160.19]:48336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwoEG-0002wO-O5 for 28593@debbugs.gnu.org; Tue, 26 Sep 2017 07:40:45 -0400 Received: from [79.123.23.187] (helo=pancake.local) by smtp.hosts.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim) (envelope-from ) id 1dwoEA-0000Zt-8H; Tue, 26 Sep 2017 12:40:39 +0100 Message-ID: <1506426036.2423.32.camel@tourbillion-technology.com> Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. From: Paul Garlick To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Dave Love Date: Tue, 26 Sep 2017 12:40:36 +0100 In-Reply-To: <87fubbj5yr.fsf@gnu.org> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Dave and Ludo, Thank you Dave for your helpful suggestions on the OpenFOAM package definition. Firstly, on the question of adding a debug output, I have checked the effect of the current '#:strip-directories' keyword definition.  In the build log: stripping binaries in "/gnu/store/4zqn4w0wlq0irdwh3dhrdbsr7i3f1dag- openfoam-4.1/lib/OpenFOAM-4.1/platforms/linux64GccDPInt32Opt/bin" with "strip" and flags ("--strip-debug" "--enable-deterministic-archives") stripping binaries in "/gnu/store/4zqn4w0wlq0irdwh3dhrdbsr7i3f1dag- openfoam-4.1/lib/OpenFOAM-4.1/platforms/linux64GccDPInt32Opt/lib" with "strip" and flags ("--strip-debug" "--enable-deterministic-archives") This suggests that the binaries in .../bin and .../lib are being stripped.  However, if I check a randomly-selected executable in the bin directory: $ objdump --syms /home/paul/.guix-profile/lib/OpenFOAM- 4.1/platforms/linux64GccDPInt32Opt/bin/blockMesh | grep debug 0000000000000000       O *UND* 0000000000000000              _ZN 4Foam8fileName5debugE 0000000000000000       O *UND* 0000000000000000              _ZN 4Foam4word5debugE The 'file' command also reports that the executables and shared objects are 'not stripped'.  Does adding a debug output achieve the effect of stripping the binaries?  > > Normally the ‘strip’ phase would strip things.  I guess the problem > here > is that libraries are not in lib/, so nothing gets stripped.  This > would > be worked around by simply passing something like: > >   #:strip-directories '("OpenFOAM-1.2.3/lib") Would that not give a 'directory not found' message?  Currently, #:strip-directories (list (string-append                                   "lib/OpenFOAM-" ,version                                   "/platforms/linux64GccDPInt32Opt/bin" )                                  (string-append                                   "lib/OpenFOAM-" ,version                                   "/platforms/linux64GccDPInt32Opt/lib" )) > > > > +                  (add-after 'build 'cleanup > > +                    ;; Avoid lots of junk installed > > +                    (lambda _ > > +                      (delete-file-recursively > > +                       "platforms/linux64GccDPInt32Opt/src") > > +                      (delete-file-recursively > > +                       "platforms/linux64GccDPInt32OptSYSTEMOPENMP > > I/src") > > +                      (zero? > > +                       (system* "find" "-name" "*.o" "-delete")))) > Rather: > >   (for-each delete-file (find-files "." "\\.o$")) > > Paul can you confirm that this is OK? > Maybe.  We need to be careful that we not delete files which are needed later on.  Typically, a user will copy part of the directory structure to a subdirectory of $HOME and compile a new solver.  The OpenFOAM 'wmake' utility takes care of the dependencies and re-compiles object files as needed.   So, object files under 'platforms/linux64GccDPInt32Opt/src' should be safe to delete.  However, this needs to be checked to make sure no dependencies are deleted that cannot easily be re-compiled.  Have you already checked this Dave by, for example, re-compiling a standard solver? Paul. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 08:08:35 2017 Received: (at 28593) by debbugs.gnu.org; 26 Sep 2017 12:08:35 +0000 Received: from localhost ([127.0.0.1]:59819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwofD-0003a6-Dh for submit@debbugs.gnu.org; Tue, 26 Sep 2017 08:08:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwofC-0003Zt-2J for 28593@debbugs.gnu.org; Tue, 26 Sep 2017 08:08:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwof0-0007fv-8k for 28593@debbugs.gnu.org; Tue, 26 Sep 2017 08:08:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwoet-0007cN-NW; Tue, 26 Sep 2017 08:08:15 -0400 Received: from [193.50.110.164] (port=40696 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dwoet-0000aM-5W; Tue, 26 Sep 2017 08:08:15 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 26 Sep 2017 14:08:13 +0200 In-Reply-To: <1506426036.2423.32.camel@tourbillion-technology.com> (Paul Garlick's message of "Tue, 26 Sep 2017 12:40:36 +0100") Message-ID: <873779hdci.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Dave Love X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) SGkgUGF1bCwNCg0KUGF1bCBHYXJsaWNrIDxwZ2FybGlja0B0b3VyYmlsbGlvbi10ZWNobm9sb2d5 LmNvbT4gc2tyaWJpczoNCg0KPiBUaGUgJ2ZpbGUnIGNvbW1hbmQgYWxzbyByZXBvcnRzIHRoYXQg dGhlIGV4ZWN1dGFibGVzIGFuZCBzaGFyZWQgb2JqZWN0cw0KPiBhcmUgJ25vdCBzdHJpcHBlZCcu DQoNClRoYXTigJlzIGJlY2F1c2Ugd2UgdXNlIOKAmC0tc3RyaXAtZGVidWfigJkgYW5kIG5vdCDi gJgtLXN0cmlwLWFsbOKAmSAoaW4gc29tZQ0KY2FzZXMsIHRoZSBsYXR0ZXIgYnJlYWtzIGJpbmFy aWVzIGluIHdlaXJkIHdheXMsIGhlbmNlIHRoZSBjb25zZXJ2YXRpdmUNCmNob2ljZS4pDQoNCkhv d2V2ZXIsIHlvdSBjYW4gc2VlIGluIHRoZSBsaXN0IG9mIEVMRiBzZWN0aW9ucyByZXBvcnRlZCBi eSDigJxvYmpkdW1wDQoteOKAnSB0aGF0IHRoZXJl4oCZcyBubyAuZGVidWcqIHNlY3Rpb27igJRp LmUuLCBiaW5hcmllcyBjb250YWluIHRoZSBzeW1ib2wNCnRhYmxlLCBidXQgbm90IERXQVJGIGRl YnVnZ2luZyBpbmZvLCB3aGljaCBpcyBmYXIgbGFyZ2VyLg0KDQo+IMKgRG9lcyBhZGRpbmcgYSBk ZWJ1ZyBvdXRwdXQgYWNoaWV2ZSB0aGUgZWZmZWN0IG9mIHN0cmlwcGluZyB0aGUNCj4gYmluYXJp ZXM/wqANCg0KSSBkb27igJl0IHRoaW5rIGl0IG1ha2VzIGFueSBkaWZmZXJlbmNlLg0KDQo+PiBO b3JtYWxseSB0aGUg4oCYc3RyaXDigJkgcGhhc2Ugd291bGQgc3RyaXAgdGhpbmdzLsKgwqBJIGd1 ZXNzIHRoZSBwcm9ibGVtDQo+PiBoZXJlDQo+PiBpcyB0aGF0IGxpYnJhcmllcyBhcmUgbm90IGlu IGxpYi8sIHNvIG5vdGhpbmcgZ2V0cyBzdHJpcHBlZC7CoMKgVGhpcw0KPj4gd291bGQNCj4+IGJl IHdvcmtlZCBhcm91bmQgYnkgc2ltcGx5IHBhc3Npbmcgc29tZXRoaW5nIGxpa2U6DQo+PiANCj4+ IMKgICM6c3RyaXAtZGlyZWN0b3JpZXMgJygiT3BlbkZPQU0tMS4yLjMvbGliIikNCj4NCj4gV291 bGQgdGhhdCBub3QgZ2l2ZSBhICdkaXJlY3Rvcnkgbm90IGZvdW5kJyBtZXNzYWdlPyDCoEN1cnJl bnRseSwNCj4NCj4gIzpzdHJpcC1kaXJlY3RvcmllcyAobGlzdCAoc3RyaW5nLWFwcGVuZA0KPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCJsaWIvT3BlbkZPQU0tIiAsdmVyc2lvbg0KPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCIvcGxhdGZv cm1zL2xpbnV4NjRHY2NEUEludDMyT3B0L2JpbiINCj4gKQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAoc3RyaW5nLWFw cGVuZA0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCJsaWIvT3BlbkZPQU0tIiAsdmVyc2lvbg0KPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCIvcGxhdGZvcm1zL2xpbnV4NjRHY2NEUEludDMyT3B0L2xpYiINCj4gKSkNCg0KT2ggc29ycnks IEkgaGFkIGZvcmdvdHRlbiB3ZSBhbHJlYWR5IGhhZCB0aGlzLiAgVGhpcyBpcyBwZXJmZWN0IQ0K DQo+PiBSYXRoZXI6DQo+PiANCj4+IMKgIChmb3ItZWFjaCBkZWxldGUtZmlsZSAoZmluZC1maWxl cyAiLiIgIlxcLm8kIikpDQo+PiANCj4+IFBhdWwgY2FuIHlvdSBjb25maXJtIHRoYXQgdGhpcyBp cyBPSz8NCj4+IA0KPg0KPiBNYXliZS4gwqBXZSBuZWVkIHRvIGJlIGNhcmVmdWwgdGhhdCB3ZSBu b3QgZGVsZXRlIGZpbGVzIHdoaWNoIGFyZSBuZWVkZWQNCj4gbGF0ZXIgb24uIMKgVHlwaWNhbGx5 LCBhIHVzZXIgd2lsbCBjb3B5IHBhcnQgb2YgdGhlIGRpcmVjdG9yeSBzdHJ1Y3R1cmUNCj4gdG8g YSBzdWJkaXJlY3Rvcnkgb2YgJEhPTUUgYW5kIGNvbXBpbGUgYSBuZXcgc29sdmVyLiDCoFRoZSBP cGVuRk9BTQ0KPiAnd21ha2UnIHV0aWxpdHkgdGFrZXMgY2FyZSBvZiB0aGUgZGVwZW5kZW5jaWVz IGFuZCByZS1jb21waWxlcyBvYmplY3QNCj4gZmlsZXMgYXMgbmVlZGVkLiDCoA0KPg0KPiBTbywg b2JqZWN0IGZpbGVzIHVuZGVyICdwbGF0Zm9ybXMvbGludXg2NEdjY0RQSW50MzJPcHQvc3JjJyBz aG91bGQgYmUNCj4gc2FmZSB0byBkZWxldGUuIMKgSG93ZXZlciwgdGhpcyBuZWVkcyB0byBiZSBj aGVja2VkIHRvIG1ha2Ugc3VyZSBubw0KPiBkZXBlbmRlbmNpZXMgYXJlIGRlbGV0ZWQgdGhhdCBj YW5ub3QgZWFzaWx5IGJlIHJlLWNvbXBpbGVkLiDCoEhhdmUgeW91DQo+IGFscmVhZHkgY2hlY2tl ZCB0aGlzIERhdmUgYnksIGZvciBleGFtcGxlLCByZS1jb21waWxpbmcgYSBzdGFuZGFyZA0KPiBz b2x2ZXI/DQoNCkkgbGV0IERhdmUgYW5zd2VyIG9uIHRoaXMgcGFydC4NCg0KVGhhbmtzLA0KTHVk b+KAmS4NCg== From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 17:25:16 2017 Received: (at 28593) by debbugs.gnu.org; 27 Sep 2017 21:25:16 +0000 Received: from localhost ([127.0.0.1]:35497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxJpP-0002sW-UY for submit@debbugs.gnu.org; Wed, 27 Sep 2017 17:25:16 -0400 Received: from clarity.mcc.ac.uk ([130.88.200.144]:27761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxJpJ-0002sG-02 for 28593@debbugs.gnu.org; Wed, 27 Sep 2017 17:25:10 -0400 Received: from asmtp1.its.manchester.ac.uk ([130.88.13.149]) by clarity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dxJpH-000B8A-G6; Wed, 27 Sep 2017 22:25:03 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:57238) by asmtp1.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dxJpH-0000lN-3F; Wed, 27 Sep 2017 22:25:03 +0100 From: Dave Love To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> X-Draft-From: ("Misc" 3095) Date: Wed, 27 Sep 2017 22:25:02 +0100 In-Reply-To: <1506426036.2423.32.camel@tourbillion-technology.com> (Paul Garlick's message of "Tue, 26 Sep 2017 12:40:36 +0100") Message-ID: <87ing3sukx.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:57238 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.149 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on clarity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Ludovic =?iso-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Paul Garlick writes: > This suggests that the binaries in .../bin and .../lib are being > stripped. =A0However, if I check a randomly-selected executable in the > bin directory: > > $ objdump --syms /home/paul/.guix-profile/lib/OpenFOAM- > 4.1/platforms/linux64GccDPInt32Opt/bin/blockMesh | grep debug > > 0000000000000000=A0=A0=A0=A0=A0=A0=A0O *UND* 0000000000000000=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0_ZN > 4Foam8fileName5debugE > 0000000000000000=A0=A0=A0=A0=A0=A0=A0O *UND* 0000000000000000=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0_ZN > 4Foam4word5debugE > > The 'file' command also reports that the executables and shared objects > are 'not stripped'. =A0Does adding a debug output achieve the effect of > stripping the binaries?=A0 That was confusing me too, and I was going to ask about it... >> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0(ze= ro? >> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= (system* "find" "-name" "*.o" "-delete")))) >> Rather: >>=20 >> =A0 (for-each delete-file (find-files "." "\\.o$")) I don't understand the need to avoid system(*), but I assumed the optimizations in find make it significantly faster then find-files -- is that not true? (Dealing with the file structure in openfoam is horribly slow when I've done builds on the NFS filesystems.) > Maybe. =A0We need to be careful that we not delete files which are needed > later on. =A0Typically, a user will copy part of the directory structure > to a subdirectory of $HOME and compile a new solver. =A0The OpenFOAM > 'wmake' utility takes care of the dependencies and re-compiles object > files as needed. =A0 > > So, object files under 'platforms/linux64GccDPInt32Opt/src' should be > safe to delete. =A0However, this needs to be checked to make sure no > dependencies are deleted that cannot easily be re-compiled. =A0Have you > already checked this Dave by, for example, re-compiling a standard > solver? > > Paul. Not in this case, but people have been using my rpm version in anger, though it's an earlier version. (I was looking at this partly to help updating the rpm.) I'd have expected to have to regenerate the dependency files when modifying the source. [I wish openfoam had a sane build system, even one that stopped on an error, sigh. Actually, it might be worth patching that, like the rpm -- I've several times missed components not being built -- assuming that hasn't changed.] From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 17:30:44 2017 Received: (at 28593) by debbugs.gnu.org; 27 Sep 2017 21:30:44 +0000 Received: from localhost ([127.0.0.1]:35508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxJum-0003my-Hd for submit@debbugs.gnu.org; Wed, 27 Sep 2017 17:30:44 -0400 Received: from probity.mcc.ac.uk ([130.88.200.94]:28722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxJul-0003kd-4I for 28593@debbugs.gnu.org; Wed, 27 Sep 2017 17:30:43 -0400 Received: from asmtp1.its.manchester.ac.uk ([130.88.13.149]) by probity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dxJuj-0004i8-5k; Wed, 27 Sep 2017 22:30:41 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:57248) by asmtp1.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dxJui-0000pm-TT; Wed, 27 Sep 2017 22:30:40 +0100 From: Dave Love To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> X-Draft-From: ("Misc" 3096) Date: Wed, 27 Sep 2017 22:30:40 +0100 In-Reply-To: <873779hdci.fsf@gnu.org> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Tue, 26 Sep 2017 14:08:13 +0200") Message-ID: <87efqrsubj.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:57248 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.149 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on probity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Ludovic Court=C3=A8s writes: > That=E2=80=99s because we use =E2=80=98--strip-debug=E2=80=99 and not =E2= =80=98--strip-all=E2=80=99 (in some > cases, the latter breaks binaries in weird ways, hence the conservative > choice.) Is that something Guix-specific? As far as I know, with rpm and dpkg, the binaries are always stripped, and I'm not aware of any problem with that. >> =C2=A0Does adding a debug output achieve the effect of stripping the >> binaries?=C2=A0 > > I don=E2=80=99t think it makes any difference. Right. Incidentally, you could save about half the size of the boost contribution to closures like this by separating the headers and the libraries, but there was some problem I don;t remember when I tried. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 04:37:15 2017 Received: (at 28593) by debbugs.gnu.org; 28 Sep 2017 08:37:15 +0000 Received: from localhost ([127.0.0.1]:35908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxUJm-0005A4-R6 for submit@debbugs.gnu.org; Thu, 28 Sep 2017 04:37:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxUJl-00059p-4Q for 28593@debbugs.gnu.org; Thu, 28 Sep 2017 04:37:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxUJe-0001vB-QA for 28593@debbugs.gnu.org; Thu, 28 Sep 2017 04:37:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxUJX-0001sj-9C; Thu, 28 Sep 2017 04:36:59 -0400 Received: from [193.50.110.164] (port=43002 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dxUJW-0004xL-Bx; Thu, 28 Sep 2017 04:36:58 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87efqrsubj.fsf@albion.it.manchester.ac.uk> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Sep 2017 10:36:56 +0200 In-Reply-To: <87efqrsubj.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Wed, 27 Sep 2017 22:30:40 +0100") Message-ID: <87lgkzz0bb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Dave Love skribis: > Ludovic Court=C3=A8s writes: > >> That=E2=80=99s because we use =E2=80=98--strip-debug=E2=80=99 and not = =E2=80=98--strip-all=E2=80=99 (in some >> cases, the latter breaks binaries in weird ways, hence the conservative >> choice.) > > Is that something Guix-specific? As far as I know, with rpm and dpkg, > the binaries are always stripped, and I'm not aware of any problem with > that. I=E2=80=99m pretty sure I tried to default to =E2=80=9C--strip-all=E2=80=9D= instead of =E2=80=9C--strip-debug=E2=80=9D and that some packages had problems with th= at, I forgot what it was. Perhaps we should try to revisit this. >>> =C2=A0Does adding a debug output achieve the effect of stripping the >>> binaries?=C2=A0 >> >> I don=E2=80=99t think it makes any difference. > > Right. > > Incidentally, you could save about half the size of the boost > contribution to closures like this by separating the headers and the > libraries, but there was some problem I don;t remember when I tried. Too bad you don=E2=80=99t remember, it would be worth looking into that. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 16:42:04 2017 Received: (at 28593) by debbugs.gnu.org; 2 Oct 2017 20:42:04 +0000 Received: from localhost ([127.0.0.1]:44595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dz7XQ-0005f6-EZ for submit@debbugs.gnu.org; Mon, 02 Oct 2017 16:42:04 -0400 Received: from serenity.mcc.ac.uk ([130.88.200.93]:14970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dz7XN-0005ed-VI for 28593@debbugs.gnu.org; Mon, 02 Oct 2017 16:42:02 -0400 Received: from asmtp1.its.manchester.ac.uk ([130.88.13.149]) by serenity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dz7XM-0009GB-1O; Mon, 02 Oct 2017 21:42:00 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:42994) by asmtp1.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dz7XL-0005ZJ-PV; Mon, 02 Oct 2017 21:41:59 +0100 From: Dave Love To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87efqrsubj.fsf@albion.it.manchester.ac.uk> <87lgkzz0bb.fsf@gnu.org> X-Draft-From: ("Misc" 3120) Date: Mon, 02 Oct 2017 21:41:59 +0100 In-Reply-To: <87lgkzz0bb.fsf@gnu.org> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Thu, 28 Sep 2017 10:36:56 +0200") Message-ID: <87fub1ffjc.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:42994 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.149 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on serenity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Ludovic Court=C3=A8s writes: > Dave Love skribis: > >> Ludovic Court=C3=A8s writes: >> >>> That=E2=80=99s because we use =E2=80=98--strip-debug=E2=80=99 and not = =E2=80=98--strip-all=E2=80=99 (in some >>> cases, the latter breaks binaries in weird ways, hence the conservative >>> choice.) >> >> Is that something Guix-specific? As far as I know, with rpm and dpkg, >> the binaries are always stripped, and I'm not aware of any problem with >> that. > > I=E2=80=99m pretty sure I tried to default to =E2=80=9C--strip-all=E2=80= =9D instead of > =E2=80=9C--strip-debug=E2=80=9D and that some packages had problems with = that, I forgot > what it was. > > Perhaps we should try to revisit this. It seems worth trying. By the way, I originally thought that debug info was left in the binaries and a debug package separated it. I think it's unfortunate not to have debug info available (the GNU build default). It presumably should be available for something like openfoam, for people to build parts of, anyhow. >> Incidentally, you could save about half the size of the boost >> contribution to closures like this by separating the headers and the >> libraries, but there was some problem I don;t remember when I tried. > > Too bad you don=E2=80=99t remember, it would be worth looking into that. > > Ludo=E2=80=99. It's easy (but not fast) to try again. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 08:34:26 2017 Received: (at 28593) by debbugs.gnu.org; 3 Oct 2017 12:34:26 +0000 Received: from localhost ([127.0.0.1]:45375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMOx-000859-Vs for submit@debbugs.gnu.org; Tue, 03 Oct 2017 08:34:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMOw-00084u-Dx for 28593@debbugs.gnu.org; Tue, 03 Oct 2017 08:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzMOl-0000wM-Nb for 28593@debbugs.gnu.org; Tue, 03 Oct 2017 08:34:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzMOc-0000qQ-0H; Tue, 03 Oct 2017 08:33:58 -0400 Received: from [193.50.110.164] (port=35982 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzMOb-0002XZ-9g; Tue, 03 Oct 2017 08:33:57 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87efqrsubj.fsf@albion.it.manchester.ac.uk> <87lgkzz0bb.fsf@gnu.org> <87fub1ffjc.fsf@albion.it.manchester.ac.uk> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 03 Oct 2017 14:33:55 +0200 In-Reply-To: <87fub1ffjc.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Mon, 02 Oct 2017 21:41:59 +0100") Message-ID: <87shf08l70.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Dave Love skribis: > Ludovic Court=C3=A8s writes: > >> Dave Love skribis: >> >>> Ludovic Court=C3=A8s writes: >>> >>>> That=E2=80=99s because we use =E2=80=98--strip-debug=E2=80=99 and not = =E2=80=98--strip-all=E2=80=99 (in some >>>> cases, the latter breaks binaries in weird ways, hence the conservative >>>> choice.) >>> >>> Is that something Guix-specific? As far as I know, with rpm and dpkg, >>> the binaries are always stripped, and I'm not aware of any problem with >>> that. >> >> I=E2=80=99m pretty sure I tried to default to =E2=80=9C--strip-all=E2=80= =9D instead of >> =E2=80=9C--strip-debug=E2=80=9D and that some packages had problems with= that, I forgot >> what it was. >> >> Perhaps we should try to revisit this. > > It seems worth trying. I take it that you=E2=80=99re volunteering? :-) The change is a simple one-liner, but making sure that nothing breaks of course takes more time (mostly CPU time!). > By the way, I originally thought that debug info was left in the > binaries and a debug package separated it. I think it's unfortunate not > to have debug info available (the GNU build default). It presumably > should be available for something like openfoam, for people to build > parts of, anyhow. Quoth : The =E2=80=98debug=E2=80=99 output mechanism in Guix is implemented by= the =E2=80=98gnu-build-system=E2=80=99 (*note Build Systems::). Currently, i= t is opt-in=E2=80=94debugging information is available only for the packages w= ith definitions explicitly declaring a =E2=80=98debug=E2=80=99 output. This = may be changed to opt-out in the future if our build farm servers can handle the load. To check whether a package has a =E2=80=98debug=E2=80=99 output, use =E2= =80=98guix package --list-available=E2=80=99 (*note Invoking guix package::). It=E2=80=99s mostly a matter of disk space and bandwidth. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 16:45:52 2017 Received: (at 28593) by debbugs.gnu.org; 7 Oct 2017 20:45:52 +0000 Received: from localhost ([127.0.0.1]:55101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0vyq-00042W-8F for submit@debbugs.gnu.org; Sat, 07 Oct 2017 16:45:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0vyo-0003uo-Sw for 28593@debbugs.gnu.org; Sat, 07 Oct 2017 16:45:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0vyj-0004kq-3b for 28593@debbugs.gnu.org; Sat, 07 Oct 2017 16:45:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0vyf-0004ji-8l; Sat, 07 Oct 2017 16:45:41 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=33114 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e0vye-0004CX-HQ; Sat, 07 Oct 2017 16:45:40 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> Date: Sat, 07 Oct 2017 22:45:38 +0200 In-Reply-To: <873779hdci.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 26 Sep 2017 14:08:13 +0200") Message-ID: <87o9piit59.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Dave Love X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Paul Garlick skribis: [...] >>> Rather: >>>=20 >>> =C2=A0 (for-each delete-file (find-files "." "\\.o$")) >>>=20 >>> Paul can you confirm that this is OK? >>>=20 >> >> Maybe. =C2=A0We need to be careful that we not delete files which are ne= eded >> later on. =C2=A0Typically, a user will copy part of the directory struct= ure >> to a subdirectory of $HOME and compile a new solver. =C2=A0The OpenFOAM >> 'wmake' utility takes care of the dependencies and re-compiles object >> files as needed. =C2=A0 >> >> So, object files under 'platforms/linux64GccDPInt32Opt/src' should be >> safe to delete. =C2=A0However, this needs to be checked to make sure no >> dependencies are deleted that cannot easily be re-compiled. =C2=A0Have y= ou >> already checked this Dave by, for example, re-compiling a standard >> solver? > > I let Dave answer on this part. I think we got sidetracked by the discussion about debugging info. Paul, Dave: what do we do this patch? https://bugs.gnu.org/28593 TIA, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 07:06:17 2017 Received: (at 28593) by debbugs.gnu.org; 9 Oct 2017 11:06:17 +0000 Received: from localhost ([127.0.0.1]:57190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1Vt2-0003bo-Uk for submit@debbugs.gnu.org; Mon, 09 Oct 2017 07:06:17 -0400 Received: from smtp.hosts.co.uk ([85.233.160.19]:19960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1Vt1-0003bb-SJ for 28593@debbugs.gnu.org; Mon, 09 Oct 2017 07:06:16 -0400 Received: from [79.123.23.187] (helo=pancake.local) by smtp.hosts.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim) (envelope-from ) id 1e1Vsv-0002vO-8Y; Mon, 09 Oct 2017 12:06:10 +0100 Message-ID: <1507547167.17241.18.camel@tourbillion-technology.com> Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. From: Paul Garlick To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Mon, 09 Oct 2017 12:06:07 +0100 In-Reply-To: <87o9piit59.fsf@gnu.org> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Dave Love X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo and Dave, > Paul, Dave: what do we do this patch? > >   https://bugs.gnu.org/28593 > To recap on my comments on the patch: i) a debug output would be fine; possibly with an extra comment for OpenFOAM users to say what it can be used for ii) deleting object files, to save disk space, under 'platforms/linux64GccDPInt32Opt/src' should also be fine, with the proviso that the re-compilation process should be checked before committing.  There is an example procedure, albeit for an earlier version, given at https://openfoamwiki.net/index.php/How_to_add_tempera ture_to_icoFoam .  A slightly modified procedure should work for version 4.1. Dave, can you try this on your patched version?  'wmake' should re- generate the object files that are needed and produce a new executable.  Check that there are no instances of errors such as 'file not found' iii) substitute a more descriptive word than 'junk' for the object files; 'intermediate' or some such iv) the source files take up much less space than the object files.  I wouldn't worry about deleting them. Best regards, Paul. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 07:06:14 2017 Received: (at 28593) by debbugs.gnu.org; 19 Oct 2017 11:06:14 +0000 Received: from localhost ([127.0.0.1]:49200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e58eT-0001RD-Rb for submit@debbugs.gnu.org; Thu, 19 Oct 2017 07:06:14 -0400 Received: from tranquility.mcc.ac.uk ([130.88.200.145]:50350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e58eR-0001R4-6Z for 28593@debbugs.gnu.org; Thu, 19 Oct 2017 07:06:11 -0400 Received: from asmtp2.its.manchester.ac.uk ([130.88.13.150]) by tranquility.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1e58eP-000IB4-DS; Thu, 19 Oct 2017 12:06:09 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:55156) by asmtp2.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1e58eP-0008EY-15; Thu, 19 Oct 2017 12:06:09 +0100 From: Dave Love To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> X-Draft-From: ("Misc" 3325) Date: Thu, 19 Oct 2017 12:06:08 +0100 In-Reply-To: <1507547167.17241.18.camel@tourbillion-technology.com> (Paul Garlick's message of "Mon, 9 Oct 2017 12:06:07 +0100") Message-ID: <87o9p3mm73.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:55156 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.150 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on tranquility.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Ludovic =?iso-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Paul Garlick writes: > ii) deleting object files, to save disk space, under > 'platforms/linux64GccDPInt32Opt/src' should also be fine, with the > proviso that the re-compilation process should be checked before > committing. =A0There is an example procedure, albeit for an earlier > version, given at=A0https://openfoamwiki.net/index.php/How_to_add_tempera > ture_to_icoFoam=A0. =A0A slightly modified procedure should work for > version 4.1. > > Dave, can you try this on your patched version? =A0'wmake' should re- > generate the object files that are needed and produce a new executable. > =A0Check that there are no instances of errors such as 'file not found' Sorry, I haven't had a chance to check that yet, and I'm hampered working on openfoam by a small-ish laptop with a slow disk. I didn't expect the dependency files to be necessary, as they aren't shipped in my rpms for previous versions that people have been using, but I will do the experiment when I can. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 08:15:46 2017 Received: (at 28593) by debbugs.gnu.org; 19 Oct 2017 12:15:46 +0000 Received: from localhost ([127.0.0.1]:49242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e59jl-0005CU-R7 for submit@debbugs.gnu.org; Thu, 19 Oct 2017 08:15:46 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:38683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e59ji-0005CI-Rv for 28593@debbugs.gnu.org; Thu, 19 Oct 2017 08:15:43 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 10846F3BE; Thu, 19 Oct 2017 14:15:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xcfs3Qc1Tt_N; Thu, 19 Oct 2017 14:15:41 +0200 (CEST) Received: from ribbon (unknown [193.50.110.53]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D1849ECEF; Thu, 19 Oct 2017 14:15:40 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <87o9p3mm73.fsf@albion.it.manchester.ac.uk> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 19 Oct 2017 14:15:39 +0200 In-Reply-To: <87o9p3mm73.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Thu, 19 Oct 2017 12:06:08 +0100") Message-ID: <87d15jjpuc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Dave Love skribis: > Paul Garlick writes: > >> ii) deleting object files, to save disk space, under >> 'platforms/linux64GccDPInt32Opt/src' should also be fine, with the >> proviso that the re-compilation process should be checked before >> committing. =C2=A0There is an example procedure, albeit for an earlier >> version, given at=C2=A0https://openfoamwiki.net/index.php/How_to_add_tem= pera >> ture_to_icoFoam=C2=A0. =C2=A0A slightly modified procedure should work f= or >> version 4.1. >> >> Dave, can you try this on your patched version? =C2=A0'wmake' should re- >> generate the object files that are needed and produce a new executable. >> =C2=A0Check that there are no instances of errors such as 'file not foun= d' > > Sorry, I haven't had a chance to check that yet, and I'm hampered > working on openfoam by a small-ish laptop with a slow disk. I didn't > expect the dependency files to be necessary, as they aren't shipped in > my rpms for previous versions that people have been using, but I will do > the experiment when I can. Paul seems to have access to a biffy build machine ;-), so maybe you can update/adjust the patch, Paul? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 06:32:14 2017 Received: (at 28593) by debbugs.gnu.org; 20 Oct 2017 10:32:14 +0000 Received: from localhost ([127.0.0.1]:51169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5Ub7-0005vq-Vb for submit@debbugs.gnu.org; Fri, 20 Oct 2017 06:32:14 -0400 Received: from smtp.hosts.co.uk ([85.233.160.19]:64492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5Ub6-0005vY-Ih for 28593@debbugs.gnu.org; Fri, 20 Oct 2017 06:32:12 -0400 Received: from [79.123.23.187] (helo=pancake.local) by smtp.hosts.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim) (envelope-from ) id 1e5Ub0-0007fc-BQ; Fri, 20 Oct 2017 11:32:06 +0100 Message-ID: <1508495524.2713.20.camel@tourbillion-technology.com> Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. From: Paul Garlick To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Dave Love Date: Fri, 20 Oct 2017 11:32:04 +0100 In-Reply-To: <87d15jjpuc.fsf@gnu.org> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <87o9p3mm73.fsf@albion.it.manchester.ac.uk> <87d15jjpuc.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Dave and Ludo, > > Sorry, I haven't had a chance to check that yet, and I'm hampered > > working on openfoam by a small-ish laptop with a slow disk.  I > > didn't > > expect the dependency files to be necessary, as they aren't shipped > > in > > my rpms for previous versions that people have been using, but I > > will do > > the experiment when I can. Great, thanks.   One of the nice features of OpenFOAM is that the principles of operation on laptops is just the same as that on supercomputers. > Paul seems to have access to a biffy build machine ;-), so maybe you > can > update/adjust the patch, Paul? Well, based on feedback on the existing package definition, I am starting to think about how best to deal with multiple versions and simplify the patch step.  There is a new version (5.0) that has been released that I can work on.   It is likely to take some time, although it should be quicker to develop than the original definition.  So, if Dave can take charge of this finishing patch (#28593) that would work best for me. In the meantime, I have made an announcement of the package availability on the CFD Online discusssion forum.  The link is: https://www.cfd-online.com/Forums/openfoam-news-announcements-other/193 865-openfoam-4-1-packaged-gnu-guix.html Best regards, Paul. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 07:28:56 2017 Received: (at 28593) by debbugs.gnu.org; 20 Oct 2017 11:28:56 +0000 Received: from localhost ([127.0.0.1]:51198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5VTz-0007Jv-PA for submit@debbugs.gnu.org; Fri, 20 Oct 2017 07:28:55 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:40812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5VTx-0007Jm-Pq for 28593@debbugs.gnu.org; Fri, 20 Oct 2017 07:28:54 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E8D6646A2; Fri, 20 Oct 2017 13:28:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Xtes-57Tm0f; Fri, 20 Oct 2017 13:28:52 +0200 (CEST) Received: from ribbon (unknown [193.50.110.53]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2FCA58B30; Fri, 20 Oct 2017 13:28:52 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <87o9p3mm73.fsf@albion.it.manchester.ac.uk> <87d15jjpuc.fsf@gnu.org> <1508495524.2713.20.camel@tourbillion-technology.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 20 Oct 2017 13:28:50 +0200 In-Reply-To: <1508495524.2713.20.camel@tourbillion-technology.com> (Paul Garlick's message of "Fri, 20 Oct 2017 11:32:04 +0100") Message-ID: <87y3o6vz0t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Dave Love X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Paul, Paul Garlick skribis: [...] >> Paul seems to have access to a biffy build machine ;-), so maybe you >> can >> update/adjust the patch, Paul? > > Well, based on feedback on the existing package definition, I am > starting to think about how best to deal with multiple versions and > simplify the patch step. =C2=A0There is a new version (5.0) that has been > released that I can work on. =C2=A0 > > It is likely to take some time, although it should be quicker to > develop than the original definition. =C2=A0So, if Dave can take charge of > this finishing patch (#28593) that would work best for me. Sounds like a plan. > In the meantime, I have made an announcement of the package > availability on the CFD Online discusssion forum. =C2=A0The link is: > > https://www.cfd-online.com/Forums/openfoam-news-announcements-other/19386= 5-openfoam-4-1-packaged-gnu-guix.html Nice! It will be interesting to see to what extent it helps OpenFOAM users and developers address their deployment issues. Cheers, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 11:26:14 2017 Received: (at 28593) by debbugs.gnu.org; 20 Oct 2017 15:26:14 +0000 Received: from localhost ([127.0.0.1]:52530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ZBd-00077i-Rn for submit@debbugs.gnu.org; Fri, 20 Oct 2017 11:26:13 -0400 Received: from probity.mcc.ac.uk ([130.88.200.94]:45137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ZBc-00077a-Bz for 28593@debbugs.gnu.org; Fri, 20 Oct 2017 11:26:12 -0400 Received: from asmtp2.its.manchester.ac.uk ([130.88.13.150]) by probity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1e5ZBa-0004rZ-GJ; Fri, 20 Oct 2017 16:26:10 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:41800) by asmtp2.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1e5ZBZ-0003iX-US; Fri, 20 Oct 2017 16:26:10 +0100 From: Dave Love To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <87o9p3mm73.fsf@albion.it.manchester.ac.uk> <87d15jjpuc.fsf@gnu.org> <1508495524.2713.20.camel@tourbillion-technology.com> X-Draft-From: ("Misc" 3527) Date: Fri, 20 Oct 2017 16:26:09 +0100 In-Reply-To: <1508495524.2713.20.camel@tourbillion-technology.com> (Paul Garlick's message of "Fri, 20 Oct 2017 11:32:04 +0100") Message-ID: <877evplu26.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:41800 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.150 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on probity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Ludovic =?iso-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Paul Garlick writes: > One of the nice features of OpenFOAM is that the principles of > operation on laptops is just the same as that on supercomputers. (Modulo MPI) but it's bad enough working with it on a decent login node! From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 11:28:38 2017 Received: (at 28593) by debbugs.gnu.org; 20 Oct 2017 15:28:38 +0000 Received: from localhost ([127.0.0.1]:52535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ZDy-0007BF-8R for submit@debbugs.gnu.org; Fri, 20 Oct 2017 11:28:38 -0400 Received: from tranquility.mcc.ac.uk ([130.88.200.145]:41340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ZDv-0007B6-Is for 28593@debbugs.gnu.org; Fri, 20 Oct 2017 11:28:36 -0400 Received: from asmtp1.its.manchester.ac.uk ([130.88.13.149]) by tranquility.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1e5ZDt-0001ir-Ri; Fri, 20 Oct 2017 16:28:33 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:41806) by asmtp1.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1e5ZDt-0005og-J8; Fri, 20 Oct 2017 16:28:33 +0100 From: Dave Love To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <87o9p3mm73.fsf@albion.it.manchester.ac.uk> <87d15jjpuc.fsf@gnu.org> <1508495524.2713.20.camel@tourbillion-technology.com> <87y3o6vz0t.fsf@gnu.org> X-Draft-From: ("Misc" 3530) Date: Fri, 20 Oct 2017 16:28:33 +0100 In-Reply-To: <87y3o6vz0t.fsf@gnu.org> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Fri, 20 Oct 2017 13:28:50 +0200") Message-ID: <8760b9lty6.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:41806 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.149 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on tranquility.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Ludovic Court=E8s writes: >> https://www.cfd-online.com/Forums/openfoam-news-announcements-other/1938= 65-openfoam-4-1-packaged-gnu-guix.html > > Nice! > > It will be interesting to see to what extent it helps OpenFOAM users and > developers address their deployment issues. In my experience of offering rpms and build advice, in the UK they're remarkably resistant to making life easy, or at least their support people are. Actually, that's not unique to OF; sigh. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 12:15:15 2017 Received: (at 28593) by debbugs.gnu.org; 22 Oct 2017 16:15:15 +0000 Received: from localhost ([127.0.0.1]:56079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6IuA-0000k7-N3 for submit@debbugs.gnu.org; Sun, 22 Oct 2017 12:15:14 -0400 Received: from tranquility.mcc.ac.uk ([130.88.200.145]:29708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Iu8-0000jy-QQ for 28593@debbugs.gnu.org; Sun, 22 Oct 2017 12:15:13 -0400 Received: from asmtp2.its.manchester.ac.uk ([130.88.13.150]) by tranquility.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1e6Iu6-0001oH-N5; Sun, 22 Oct 2017 17:15:10 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:48778) by asmtp2.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1e6Iu6-00052A-Di; Sun, 22 Oct 2017 17:15:10 +0100 From: Dave Love To: Paul Garlick Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> X-Draft-From: ("Misc" 3325) Date: Sun, 22 Oct 2017 17:15:09 +0100 In-Reply-To: <1507547167.17241.18.camel@tourbillion-technology.com> (Paul Garlick's message of "Mon, 9 Oct 2017 12:06:07 +0100") Message-ID: <874lqrjh0y.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Yukon-Rand-Corporation-password-AVIP-South-Africa" X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:48778 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.150 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on tranquility.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Ludovic =?iso-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) --Yukon-Rand-Corporation-password-AVIP-South-Africa Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Paul Garlick writes: > ii) deleting object files, to save disk space, under > 'platforms/linux64GccDPInt32Opt/src' should also be fine, with the > proviso that the re-compilation process should be checked before > committing. =A0There is an example procedure, albeit for an earlier > version, given at=A0https://openfoamwiki.net/index.php/How_to_add_tempera > ture_to_icoFoam=A0. =A0A slightly modified procedure should work for > version 4.1. > > Dave, can you try this on your patched version? =A0'wmake' should re- > generate the object files that are needed and produce a new executable. > =A0Check that there are no instances of errors such as 'file not found' I successfully rebuilt pisoFoam following the example in the current documentation. Is that good enough? Here's a modified patch to change the comment and avoid an empty directory. --Yukon-Rand-Corporation-password-AVIP-South-Africa Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-gnu-openfoam-Clean-up-to-reduce-closure.patch >From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001 From: Dave Love Date: Sat, 21 Oct 2017 17:20:42 +0100 Subject: [PATCH] gnu: openfoam: Clean up to reduce closure. This saves ~1GB. * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. [arguments]: Clean up .o and src after build. --- gnu/packages/simulation.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm index de07b6844..3e65d1687 100644 --- a/gnu/packages/simulation.scm +++ b/gnu/packages/simulation.scm @@ -84,6 +84,10 @@ `(("gzip" ,gzip) ("gnuplot" ,gnuplot) ("openmpi" ,openmpi))) + ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc + ;; (8MB) + (outputs '("debug" ;~60MB + "out")) (arguments `( ;; Executable files and shared libraries are located in the 'platforms' ;; subdirectory. @@ -171,6 +175,15 @@ (("lockDir=.*$") "lockDir=$HOME/.$WM_PROJECT/.wmake\n")) #t)) + (add-after 'build 'cleanup + ;; Avoid unncessary, voluminous object and dep files + (lambda _ + (delete-file-recursively + "platforms/linux64GccDPInt32Opt/src") + (delete-file-recursively + "platforms/linux64GccDPInt32OptSYSTEMOPENMPI") + (zero? + (system* "find" "-name" "*.o" "-delete")))) (replace 'install (lambda _ ;; use 'OpenFOAM-version' convention -- 2.11.0 --Yukon-Rand-Corporation-password-AVIP-South-Africa-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 11:00:22 2017 Received: (at 28593) by debbugs.gnu.org; 23 Oct 2017 15:00:22 +0000 Received: from localhost ([127.0.0.1]:57859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6eDG-0004Fl-7n for submit@debbugs.gnu.org; Mon, 23 Oct 2017 11:00:22 -0400 Received: from smtp.hosts.co.uk ([85.233.160.19]:8770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6eDD-0004FX-NO for 28593@debbugs.gnu.org; Mon, 23 Oct 2017 11:00:20 -0400 Received: from [79.123.23.187] (helo=pancake.local) by smtp.hosts.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim) (envelope-from ) id 1e6eD7-0001f7-4d; Mon, 23 Oct 2017 16:00:13 +0100 Message-ID: <1508770811.11712.19.camel@tourbillion-technology.com> Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. From: Paul Garlick To: Dave Love Date: Mon, 23 Oct 2017 16:00:11 +0100 In-Reply-To: <874lqrjh0y.fsf@albion.it.manchester.ac.uk> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <874lqrjh0y.fsf@albion.it.manchester.ac.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 28593 Cc: 28593@debbugs.gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Sun, 2017-10-22 at 17:15 +0100, Dave Love wrote: > > I successfully rebuilt pisoFoam following the example in the current > documentation.  Is that good enough? Yes, that is a good example case.  Thank you for doing the check. > Here's a modified patch to change the comment and avoid an empty > directory. Fine, with a caveat on the FIXME comment: i) 'wmake' will fail to find headers in subdirectories of 'src' if they are not installed.  So, a re-compilation as you did above would not be possible without installing the extra output.  This is perhaps confusing for a new user, who may not know the details of the dependency structure. ii) OpenFOAM would be difficult to use without the 'tutorials' directory, as these are often used as the starting point for new development.  I think it is helpful for these files to be installed by default. My own preference would be to not fix the FIXME (or, in fact, to omit the comment at this stage). Best, Paul. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 01 05:28:01 2017 Received: (at 28593-done) by debbugs.gnu.org; 1 Dec 2017 10:28:01 +0000 Received: from localhost ([127.0.0.1]:39088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKiY5-0000YX-1N for submit@debbugs.gnu.org; Fri, 01 Dec 2017 05:28:01 -0500 Received: from [141.255.128.1] (port=33767 helo=hera.aquilenet.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKiY3-0000YN-Hm for 28593-done@debbugs.gnu.org; Fri, 01 Dec 2017 05:27:59 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B04ADF9F0; Fri, 1 Dec 2017 11:28:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CH6BS0uZZPLR; Fri, 1 Dec 2017 11:28:01 +0100 (CET) Received: from ribbon (unknown [193.50.110.211]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DA25BF129; Fri, 1 Dec 2017 11:28:00 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <874lqrjh0y.fsf@albion.it.manchester.ac.uk> Date: Fri, 01 Dec 2017 11:27:57 +0100 In-Reply-To: <874lqrjh0y.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Sun, 22 Oct 2017 17:15:09 +0100") Message-ID: <87374uivyq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dave Love skribis: >>From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Sat, 21 Oct 2017 17:20:42 +0100 > Subject: [PATCH] gnu: openfoam: Clean up to reduce closure. > > This saves ~1GB. > > * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. > [arguments]: Clean up .o and src after build. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo; id=hera.aquilenet.fr; ip=141.255.128.1; r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 28593-done Cc: 28593-done@debbugs.gnu.org, Paul Garlick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dave Love skribis: >>From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Sat, 21 Oct 2017 17:20:42 +0100 > Subject: [PATCH] gnu: openfoam: Clean up to reduce closure. > > This saves ~1GB. > > * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. > [arguments]: Clean up .o and src after build. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dave Love skribis: >>>From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Sat, 21 Oct 2017 17:20:42 +0100 > Subject: [PATCH] gnu: openfoam: Clean up to reduce closure. > > This saves ~1GB. > > * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug. > [arguments]: Clean up .o and src after build. I removed the FIXME as suggested by Paul, made the changes below, and committed. Thank you, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm index 3e65d1687..a5b661e34 100644 --- a/gnu/packages/simulation.scm +++ b/gnu/packages/simulation.scm @@ -84,8 +84,6 @@ `(("gzip" ,gzip) ("gnuplot" ,gnuplot) ("openmpi" ,openmpi))) - ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc - ;; (8MB) (outputs '("debug" ;~60MB "out")) (arguments @@ -176,14 +174,14 @@ "lockDir=$HOME/.$WM_PROJECT/.wmake\n")) #t)) (add-after 'build 'cleanup - ;; Avoid unncessary, voluminous object and dep files + ;; Avoid unncessary, voluminous object and dep files. (lambda _ (delete-file-recursively "platforms/linux64GccDPInt32Opt/src") (delete-file-recursively "platforms/linux64GccDPInt32OptSYSTEMOPENMPI") - (zero? - (system* "find" "-name" "*.o" "-delete")))) + (for-each delete-file (find-files "." "\\.o$")) + #t)) (replace 'install (lambda _ ;; use 'OpenFOAM-version' convention --=-=-=-- From unknown Mon Jun 23 18:29:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 29 Dec 2017 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator