GNU bug report logs - #28583
[PATCH] Add es-dump-restore and dependencies

Previous Next

Full log

Message #77 received at 28583 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
Cc: 28583 <at> debbugs.gnu.org
Subject: Re: [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json.
Date: Sat, 30 Sep 2017 09:21:44 +0100

[Message part 1 (text/plain, inline)]

On Wed, 27 Sep 2017 22:03:32 +1000
Ben Woodcroft <b.woodcroft <at> uq.edu.au> wrote:

> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-multi-json): New variable.  
> [..]
> > +    (arguments
> > +     '(#:tests? #f)) ;; No testsuite.  
> No testsuite included in distributed gem, rather.

I've updated the comment.

> > +    (synopsis
> > +     "Common interface to multiple JSON libraries for Ruby")
> > +    (description
> > +     "This package provides a common interface to multiple JSON
> > libraries, +including Oj, Yajl, the JSON gem (with C-extensions),
> > the pure-Ruby JSON gem, +NSJSONSerialization, gson.rb, JrJackson,
> > and OkJson.")
> > +    (home-page
> > +     "http://github.com/intridea/multi_json")  
> Both home-page and synopsis could be moved to the line before.

And also updated the formatting.

> Otherwise LGTM.
> ben

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.