GNU bug report logs - #28583
[PATCH] Add es-dump-restore and dependencies

Previous Next

Full log

View this message in rfc822 format

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Christopher Baines <mail <at> cbaines.net>, 28583 <at> debbugs.gnu.org
Subject: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore.
Date: Thu, 28 Sep 2017 18:38:19 +1000

On 25/09/17 03:17, Christopher Baines wrote:
> * gnu/packages/databases.scm (es-dump-restore): New variable.
[..]
> +    (arguments
> +     '(#:tests? #f
Including a reason here would be good.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'wrap-bin-es_dump_restore
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (wrap-program (string-append (assoc-ref outputs "out")
> +                                          "/bin/es_dump_restore")
> +               `("GEM_PATH" ":" prefix (,(string-append
> +                                          (getenv "GEM_PATH")
> +                                          ":"
> +                                          (getenv "GEM_HOME")))))
> +             #t)))))
Again, it would be preferable to have this done as part of the build 
system, but OK.

> +    (propagated-inputs
> +     `(("ruby-httpclient" ,ruby-httpclient)
> +       ("ruby-multi-json" ,ruby-multi-json)
> +       ("ruby-progress_bar" ,ruby-progress_bar)
> +       ("ruby-rubyzip" ,ruby-rubyzip)
> +       ("ruby-thor" ,ruby-thor)))
> +    (synopsis
> +     "Utility for dumping and restoring ElasticSearch indexes")
This can be moved onto the previous line.

> +    (description
> +     "This package provides a utility for dumping the contents of an
> +ElasticSearch index to a compressed file and restoring the dumpfile back to an
> +ElasticSearch server")
> +    (home-page
> +     "https://github.com/patientslikeme/es_dump_restore")
As can this. Otherwise LGTM - thanks for this series.
ben

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.