GNU bug report logs - #28583
[PATCH] Add es-dump-restore and dependencies

Previous Next

Full log

View this message in rfc822 format

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Christopher Baines <mail <at> cbaines.net>, 28583 <at> debbugs.gnu.org
Subject: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline.
Date: Wed, 27 Sep 2017 22:37:39 +1000

[Message part 1 (text/plain, inline)]

On 25/09/17 03:17, Christopher Baines wrote:
> * gnu/packages/ruby.scm (ruby-highline): New variable.
> ---
>   gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 1ee03e066..9863d4b37 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
>                (("/bin/sh") (which "sh"))))
>            %standard-phases)))))
>   
> +(define-public ruby-highline
> +  (package
> +    (name "ruby-highline")
> +    (version "1.7.8")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "highline" version))
> +       (sha256
> +        (base32
> +         "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; TODO: Requires code_statistics
I've attached a package for code_statistics, but adding it does not help 
because there appears to be something amiss in the Rakefile. This has 
been fixed in the not quite released 2.0.0 version, so the patch may be 
useful in future.

> +    (native-inputs
> +     `(("bundler" ,bundler)))
> +    (synopsis
> +     "HighLine helps you build command-line interfaces")
> +    (description
> +     "HighLine provides a high-level IO library that provides validation,
> +type conversion, and more for command-line interfaces.
> +
> +HighLine also includes a menu system for providing multiple options to the
> +user.")
I would combine the two sentences into one paragraph.

Otherwise LGTM.

[0001-gnu-Add-ruby-code-statistics.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.