Subject: Re: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline.

From: Ben Woodcroft <[email-masked]>
Date: Wed, 27 Sep 2017 22:37:39 +1000

On 25/09/17 03:17, Christopher Baines wrote:
> * gnu/packages/ruby.scm (ruby-highline): New variable.
> ---
>   gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 1ee03e066..9863d4b37 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
>                (("/bin/sh") (which "sh"))))
>            %standard-phases)))))
>   
> +(define-public ruby-highline
> +  (package
> +    (name "ruby-highline")
> +    (version "1.7.8")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "highline" version))
> +       (sha256
> +        (base32
> +         "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; TODO: Requires code_statistics
I've attached a package for code_statistics, but adding it does not help 
because there appears to be something amiss in the Rakefile. This has 
been fixed in the not quite released 2.0.0 version, so the patch may be 
useful in future.

> +    (native-inputs
> +     `(("bundler" ,bundler)))
> +    (synopsis
> +     "HighLine helps you build command-line interfaces")
> +    (description
> +     "HighLine provides a high-level IO library that provides validation,
> +type conversion, and more for command-line interfaces.
> +
> +HighLine also includes a menu system for providing multiple options to the
> +user.")
I would combine the two sentences into one paragraph.

Otherwise LGTM.

>From e2fb88306d527db0bbc53e980a071474d3b67100 Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <[email-masked]>
Date: Wed, 27 Sep 2017 22:18:33 +1000
Subject: [PATCH] gnu: Add ruby-code-statistics.

* gnu/packages/ruby.scm (ruby-code-statistics): New variable.
---
 gnu/packages/ruby.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 1ee03e066..c41c80569 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -4378,3 +4378,24 @@ really opens up the email messages you are parsing, if you know what you
 are doing, you can fiddle with every last bit of your email directly.")
     (home-page "https://github.com/mikel/mail")
     (license license:expat)))
+
+(define-public ruby-code-statistics
+  (package
+    (name "ruby-code-statistics")
+    (version "0.2.13")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "code_statistics" version))
+       (sha256
+        (base32
+         "07rdpsbwbmh4vp8nxyh308cj7am2pbrfhv9v5xr2d5gq8hnnsm93"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ; Not all test code is included in gem.
+    (synopsis "Port of the rails 'rake stats' method")
+    (description
+     "This gem is a port of the rails 'rake stats' method so it can be made
+more robust and work for non rails projects.")
+    (home-page "http://github.com/danmayer/code_statistics")
+    (license license:expat)))
-- 
2.14.1