Subject: [bug#28579] gpa

From: ng0 <[email-masked]>
Date: Sun, 24 Sep 2017 16:45:56 +0000

Nicolas Goaziou transcribed 1.6K bytes:
> Hello,
> 
> ng0 <[email-masked]> writes:
> 
> > A GUI for GnuPG.
> >
> > Builds.
> > GUI works, Preferences pick up my $HOME/.gnupg settings.
> > More wasn't tested.
> 
> Thank you. I have some comments about your patch.
> 
> > +(define-public gpa
> > +  (package
> > +    (name "gpa")
> > +    (version "0.9.9")
> 
> version 0.9.10 is out since 2016. Would it make sense to package it instead?

I did only find 0.9.9, but I'll try again. I've catched a cold.

> > +    (source
> > +     (origin
> > +      (method url-fetch)
> > +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> > +                          name "-" version ".tar.bz2"))
> 
> Guix lint reports:
> 
>   URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

Well I had a mirror first but did not find gpa on it.
I'll try this.

> > +      (sha256
> > +       (base32
> > +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("gnupg" ,gnupg)
> > +       ("gpgme" ,gpgme)
> > +       ("libassuan" ,libassuan)
> > +       ("libgpg-error" ,libgpg-error)
> > +       ("gtk+-2" ,gtk+-2)))
> > +    (home-page "https://gnupg.org/software/gpa/index.html")
> > +    (synopsis "GUI for GnuPG")
> > +    (description
> > +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> > +interface for the @defn{GNU Privacy Guard} (GnuPG).")
> 
> Guix lint reports an error about invalid Texinfo markup.

Right! It's @dfn{} not @defn{}.

> I'm not sure about what to do to fix it, if there is anything to do at
> all. IMO, @defn is not adequate here.

Why? It is a definition being used.
Although I have to admit it looks unusual compared to the rest of the file.

…
synopsis: GUI for GnuPG
description: "GNU Privacy Assistant" (GPA) is a graphical user interface for the "GNU Privacy Guard" (GnuPG).

> > +    (license license:gpl3)))
> 
> Every ".c" file I checked use "or any later version". I think this
> should be "gpl3+". WDYT?

Okay.

> Regards,
> 
> -- 
> Nicolas Goaziou                                                0x80A93738
> 

Thanks for finding the mistakes. Correction appended.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org
From 5d5749da28f4943a356970c142ce63dc3ec541a6 Mon Sep 17 00:00:00 2001
From: ng0 <[email-masked]>
Date: Sun, 24 Sep 2017 15:52:05 +0000
Subject: [PATCH] gnu: Add gpa.

* gnu/packages/gnupg.scm (gpa): New variable.
---
 gnu/packages/gnupg.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index c6af5caa4..075eec4a2 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -7,7 +7,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <[email-masked]>
 ;;; Copyright © 2015, 2016 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2016 Christopher Allan Webber <[email-masked]>
-;;; Copyright © 2016 ng0 <[email-masked]>
+;;; Copyright © 2016, 2017 ng0 <[email-masked]>
 ;;; Copyright © 2016 Christopher Baines <[email-masked]>
 ;;; Copyright © 2016 Mike Gerwitz <[email-masked]>
 ;;; Copyright © 2016 Troy Sankey <[email-masked]>
@@ -822,3 +822,31 @@ qualities.  To reconstruct a secret key, you re-enter those
 bytes (whether by hand, OCR, QR code, or the like) and paperkey can use
 them to transform your existing public key into a secret key.")
     (license license:gpl2+)))
+
+(define-public gpa
+  (package
+    (name "gpa")
+    (version "0.9.10")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://gnupg/gpa/"
+                          name "-" version ".tar.bz2"))
+      (sha256
+       (base32
+        "09xphbi2456qynwqq5n0yh0zdmdi2ggrj3wk4hsyh5lrzlvcrff3"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gnupg" ,gnupg)
+       ("gpgme" ,gpgme)
+       ("libassuan" ,libassuan)
+       ("libgpg-error" ,libgpg-error)
+       ("gtk+-2" ,gtk+-2)))
+    (home-page "https://gnupg.org/software/gpa/index.html")
+    (synopsis "GUI for GnuPG")
+    (description
+     "@dfn{GNU Privacy Assistant} (GPA) is a graphical user
+interface for the @dfn{GNU Privacy Guard} (GnuPG).")
+    (license license:gpl3+)))
-- 
2.14.1