GNU bug report logs - #28561
Add gnome-clocks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28561 in the body.
You can then email your comments to 28561 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: guix-patches <at> gnu.org
Subject: Add gnome-clocks
Date: Sat, 23 Sep 2017 09:05:42 +0530 (IST)

[Message part 1 (text/plain, inline)]

[0001-gnu-libgweather-Enable-vala-support.patch (text/x-patch, attachment)]

[0002-gnu-Add-gsound.patch (text/x-patch, attachment)]

[0003-gnu-Add-gnome-clocks.patch (text/x-patch, attachment)]

Message #8 received at 28561 <at> debbugs.gnu.org (full text, mbox):

From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: 28561 <at> debbugs.gnu.org
Subject: Add gnome-clocks
Date: Sat, 23 Sep 2017 09:19:46 +0530 (IST)

[Message part 1 (text/plain, inline)]

Forgot to update the details. Updated patch attached

[0003-gnu-Add-gnome-clocks.patch (text/x-patch, attachment)]

Message #11 received at 28561 <at> debbugs.gnu.org (full text, mbox):

From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: 28561 <at> debbugs.gnu.org
Subject: Re: Add gnome-clocks
Date: Sat, 23 Sep 2017 09:47:22 +0530 (IST)

[Message part 1 (text/plain, inline)]

Sorry, a few more fixes reported by 'guix lint'.

Btw, this is my first contribution. Hope to get reviewed soon.

[0001-gnu-libgweather-Enable-vala-support.patch (text/x-patch, attachment)]

[0002-gnu-Add-gsound.patch (text/x-patch, attachment)]

[0003-gnu-Add-gnome-clocks.patch (text/x-patch, attachment)]

Message #16 received at 28561-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mohammed Sadiq <sadiq <at> sadiqpk.org>
Cc: 28561-done <at> debbugs.gnu.org
Subject: Re: [bug#28561] Add gnome-clocks
Date: Sat, 23 Sep 2017 18:31:17 +0200

Hi Mohammed,

Mohammed Sadiq <sadiq <at> sadiqpk.org> skribis:

> From 5d0f93a67a221e9a331405fad9322f4fb0ab6991 Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:28:53 +0530
> Subject: [PATCH 1/3] gnu: libgweather: Enable vala support.
>
> * gnu/packages/gnome.scm (libgweather)[native-inputs]: Add vala.
> (libgweather)[arguments]: Install vala bindings into out.

[...]

> From 684afe8b15baf153178e1a2d66c10f12b221ebee Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:29:34 +0530
> Subject: [PATCH 2/3] gnu: Add gsound.
>
> * gnu/packages/gnome.scm (gsound): New public variable.

[...]

> From d0620afbb72d340ead5546509d5cc3699c2edac6 Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:38:44 +0530
> Subject: [PATCH 3/3] gnu: Add gnome-clocks.
>
> * gnu/packages/gnome.scm (gnome-clocks): New public variable.

Applied all 3 patches.  This first contribution is perfect.  :-)

Maybe you’ll find that some packages should be added to our ‘gnome’
meta-package.  Let us know.

Thank you, and welcome aboard!

Ludo’.

Message #19 received at 28561 <at> debbugs.gnu.org (full text, mbox):

From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: 28561 <at> debbugs.gnu.org, GNU bug Tracking System <help-debbugs <at> gnu.org>
Subject: Re: bug#28561: closed (Re: [bug#28561] Add gnome-clocks)
Date: Sun, 24 Sep 2017 12:58:33 +0530 (IST)

I didn't find a way to make gnome-shell optionally support gnome-clocks.
And so I didn't add that.

I don't need gnome-shell to have a propagated-input dependency on gnome-clocks.
But in case gnome-clocks is installed, gnome-shell should have access to
gnome-clocks' gsettings schema settings (The only the added clocks will be
displayed in gnome-shell dropdown). How can I do that.

And thanks for the review. :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.