GNU bug report logs - #28558
[PATCH] gnu: Add atool.

Previous Next

Package: guix-patches;

Reported by: Stefan Reichör <stefan <at> xsteve.at>

Date: Fri, 22 Sep 2017 21:50:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Reichör <stefan <at> xsteve.at>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28558 <at> debbugs.gnu.org
Subject: [bug#28558] [PATCH] gnu: Add atool.
Date: Sun, 08 Oct 2017 11:25:54 +0200
> Hi Stefan,
>
> Stefan Reichör <stefan <at> xsteve.at> skribis:
>
>>> On 23/09/17 07:49, Stefan Reichör wrote:
>>>> * gnu/packages/compression.scm (atool): New variable.
>>> Thanks for the patch. While adding all compression programs supported
>>> (e.g. tar) as inputs is probably too much given their large number, I
>>> think it would be good to add "file" and patch in the path to "file"
>>> in bin/atool. WDYT?
>>
>> Thanks for your feedback. I don't think that file is an important tool
>> for atool. At least I use only archives with the correct file extension.
>> And all the archives that I remember that I downloaded from some site
>> also provided the correct file extension. In that case file is not needed to
>> detect the archive type.
>>
>> However, if you think that hard coding the full path to file is a good
>> thing I will update my patch. It should be doable for me...
>
> As discussed earlier in another thread, I think it’s a good idea to
> hard-code absolute file names.  Could you update the patch accordingly?
>
> TIA,
> Ludo’.

Hi Ludo!

I am really busy for the next weeks. So I won't have time to do some
work for Guix. I will try to improve my patches when I find the time.

Stefan.




This bug report was last modified 7 years and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.