From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 19 04:27:08 2017 Received: (at submit) by debbugs.gnu.org; 19 Sep 2017 08:27:08 +0000 Received: from localhost ([127.0.0.1]:47215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duDs3-0006Ej-FB for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:27:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duDs1-0006EB-SF for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:27:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duDrq-0004FH-79 for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:27:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1duDrq-0004F4-3Q for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:26:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duDro-0004Ak-Bm for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 04:26:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duDrm-0004Dd-UZ for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 04:26:52 -0400 Received: from mail-qt0-x232.google.com ([2607:f8b0:400d:c0d::232]:47876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duDrm-0004Bx-NG for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 04:26:50 -0400 Received: by mail-qt0-x232.google.com with SMTP id b1so2963377qtc.4 for ; Tue, 19 Sep 2017 01:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=bNd0YMBYNxh/ioWCYjcf60q1L0Y9Rig/Z6GyIJz78uM=; b=Poj8ugPEpMVHqLpajOkIXVRF0rNKoYU7/ovJGX99GzAsnqPxQ2GMap5Cv+0R0q7V7C +0hItbUzu5AaJgBhSClVfhrrf95hswuZXJgKcIQyj+qgbVwcXsBQO+CJ1oSFSjSRFoNX 0DJRj1NOjAg+UyBpY8YgDBwA88uWVfxGV9g5Y4RwjjLYhAqdBO+URiC8mwMLUSt5tEPb bgQJCdbTiJjwUq277RLfm8ysHkhT6ceTdowaTGD7XyVXpMOnCq+yVTqa3gnojxVAaMuY 46L8rdrv03WtD/oWOSoZlH3QtQkZGmiirBB0AaznG+lUx4sxCSd4c+x3m7AlaoGGTijB /zOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=bNd0YMBYNxh/ioWCYjcf60q1L0Y9Rig/Z6GyIJz78uM=; b=LNvYNf+P5KuDpvYYkkH8mVcag03bhua7dxrSH5ybJeoXD8vqM9hzqYNYiuK/VFyMz5 yKHMYrlmexE0aQfjdYZI7xUVs8l4CkRMAb4zhXLxz3WqdtGfTz5Y4IY1bIYdpBOsrXEe G5aIzgkBPEzSWbq/IiXCLyWqsoSSfARsr+X/txLvXA96t9m0O6NZjJasHH5rrS4/X/+C sUW3H7+jgefl4vuG7WrzikL5+U7XhAfGjI7OEamvpfu87+Qi93LNqRivNZ2LJ4JyycTo Ve0U7xIoTP19yj0KvSanMcsz15+NxSOEc7An2GcyPqNFgQM9Kol+q9U+3hj6cmco4vVr 4nOQ== X-Gm-Message-State: AHPjjUgo5gNNtKX3rlmybbTZ6l9k8RXsCntFii+RRaW6aH+ytUh+Qdfu ICGIoc7vV0c8oClnmdUxqacwRIjXTdjZCF2EfM8Q6w== X-Google-Smtp-Source: AOwi7QCjjH0Dd/ncGZvlFc0iNStwvgPtQTwNmmXMSdflSb1LfCctk8GoHzlRxLJ6y22p+NmpQQkcMOptsQCLv9eHvjw= X-Received: by 10.200.40.117 with SMTP id 50mr829779qtr.167.1505809608526; Tue, 19 Sep 2017 01:26:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.82.8 with HTTP; Tue, 19 Sep 2017 01:26:27 -0700 (PDT) From: Fabrice Popineau Date: Tue, 19 Sep 2017 10:26:27 +0200 Message-ID: Subject: 26.0.60; Problem with mkdir() on root drive (ms-windows) To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="001a113c6008d0e9890559869e79" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a113c6008d0e9890559869e79 Content-Type: text/plain; charset="UTF-8" On the following: (make-directory-internal "c:/") emacs reports "Permission denied" rather than "File already exists". This has several consequences. First, (make-directory "c:/" t) should not error, but it does because it does not catch the "Permission denied" error. Second, while running make check in the current emacs-26 branch, there is a failure in files-tests.el directly related to the previous point. Suggestion: modify files--ensure-directory to catch the case of a root drive and avoid/catch the permission denied error. Best regards, Fabrice In GNU Emacs 26.0.60 (build 3, x86_64-w64-mingw32) of 2017-09-19 built on LOBSANG Repository revision: 4bd6e39c01ebdc815a5d0670922a827295766677 Windowing system distributor 'Microsoft Corp.', version 10.0.16288 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Entering debugger... is undefined previous-line: Beginning of buffer Configured using: 'configure --prefix=/MingW64 --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2 --with-gnutls --with-imagemagick --without-dbus --enable-checking=no 'CFLAGS=-I/mingw64/include -O3 -g0 -mtune=corei7 -fomit-frame-pointer' CPPFLAGS=-I/mingw64/include LDFLAGS=-L/mingw64/lib' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS LCMS2 Important settings: value of $LANG: fr_FR locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu cl-print byte-opt gv bytecomp byte-compile cl-loaddefs cl-lib cconv debug elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 99907 11069) (symbols 56 20316 1) (miscs 48 65 98) (strings 32 30120 1035) (string-bytes 1 759473) (vectors 16 14922) (vector-slots 8 488682 7533) (floats 8 60 110) (intervals 56 314 8) (buffers 992 12)) --001a113c6008d0e9890559869e79 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On the following:

=
(make-directory-internal "c:/")

ema= cs reports "Permission denied" rather than "File already exi= sts".
This has several consequences.
First,
<= div>(make-directory "c:/" t)
should not error, but it d= oes because it does not catch the
"Permission denied" e= rror.
Second, while running
make check
in the= current emacs-26 branch, there is a failure
in files-tests.el di= rectly related to the previous point.

Suggestion: = modify files--ensure-directory to catch the case
of a root drive = and avoid/catch the permission denied error.

Best = regards,

Fabrice


In GNU Emacs 26.0.60 (build 3, x86_64-w64-mingw32)
=C2=A0o= f 2017-09-19 built on LOBSANG
Repository revision: 4bd6e39c01ebdc= 815a5d0670922a827295766677
Windowing system distributor 'Micr= osoft Corp.', version 10.0.16288
Recent messages:
F= or information about GNU Emacs and the GNU system, type C-h C-a.
= Entering debugger...
<apps> is undefined
previous= -line: Beginning of buffer
Configured using:
=C2=A0'= ;configure --prefix=3D/MingW64 --with-jpeg --with-xpm --with-png
= =C2=A0--with-tiff --with-rsvg --with-xml2 --with-gnutls --with-imagemagick<= /div>
=C2=A0--without-dbus --enable-checking=3Dno 'CFLAGS=3D-I/ming= w64/include -O3 -g0
=C2=A0-mtune=3Dcorei7 -fomit-frame-pointer= 9; CPPFLAGS=3D-I/mingw64/include
=C2=A0LDFLAGS=3D-L/mingw64/lib&#= 39;

Configured features:
XPM JPEG TIFF G= IF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
ZLIB TOOL= KIT_SCROLL_BARS LCMS2

Important settings:
=C2=A0 value of $LANG: fr_FR
=C2=A0 locale-coding-system: cp125= 2

Major mode: Lisp Interaction

Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2= =A0 global-eldoc-mode: t
=C2=A0 eldoc-mode: t
=C2=A0 el= ectric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0= tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-n= ame-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2= =A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2= =A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: t
=
=C2=A0 auto-compression-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

Load-path s= hadows:
None found.

Features:
= (shadow sort mail-extr emacsbug message subr-x puny seq dired
dir= ed-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived
=
epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail=
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mo= de
easymenu cl-print byte-opt gv bytecomp byte-compile cl-loaddef= s cl-lib
cconv debug elec-pair time-date mule-util tooltip eldoc = electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-= w32 ls-lisp
disp-table term/w32-win w32-win w32-vars term/common-= win tool-bar dnd
fontset image regexp-opt fringe tabulated-list r= eplace newcomment
text-mode elisp-mode lisp-mode prog-mode regist= er page menu-bar
rfn-eshadow isearch timer select scroll-bar mous= e jit-lock font-lock
syntax facemenu font-core term/tty-colors fr= ame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibe= tan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew gre= ek romanian slovak czech european
ethiopic indian cyrillic chines= e composite charscript charprop
case-table epa-hook jka-cmpr-hook= help simple abbrev obarray minibuffer
cl-preloaded nadvice loadd= efs button faces cus-face macroexp files
text-properties overlay = sha1 md5 base64 format env code-pages mule
custom widget hashtabl= e-print-readable backquote w32notify w32 lcms2
multi-tty make-net= work-process emacs)

Memory information:
= ((conses 16 99907 11069)
=C2=A0(symbols 56 20316 1)
=C2= =A0(miscs 48 65 98)
=C2=A0(strings 32 30120 1035)
=C2= =A0(string-bytes 1 759473)
=C2=A0(vectors 16 14922)
=C2= =A0(vector-slots 8 488682 7533)
=C2=A0(floats 8 60 110)
=C2=A0(intervals 56 314 8)
=C2=A0(buffers 992 12))
--001a113c6008d0e9890559869e79-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 19 04:51:08 2017 Received: (at 28508-done) by debbugs.gnu.org; 19 Sep 2017 08:51:08 +0000 Received: from localhost ([127.0.0.1]:47248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duEFH-0000EJ-ND for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:51:08 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duEFG-0000Dn-Et for 28508-done@debbugs.gnu.org; Tue, 19 Sep 2017 04:51:07 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8E384160D8B; Tue, 19 Sep 2017 01:51:00 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sRlEH_YPtxpF; Tue, 19 Sep 2017 01:50:59 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CC318160D8C; Tue, 19 Sep 2017 01:50:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eFyXG7JfBnZk; Tue, 19 Sep 2017 01:50:59 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AB1CA160D8B; Tue, 19 Sep 2017 01:50:59 -0700 (PDT) To: Fabrice Popineau From: Paul Eggert Subject: Re: 26.0.60; Problem with mkdir() on root drive (ms-windows) Organization: UCLA Computer Science Department Message-ID: <6fb106d9-c129-28e2-9ac4-1737a3f256ff@cs.ucla.edu> Date: Tue, 19 Sep 2017 01:50:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4A89721582382C56977E0185" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28508-done Cc: 28508-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------4A89721582382C56977E0185 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached patch into the emacs-26 branch. --------------4A89721582382C56977E0185 Content-Type: text/x-patch; name="0001-Fix-bug-with-make-directory-on-MS-Windows-root.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-bug-with-make-directory-on-MS-Windows-root.patch" >From 3c8da733879cd9c9ffd3b4709b596589f79f4fdf Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 19 Sep 2017 01:47:39 -0700 Subject: [PATCH] Fix bug with make-directory on MS-Windows root * lisp/files.el (files--ensure-directory): Treat any error, not just file-already-exists, as an opportunity to check whether DIR is already a directory (Bug#28508). --- lisp/files.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/files.el b/lisp/files.el index ff0ab70..0c30d40 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5337,7 +5337,7 @@ files--ensure-directory "Make directory DIR if it is not already a directory. Return nil." (condition-case err (make-directory-internal dir) - (file-already-exists + (error (unless (file-directory-p dir) (signal (car err) (cdr err)))))) -- 2.7.4 --------------4A89721582382C56977E0185-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 19 12:40:43 2017 Received: (at 28508) by debbugs.gnu.org; 19 Sep 2017 16:40:43 +0000 Received: from localhost ([127.0.0.1]:48494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duLZj-0006tZ-45 for submit@debbugs.gnu.org; Tue, 19 Sep 2017 12:40:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duLZh-0006tN-NK for 28508@debbugs.gnu.org; Tue, 19 Sep 2017 12:40:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duLZb-0000C6-UW for 28508@debbugs.gnu.org; Tue, 19 Sep 2017 12:40:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duLZW-00009B-RV; Tue, 19 Sep 2017 12:40:30 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1775 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1duLZV-0007mh-Ff; Tue, 19 Sep 2017 12:40:30 -0400 Date: Tue, 19 Sep 2017 19:40:11 +0300 Message-Id: <83h8vyhcb8.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <6fb106d9-c129-28e2-9ac4-1737a3f256ff@cs.ucla.edu> (message from Paul Eggert on Tue, 19 Sep 2017 01:50:59 -0700) Subject: Re: bug#28508: 26.0.60; Problem with mkdir() on root drive (ms-windows) References: <6fb106d9-c129-28e2-9ac4-1737a3f256ff@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28508 Cc: 28508@debbugs.gnu.org, fabrice.popineau@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Tue, 19 Sep 2017 01:50:59 -0700 > Cc: 28508-done@debbugs.gnu.org > > Thanks for reporting that. I installed the attached patch into the emacs-26 branch. Thanks, the problem is fixed now on my system. From unknown Sat Jun 14 04:55:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Oct 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator