From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:12:59 2017 Received: (at submit) by debbugs.gnu.org; 18 Sep 2017 15:13:00 +0000 Received: from localhost ([127.0.0.1]:46562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtxjH-0003sl-FV for submit@debbugs.gnu.org; Mon, 18 Sep 2017 11:12:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtwte-0002c3-Dd for submit@debbugs.gnu.org; Mon, 18 Sep 2017 10:19:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtwtV-0004Qf-5Q for submit@debbugs.gnu.org; Mon, 18 Sep 2017 10:19:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dtwtV-0004Qb-1m for submit@debbugs.gnu.org; Mon, 18 Sep 2017 10:19:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtwtT-0001yS-MC for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 10:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtwtO-0004Nf-J4 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 10:19:27 -0400 Received: from avasout03.plus.net ([84.93.230.244]:44373) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtwtO-0004L5-Bs for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 10:19:22 -0400 Received: from [192.168.0.2] ([80.229.245.74]) by avasout03 with smtp id B2KH1w0071d2MPU012KJEM; Mon, 18 Sep 2017 15:19:18 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=BeGo6vl2 c=1 sm=1 tr=0 a=dxFS4x0sVolc9CPZkeRDrw==:117 a=dxFS4x0sVolc9CPZkeRDrw==:17 a=kj9zAlcOel0A:10 a=h55ZjLXlAAAA:8 a=NmM7OjWb1dqr2YQhkfMA:9 a=T8e1oae3fi7k_Uz4:21 a=gKVBrhpVTz-4ihYd:21 a=CjuIK1q_8ugA:10 a=bVIcrEQjCtdAe-SrG74p:22 From: Duncan Harvey Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: 25.2; follow.el; Missing lighter and unused variable Message-Id: <98489D63-14B1-46E6-906A-0F87EED0711D@syndrig.co.uk> Date: Mon, 18 Sep 2017 15:19:17 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 18 Sep 2017 11:12:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) In .../lisp/follow.el{.gz} `follow-mode-line-text' is defined but not = used. Also, the `follow-mode' minor-mode does not define a lighter. My expectations, in order of preference: 1) Use the variable to define a lighter for `follow-mode', e.g.: --- follow.el 2017-02-03 10:25:44.000000000 +0000 +++ enlightened-follow.el 2017-09-18 14:53:15.000000000 +0100 @@ -416,6 +416,7 @@ (define-minor-mode follow-mode Keys specific to Follow mode: \\{follow-mode-map}" + :lighter follow-mode-line-text :keymap follow-mode-map (if follow-mode (progn 2) Define a lighter for `follow-mode', but don't use = `follow-mode-line-text'; remove definition of `follow-mode-line-text'. 3) Leave `follow-mode' without a lighter; remove definition of = `follow-mode-line-text'. In GNU Emacs 25.2.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 = Version 10.9.5 (Build 13F1911)) of 2017-04-21 built on builder10-9.porkrind.org Windowing system distributor 'Apple', version 10.3.1504 Configured using: 'configure --with-ns '--enable-locallisppath=3D/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 195592 8052) (symbols 48 19499 0) (miscs 40 51 194) (strings 32 14879 5891) (string-bytes 1 430402) (vectors 16 32840) (vector-slots 8 649625 4411) (floats 8 160 47) (intervals 56 199 0) (buffers 976 18)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 20:50:45 2017 Received: (at 28495) by debbugs.gnu.org; 19 Sep 2017 00:50:45 +0000 Received: from localhost ([127.0.0.1]:47023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6kP-0001oo-M0 for submit@debbugs.gnu.org; Mon, 18 Sep 2017 20:50:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6kO-0001oc-Gb for 28495@debbugs.gnu.org; Mon, 18 Sep 2017 20:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du6kI-0004jt-Hl for 28495@debbugs.gnu.org; Mon, 18 Sep 2017 20:50:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du6kE-0004gl-T9; Mon, 18 Sep 2017 20:50:34 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1du6kE-0003Jb-I5; Mon, 18 Sep 2017 20:50:34 -0400 From: Glenn Morris To: Duncan Harvey Subject: Re: bug#28495: 25.2; follow.el; Missing lighter and unused variable References: <98489D63-14B1-46E6-906A-0F87EED0711D@syndrig.co.uk> X-Spook: smugglers tempest Leitrim Cain and Abel Customs and X-Ran: jmw(ae/0x2#lJ:_|vthL&h_sk$^^KuKlu\2NzF4WCvT+2(NAA?WTKgFW.#TkfOurtd:%W- X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 18 Sep 2017 20:50:34 -0400 In-Reply-To: <98489D63-14B1-46E6-906A-0F87EED0711D@syndrig.co.uk> (Duncan Harvey's message of "Mon, 18 Sep 2017 15:19:17 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 28495 Cc: 28495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Duncan Harvey wrote: > In .../lisp/follow.el{.gz} `follow-mode-line-text' is defined but not used. Looks like it was used before commit 08a1dbe (ie, Emacs 22.1), via: (setq minor-mode-alist (cons '(follow-mode follow-mode-line-text) minor-mode-alist)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 20:52:26 2017 Received: (at control) by debbugs.gnu.org; 19 Sep 2017 00:52:26 +0000 Received: from localhost ([127.0.0.1]:47027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6m2-0001rp-0S for submit@debbugs.gnu.org; Mon, 18 Sep 2017 20:52:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6m0-0001ra-98 for control@debbugs.gnu.org; Mon, 18 Sep 2017 20:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du6lu-0006EL-Ll for control@debbugs.gnu.org; Mon, 18 Sep 2017 20:52:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du6lu-0006E9-Ho for control@debbugs.gnu.org; Mon, 18 Sep 2017 20:52:18 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1du6lu-0003Su-4B for control@debbugs.gnu.org; Mon, 18 Sep 2017 20:52:18 -0400 Subject: control message for bug 28495 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 18 Sep 2017 20:52:18 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) found 28495 22.1,25.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 21 19:25:05 2017 Received: (at 28495-done) by debbugs.gnu.org; 22 Nov 2017 00:25:05 +0000 Received: from localhost ([127.0.0.1]:51601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHIqf-0002sw-KG for submit@debbugs.gnu.org; Tue, 21 Nov 2017 19:25:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHIqe-0002rL-B0 for 28495-done@debbugs.gnu.org; Tue, 21 Nov 2017 19:25:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHIqY-000373-GF for 28495-done@debbugs.gnu.org; Tue, 21 Nov 2017 19:24:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHIqY-00036y-Cq for 28495-done@debbugs.gnu.org; Tue, 21 Nov 2017 19:24:58 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eHIqX-0001Xo-Uu; Tue, 21 Nov 2017 19:24:58 -0500 From: Glenn Morris To: 28495-done@debbugs.gnu.org Subject: Re: bug#28495: 25.2; follow.el; Missing lighter and unused variable References: <98489D63-14B1-46E6-906A-0F87EED0711D@syndrig.co.uk> X-Spook: Al-Qaeda CDMA Influenza Lockdown Disaster MIT-LL Smallpox X-Ran: #_!ZJjYl_&C8dS,g7l!YT_vp_]m[}SL(I&@KQ@Fj3:e;>6\=B(.R(g"%[XG (Glenn Morris's message of "Mon, 18 Sep 2017 20:50:34 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28495-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 26.0.91 commit 17fc74d (HEAD, emacs-26) Date: Tue Nov 21 19:23:30 2017 -0500 * lisp/follow.el (follow-mode): Restore mode line lighter. (Bug#28495) diff --git a/lisp/follow.el b/lisp/follow.el index 4893cad..1ec6ff3 100644 --- a/lisp/follow.el +++ b/lisp/follow.el @@ -416,6 +416,7 @@ follow-mode Keys specific to Follow mode: \\{follow-mode-map}" + :lighter follow-mode-line-text :keymap follow-mode-map (if follow-mode (progn From unknown Sun Jun 15 08:47:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Dec 2017 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator