GNU bug report logs - #28483
26.0.50; copy-directory does not create directories

Previous Next

Package: emacs;

Reported by: Aaron Jensen <aaronjensen <at> gmail.com>

Date: Sun, 17 Sep 2017 19:12:02 UTC

Severity: normal

Found in version 26.0.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: 28483 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>
Subject: bug#28483: [PATCH] Fix copy-directory creating missing directory
Date: Sun, 17 Sep 2017 13:19:55 -0700
On September 17, 2017 at 12:48:54 PM, Philipp Stephani
(p.stephani2 <at> gmail.com(mailto:p.stephani2 <at> gmail.com)) wrote:

> This would reintroduce the security hole that e22794867d878d53675fcc91d2ef1ad2494a2ff2 fixed.

Indeed, sorry about that. I’m attempting to patch the downstream
library that led me to this issue:
https://github.com/syl20bnr/spacemacs/pull/9600

> Paul, maybe you want to add some comments to the places where you introduced `directory-name-p' so that people don't attempt to revert these changes?

I’m not sure what Emac’s principles are on it, but perhaps an error
pointing to this change when attempting to copy to a non-existing
directory would help people in the future as well since this is a
change in behavior to an existing function w/o a deprecation.

Thanks,

Aaron




This bug report was last modified 7 years and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.