From unknown Fri Jun 20 07:20:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28483 <28483@debbugs.gnu.org> To: bug#28483 <28483@debbugs.gnu.org> Subject: Status: 26.0.50; copy-directory does not create directories Reply-To: bug#28483 <28483@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:20:41 +0000 retitle 28483 26.0.50; copy-directory does not create directories reassign 28483 emacs submitter 28483 Aaron Jensen severity 28483 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 15:11:27 2017 Received: (at submit) by debbugs.gnu.org; 17 Sep 2017 19:11:27 +0000 Received: from localhost ([127.0.0.1]:45262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dteyT-0006yx-89 for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:11:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dteyQ-0006yj-Kb for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:11:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dteyH-0000oA-GA for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:11:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dteyH-0000nx-CM for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:11:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dteyD-0003Qf-FF for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 15:11:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtey9-0000jb-DX for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 15:11:09 -0400 Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:45454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtey9-0000ij-17 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 15:11:05 -0400 Received: by mail-pf0-x229.google.com with SMTP id q76so3762516pfq.2 for ; Sun, 17 Sep 2017 12:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=SoloC8caPC2dly6JrATn3YHZaubuTKC9g2rD69ZI2AE=; b=D3B1h55Q8G6eQBESVlHeIpajd4Ty1f6hEf9rBG5BSjN1cfBWBnQSerCsxhvOhzPHQN HhgBvKuDx2fApMyExXFLGrpf5CoMfOq1mrnBlrz5k9d5AwMyR+9vk33QZRnXz0rDsu4j 6cs2OhpoUW+POSX4vLq9p3pRANE/WDkln9mDdJnz904sprs8GaLdsyx3fwCA0VudYcge aPnK2xZmfPCqk42O11uHDcLDmcZioZUDc7EqlEOUdWaMg1u98VUm9Q5F1uCWxPQCk9Zv wvOpAdw+Ot2G/dHc7DoJdZMnQWX7l56yUivXJRIXW+WDjgvcdWkKxkRucwfnXzMU/+nd QsMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=SoloC8caPC2dly6JrATn3YHZaubuTKC9g2rD69ZI2AE=; b=j6TCR4XfcMYhvI03+eu5wpinm/NBdzCgRZ0P5+efrlMBX/rIEPFjJNv15e+rU45E80 zDYhLVL9cKMZeM17gJ7wAOjCsTgbsIPgAZlWKGV5O1UwdA6npQ0rAn+xpTGOCecxcsEB LZISKAYK0Ph9DHtwWn7FcyxKM0ElnqaPuFfPyt+5w+wwcSmy7fZpQ0CwW+pjW8svR41T BVfnVVamBKRT2LaKDeLCNJPzFiJfPTnjtbDObwE/DPKWh+Wv+zxTC5mOqll6s9CkzSUN e8UjHwhfSjGrmolPwRxtMIow7oruYaRSbWFToA2RxTyPGZDIcPkfrjW8qiE+cOo7ILoU nIVg== X-Gm-Message-State: AHPjjUhi4/JBETp2mBqYICCD+jTnEmEMMbs4hPjQq6/d60x4PJQJJWkc nlSII9p63+/LYsc8evI= X-Google-Smtp-Source: ADKCNb6ubvwbedKtT4CWtxHnDcUcxWKxQ7pZCUPKS339ckeC0/ey1rjRDK3qAy59ouheySrYpt0FuQ== X-Received: by 10.98.34.219 with SMTP id p88mr30052322pfj.121.1505675462954; Sun, 17 Sep 2017 12:11:02 -0700 (PDT) Received: from aaron-mbpt.local (c-76-28-156-232.hsd1.wa.comcast.net. [76.28.156.232]) by smtp.gmail.com with ESMTPSA id 75sm11397243pfx.145.2017.09.17.12.11.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Sep 2017 12:11:01 -0700 (PDT) From: Aaron Jensen To: bug-gnu-emacs@gnu.org Subject: 26.0.50; copy-directory does not create directories Date: Sun, 17 Sep 2017 12:10:59 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) (copy-directory "existing-dir" "not-existing-dir/" 'keeptime 'create 'copy-content) The problem seems to be that copy-directory uses directory-name-p instead of file-directory-p to detect whether or not the directory exists. In GNU Emacs 26.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29)) of 2017-09-13 built on aaron-mbpt.local Repository revision: a0202fdc85ddc36b73a1c7c4f2d3ec45cd22c5e1 Windowing system distributor 'Apple', version 10.3.1504 Recent messages: t Type "q" to delete help window. [2 times] copy-directory newname /Users/aaronjensen/.emacs.d/.cache/.rollback/26.0/17-09-17_11.49.00/cider-20170905.1037/ wat t t Mark saved where search started [2 times] Saving file /Users/aaronjensen/Source/emacs/lisp/files.el... Wrote /Users/aaronjensen/Source/emacs/lisp/files.el Wrote /Users/aaronjensen/Source/emacs/lisp/files.elc Wrote /Users/aaronjensen/Source/emacs/lisp/files.{el,elc} Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus/HEAD-a0202fd_2 --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: company-mode: t auto-compile-mode: t elisp-slime-nav-mode: t eros-mode: t lispyville-mode: t lispy-mode: t nameless-mode: t goto-address-prog-mode: t bug-reference-prog-mode: t auto-highlight-symbol-mode: t highlight-numbers-mode: t highlight-parentheses-mode: t rainbow-delimiters-mode: t yas-global-mode: t yas-minor-mode: t global-git-gutter+-mode: t git-gutter+-mode: t projectile-mode: t recentf-mode: t evil-mc-mode: t hl-todo-mode: t global-spacemacs-whitespace-cleanup-mode: t spacemacs-whitespace-cleanup-mode: t ws-butler-global-mode: t ws-butler-mode: t winum-mode: t winner-mode: t volatile-highlights-mode: t global-vi-tilde-fringe-mode: t vi-tilde-fringe-mode: t pupo-mode: t purpose-mode: t spaceline-info-mode: t spaceline-helm-mode: t save-place-mode: t savehist-mode: t persp-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t Info-breadcrumbs-in-mode-line-mode: t flycheck-pos-tip-mode: t global-flycheck-mode: t flx-ido-mode: t eyebrowse-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-search-highlight-persist: t evil-search-highlight-persist: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-mode: t evil-lion-mode: t evil-escape-mode: t global-anzu-mode: t anzu-mode: t eval-sexp-fu-flash-mode: t editorconfig-mode: t global-edit-server-edit-mode: t dtrt-indent-mode: t diff-auto-refine-mode: t counsel-mode: t ivy-mode: t clean-aindent-mode: t aggressive-fill-paragraph-mode: t hybrid-mode: t which-key-mode: t override-global-mode: t global-undo-tree-mode: t undo-tree-mode: t evil-mode: t evil-local-mode: t spacemacs-leader-override-mode: t global-spacemacs-leader-override-mode: t global-hl-line-mode: t xterm-mouse-mode: t global-auto-revert-mode: t shell-dirtrack-mode: t ido-vertical-mode: t global-page-break-lines-mode: t page-break-lines-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t hs-minor-mode: t Load-path shadows: /Users/aaronjensen/.emacs.d/elpa/26.0/org-mac-link-20170105.1723/org-mac-link hides /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-mac-link /Users/aaronjensen/.emacs.d/elpa/26.0/ht-20161015.1945/ht hides /Users/aaronjensen/.emacs.d/core/libs/ht /Users/aaronjensen/.emacs.d/elpa/26.0/less-css-mode-20160930.2153/less-css-mode hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/textmodes/less-css-mode /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-texinfo hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-texinfo /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-publish hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-publish /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-org hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-org /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-odt hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-odt /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-md hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-md /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-man hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-man /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-latex hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-latex /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-icalendar hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-icalendar /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-html hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-html /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-beamer hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-beamer /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ox-ascii hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ox-ascii /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-w3m hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-w3m /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-version hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-version /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-timer hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-timer /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-table hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-table /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-src hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-src /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-rmail hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-rmail /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-protocol hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-protocol /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-plot hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-plot /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-pcomplete hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-pcomplete /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-mouse hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-mouse /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-mobile hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-mobile /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-mhe hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-mhe /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-macs hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-macs /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-macro hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-macro /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-loaddefs hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-loaddefs /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-list hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-list /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-lint hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-lint /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-irc hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-irc /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-install hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-install /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-inlinetask hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-inlinetask /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-info hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-info /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-indent hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-indent /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-id hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-id /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-habit hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-habit /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-gnus hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-gnus /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-footnote hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-footnote /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-feed hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-feed /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-faces hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-faces /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-eww hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-eww /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-eshell hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-eshell /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-entities hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-entities /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-element hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-element /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-docview hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-docview /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-datetree hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-datetree /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-ctags hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-ctags /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-crypt hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-crypt /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-compat hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-compat /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-colview hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-colview /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-clock hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-clock /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-capture hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-capture /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-bibtex hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-bibtex /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-bbdb hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-bbdb /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-attach hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-attach /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-archive hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-archive /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/org-agenda hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/org-agenda /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-tangle hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-tangle /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-table hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-table /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-stan hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-stan /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-sqlite hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-sqlite /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-sql hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-sql /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-shen hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-shen /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-shell hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-shell /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-sed hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-sed /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-screen hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-screen /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-scheme hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-scheme /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-sass hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-sass /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ruby hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ruby /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ref hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ref /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-R hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-R /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-python hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-python /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-processing hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-processing /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-plantuml hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-plantuml /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-picolisp hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-picolisp /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-perl hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-perl /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-org hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-org /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-octave hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-octave /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ocaml hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ocaml /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-mscgen hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-mscgen /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-maxima hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-maxima /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-matlab hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-matlab /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-makefile hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-makefile /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-lua hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-lua /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-lob hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-lob /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-lisp hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-lisp /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-lilypond hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-lilypond /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ledger hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ledger /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-latex hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-latex /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-keys hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-keys /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-js hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-js /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-java hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-java /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-J hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-J /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-io hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-io /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-haskell hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-haskell /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-groovy hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-groovy /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-gnuplot hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-gnuplot /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-fortran hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-fortran /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-forth hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-forth /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-exp hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-exp /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-eval hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-eval /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-emacs-lisp hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-emacs-lisp /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ebnf hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ebnf /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-dot hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-dot /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-ditaa hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-ditaa /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-css hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-css /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-core hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-core /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-coq hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-coq /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-comint hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-comint /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-clojure hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-clojure /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-calc hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-calc /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-C hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-C /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-awk hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-awk /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-asymptote hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-asymptote /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170911/ob-abc hides /usr/local/Cellar/emacs-plus/HEAD-a0202fd_2/share/emacs/26.0.50/lisp/org/ob-abc Features: (shadow sort mail-extr emacsbug sendmail executable counsel-projectile dired-collapse f drupal-mode drupal/emacs-drush drupal/flycheck drupal/phpcs drupal/ispell drupal/etags drupal/eldoc sql view php-mode flymake flymake-proc flymake-ui cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs eieio-opt speedbar sb-image ezimage dframe two-column iso-transl reposition mwim misearch multi-isearch vc-git open-junk-file company-files company-keywords company-etags company-gtags company-template company-dabbrev-code company-dabbrev company-capf company-insert-selected php-extras company auto-compile packed elisp-slime-nav eros flycheck-package package-lint finder lispyville lispy iedit iedit-lib multiple-cursors-core lispy-inline avy semantic/db semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet evil-ediff ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff edebug lispy-tags nameless goto-addr bug-reference auto-highlight-symbol highlight-numbers parent-mode highlight-parentheses hideshow rainbow-delimiters clojure-snippets yasnippet elec-pair editorconfig-core editorconfig-core-handle editorconfig-fnmatch cl-print debug git-gutter-fringe+ fringe-helper git-gutter+ mm-archive network-stream starttls url-cache colir smex projectile grep compile recentf tree-widget quiet-emacs fill-or-unfill restore-frame-position contextual-menubar init-xclip init-flyspell init-terminal-cursor evil-terminal-cursor-changer init-org org-inlinetask init-magit evil-mc evil-mc-command-execute evil-mc-command-record evil-mc-cursor-make evil-mc-region evil-mc-cursor-state evil-mc-undo evil-mc-vars evil-mc-known-commands evil-mc-common hl-todo ucs-utils persistent-soft list-utils font-utils zone xterm-color spacemacs-whitespace-cleanup ws-butler winum winner window-purpose-x imenu-list imenu ibuf-ext ibuffer ibuffer-loaddefs volatile-highlights vi-tilde-fringe unicode-fonts tmux string-inflection spacemacs-purpose-popwin window-purpose window-purpose-fixes window-purpose-prefix-overload window-purpose-switch let-alist window-purpose-layout window-purpose-core window-purpose-configuration window-purpose-utils spaceline-config spaceline-segments spaceline powerline powerline-separators color powerline-themes smartparens-config smartparens-text smartparens-ruby saveplace savehist ruby-test-mode pcre2el rxt re-builder ruby-mode smie popwin persp-mode osx-trash orgit git-rebase magit-gh-pulls gh gh-users gh-issues gh-pulls gh-repos gh-comments gh-gist gh-oauth gh-api logito gh-cache pcache eieio-base gh-auth gh-url url-http tls gnutls url-auth url-gw nsm evil-magit magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-branch magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-margin magit-mode magit-git magit-section magit-popup git-commit magit-utils crm log-edit message puny dired dired-loaddefs rfc822 mml mml-sec epa epg gnus-util rmail rmail-loaddefs mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async server ob-elixir ob-http ob-http-mode ob-restclient restclient url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap linum ivy-hydra info+ image-mode gh-common gh-profile s marshal flycheck-pos-tip pos-tip flycheck-flow flycheck flx-ido eyebrowse evil-surround evil-search-highlight-persist evil-numbers evil-lisp-state smartparens evil-lion evil-indent-plus evil-exchange evil-escape evil-args evil-anzu anzu cider-eval-sexp-fu eval-sexp-fu highlight editorconfig edit-server dtrt-indent drupal/pcomplete rx docker-tramp tramp-cache diff-hl vc-dir ewoc vc vc-dispatcher diff-mode counsel jka-compr esh-util etags xref project swiper ivy flx delsel ivy-overlay ffap clean-aindent-mode aggressive-fill-paragraph org-element avl-tree generator org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs dash adaptive-wrap hybrid-mode exec-path-from-shell evil-evilified-state which-key use-package diminish bind-key hydra lv cus-edit evil evil-integration undo-tree diff evil-maps evil-commands flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core evil-common windmove thingatpt rect evil-digraphs evil-vars info bind-map quelpa help-fns radix-tree package-build mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr json map lisp-mnt hl-line xt-mouse autorevert filenotify cl-extra disp-table wid-edit monokai-theme finder-inf tramp tramp-compat tramp-loaddefs trampver shell pcomplete comint ansi-color ring parse-time format-spec cus-start cus-load init-sass init-php init-html init-evil core-configuration-layer eieio-compat ht cl help-mode warnings package epg-config url-handlers url-parse auth-source cl-seq password-cache url-vars eieio eieio-core eieio-loaddefs ido-vertical-mode ido seq byte-opt bytecomp byte-compile cconv core-spacemacs core-use-package-ext core-transient-state core-micro-state core-toggle core-keybindings core-fonts-support core-spacemacs-buffer core-funcs cl-macs gv core-themes-support core-display-init core-jump core-release-management core-custom-settings core-dotspacemacs core-command-line pcase core-debug edmacro kmacro derived advice profiler easymenu cl-loaddefs cl-lib page-break-lines easy-mmode subr-x time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 1706186 1576957) (symbols 48 86264 46) (miscs 40 1795 4219) (strings 32 361663 146861) (string-bytes 1 10359082) (vectors 16 134081) (vector-slots 8 3856604 684583) (floats 8 568 3219) (intervals 56 82739 26409) (buffers 992 32)) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 15:15:22 2017 Received: (at 28483) by debbugs.gnu.org; 17 Sep 2017 19:15:22 +0000 Received: from localhost ([127.0.0.1]:45267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtf2I-0007Dl-M2 for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:15:22 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:55610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtf2G-0007D5-Ig for 28483@debbugs.gnu.org; Sun, 17 Sep 2017 15:15:20 -0400 Received: by mail-qk0-f182.google.com with SMTP id u73so5608552qkl.12 for <28483@debbugs.gnu.org>; Sun, 17 Sep 2017 12:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=WyKz/6EgSfhn4GlJ8TAipV4Y1CZxPRS1RhnMgwzWSbg=; b=rNUc8IqeD42dFQxblKUF3UaS4qlP1Bvgqvq3OfHfOV93qAh051GMgdOCubMjEYZ/mU biSW2vOr15srfC9uIdMWz1/7qCQMEOaA+qRViZrl/4UAldEZ5LXUQitx9cYO3OlopCMm Sxu2KEQFux/1frQtSm9BEPdCQav7TDCBHLdSueWWVCjZBpUZTRSzNtDnZxLoPPJ01k+Q bWtFS7lsR+TXIOa37zBy76knILAofmMvqAzAvtEsmjVaIgCw3AWjcV04WFSowdZySbhs aILK+dacRnYYB+1PeCDTRYkp2eCOgYDU5av/zJ5dS53GkjzxYRH5Om+FMyF9gS9QLQm/ j2Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=WyKz/6EgSfhn4GlJ8TAipV4Y1CZxPRS1RhnMgwzWSbg=; b=BME5KIFe9ZK8dXyjW7tLM82NMVdjXJojgw7AruAlNxJ1M6lqd5WvLS4vo48qwMwZ5v 7lYxISdktQuBCXQVOmrt2jJg7+AICTZE2zOmX2VfoZlPI83HNPNnCuBQbs3W+P5E7Ezo kaDV5sZNY/2TFgZW8uO3H4C4BkbPAdo6ukSc+M8yEnngIOsg17vX4EhnHrN/g3HAbELz ThZng3bkDfBezc921DZ/00AjtPx2XAai5sNwbhFeaWSNjSrl1w9brHHqLEtuOWDy0Qpe F53bxsYt7TKATp0HEg6BstwzcrkBmmHLgnxl9lO/kcK/djIlBUflmOllHafOzLrmTq4R +BdQ== X-Gm-Message-State: AHPjjUj9Oo+MlEYuKavLDjx9PmDwyUeChPzXs9gpIE+yMPC/FGmwHgvb d6XLoZ/jEeEUaZKbuEv07qUpi+RXShHRotQGG5n3SA== X-Google-Smtp-Source: AOwi7QAKoWbbgoCbjoc6QPxHky7ei+tnwgLrCq33axKZGUoZgFRnYsKW2EKgPoEYAHeo2cLSrimbMGayo6omxWhFrWg= X-Received: by 10.55.21.210 with SMTP id 79mr1882333qkv.56.1505675714776; Sun, 17 Sep 2017 12:15:14 -0700 (PDT) Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Sep 2017 12:15:13 -0700 From: Aaron Jensen X-Mailer: Airmail (442) MIME-Version: 1.0 Date: Sun, 17 Sep 2017 12:15:13 -0700 Message-ID: Subject: [PATCH] Fix copy-directory creating missing directory To: 28483@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * lisp/files.el (copy-directory): Use file-directory-p instead of directory-name-p. --- =C2=A0lisp/files.el | 2 +- =C2=A01 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/files.el b/lisp/files.el index c55c8097c1..b3a55af976 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5540,7 +5540,7 @@ copy-directory =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq directory (directory-file-name (expand-fil= e-name directory)) =C2=A0 =C2=A0 =C2=A0newname (expand-file-name newname)) - =C2=A0 =C2=A0 =C2=A0(cond ((not (directory-name-p newname)) + =C2=A0 =C2=A0 =C2=A0(cond ((not (file-directory-p newname)) =C2=A0 =C2=A0 =C2=A0 ;; If NEWNAME is not a directory name, create it; =C2=A0 =C2=A0 =C2=A0 ;; that is where we will copy the files of DIRECTORY. =C2=A0 =C2=A0 =C2=A0 (make-directory newname parents)) -- 2.13.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 15:20:08 2017 Received: (at 28483) by debbugs.gnu.org; 17 Sep 2017 19:20:08 +0000 Received: from localhost ([127.0.0.1]:45273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtf6u-0007QV-7b for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:20:08 -0400 Received: from mail-qt0-f177.google.com ([209.85.216.177]:51062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtf6s-0007Q4-JW for 28483@debbugs.gnu.org; Sun, 17 Sep 2017 15:20:06 -0400 Received: by mail-qt0-f177.google.com with SMTP id f15so5867127qtf.7 for <28483@debbugs.gnu.org>; Sun, 17 Sep 2017 12:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:date:message-id:subject:to:cc; bh=35VY7N84P6plFPtfnTyJhmWH6DfsDiVw/XvDOS7WuuY=; b=c1nvu8xErCEDCDGumkP2aBO0TOF+5djusYRYDxO/dIc4/GN3L6Vp1NULNat2XfprRk rjLTbYjpxsAUNYgiOjgJ5TyUNEqMfRZ0ISJjU5RWFyi9g9ceDg+HatRJZDhZyW0GoBQ3 P93Lzg0ingjLYHy78FkJ4Fok8A+gXod4PvXbE71cn6q+RMn7Gwre31hCSD9hXR5suJvf /LTxLcKF/aY3BhApnOsrAJf/18q4FpdoHRReXdKQMZg0DjDDEDoov8XgqsfYTnkwMZxu Wu/sY3xim95igTXOFM7Nq5pe1b+dGW/9/s73mbYgACHIVN5e3utuiqeqNmJ+ypzdVuHz HSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to:cc; bh=35VY7N84P6plFPtfnTyJhmWH6DfsDiVw/XvDOS7WuuY=; b=j0TY8cx2CBRuI9qsJvCmD60ofyvoS8RXORbwSoPXIbWBR14ULsP5l+LHwmlXYmE4H9 L0a3Sz10TxN+Zn3/+hFXD28stvx1p2C6+OrLq6Z1Tq/rJQz3hEe+UAAhdmPGtagNrJbO YKyhLzDAZeqlfFJ+TgRThwNMqB+7+eFCX2qPuExLr96nE3Ju4K9uPem92LCJehaHV7v7 4E4beANaGIQHdL41pYa4Y7z8KJrCPOB+zvonzWkinbyLPh1F7sTKLCjfamLYauqZlRJ7 w4TrviEhr5RHH0OxRc5jETcCOnnP/JLSW1LOkmNvOiN/d9OM7E87rNZvYrgVDiVUeRyK F/tA== X-Gm-Message-State: AHPjjUiT0PGW7ff+dz/2s4IyrUcpqj6Ll0zagW+74yRa4FqKejUM1/OB UGThMi3EsPaTBnDZhNPcVVxVWQu0Do2yprnn+mUqUg== X-Google-Smtp-Source: AOwi7QAxhI/JdPWhdKpkbJrNPK1gIfA3SeyX8DDAxSZi+ZznN+9ntJT2rqDH8N/NEUVVZZ45DauxM3r/qj5GQfiYXZY= X-Received: by 10.200.42.46 with SMTP id k43mr44800947qtk.273.1505676001018; Sun, 17 Sep 2017 12:20:01 -0700 (PDT) Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Sep 2017 12:20:00 -0700 From: Aaron Jensen X-Mailer: Airmail (442) MIME-Version: 1.0 Date: Sun, 17 Sep 2017 12:20:00 -0700 Message-ID: Subject: Re: 26.0.50; copy-directory does not create directories To: 28483@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a1140478e30209e055967836f" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28483 Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a1140478e30209e055967836f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It looks like this actually regressed in e22794867d878d53675fcc91d2ef1ad2494a2ff2 and was an intentional change. Paul, could you please take a look at my patch and see if it doesn=E2=80=99= t regress your intended change? Maybe there=E2=80=99s another cond necessary. Thanks, Aaron --001a1140478e30209e055967836f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =
It looks like this actually regressed in=C2=A0e22= 794867d878d53675fcc91d2ef1ad2494a2ff2 and was an intentional change.=C2=A0<= /div>

Paul, could you pleas= e take a look at my patch and see if it doesn=E2=80=99t regress your intend= ed change? Maybe there=E2=80=99s another cond necessary.

Thanks,

Aaron
--001a1140478e30209e055967836f-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 15:49:02 2017 Received: (at 28483) by debbugs.gnu.org; 17 Sep 2017 19:49:02 +0000 Received: from localhost ([127.0.0.1]:45283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtfYr-00085H-PS for submit@debbugs.gnu.org; Sun, 17 Sep 2017 15:49:02 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:51317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtfYq-00084M-9W for 28483@debbugs.gnu.org; Sun, 17 Sep 2017 15:49:00 -0400 Received: by mail-io0-f174.google.com with SMTP id l15so14372871iol.8 for <28483@debbugs.gnu.org>; Sun, 17 Sep 2017 12:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=f3VekUZXunKHS+cIPGYtvbRWiz1f5DZRxBKwetxFe4k=; b=B94YrX6yrhUw2CisEaIEKbugz/05P9e8Yl2d1utKTh8NUncvUhDGpRboajNFy1w3QS RIA8MB4nt5NLTZ7INluzLgIWN96TPg2c15t26Xe/6olG2w/QZ/ta8ZSudOGQwNzXTZLA cfA7JzIxuWi5XwyLE6tx40ZL6qmOr9EbxobAMPiAU5L7dx/HXqLhOeRXoG5zxV0noK1p QG7vw39kI0tpAYUL9SdkXryOoEq36Q8IpmrSjWu2sFn67OdtKaSfWqIM4Pl6yvsQpy/v BeU4JbuhuoG7e3yfxwOeuq7XSCVQogPueRlCZMSv00sndDnxQszOxIFsRaMbfjpGHrZU UA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=f3VekUZXunKHS+cIPGYtvbRWiz1f5DZRxBKwetxFe4k=; b=j1tpBd8qB+f5/L4VA9TlBt1q0H9AIMVsLiO0aVY6i6TCKp22JORZnKvrJNjKTIkRpY HMCo/ZYp0mUJO4C2ceJiHTQM9D5MqM+Pr9FPJnfK58FknnyvSdytuCrFWDzptRBOBaR4 tF78nXLVIPpm7pAdEzjW+GRj4gbV1nTjIycwidbGnvTk3OWoxjpfDAT1bO+0DCjZlCQd 4G75RXxb0PfCN0nNMXymPDG6k/s/FPx1szCubrdlVjy400W6Nst/JxNQNnapQrcvdSt7 7HCj9KcJZto2D3n+9Dv5QBTbhRfev+eiohT/YgDWxTbG9pbKZhmFEJaF1gRCeUjN0q0T tWBg== X-Gm-Message-State: AHPjjUiwV6K5d0LxufACLDgV87bWRMwBxPAUDgh5Td4k8Sp9aqRqL/6+ XDFz5OEhF1UwYqJ7CSZoL2N+ibVZN7H7uAwbKyM= X-Google-Smtp-Source: AOwi7QCA039leXC++BplvrjdOACztLH/KDSqCObr+YiTjlOG3iHC7sqAtPRTfm6Ci/yDxmbDTSCgs+1CyvBeUEb1uaA= X-Received: by 10.202.171.147 with SMTP id u141mr15747475oie.312.1505677734477; Sun, 17 Sep 2017 12:48:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Sun, 17 Sep 2017 19:48:44 +0000 Message-ID: Subject: Re: bug#28483: [PATCH] Fix copy-directory creating missing directory To: Aaron Jensen , 28483@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a113cc362828410055967ea80" X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 28483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --001a113cc362828410055967ea80 Content-Type: text/plain; charset="UTF-8" Aaron Jensen schrieb am So., 17. Sep. 2017 um 21:16 Uhr: > * lisp/files.el (copy-directory): Use file-directory-p instead of > directory-name-p. > --- > lisp/files.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/files.el b/lisp/files.el > index c55c8097c1..b3a55af976 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -5540,7 +5540,7 @@ copy-directory > (setq directory (directory-file-name (expand-file-name directory)) > newname (expand-file-name newname)) > > - (cond ((not (directory-name-p newname)) > + (cond ((not (file-directory-p newname)) > ;; If NEWNAME is not a directory name, create it; > ;; that is where we will copy the files of DIRECTORY. > (make-directory newname parents)) > This would reintroduce the security hole that e22794867d878d53675fcc91d2ef1ad2494a2ff2 fixed. Paul, maybe you want to add some comments to the places where you introduced `directory-name-p' so that people don't attempt to revert these changes? --001a113cc362828410055967ea80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


* lisp/files.el (copy-directory): Use file-directory-p= instead of
directory-name-p.
---
=C2=A0lisp/files.el | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/files.el b/lisp/files.el
index c55c8097c1..b3a55af976 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -5540,7 +5540,7 @@ copy-directory
=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq directory (directory-file-name (expand-fil= e-name directory))
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0newname (expand-file-name ne= wname))

- =C2=A0 =C2=A0 =C2=A0(cond ((not (directory-name-p newname))
+ =C2=A0 =C2=A0 =C2=A0(cond ((not (file-directory-p newname))
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; If NEWNAME is not a dire= ctory name, create it;
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; that is where we will co= py the files of DIRECTORY.
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (make-directory newname par= ents))

This would reintroduce the security hole t= hat e22794867d878d53675fcc91d2ef1ad2494a2ff2 fixed.

Paul, maybe you want to add some comments to the places where you introdu= ced `directory-name-p' so that people don't attempt to revert these= changes?
--001a113cc362828410055967ea80-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 16:20:09 2017 Received: (at 28483) by debbugs.gnu.org; 17 Sep 2017 20:20:09 +0000 Received: from localhost ([127.0.0.1]:45327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtg2x-0000Ol-Ft for submit@debbugs.gnu.org; Sun, 17 Sep 2017 16:20:08 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:45266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtg2s-0000OA-MB for 28483@debbugs.gnu.org; Sun, 17 Sep 2017 16:20:06 -0400 Received: by mail-qk0-f178.google.com with SMTP id r141so5741454qke.2 for <28483@debbugs.gnu.org>; Sun, 17 Sep 2017 13:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=IKSQtFs+HdJoLugtTGxLih5SinWTxmi9ouUzgTNpbcE=; b=vW5BIJZrkNPXilrHj0TaIdvD+/Un8/gGQUrCWidG7nWebSENDQwW0TRcXciEsgMdSY t4Gwp/2cVrSounoUBo0G2Fd9YitvVIDxFORS4sKmdeXgryPpR9x0b8OM85ISnXPaSPaj itTfu5AdllHHElF1iXdNQaPC0/l1UNsdC2ToLEnRcF5YJqyC8mADmB9SuQLOAYtkClVv +jsdObUTnOyb59mVBA4cqxb3ieHWwFv1TTlGZSF8g6q9qxv9zYezwrq6WLmV9QuwGQ29 JggFSSJCJ+uygyPQ+LkWZhx79PQ8iujasqv7Qo2XAPWSeIP69ap23iytdSPCntMXKZrA lwKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=IKSQtFs+HdJoLugtTGxLih5SinWTxmi9ouUzgTNpbcE=; b=H4/FksCNI3aChXOJLx8KcEnaDzioiEwZd3vYoeYn7Ib6lzAIre7NBzclb5UpvUzM0J 0zb2yU48EM4a94IGTswB4NPoo5q1/Q33RRLdnqQ7I9Ssg/TK7lamLUrjW2+FthPNr1SW SMWW4E8xwRrEwLt02qXBzCAIQkv4+E+54H4O9tKaKhPBymFo8R/P4L2fmFDmNDzrfdAI rm0X71558hVcVHD7DqaNDw6h/8kKuuIJVG5tPHsLkSRVoyiyetswuMunM781rIxv2hRt Bw1sTiqNHVa9o8vjgAJTfibS/AAhv/0vSnh8o5bEiaS68MYVo8wPz+FGUUiA3VkS0SPb rwfw== X-Gm-Message-State: AHPjjUg3lGChv9D/qhss66BB59xmOpL3AiTJieVlpT2dnDzHz95F2Rjw /jR04TlMYRj2KLOVDYvNuUd26XGdDIUwDXx2jbnUJQ== X-Google-Smtp-Source: AOwi7QDF/pYbSrCdj/TlJCBswLQ1lQ+FfAypIT9W7grs1BpOMJmS1edTXt7MNkNXwEko+lUxYJgKbYBvu310nq1et7w= X-Received: by 10.55.21.210 with SMTP id 79mr2067297qkv.56.1505679596918; Sun, 17 Sep 2017 13:19:56 -0700 (PDT) Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Sep 2017 13:19:55 -0700 From: Aaron Jensen In-Reply-To: References: X-Mailer: Airmail (442) MIME-Version: 1.0 Date: Sun, 17 Sep 2017 13:19:55 -0700 Message-ID: Subject: Re: bug#28483: [PATCH] Fix copy-directory creating missing directory To: 28483@debbugs.gnu.org, Philipp Stephani Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On September 17, 2017 at 12:48:54 PM, Philipp Stephani (p.stephani2@gmail.com(mailto:p.stephani2@gmail.com)) wrote: > This would reintroduce the security hole that e22794867d878d53675fcc91d2e= f1ad2494a2ff2 fixed. Indeed, sorry about that. I=E2=80=99m attempting to patch the downstream library that led me to this issue: https://github.com/syl20bnr/spacemacs/pull/9600 > Paul, maybe you want to add some comments to the places where you introdu= ced `directory-name-p' so that people don't attempt to revert these changes= ? I=E2=80=99m not sure what Emac=E2=80=99s principles are on it, but perhaps = an error pointing to this change when attempting to copy to a non-existing directory would help people in the future as well since this is a change in behavior to an existing function w/o a deprecation. Thanks, Aaron From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 16:41:03 2017 Received: (at 28483-done) by debbugs.gnu.org; 17 Sep 2017 20:41:03 +0000 Received: from localhost ([127.0.0.1]:45348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtgN9-0000sc-Qy for submit@debbugs.gnu.org; Sun, 17 Sep 2017 16:41:03 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtgN5-0000sM-BU for 28483-done@debbugs.gnu.org; Sun, 17 Sep 2017 16:40:59 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D22C8160D33; Sun, 17 Sep 2017 13:40:49 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QC6YSikQKSwg; Sun, 17 Sep 2017 13:40:45 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7AF66160CCA; Sun, 17 Sep 2017 13:40:45 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8bwyAVYJSIa1; Sun, 17 Sep 2017 13:40:45 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5C58F160078; Sun, 17 Sep 2017 13:40:45 -0700 (PDT) Subject: Re: 26.0.50; copy-directory does not create directories To: Aaron Jensen , 28483-done@debbugs.gnu.org References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> Date: Sun, 17 Sep 2017 13:40:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28483-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The recent security patch to copy-directory had the unintended side effect of refusing to make the destination directory when COPY-CONTENTS is non-nil and when the destination is a directory name. Sorry about that. I installed a patch in the emacs-26 branch, here: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=37b5e661d298cbfe51422cd515b6696a1cdaa868 Please give it a try. As I think it fixes the bug, I'm boldly closing this bug report; we can reopen it if I'm wrong. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 19:12:34 2017 Received: (at 28483-done) by debbugs.gnu.org; 17 Sep 2017 23:12:34 +0000 Received: from localhost ([127.0.0.1]:45375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtijp-0004NB-Mf for submit@debbugs.gnu.org; Sun, 17 Sep 2017 19:12:34 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:56543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtijk-0004Mu-84 for 28483-done@debbugs.gnu.org; Sun, 17 Sep 2017 19:12:32 -0400 Received: by mail-qk0-f181.google.com with SMTP id u7so5827074qku.13 for <28483-done@debbugs.gnu.org>; Sun, 17 Sep 2017 16:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=4fCkFhu26hR5agPTv0b/FoU7PJbHYtIAU0rp7szxkgs=; b=RXHjbImrU8mVvh+5yfKkO6xMCJbJtY90fk2gIxizuqUf3mt2znsWFj316XUJbNa3z7 ap+sY+5EblO7T0jst1Wo8LCsluxu2QUtp5NdosOdiP9/iQOOos1PRZli2nCmywwucjXn eYIUtqeZKVkPED2AzzghJHoWsVgnu75eXu1iLAYBWnwgNmewxAiDV4VnJFYzMHq5QHzJ 21z9CiVcnZCJ+RPKqhg2ZZa4ok8lESdwN9FAb/QXxksa14efAdYqar880js9Ke4PBXp+ zAUu0ajeTPxjpYR2BgsIHTdFiKblnBF8BGnGi5cf5JXysqi4pgN32C6sEPFmS1RycuOI oWPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=4fCkFhu26hR5agPTv0b/FoU7PJbHYtIAU0rp7szxkgs=; b=SJOq7ijw+XF8OpD7F7yhJQ7T4Fh56Hf//fMlh7H3tPhlXwylGKqb6yIHaphOssxkCK C+d4VBD3AmX72nczVRZsV4Y050R93MkuMcnq966xGuAvWX1/FyUfVkh3KqAIP7AyRXX/ F0VInWRV4ih9ZusLuDhIAhmbEW1CnH8wKEwsD1lsS6yAWZIxLI/vUNULxWiyH8QcHxTN 3FnK14LJsFblsBZwRL2lBBSrL+WENU2vu0ejG5ZMI9xmPyzFfHc91nXa8tNCl3u/mJpL jOnsaiGQ8L7eE/LcsuZdQJFWM3BMyHDliNF8e0W0IJ01rFFQOQvtC8mZco0uJNzKhG0I 2B8A== X-Gm-Message-State: AHPjjUhNCd/nS09qRfgwyuwhDYOaMPLSzNfLKxHw0Qw3DXls2Nkp0StH PqPz0hDB/UQsjs8DmXERpoSz3AdJ/Etv6smtk1w= X-Google-Smtp-Source: AOwi7QADD/Kt2E8D/D2UVMC1VPlW/6hmrDpgMmLKmGYlesDKuG2+UV5s0ubrolOjF4IR3a2ANqC9gZJxQ3J8xE4mC0Q= X-Received: by 10.55.73.213 with SMTP id w204mr18012725qka.215.1505689942815; Sun, 17 Sep 2017 16:12:22 -0700 (PDT) Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Sep 2017 16:12:21 -0700 From: Aaron Jensen In-Reply-To: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> References: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> X-Mailer: Airmail (442) MIME-Version: 1.0 Date: Sun, 17 Sep 2017 16:12:21 -0700 Message-ID: Subject: Re: 26.0.50; copy-directory does not create directories To: Paul Eggert , 28483-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28483-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On September 17, 2017 at 1:40:50 PM, Paul Eggert (eggert@cs.ucla.edu(mailto:eggert@cs.ucla.edu)) wrote: > The recent security patch to copy-directory had the unintended side effec= t of > refusing to make the destination directory when COPY-CONTENTS is non-nil = and > when the destination is a directory name. Sorry about that. I installed a= patch > in the emacs-26 branch, here: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-26&id=3D37b5= e661d298cbfe51422cd515b6696a1cdaa868 > > Please give it a try. As I think it fixes the bug, I'm boldly closing thi= s bug > report; we can reopen it if I'm wrong. That fixed it for me. Thank you! And thanks for pointing out the emacs-26 branch, that=E2=80=99s exciting. D= o fixes not typically get merged back into master until after the release? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 19:52:11 2017 Received: (at 28483-done) by debbugs.gnu.org; 17 Sep 2017 23:52:11 +0000 Received: from localhost ([127.0.0.1]:45387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtjMA-0005IO-RB for submit@debbugs.gnu.org; Sun, 17 Sep 2017 19:52:10 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtjM8-0005IB-SJ for 28483-done@debbugs.gnu.org; Sun, 17 Sep 2017 19:52:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1C6EA160D5C; Sun, 17 Sep 2017 16:52:02 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3kAEmAJ5_LQ3; Sun, 17 Sep 2017 16:52:01 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6CDED160D4B; Sun, 17 Sep 2017 16:52:01 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Quq447aHkleg; Sun, 17 Sep 2017 16:52:01 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4E57A160D1D; Sun, 17 Sep 2017 16:52:01 -0700 (PDT) Subject: Re: 26.0.50; copy-directory does not create directories To: Aaron Jensen , 28483-done@debbugs.gnu.org References: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <5da6051f-ab51-80e4-113b-1580a94ce6fa@cs.ucla.edu> Date: Sun, 17 Sep 2017 16:52:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28483-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Aaron Jensen wrote: > Do > fixes not typically get merged back into master until after the > release? No, we typically merge them periodically well before then. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 13:40:36 2017 Received: (at 28483) by debbugs.gnu.org; 18 Sep 2017 17:40:36 +0000 Received: from localhost ([127.0.0.1]:46763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du027-0002s7-Gq for submit@debbugs.gnu.org; Mon, 18 Sep 2017 13:40:36 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:55815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du024-0002rt-4Y for 28483@debbugs.gnu.org; Mon, 18 Sep 2017 13:40:33 -0400 Received: by mail-io0-f172.google.com with SMTP id z187so3971798ioz.12 for <28483@debbugs.gnu.org>; Mon, 18 Sep 2017 10:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=07gYOrF6GEH6HKsPQLy1LKedBQbzczzkfEzPyKPQZKI=; b=sOg3kquEe9b2uLmLO511m1WyWzKvaGhi1A8v80/nTQVjY6wwiEMpw3G5iaL6+qWutS xtlU8gN7OkJG2s2J2UShTLdrGe7jgZkvoIdX/U+YWP2A35rMSjAcVKD5cEnxwsORQWtH 5EQeACB+jIsPYBy2kSKYZbqSvI2ZW651nMCDQIBmAeKrlLNzlBEj4Mkz3enKATgI9aMv OlniusRV9DzmdAwFT+idchwjqrl/GsPjl9xOQkibV27omxNtQPINKOe9fQ75lDJzfQ1P e53DfY9PODSnux2mRA57/NDOSV8TUBU68Bq1sGVuYd8WBsTqFm3pDxyWS11unQk5mVjg QCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=07gYOrF6GEH6HKsPQLy1LKedBQbzczzkfEzPyKPQZKI=; b=t3jYDyelrVGx/E7GuJqQLuduI/KDokPdlYpVKmiCDxRIonOSd3YtUaEvIAqB69NwnK DIFf2syvUo/0uYmibM0QlPfaHBfBTlN+Nox3JB9byeHyv3eGP6Xm9AIbO/Eoi1/Td86f 1oDKVOhv6J8xlWbc7y/lRSqeAcPhsjm5PLVqNrQtg1FgD93vF3pFXWA2QdxlOtU74XI0 PIoyLpQKMQwvQWQETcyQifX1k4etLHgOmX/hYre1bHzls27WpGWx2J7SI6W3O1kJra/m RF5IyLifJpfLftEiImZSMY048Eixhvgv+rP3zbP1PLW4BjsGfRp84wfuWgPaezkww0Q6 AIOg== X-Gm-Message-State: AHPjjUgxtR9y5rq11On7E8f7eWiQUrmhwro1sJxv+94bZAJol+TPMtC4 G2OvatMnLzWgkmNlg4rFcXMA6uLk0to4cRbi+o4= X-Google-Smtp-Source: AOwi7QBId34TXwjtbwI3Ze2xjEsq75NHmI8Hwcb8pY6mWIL1ndI2dbF7SHYFk0kSBNn+wBRfNjHyJvQvN27AzqKVihQ= X-Received: by 10.202.66.196 with SMTP id p187mr11145953oia.52.1505756426343; Mon, 18 Sep 2017 10:40:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Mon, 18 Sep 2017 17:40:15 +0000 Message-ID: Subject: Re: bug#28483: [PATCH] Fix copy-directory creating missing directory To: Aaron Jensen , 28483@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a113d688ce91e5c05597a3ca6" X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 28483 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --001a113d688ce91e5c05597a3ca6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Aaron Jensen schrieb am So., 17. Sep. 2017 um 22:19 Uhr: > > I=E2=80=99m not sure what Emac=E2=80=99s principles are on it, but perhap= s an error > pointing to this change when attempting to copy to a non-existing > directory would help people in the future as well since this is a > change in behavior to an existing function w/o a deprecation. > > I think copy-directory is mostly used by libraries, so alerting the user wouldn't help: the problem is in the libraries that invoke copy-directory. That the behavior changed is unfortunate, but unavoidable due to security concerns. The behavior changes are mentioned in NEWS. --001a113d688ce91e5c05597a3ca6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable --001a113d688ce91e5c05597a3ca6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 20 11:11:38 2017 Received: (at 28483) by debbugs.gnu.org; 20 Sep 2017 15:11:38 +0000 Received: from localhost ([127.0.0.1]:50291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dugf4-00044O-9q for submit@debbugs.gnu.org; Wed, 20 Sep 2017 11:11:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dugf1-00044A-MB for 28483@debbugs.gnu.org; Wed, 20 Sep 2017 11:11:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duge5-0002CE-Sv for 28483@debbugs.gnu.org; Wed, 20 Sep 2017 11:11:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dugct-00087K-Ft; Wed, 20 Sep 2017 11:09:23 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3300 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dud9l-00070N-Pr; Wed, 20 Sep 2017 07:27:06 -0400 Date: Wed, 20 Sep 2017 14:26:56 +0300 Message-Id: <83mv5pfw5b.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> (message from Paul Eggert on Sun, 17 Sep 2017 13:40:45 -0700) Subject: Re: bug#28483: 26.0.50; copy-directory does not create directories References: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28483 Cc: 28483@debbugs.gnu.org, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Sun, 17 Sep 2017 13:40:45 -0700 > > The recent security patch to copy-directory had the unintended side effect of > refusing to make the destination directory when COPY-CONTENTS is non-nil and > when the destination is a directory name. Sorry about that. I installed a patch > in the emacs-26 branch, here: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=37b5e661d298cbfe51422cd515b6696a1cdaa868 > > Please give it a try. As I think it fixes the bug, I'm boldly closing this bug > report; we can reopen it if I'm wrong. Thanks. I still see a problem in copy-directory if I modify the original recipe slightly: by having the directory ~/test2/a empty (in the original recipe it included one file. ~/test2/a/e). If that directory is empty, it is not copied to the destination. Moreover, the logic in copy-directory transfers the modes and timestamp of the (not-copied) directory to the destination directory, not to the copy. I think the problem is in this line: (cond ((eq filetype t) ; Directory but not a symlink. (copy-directory file newname keep-time parents)) <<<<<<<<<<< Instead of 'newname', there should be (file-name-as-directory newname) there. I think. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 20 14:59:49 2017 Received: (at 28483) by debbugs.gnu.org; 20 Sep 2017 18:59:49 +0000 Received: from localhost ([127.0.0.1]:50492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dukDr-0001HS-8I for submit@debbugs.gnu.org; Wed, 20 Sep 2017 14:59:47 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dukDp-0001H7-7H; Wed, 20 Sep 2017 14:59:45 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3C64B160AEB; Wed, 20 Sep 2017 11:59:39 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GO5z218rFOvq; Wed, 20 Sep 2017 11:59:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4E639160BF0; Wed, 20 Sep 2017 11:59:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 62g8EZC72wKQ; Wed, 20 Sep 2017 11:59:38 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2DC3B160AEB; Wed, 20 Sep 2017 11:59:38 -0700 (PDT) Subject: Re: bug#28483: 26.0.50; copy-directory does not create directories To: Eli Zaretskii References: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> <83mv5pfw5b.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Wed, 20 Sep 2017 11:59:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <83mv5pfw5b.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------76E760785E419C48D3063ADA" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28483 Cc: 28483@debbugs.gnu.org, Adam Plaice , 28520-done@debbugs.gnu.org, aaronjensen@gmail.com, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------76E760785E419C48D3063ADA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 09/20/2017 04:26 AM, Eli Zaretskii wrote: > I think the problem is in this line: > > (cond > ((eq filetype t) ; Directory but not a symlink. > (copy-directory file newname keep-time parents)) <<<<<<<<<<< > > Instead of 'newname', there should be (file-name-as-directory newname) > there. I think. Thanks for diagnosing the problem and for the fix. That fix should work, and I think we can improve on it slightly by using (copy-directory file target keep-time parents t), as this makes the cond branch more parallel with the other alternatives and avoids a call to file-name-as-directory. So I installed the attached patch into the emacs-26 branch to do that, and to add a test case for this bug. This patch should also fix Bug#28520 "Dired recursive copy of directory fails", so I'll CC: that bug report and boldly close it. PS. Sorry, Adam, for misspelling your first name in the commit message. I'll try to remember to fix that when it spills out into the ChangeLog file. --------------76E760785E419C48D3063ADA Content-Type: text/x-patch; name="0001-Fix-new-copy-directory-bug-with-empty-dirs.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-new-copy-directory-bug-with-empty-dirs.patch" >From b4531a78ded7efb0c133763b5efe1f4dab1aa4de Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 20 Sep 2017 11:49:12 -0700 Subject: [PATCH] Fix new copy-directory bug with empty dirs Problem reported by Afdam Plaice (Bug#28520) and by Eli Zaretskii (Bug#28483#34). This is another bug that I introduced in my recent copy-directory changes. * lisp/files.el (copy-directory): Work with empty subdirectories, too. * test/lisp/files-tests.el (files-tests--copy-directory): Test for this bug. --- lisp/files.el | 2 +- test/lisp/files-tests.el | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index 0c30d40c13..f0a1f2380d 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5564,7 +5564,7 @@ copy-directory (filetype (car (file-attributes file)))) (cond ((eq filetype t) ; Directory but not a symlink. - (copy-directory file newname keep-time parents)) + (copy-directory file target keep-time parents t)) ((stringp filetype) ; Symbolic link (make-symbolic-link filetype target t)) ((copy-file file target t keep-time))))) diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el index f2a9a32180..285a884b69 100644 --- a/test/lisp/files-tests.el +++ b/test/lisp/files-tests.el @@ -399,11 +399,16 @@ files-tests--with-temp-file (dirname (file-name-as-directory dir)) (source (concat dirname "source")) (dest (concat dirname "dest/new/directory/")) - (file (concat (file-name-as-directory source) "file"))) + (file (concat (file-name-as-directory source) "file")) + (source2 (concat dirname "source2")) + (dest2 (concat dirname "dest/new2"))) (make-directory source) (write-region "" nil file) (copy-directory source dest t t t) (should (file-exists-p (concat dest "file"))) + (make-directory (concat (file-name-as-directory source2) "a") t) + (copy-directory source2 dest2) + (should (file-directory-p (concat (file-name-as-directory dest2) "a"))) (delete-directory dir 'recursive))) (provide 'files-tests) -- 2.13.5 --------------76E760785E419C48D3063ADA-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 20 15:55:09 2017 Received: (at 28483) by debbugs.gnu.org; 20 Sep 2017 19:55:09 +0000 Received: from localhost ([127.0.0.1]:50533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dul5R-0002dC-F0 for submit@debbugs.gnu.org; Wed, 20 Sep 2017 15:55:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dul5Q-0002cy-EN for 28483@debbugs.gnu.org; Wed, 20 Sep 2017 15:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dul5G-0004g9-UL for 28483@debbugs.gnu.org; Wed, 20 Sep 2017 15:55:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dul4s-0004Gj-Rx; Wed, 20 Sep 2017 15:54:34 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3848 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dul4s-0003jW-Ai; Wed, 20 Sep 2017 15:54:34 -0400 Date: Wed, 20 Sep 2017 22:54:26 +0300 Message-Id: <837ewtf8nh.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Wed, 20 Sep 2017 11:59:37 -0700) Subject: Re: bug#28483: 26.0.50; copy-directory does not create directories References: <972c8b3c-f72d-d447-78b3-cc7fcf6234e5@cs.ucla.edu> <83mv5pfw5b.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28483 Cc: 28483@debbugs.gnu.org, plaice.adam+lists@gmail.com, 28520@debbugs.gnu.org, aaronjensen@gmail.com, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 28483@debbugs.gnu.org, aaronjensen@gmail.com, 28520-done@debbugs.gnu.org, > Adam Plaice , > Tino Calancha > From: Paul Eggert > Date: Wed, 20 Sep 2017 11:59:37 -0700 > > Thanks for diagnosing the problem and for the fix. That fix should work, > and I think we can improve on it slightly by using (copy-directory file > target keep-time parents t), as this makes the cond branch more parallel > with the other alternatives and avoids a call to file-name-as-directory. > So I installed the attached patch into the emacs-26 branch to do that, > and to add a test case for this bug. Thanks, works for me. From unknown Fri Jun 20 07:20:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Oct 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator