Subject: Re: bug#28483: [PATCH] Fix copy-directory creating missing directory

From: Aaron Jensen <[email-masked]>
Date: Sun, 17 Sep 2017 13:19:55 -0700

On September 17, 2017 at 12:48:54 PM, Philipp Stephani
([email-masked](mailto:[email-masked])) wrote:

> This would reintroduce the security hole that e22794867d878d53675fcc91d2ef1ad2494a2ff2 fixed.

Indeed, sorry about that. I’m attempting to patch the downstream
library that led me to this issue:
https://github.com/syl20bnr/spacemacs/pull/9600

> Paul, maybe you want to add some comments to the places where you introduced `directory-name-p' so that people don't attempt to revert these changes?

I’m not sure what Emac’s principles are on it, but perhaps an error
pointing to this change when attempting to copy to a non-existing
directory would help people in the future as well since this is a
change in behavior to an existing function w/o a deprecation.

Thanks,

Aaron