From unknown Wed Jun 18 00:25:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28476 <28476@debbugs.gnu.org> To: bug#28476 <28476@debbugs.gnu.org> Subject: Status: 26.0.60; Gnus: broken timezone in citation line Reply-To: bug#28476 <28476@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:25:32 +0000 retitle 28476 26.0.60; Gnus: broken timezone in citation line reassign 28476 emacs submitter 28476 Mike Kupfer severity 28476 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 01:14:37 2017 Received: (at submit) by debbugs.gnu.org; 17 Sep 2017 05:14:37 +0000 Received: from localhost ([127.0.0.1]:44384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtRuf-0000kg-FN for submit@debbugs.gnu.org; Sun, 17 Sep 2017 01:14:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtRud-0000kP-GT for submit@debbugs.gnu.org; Sun, 17 Sep 2017 01:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtRuX-0004oN-3w for submit@debbugs.gnu.org; Sun, 17 Sep 2017 01:14:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52169) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dtRuX-0004oB-0c for submit@debbugs.gnu.org; Sun, 17 Sep 2017 01:14:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtRuV-0001pz-5T for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 01:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtRuR-0004i9-W1 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 01:14:27 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:34452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtRuR-0004e1-MV for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 01:14:23 -0400 Received: from alto (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id v8H5EIHk047900 for ; Sat, 16 Sep 2017 22:14:19 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be alto From: Mike Kupfer To: bug-gnu-emacs@gnu.org Subject: 26.0.60; Gnus: broken timezone in citation line X-Mailer: MH-E 8.6+git; nmh 1.7-RC3; GNU Emacs 26.0.60 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20971.1505625258.1@alto> Content-Transfer-Encoding: quoted-printable Date: Sat, 16 Sep 2017 22:14:18 -0700 Message-ID: <20972.1505625258@alto> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I have message-citation-line-format set to "On %e %B %Y %R %Z, %N wrote:\n" When replying to a message whose date field is displayed as Date: Sat, 16 Sep 2017 17:18:30 -0700 the citation comes out as On 16 September 2017 17:18 +07, Mike Kupfer wrote: I expect On 16 September 2017 17:18 -0700, Mike Kupfer wrote: which is what Emacs 25.3 gives me. The message I'm replying to is on an IMAP server, if that makes any difference. In GNU Emacs 26.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw scroll = bars) of 2017-09-16 built on alto Repository revision: 1d599df5e0fbbc52e8592c0aff1d23e978c29b67 Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 8.9 (jessie) Recent messages: Opening nndoc server on /media/kupfer/KBLUE/ToFile/upload-tofile-home...do= ne Opening nndoc server on /home/kupfer/Desktop/upload-action...done Contacting host: [redacted] Contacting host: [redacted] Checking new news...done nnimap read 0k from [redacted] Processing kill file /home/kupfer/News/KILL...done No more unseen articles nnimap read 0k from [redacted] Mark set [12 times] Configured using: 'configure --prefix=3D/usr/new' Configured features: XPM JPEG TIFF GIF PNG SOUND NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 Important settings: value of $LC_TIME: C value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Message Minor modes in effect: gnus-message-citation-mode: t mml-mode: t shell-dirtrack-mode: t delete-selection-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t auto-fill-function: message-do-auto-fill transient-mark-mode: t Load-path shadows: None found. Features: (shadow mh-mime mh-identity mh-tool-bar mh-letter mh-show goto-addr mh-xface mh-utils mh-comp mh-scan mh-gnus mh-e mh-compat mh-buffers mh-loaddefs emacsbug cl-print help-fns radix-tree vc-hg nnir sort gnus-cite mail-extr gnus-async gnus-bcklg gnus-kill gnus-dup gnus-ml disp-table mm-archive url-http url-gw url-cache url-auth url-handlers nnrss xml mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars nndoc nndraft nnmh utf-7 rfc2104 cl-extra help-mode network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap nntp gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader mdk-mail smtpmail auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs sendmail message subr-x puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader misearch multi-isearch crm thingatpt cus-edit cus-start cus-load wid-edit elec-pair warnings server noutline outline easy-mmode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs shell pcomplete comint ansi-color ring xcscope easymenu advice delsel vc cl-loaddefs cl-lib vc-dispatcher timeclock mdk-hacks time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 505215 21681) (symbols 48 244263 6) (miscs 40 586 680) (strings 32 198558 4337) (string-bytes 1 6115645) (vectors 16 33085) (vector-slots 8 887601 27067) (floats 8 270 670) (intervals 56 1582 28) (buffers 992 43) (heap 1024 75376 11221)) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 10:25:29 2017 Received: (at 28476) by debbugs.gnu.org; 17 Sep 2017 14:25:29 +0000 Received: from localhost ([127.0.0.1]:45185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtaVl-0000Yi-A9 for submit@debbugs.gnu.org; Sun, 17 Sep 2017 10:25:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtaVj-0000YT-NR for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 10:25:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtaVZ-0005JR-LI for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 10:25:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtaVZ-0005JM-HK; Sun, 17 Sep 2017 10:25:17 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3234 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dtaVY-0000uM-Qa; Sun, 17 Sep 2017 10:25:17 -0400 Date: Sun, 17 Sep 2017 17:25:27 +0300 Message-Id: <83efr5jtbc.fsf@gnu.org> From: Eli Zaretskii To: Mike Kupfer In-reply-to: <20972.1505625258@alto> (message from Mike Kupfer on Sat, 16 Sep 2017 22:14:18 -0700) Subject: Re: bug#28476: 26.0.60; Gnus: broken timezone in citation line References: <20972.1505625258@alto> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28476 Cc: 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Mike Kupfer > Date: Sat, 16 Sep 2017 22:14:18 -0700 > > I have message-citation-line-format set to > > "On %e %B %Y %R %Z, %N wrote:\n" > > When replying to a message whose date field is displayed as > > Date: Sat, 16 Sep 2017 17:18:30 -0700 > > the citation comes out as > > On 16 September 2017 17:18 +07, Mike Kupfer wrote: > > I expect > > On 16 September 2017 17:18 -0700, Mike Kupfer wrote: > > which is what Emacs 25.3 gives me. I think you should use %z, not %Z. %Z gives the time-zone _name_, a string, whereas %z gives its numeric form. FWIW, I get the time-zone name from %Z in both Emacs 25.3 and the current emacs-26 branch. Not sure why you get different results in 25.3. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 11:29:57 2017 Received: (at 28476) by debbugs.gnu.org; 17 Sep 2017 15:29:57 +0000 Received: from localhost ([127.0.0.1]:45201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtbW5-00022F-Ht for submit@debbugs.gnu.org; Sun, 17 Sep 2017 11:29:57 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:24295 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtbW0-000224-Ur for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 11:29:52 -0400 Received: from alto (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id v8HFTkr9084931; Sun, 17 Sep 2017 08:29:46 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be alto From: Mike Kupfer To: Eli Zaretskii Subject: Re: bug#28476: 26.0.60; Gnus: broken timezone in citation line In-Reply-To: Your message of "Sun, 17 Sep 2017 17:25:27 +0300." <83efr5jtbc.fsf@gnu.org> X-Mailer: MH-E 8.6; nmh 1.7-RC3; GNU Emacs 25.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21806.1505662186.1@alto> Date: Sun, 17 Sep 2017 08:29:46 -0700 Message-ID: <21807.1505662186@alto> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28476 Cc: 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii wrote: > > From: Mike Kupfer > > I have message-citation-line-format set to > > > > "On %e %B %Y %R %Z, %N wrote:\n" [...] > I think you should use %z, not %Z. %Z gives the time-zone _name_, a > string, whereas %z gives its numeric form. FWIW, I get the time-zone > name from %Z in both Emacs 25.3 and the current emacs-26 branch. Not > sure why you get different results in 25.3. How are you testing this? The docstring for message-citation-line-format says that %z and %Z are special-cased, with both producing the time zone in numeric form. Maybe there was a deliberate change in Gnus to distinguish %z from %Z for Emacs 26? If so, there are still 2 issues: the documentation is wrong, and I'd expect %Z to produce "PDT", not "+07". (format-time-string "%Z") => "PDT" mike From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 12:00:00 2017 Received: (at 28476) by debbugs.gnu.org; 17 Sep 2017 16:00:00 +0000 Received: from localhost ([127.0.0.1]:45206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtbzA-0002hR-Jx for submit@debbugs.gnu.org; Sun, 17 Sep 2017 12:00:00 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:58474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtbz4-0002hE-DQ for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 11:59:54 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3xwDNj22hBz1qqkd; Sun, 17 Sep 2017 17:59:49 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3xwDNj0bt8z1qqkC; Sun, 17 Sep 2017 17:59:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NoHRkqwxEt3w; Sun, 17 Sep 2017 17:59:48 +0200 (CEST) X-Auth-Info: NgVE29IKbNvS/fF/W7wKZrUIWgbB1pCvXKbiISFwliCcdrj2QzL4tPajJnT3rHlL Received: from igel.home (ppp-88-217-5-81.dynamic.mnet-online.de [88.217.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 17 Sep 2017 17:59:48 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id AD3652C4C9B; Sun, 17 Sep 2017 17:59:47 +0200 (CEST) From: Andreas Schwab To: Mike Kupfer Subject: Re: bug#28476: 26.0.60; Gnus: broken timezone in citation line References: <20972.1505625258@alto> <21807.1505662186@alto> X-Yow: I'm RELIGIOUS!! I love a man with a HAIRPIECE!! Equip me with MISSILES!! Date: Sun, 17 Sep 2017 17:59:47 +0200 In-Reply-To: <21807.1505662186@alto> (Mike Kupfer's message of "Sun, 17 Sep 2017 08:29:46 -0700") Message-ID: <87a81tfh8s.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28476 Cc: Eli Zaretskii , 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sep 17 2017, Mike Kupfer wrote: > Eli Zaretskii wrote: > >> > From: Mike Kupfer > >> > I have message-citation-line-format set to >> > >> > "On %e %B %Y %R %Z, %N wrote:\n" > [...] >> I think you should use %z, not %Z. %Z gives the time-zone _name_, a >> string, whereas %z gives its numeric form. FWIW, I get the time-zone >> name from %Z in both Emacs 25.3 and the current emacs-26 branch. Not >> sure why you get different results in 25.3. > > How are you testing this? The docstring for > message-citation-line-format says that %z and %Z are special-cased, with > both producing the time zone in numeric form. That was broken by commit 7d835d8e79. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 12:12:13 2017 Received: (at 28476) by debbugs.gnu.org; 17 Sep 2017 16:12:13 +0000 Received: from localhost ([127.0.0.1]:45215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtcAz-000303-0k for submit@debbugs.gnu.org; Sun, 17 Sep 2017 12:12:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtcAu-0002zX-MD for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 12:12:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtcAk-0006SK-KQ for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 12:11:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtcAk-0006S0-Gk; Sun, 17 Sep 2017 12:11:54 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dtcAj-0002hU-Hz; Sun, 17 Sep 2017 12:11:54 -0400 Date: Sun, 17 Sep 2017 19:12:01 +0300 Message-Id: <834ls1jodq.fsf@gnu.org> From: Eli Zaretskii To: Mike Kupfer In-reply-to: <21807.1505662186@alto> (message from Mike Kupfer on Sun, 17 Sep 2017 08:29:46 -0700) Subject: Re: bug#28476: 26.0.60; Gnus: broken timezone in citation line References: <21807.1505662186@alto> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28476 Cc: 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Mike Kupfer > cc: 28476@debbugs.gnu.org > Date: Sun, 17 Sep 2017 08:29:46 -0700 > > Eli Zaretskii wrote: > > > > From: Mike Kupfer > > > > I have message-citation-line-format set to > > > > > > "On %e %B %Y %R %Z, %N wrote:\n" > [...] > > I think you should use %z, not %Z. %Z gives the time-zone _name_, a > > string, whereas %z gives its numeric form. FWIW, I get the time-zone > > name from %Z in both Emacs 25.3 and the current emacs-26 branch. Not > > sure why you get different results in 25.3. > > How are you testing this? The docstring for > message-citation-line-format says that %z and %Z are special-cased, with > both producing the time zone in numeric form. Sorry, I assumed without checking that the format was handed to format-time-string. Anyway, I think Andreas found the reason. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 23:58:25 2017 Received: (at 28476) by debbugs.gnu.org; 18 Sep 2017 03:58:25 +0000 Received: from localhost ([127.0.0.1]:45453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtnCT-0002W6-Iy for submit@debbugs.gnu.org; Sun, 17 Sep 2017 23:58:25 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtnCQ-0002Vr-VQ for 28476@debbugs.gnu.org; Sun, 17 Sep 2017 23:58:23 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A3131164735; Sun, 17 Sep 2017 20:58:16 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id smo1GXpnzMgH; Sun, 17 Sep 2017 20:58:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D241B164474; Sun, 17 Sep 2017 20:57:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CaWbc_PuYujm; Sun, 17 Sep 2017 20:57:14 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 461601643C0; Sun, 17 Sep 2017 20:56:06 -0700 (PDT) To: Mike Kupfer From: Paul Eggert Subject: 26.0.60; Gnus: broken timezone in citation line Organization: UCLA Computer Science Department Message-ID: Date: Sun, 17 Sep 2017 20:56:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9FB019246B37EDE0BFDF2CE0" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28476 Cc: 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------9FB019246B37EDE0BFDF2CE0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks for the bug report. I see two issues here. First, the change in message-citation-line-format'= s=20 treatment of %Z was deliberate. The new treatment (unlike the old one) is= =20 consistent with format-time-string and this consistency simplifies the=20 documentation and code. If backward-compatibility is a significant hassle= we can=20 re-complicate Emacs, but I'm hoping that users can change %Z to %z in the= ir=20 settings and move on. In the meantime I installed the first attached patc= h into=20 the emacs-26 branch so that the documentation matches the new behavior. (= Sorry,=20 I missed that part of the documentation before.) Second, (format-time-string "%Z" nil -25200) returns "+07" where it shoul= d=20 return "-07" since -25200 denotes 7 hours west of UTC. This is due to a b= lunder=20 in my commit fdb1ba144ca61185e6457f092f38f59dd9bbe6a0 dated 2016-04-12 09= :19:11=20 -0700: the %Z code gets the sign wrong on purely-numeric time zones west = of=20 Greenwich. To fix this bug I installed the second attached patch into the= =20 emacs-26 branch. This fix should cause your example to come out as: On 16 September 2017 17:18 -07, Mike Kupfer wrote: which at least gets the sign right. --------------9FB019246B37EDE0BFDF2CE0 Content-Type: text/x-patch; name="0001-message-citation-line-format-Z-is-now-tz-name.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-message-citation-line-format-Z-is-now-tz-name.patch" =46rom 679e05eeb97eae5a32fc67f4673b019c873ebcca Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 17 Sep 2017 17:46:18 -0700 Subject: [PATCH 1/2] message-citation-line-format %Z is now tz name * etc/NEWS: * lisp/gnus/message.el (message-citation-line-format): Fix doc to match new behavior (Bug#28476). --- etc/NEWS | 6 ++++++ lisp/gnus/message.el | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index a042ce9..5aa57a7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -701,6 +701,12 @@ method is an NNTP select method. *** A new command for sorting articles by readedness marks has been added: 'C-c C-s C-m C-m'. =20 ++++ + +*** In message-citation-line-format the %Z format is now the time zone n= ame +instead of the numeric form. The %z format continues to be the +numeric form. The new behavior is compatible with format-time-string. + ** Ibuffer =20 --- diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 690dd28..a9e66ce 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -991,7 +991,6 @@ message-citation-line-format %F The first name if present, e.g.: \"John\", else fall back to the mail address. %L The last name if present, e.g.: \"Doe\". - %Z, %z The time zone in the numeric form, e.g.:\"+0000\". =20 All other format specifiers are passed to `format-time-string' which is called using the date from the article your replying to, but --=20 2.7.4 --------------9FB019246B37EDE0BFDF2CE0 Content-Type: text/x-patch; name="0002-Fix-format-time-string-Z-bug-with-negative-tz.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-Fix-format-time-string-Z-bug-with-negative-tz.patch" =46rom 74fbe646c7d735343628979f6e9bb4543f01fe52 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 17 Sep 2017 20:38:12 -0700 Subject: [PATCH 2/2] Fix format-time-string %Z bug with negative tz * src/editfns.c (tzlookup): Fix sign error in %Z when a purely numeric zone is negative (Bug#28746). * test/src/editfns-tests.el (format-time-string-with-zone): Add test for this bug. --- src/editfns.c | 3 ++- test/src/editfns-tests.el | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/editfns.c b/src/editfns.c index b03eb94..2f8b075 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -187,7 +187,8 @@ tzlookup (Lisp_Object zone, bool settz) if (sec !=3D 0) prec +=3D 2, numzone =3D 100 * numzone + sec; } - sprintf (tzbuf, tzbuf_format, prec, numzone, + sprintf (tzbuf, tzbuf_format, prec, + XINT (zone) < 0 ? -numzone : numzone, &"-"[XINT (zone) < 0], hour, min, sec); zone_string =3D tzbuf; } diff --git a/test/src/editfns-tests.el b/test/src/editfns-tests.el index 1c3fde8..f910afa 100644 --- a/test/src/editfns-tests.el +++ b/test/src/editfns-tests.el @@ -166,6 +166,10 @@ transpose-test-get-byte-positions (should (string-equal (format-time-string format look '(-28800 "PST")) "1972-06-30 15:59:59.999 -0800 (PST)")) + ;; Negative UTC offset, as a Lisp integer. + (should (string-equal + (format-time-string format look -28800) + "1972-06-30 15:59:59.999 -0800 (-08)")) ;; Positive UTC offset that is not an hour multiple, as a string. (should (string-equal (format-time-string format look "IST-5:30") --=20 2.7.4 --------------9FB019246B37EDE0BFDF2CE0-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:37:23 2017 Received: (at 28476) by debbugs.gnu.org; 18 Sep 2017 15:37:23 +0000 Received: from localhost ([127.0.0.1]:46626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dty6t-0004Y5-7W for submit@debbugs.gnu.org; Mon, 18 Sep 2017 11:37:23 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:61051 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dty6r-0004Xx-OF for 28476@debbugs.gnu.org; Mon, 18 Sep 2017 11:37:22 -0400 Received: from alto (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id v8IFbC07001639; Mon, 18 Sep 2017 08:37:12 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be alto From: Mike Kupfer To: Paul Eggert Subject: Re: 26.0.60; Gnus: broken timezone in citation line In-Reply-To: Your message of "Sun, 17 Sep 2017 20:56:05 -0700." X-Mailer: MH-E 8.6+git; nmh 1.7-RC3; GNU Emacs 26.0.60 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23488.1505749032.1@alto> Date: Mon, 18 Sep 2017 08:37:12 -0700 Message-ID: <23489.1505749032@alto> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28476 Cc: 28476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi Paul, thanks for your response. I'm fine with this sort of consistency/simplification change. The doc changes look good to me. And after thinking about it some more, I realized that Emacs doesn't really have enough context to ensure that "PDT" is correct in my example, so I'm good with "-07" as the name. Feel free to close this bug. regards, mike From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:58:31 2017 Received: (at control) by debbugs.gnu.org; 18 Sep 2017 15:58:31 +0000 Received: from localhost ([127.0.0.1]:46660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtyRK-00055N-VR for submit@debbugs.gnu.org; Mon, 18 Sep 2017 11:58:31 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtyRI-000559-Ow for control@debbugs.gnu.org; Mon, 18 Sep 2017 11:58:29 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C564D160AD7 for ; Mon, 18 Sep 2017 08:58:22 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qVOYeKC-OgIt for ; Mon, 18 Sep 2017 08:58:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 306C5160BF0 for ; Mon, 18 Sep 2017 08:58:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2T71JD2hLnnF for ; Mon, 18 Sep 2017 08:58:22 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1585C160AD7 for ; Mon, 18 Sep 2017 08:58:22 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: close 28476 Organization: UCLA Computer Science Department Message-ID: Date: Mon, 18 Sep 2017 08:58:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) close 28476 From unknown Wed Jun 18 00:25:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Oct 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator