From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 00:34:53 2017 Received: (at submit) by debbugs.gnu.org; 15 Sep 2017 04:34:53 +0000 Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsiL6-0001ba-M5 for submit@debbugs.gnu.org; Fri, 15 Sep 2017 00:34:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsiL4-0001bL-RA for submit@debbugs.gnu.org; Fri, 15 Sep 2017 00:34:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsiKy-0003E5-BP for submit@debbugs.gnu.org; Fri, 15 Sep 2017 00:34:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41672) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsiKy-0003Dz-7U for submit@debbugs.gnu.org; Fri, 15 Sep 2017 00:34:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsiKv-00046b-Hf for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2017 00:34:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsiKs-0003CZ-Az for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2017 00:34:41 -0400 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:46464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsiKr-0002od-SM for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2017 00:34:38 -0400 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id 4B680215C61 for ; Thu, 14 Sep 2017 22:34:18 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 9gaC1w0082f2jeq01gaFQZ; Thu, 14 Sep 2017 22:34:18 -0600 X-Authority-Analysis: v=2.2 cv=K4VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=u-K84vV3GXtPh2qnwm8A:9 a=gJ0XG-Rq3r6ytfKh:21 a=Ot0uTjdm3h8feQD4:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WuMjHHvXWhjyLS5UaUhouj8HjQ8/ooOXM2HgOURR0mY=; b=HC36mj2vYjWxIcfgkVdvrDoOhh EW5mMAlRP5wBnBORlT4Lq9iEsaCfzdWArH5pfHbg7jpg9dpwBb02l651GnGqriamCkrDGPER8XtCq KH34xNqkLR09NSAFvOCgr3SBF; Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:54446 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dsiKS-0022xO-EG; Thu, 14 Sep 2017 22:34:12 -0600 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 26.0.50; diff in vc-outgoing doesn't work properly X-Attribution: Tom Date: Thu, 14 Sep 2017 22:34:10 -0600 Message-ID: <87h8w4shq5.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.76.94 X-Exim-ID: 1dsiKS-0022xO-EG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:54446 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I'm using vc-dir mode. I used "O" to show the outgoing changes. In the *vc-outgoing* buffer, I selected the entire buffer (C-x h) and then typed "=" to make a diff. I was expecting to see a diff showing the combined contents of all 3 of my outgoing patches. However, the generated diff is missing the oldest patch in the series. Tom In GNU Emacs 26.0.50 (build 20, x86_64-pc-linux-gnu, GTK+ Version 3.22.17) of 2017-09-14 built on bapiya Repository revision: a7036e04014e5b0548653f26f87ee9e98be05ba3 Windowing system distributor 'Fedora Project', version 11.0.11903000 System Description: Fedora release 25 (Twenty Five) Recent messages: Mark set Quit [3 times] Mark activated next-line: End of buffer Finding changes in .... Quit [2 times] next-line: End of buffer Mark set previous-line: Beginning of buffer Finding changes in .... scroll-up-command: End of buffer Configured using: 'configure --prefix=/home/tromey/Emacs/install' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LCMS2 Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Diff Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t which-function-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/26.0.50/lisp/play/bubbles Features: (shadow emacsbug org-bullets org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org-element avl-tree generator org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs goto-addr log-edit tcl smerge-mode find-dired shell shr svg dom supercite regi mail-hist nnir mm-archive mailalias gnus-html url-queue help-fns radix-tree browse-url xml url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util sort smiley gnus-cite gnus-bcklg gnus-async mail-extr gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry ebdb-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader pulse etags xref project dabbrev jka-compr misearch multi-isearch texinfo copyright bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds add-log log-view pcvs-util map vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs elec-pair flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext ibuffer ibuffer-loaddefs dash appt diary-lib diary-loaddefs which-func imenu minimap autorevert filenotify cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs ebdb-complete ebdb-message sendmail message puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mail-utils gmm-utils mailheader ebdb-mua ebdb-com crm mailabbrev ebdb-format qp ebdb cl-extra help-mode eieio-opt speedbar sb-image ezimage dframe find-func eieio-base pcase subr-x cal-menu calendar cal-loaddefs timezone ange-ftp comint ansi-color ring server savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads lisppaste-autoloads pydoc-info-autoloads info-look cl weblogger-autoloads info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1344642 1361281) (symbols 48 53087 3) (miscs 40 11459 454) (strings 32 518815 50035) (string-bytes 1 13923769) (vectors 16 242764) (vector-slots 8 2919741 62026) (floats 8 519 469) (intervals 56 20555 1635) (buffers 992 57)) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 16 17:54:43 2017 Received: (at submit) by debbugs.gnu.org; 16 Sep 2017 21:54:43 +0000 Received: from localhost ([127.0.0.1]:44323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtL2w-0007Ss-Nd for submit@debbugs.gnu.org; Sat, 16 Sep 2017 17:54:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtL2u-0007Sc-HZ for submit@debbugs.gnu.org; Sat, 16 Sep 2017 17:54:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtL2o-0006s4-IC for submit@debbugs.gnu.org; Sat, 16 Sep 2017 17:54:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dtL2o-0006rw-FJ for submit@debbugs.gnu.org; Sat, 16 Sep 2017 17:54:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtL2n-0007Ue-99 for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2017 17:54:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtL2i-0006pg-CV for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2017 17:54:33 -0400 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:59995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dtL2i-0006d5-2V for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2017 17:54:28 -0400 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id 94D31215C52 for ; Sat, 16 Sep 2017 15:54:05 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id AMu21w0012f2jeq01Mu5Aw; Sat, 16 Sep 2017 15:54:05 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=vUH1JksB0ihlV9GU8jEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NwSFZzyBPoorZijM1yP8Vdwk4FZDUyogF9JRv+/kMzA=; b=WclhJHLfdSwSKJBxWWAhmtYkMn Uv4C0h+h1D2mdAqbcMcLbpjtBOxQ6NXXIQ2VVJcOfU3h7H+VVASKLaiGjI/0SO4RW4A7gWIx7fbio QXhNG21TU+k75XDS4l+S7KwaP; Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:39496 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dtL2H-004EfK-Oi; Sat, 16 Sep 2017 15:54:01 -0600 From: Tom Tromey To: Tom Tromey Subject: Re: 26.0.50; diff in vc-outgoing doesn't work properly References: <87h8w4shq5.fsf@tromey.com> X-Attribution: Tom Date: Sat, 16 Sep 2017 15:53:57 -0600 In-Reply-To: <87h8w4shq5.fsf@tromey.com> (Tom Tromey's message of "Thu, 14 Sep 2017 22:34:10 -0600") Message-ID: <8760ciwbre.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.76.94 X-Exim-ID: 1dtL2H-004EfK-Oi X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:39496 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Tom> I was expecting to see a diff showing the combined contents of all 3 of Tom> my outgoing patches. Tom> However, the generated diff is missing the oldest patch in the series. The appended patch fixes this for me. I'll put it on the Emacs 26 branch after a few days, unless there are comments. Tom diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index 52f56ed..d6963d0 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -608,10 +608,16 @@ log-view-diff-changeset (log-view-diff-common beg end t))) (defun log-view-diff-common (beg end &optional whole-changeset) - (let ((to (log-view-current-tag beg)) - (fr (log-view-current-tag end))) - (when (string-equal fr to) - ;; TO and FR are the same, look at the previous revision. + (let* ((to (log-view-current-tag beg)) + (fr-entry (log-view-current-entry end)) + (fr (cadr fr-entry))) + ;; When TO and FR are the same, or when point is on a line after + ;; the last entry, look at the previous revision. + (when (or (string-equal fr to) + (>= (point) + (save-excursion + (goto-char (car fr-entry)) + (forward-line)))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 20:39:16 2017 Received: (at 28466) by debbugs.gnu.org; 19 Sep 2017 00:39:16 +0000 Received: from localhost ([127.0.0.1]:46995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6ZI-0001Te-E1 for submit@debbugs.gnu.org; Mon, 18 Sep 2017 20:39:16 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:37644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6ZG-0001TP-JA for 28466@debbugs.gnu.org; Mon, 18 Sep 2017 20:39:14 -0400 Received: by mail-lf0-f67.google.com with SMTP id q132so1114747lfe.4 for <28466@debbugs.gnu.org>; Mon, 18 Sep 2017 17:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7I8N99xHBbCwzd3Vpx2MnD5IaciG+YhnRV20CMvFn14=; b=KG8DaZKZ+PA6tOvT/ge/IYyAwzYlp0fYUhQm5NN6LHFhyD+nrMO5gg841Ng8ZLdXsM nUNvZlv6TwBOBaesyfXw8I2XurN5JGWCBMi8MCvTt9xJ3NoiEc7f0V8NKfnVc9V1bE6g Vt5RiWDe/dV0cFjw0HGlTkssxqeOTVlCSyoeRWKRTkS2+3Ze0nU82LX8QaR8leN0yDhI VamOqLZB5LWbqwKxTnA9y2a02xnksv9C6XWbTj6rEzkjrV6tDOYS//Vr/OpCHeiXUBQE EPf6Au7B3OhrKYDr7ERX6UTgf23NeOKc+LINU23OIAJEoV7cXSxyQ8kNb+zUXsdDZiPs SvGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7I8N99xHBbCwzd3Vpx2MnD5IaciG+YhnRV20CMvFn14=; b=fg8mfj4v2EuFl3/AMstNu9L55t8BV+Wx3V7Pyk4SsPkN1oo2BCcn7Zy89QQECX7QL2 7ONNqIrXlLb+0Q23vhoTqB0vTTj7CDjtbqL79AVMRJabXFP1/PEv8eVf/Ir+iqS0wI1L +5SfFGOGhEOZV2jOcCyRR14uESapRW+3O5jpVWmVvZcm7f0BpuYmwFDJTERJii8k7YD5 mgKzkPo8xeMt7oBBW4WROXwy9Dtc7qKEaFODqHP7NgEncqnoPg25N4UirSTW6JXLh8IL 71zoS8mw7s0SHZXouyjNn5afSBnQLtvQUdlkXaxMkc2afwBU68x61OkJUWMVOVZFJOVl HcAQ== X-Gm-Message-State: AHPjjUigCsBlBcQJaH+ml2uRWbujUBpDCCM/mjNrydGJcrPCPF4r8FIe ukzkU54yZ2V6LnztXHw= X-Google-Smtp-Source: AOwi7QASasPwq8AGme1fAvDX2iqh+oZQJoQ0KruP/k338z0+IDy/il4HZWcXXvIrJISPu3uPURrlnw== X-Received: by 10.25.18.71 with SMTP id h68mr3210033lfi.217.1505781548299; Mon, 18 Sep 2017 17:39:08 -0700 (PDT) Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id i13sm1644663lfa.68.2017.09.18.17.39.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Sep 2017 17:39:07 -0700 (PDT) Subject: Re: bug#28466: 26.0.50; diff in vc-outgoing doesn't work properly To: Tom Tromey References: <87h8w4shq5.fsf@tromey.com> <8760ciwbre.fsf@tromey.com> From: Dmitry Gutov Message-ID: <4e4981d4-9209-ec6a-b4fe-56c0151e1d14@yandex.ru> Date: Tue, 19 Sep 2017 03:39:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 In-Reply-To: <8760ciwbre.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 9/17/17 12:53 AM, Tom Tromey wrote: > The appended patch fixes this for me. > I'll put it on the Emacs 26 branch after a few days, unless there are > comments. Makes sense to me, please feel free to commit. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.67 listed in list.dnswl.org] 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.67 listed in dnsbl.sorbs.net] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.67 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 28466 Cc: 28466@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 9/17/17 12:53 AM, Tom Tromey wrote: > The appended patch fixes this for me. > I'll put it on the Emacs 26 branch after a few days, unless there are > comments. Makes sense to me, please feel free to commit. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.67 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.67 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.67 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders On 9/17/17 12:53 AM, Tom Tromey wrote: > The appended patch fixes this for me. > I'll put it on the Emacs 26 branch after a few days, unless there are > comments. Makes sense to me, please feel free to commit. I don't particularly like how the region end is interpreted in this command, though. I'd be more comfortable with the semantics of "show the contents of all these revisions combined", which means replacing the condition with t. Something to think about, for some future version. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 22:18:15 2017 Received: (at 28466-done) by debbugs.gnu.org; 19 Sep 2017 02:18:15 +0000 Received: from localhost ([127.0.0.1]:47074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du875-0005mH-0d for submit@debbugs.gnu.org; Mon, 18 Sep 2017 22:18:15 -0400 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:56578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du872-0005m2-Sz for 28466-done@debbugs.gnu.org; Mon, 18 Sep 2017 22:18:13 -0400 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 5FCFB1E0758 for <28466-done@debbugs.gnu.org>; Mon, 18 Sep 2017 20:18:04 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id BEJ01w00K2f2jeq01EJ34Z; Mon, 18 Sep 2017 20:18:04 -0600 X-Authority-Analysis: v=2.2 cv=K/VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=FxKpEnC0CrsV8nijWlEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Kaqahs4BGVl13mnQrGicPt81twyfd1kJCj63vVXngqk=; b=yTlSS/mupIzFvVmcklmtEXfmjN A4A9zt4VHngj8atvH2oKVXfidvA7lDsA/KCiid1E8nRwEQqRnfnqKjctZACWfCDppBGorpP8oACUk QQ/T5fOWvtQ28fMxVoCT+dVZw; Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:59056 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1du86q-000Iad-1F; Mon, 18 Sep 2017 20:18:00 -0600 From: Tom Tromey To: 28466-done@debbugs.gnu.org Subject: doneu X-Attribution: Tom Date: Mon, 18 Sep 2017 20:17:57 -0600 Message-ID: <87r2v3a0tm.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.76.94 X-Exim-ID: 1du86q-000Iad-1F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:59056 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 28466-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Fix checked in. Tom From unknown Sun Jun 22 17:15:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Oct 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator