From unknown Sun Jun 22 11:34:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28465 <28465@debbugs.gnu.org> To: bug#28465 <28465@debbugs.gnu.org> Subject: Status: [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files Reply-To: bug#28465 <28465@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:34:21 +0000 retitle 28465 [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC f= iles reassign 28465 guix-patches submitter 28465 Maxim Cournoyer severity 28465 normal tag 28465 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 14 16:14:53 2017 Received: (at submit) by debbugs.gnu.org; 14 Sep 2017 20:14:54 +0000 Received: from localhost ([127.0.0.1]:41513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsaXF-0006ty-LP for submit@debbugs.gnu.org; Thu, 14 Sep 2017 16:14:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsaXE-0006tm-JM for submit@debbugs.gnu.org; Thu, 14 Sep 2017 16:14:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsaX8-0001Ul-4x for submit@debbugs.gnu.org; Thu, 14 Sep 2017 16:14:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsaX8-0001Uf-1D for submit@debbugs.gnu.org; Thu, 14 Sep 2017 16:14:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsaX6-0001bN-KG for guix-patches@gnu.org; Thu, 14 Sep 2017 16:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsaX3-0001Pn-AG for guix-patches@gnu.org; Thu, 14 Sep 2017 16:14:44 -0400 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:44039) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsaX3-0001PS-4l for guix-patches@gnu.org; Thu, 14 Sep 2017 16:14:41 -0400 Received: by mail-io0-x232.google.com with SMTP id v36so3518326ioi.1 for ; Thu, 14 Sep 2017 13:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=D+03rjNBAANdAHtIFd0Tf7GvKFYpaeBif5JQowMMb9U=; b=doIf5hS/TgafqE0LbPtKK51KzAKQP4Uc+53dL8Y1hpgWv4/omXtHwVYGalT/IOzFoW NjyH/57Dofk8NHbDWrAFHBGZA7yGSEBDo14Qtt3ONKxVYnVUTgn/nDDrKkdHkazsItbO MohtA0losICQ30YVjh3aKbjo15U4GmISV4N30dqw+aKhsEF2LpMaa4kQ20f1AjCtZK6r 3amc0+dUo+fD3i5nat/cwaIIqnpmFJhF9mDb3MHDOO7lnuQxYLI020Uo609vmE6q7th4 4ro4aS+f3XJpWASYSP2Bke/eyay1b0kbAtXlkaX6rS5H0e9BegbIKk1afGaW8PHSEQuS 1OHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=D+03rjNBAANdAHtIFd0Tf7GvKFYpaeBif5JQowMMb9U=; b=LdjaGJzualh8/9B9nSU8R9ldOMl6e4MtZSxMPTD6A0N20zc37QWZiFOa2EMRY7D+DT o4zmeX5CopAgWv9V/0MXhilXGzs6D0agh8pBZlYxBqWHAH4gbRBF9XEoyn5Y+tw//xlP fi2WIsz5RbDlCKEldvqFbm2C2tiry+JDbQpv/aN8j+XJqKgphCXF19hJJlnVEAF8Z6e7 M7Abg/sdt8GdiK9bfOf3UyoXUFRxwwADXtbirtHrzm8W/z/1Oe/3sR0WaZPTC6VBSrMo W+ZhdPWWGhvb7fYBuilkoCqcJbhCO/dtBP46sj4BWsSuZI7VXC2iJYskN0Al4feynuws dZUA== X-Gm-Message-State: AHPjjUhZSClLZ+IAC+ztHfb86R71eckIbCLnqqNzKeAZrv5+MhThf+eJ QtOEO/dmkZS9IGI4 X-Google-Smtp-Source: AOwi7QCZd69WMmQwG8gwnL+o1DUnoTbhrY9OXqr4eUKK2PNmzD/4XCkA2vKYw7ZvZzbjVd5T5FfHBQ== X-Received: by 10.107.25.210 with SMTP id 201mr4945798ioz.232.1505420080222; Thu, 14 Sep 2017 13:14:40 -0700 (PDT) Received: from apteryx ([45.72.233.254]) by smtp.gmail.com with ESMTPSA id x8sm400652itf.14.2017.09.14.13.14.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Sep 2017 13:14:39 -0700 (PDT) From: Maxim Cournoyer To: guix-patches Subject: [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files Date: Thu, 14 Sep 2017 16:14:37 -0400 Message-ID: <87d16t3umq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, This enhances our emacs-emms package so that it can retrieve the metadata from FLAC and MP3 files. It also references GNU find explicitly. Here's how I tested it: 1. Backup (rename) any existing ~/.emacs.d/emms directory to get rid of any cached playlist. 2. Make sure you have a collections of a few FLAC, Ogg and MP3 files under ~/Music. 3. Add the following config to your .emacs file: --8<---------------cut here---------------start------------->8--- ;;; EMMS (require 'emms-info-metaflac) (require 'emms-setup) (emms-all) (emms-default-players) (add-to-list 'emms-info-functions #'emms-info-metaflac) (setq emms-source-file-directory-tree-function #'emms-source-file-directory-tree-find) (setq emms-source-file-default-directory "~/Music/") --8<---------------cut here---------------end--------------->8--- 4. With the patch applied, run: --8<---------------cut here---------------start------------->8--- ./pre-inst-env guix environment --pure --ad-hoc emacs emacs-emms emacs --8<---------------cut here---------------end--------------->8--- 5. Create the playlist from your default music directory: M-x emms-add-directory-tree RET ~/Music RET 6. Finally, lauch EMMS with M-x emms and observe that the playlist was correctly generated based on the files' metadata. Thank you, Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-emacs-emms-Fix-metadata-retrieval-for-MP3-and-FL.patch >From fcda96d1469864678ab1f24ec7ba8ee3fa8d28b7 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 13 Sep 2017 17:13:19 -0400 Subject: [PATCH] gnu: emacs-emms: Fix metadata retrieval for MP3 and FLAC files. * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metaflac by their complete file path. [inputs]: Add flac. --- gnu/packages/emacs.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 5d9fd728a..784d8798b 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -840,6 +840,7 @@ provides an optional IDE-like error list.") (replace 'configure (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) + (flac (assoc-ref inputs "flac")) (vorbis (assoc-ref inputs "vorbis-tools")) (alsa (assoc-ref inputs "alsa-utils")) (mpg321 (assoc-ref inputs "mpg321")) @@ -862,6 +863,9 @@ provides an optional IDE-like error list.") (substitute* "emms-player-simple.el" (("\"ogg123\"") (string-append "\"" vorbis "/bin/ogg123\""))) + (substitute* "emms-player-simple.el" + (("\"mpg321\"") + (string-append "\"" mpg321 "/bin/mpg321\""))) (emacs-substitute-variables "emms-info-ogginfo.el" ("emms-info-ogginfo-program-name" (string-append vorbis "/bin/ogginfo"))) @@ -871,6 +875,11 @@ provides an optional IDE-like error list.") (emacs-substitute-variables "emms-info-mp3info.el" ("emms-info-mp3info-program-name" (string-append mp3info "/bin/mp3info"))) + (emacs-substitute-variables "emms-info-metaflac.el" + ("emms-info-metaflac-program-name" + (string-append flac "/bin/metaflac"))) + (emacs-substitute-variables "emms-source-file.el" + ("emms-source-file-gnu-find" (which "find"))) (substitute* "emms-volume-amixer.el" (("\"amixer\"") (string-append "\"" alsa "/bin/amixer\""))) @@ -896,6 +905,7 @@ provides an optional IDE-like error list.") (native-inputs `(("emacs" ,emacs-minimal) ;for (guix build emacs-utils) ("texinfo" ,texinfo))) (inputs `(("alsa-utils" ,alsa-utils) + ("flac" ,flac) ;for metaflac ("vorbis-tools" ,vorbis-tools) ("mpg321" ,mpg321) ("taglib" ,taglib) -- 2.14.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 10:49:36 2017 Received: (at 28465-done) by debbugs.gnu.org; 15 Sep 2017 14:49:36 +0000 Received: from localhost ([127.0.0.1]:43006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsrvz-00057C-SP for submit@debbugs.gnu.org; Fri, 15 Sep 2017 10:49:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsrvy-00056x-Oj for 28465-done@debbugs.gnu.org; Fri, 15 Sep 2017 10:49:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsrvq-0001qs-Ji for 28465-done@debbugs.gnu.org; Fri, 15 Sep 2017 10:49:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsrvq-0001qh-GT; Fri, 15 Sep 2017 10:49:26 -0400 Received: from [193.50.110.249] (port=59338 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dsrvq-0002BS-2Z; Fri, 15 Sep 2017 10:49:26 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Maxim Cournoyer Subject: Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files References: <87d16t3umq.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 15 Sep 2017 16:49:24 +0200 In-Reply-To: <87d16t3umq.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 14 Sep 2017 16:14:37 -0400") Message-ID: <87bmmct3t7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28465-done Cc: 28465-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Maxim Cournoyer skribis: > This enhances our emacs-emms package so that it can retrieve the > metadata from FLAC and MP3 files. It also references GNU find > explicitly. Nice! > Here's how I tested it: I didn=E2=80=99t go through this procedure, but I trust you (and I=E2=80=99= ll quickly notice if something goes wrong ;-)). > From fcda96d1469864678ab1f24ec7ba8ee3fa8d28b7 Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer > Date: Wed, 13 Sep 2017 17:13:19 -0400 > Subject: [PATCH] gnu: emacs-emms: Fix metadata retrieval for MP3 and FLAC > files. > > * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metafla= c by > their complete file path. > [inputs]: Add flac. Applied, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 18:20:52 2017 Received: (at 28465-done) by debbugs.gnu.org; 15 Sep 2017 22:20:52 +0000 Received: from localhost ([127.0.0.1]:43186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsyyh-0006ym-Tk for submit@debbugs.gnu.org; Fri, 15 Sep 2017 18:20:52 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:52754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsyyg-0006ya-A0 for 28465-done@debbugs.gnu.org; Fri, 15 Sep 2017 18:20:50 -0400 Received: by mail-io0-f181.google.com with SMTP id i197so11615012ioe.9 for <28465-done@debbugs.gnu.org>; Fri, 15 Sep 2017 15:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ZB3hPuN5Awpr8CrStyiuSumAzfcWDx7t20f+OHVJeSg=; b=XlwGPow+cUrGwWA4KdOiYV5TQY5kRnUKbWxlz9UVTrDuVA9HjmLoRSY4smKHQ2PJC9 SfokTwedwr7E0Cf1RL0J9chLJFa9s3S3sLAGrL6vs+WjKbfBDO0ZbCf97bxMBqTTJoSE LK5yjFRFBfFWOeBQ39OlcCABnVBKf86r5ZLvy8q87ul+s2fXglBE8raw5q+xT5dqWl5z nx4bVBmzmv4zytwEWYcCOWMZpd9sfsWbi/FQfl57EbMntL3cL2ot8NlsMkiNqO47KYCf Ru4J/qarKAxiMGQKmg+Xtk8eIOwE6ITEqlRK4pxTJj3+DEV0OVbJqyZsgvlfH+t8k7tj 7pFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ZB3hPuN5Awpr8CrStyiuSumAzfcWDx7t20f+OHVJeSg=; b=Z5CUmmVPgLkm9QzNpOjPZ0Kt7KZ14cnj90+JZ46yIXfpHv5r6QU84hZznMtDUzloJ8 aZetcLXxYc0Z3wwwFL6Q42ow0MGKoufQdRKWLdb0036DcFUloY/u2Gab8HtVklZ537p4 HK6eCfdKr5wQoAsryRQIDb/U509WuiF+rvTHGV53CkvTfbSn5JNbFQQsyMlljwNFEuYU FrMX4pgm9Ldj4IhCpHXIo5EY/3kKCSdpB65v51iVd1PwhdpgKRuXV6RjB7krfk2nqtrN s6ZPV7W5EsAU8YUNATB3XhU/GsAfnki9zJHVLY+UWHkGZvyNYibrJLXA9GQiKgyTPx5m IIXw== X-Gm-Message-State: AHPjjUjfeKEy1wulMuXOWRv/1SSxznxF/oD5Upkde2UqAbFUeHkWEGGq TawQSsPblyeDBpM4 X-Google-Smtp-Source: AOwi7QBWtHaduMkB9v+8aY6MUWPdF2d5yr2JZU87g8f8+m8C/qlq/BWj+UUXv6lDBGiqNpkTJ6n3jQ== X-Received: by 10.107.7.78 with SMTP id 75mr10806570ioh.298.1505514044452; Fri, 15 Sep 2017 15:20:44 -0700 (PDT) Received: from apteryx ([45.72.233.254]) by smtp.gmail.com with ESMTPSA id i9sm983549ioi.54.2017.09.15.15.20.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Sep 2017 15:20:43 -0700 (PDT) From: Maxim Cournoyer To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files References: <87d16t3umq.fsf@gmail.com> <87bmmct3t7.fsf@gnu.org> Date: Fri, 15 Sep 2017 18:20:42 -0400 In-Reply-To: <87bmmct3t7.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 15 Sep 2017 16:49:24 +0200") Message-ID: <87poarr4cl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28465-done Cc: 28465-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metafl= ac by >> their complete file path. >> [inputs]: Add flac. > > Applied, thanks! > > Ludo=E2=80=99. Thanks Ludovic, that was quick! Maxim From unknown Sun Jun 22 11:34:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Oct 2017 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator