GNU bug report logs - #28465
[PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28465 in the body.
You can then email your comments to 28465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] emacs-emms: Fix metadata retrieval for MP3 and FLAC files
Date: Thu, 14 Sep 2017 16:14:37 -0400

[Message part 1 (text/plain, inline)]

Hi,

This enhances our emacs-emms package so that it can retrieve the
metadata from FLAC and MP3 files. It also references GNU find
explicitly.

Here's how I tested it:

1. Backup (rename) any existing ~/.emacs.d/emms directory to get rid of
any cached playlist.
2. Make sure you have a collections of a few FLAC, Ogg and MP3 files
under ~/Music.
3. Add the following config to your .emacs file:
--8<---------------cut here---------------start------------->8---
;;; EMMS
(require 'emms-info-metaflac)
(require 'emms-setup)
(emms-all)
(emms-default-players)
(add-to-list 'emms-info-functions #'emms-info-metaflac)
(setq emms-source-file-directory-tree-function
      #'emms-source-file-directory-tree-find)
(setq emms-source-file-default-directory "~/Music/")
--8<---------------cut here---------------end--------------->8---
4. With the patch applied, run:
--8<---------------cut here---------------start------------->8---
./pre-inst-env guix environment --pure --ad-hoc emacs emacs-emms
emacs
--8<---------------cut here---------------end--------------->8---
5. Create the playlist from your default music directory:
M-x emms-add-directory-tree RET ~/Music RET
6. Finally, lauch EMMS with M-x emms and observe that the playlist was
correctly generated based on the files' metadata.

Thank you,

Maxim

[0001-gnu-emacs-emms-Fix-metadata-retrieval-for-MP3-and-FL.patch (text/x-patch, attachment)]

Message #10 received at 28465-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28465-done <at> debbugs.gnu.org
Subject: Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for MP3
 and FLAC files
Date: Fri, 15 Sep 2017 16:49:24 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> This enhances our emacs-emms package so that it can retrieve the
> metadata from FLAC and MP3 files. It also references GNU find
> explicitly.

Nice!

> Here's how I tested it:

I didn’t go through this procedure, but I trust you (and I’ll quickly
notice if something goes wrong ;-)).

> From fcda96d1469864678ab1f24ec7ba8ee3fa8d28b7 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Wed, 13 Sep 2017 17:13:19 -0400
> Subject: [PATCH] gnu: emacs-emms: Fix metadata retrieval for MP3 and FLAC
>  files.
>
> * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metaflac by
> their complete file path.
> [inputs]: Add flac.

Applied, thanks!

Ludo’.

Message #13 received at 28465-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28465-done <at> debbugs.gnu.org
Subject: Re: [bug#28465] [PATCH] emacs-emms: Fix metadata retrieval for MP3
 and FLAC files
Date: Fri, 15 Sep 2017 18:20:42 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

>> * gnu/packages/emacs.scm (emacs-emms): Reference find, mpg321 and metaflac by
>> their complete file path.
>> [inputs]: Add flac.
>
> Applied, thanks!
>
> Ludo’.

Thanks Ludovic, that was quick!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.