From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 14 13:45:49 2017 Received: (at submit) by debbugs.gnu.org; 14 Sep 2017 17:45:49 +0000 Received: from localhost ([127.0.0.1]:41392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsYCz-0002Qs-8l for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:45:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsYAU-0001Xf-1O for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:43:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsYAO-0000mi-3b for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:43:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56038) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsYAO-0000mc-00 for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:43:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsYAM-0003ni-TP for bug-coreutils@gnu.org; Thu, 14 Sep 2017 13:43:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsYAM-0000kR-0i for bug-coreutils@gnu.org; Thu, 14 Sep 2017 13:43:06 -0400 Received: from mail-ua0-x22f.google.com ([2607:f8b0:400c:c08::22f]:45180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsYAL-0000j3-Rl for bug-coreutils@gnu.org; Thu, 14 Sep 2017 13:43:05 -0400 Received: by mail-ua0-x22f.google.com with SMTP id c27so45794uah.2 for ; Thu, 14 Sep 2017 10:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=sF1Ti0keSSzlolp63dv+O3vEBL3EUK55y0GhWT3C4f0=; b=scgTxbdI4WgX4qs9EsvrZiffh5Y//GhncRDZHp1dm0rvDPBEyi392+yxYbmI5Quwkp qHoPW+CWmL+a6YRqr8iLImsPo8dsCXSp6WUJmGFAfhht3MCRuzV3nirVmculYv2zvQ87 ttFtpbCOOWqEjEMW1WwI5z7vzwR8dCbP3Pa/jUtMCQbavfGpRu67UanYB19eKFjwaTpa 706uvKnsrtp3Dyg2UUWsTg9GmG7rUh3PV5OrkXFMbeOemsRQWwJ6+wZSU0/I1FDZcanm Qj8t82b2YM3KageZGFMQBigV/SUGJhvTXjXOT1uFB/GKOJmwPXa26tUQyzk449eu10Sx 2Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sF1Ti0keSSzlolp63dv+O3vEBL3EUK55y0GhWT3C4f0=; b=ZaOBjX8lt5PC9IcBx4YfT0AFDGOb6p529G20bWJM8OmCtMSg1dCtvXu5ODHyXW5/Fi 92eRBB1iPeU0JMhNZMWX3YaweDMkwaIwSljZDHzf5OCqxEX+sh7bvkXbJPYNNywcS5nx pCNX2krT7ClVDmkwD7ynQzbGiUT9Pwi8KmB1zFAJ1a2y1/8Cqip1uJE+xLcVCkC/mXUe oAGPLaIeuaPu1+dfBn0Cl4lAYLdupKzwYHtiytlctx4RnEbs83FFTQemaAjKt2bZC5To nfaL22fwCa0AOC0bYeypXYvOfeZCy2n8SVzm1PJA5BPUjT7Dcr8zMl3U+V3HFeM+c2rW Kz7Q== X-Gm-Message-State: AHPjjUiBD8T0q1unSXjN+AutFR/qXAi03k7IAqiNG8+qNz9PkVXjvcVe w4XsF75qPUgNHEcgJpFYKpM3KsLmJW4jqoinFi6WPQ== X-Google-Smtp-Source: AOwi7QBGuZZ16b4j0A+Pu3sCHkX+4OAFpwVhksfGcBPLkk4gdIzTUBiLBv+k/jNltVZoE3p78ocKPWEmIB2gVtMlUvg= X-Received: by 10.176.94.175 with SMTP id y47mr18275915uag.95.1505410983619; Thu, 14 Sep 2017 10:43:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.4.49 with HTTP; Thu, 14 Sep 2017 10:43:03 -0700 (PDT) From: Eric Mariaud Date: Thu, 14 Sep 2017 19:43:03 +0200 Message-ID: Subject: erreurs To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary="f403043c59c4eb6f2e055929cee4" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 14 Sep 2017 13:45:48 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --f403043c59c4eb6f2e055929cee4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Bonjour voici le r=C3=A9sultat des commandes que me retourne mon terminal, Xubuntu = 14.04 eric@Eric-Xub:~/Bureau$ expr 2 + 3 5 eric@Eric-Xub:~/Bureau$ expr 2 * 3 expr: erreur de syntaxe eric@Eric-Xub:~/Bureau$ Cordialement --f403043c59c4eb6f2e055929cee4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Bonjour

voici le r=C3=A9sultat des= commandes que me retourne mon terminal, Xubuntu 14.04


eric@Eric= -Xub:~/Bureau$ expr 2 + 3
5
eric@Eric-Xub:~/Bureau$ expr 2 * 3
exp= r: erreur de syntaxe
eric@Eric-Xub:~/Bureau$

Cordialement<= br>


--f403043c59c4eb6f2e055929cee4-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 14 14:01:05 2017 Received: (at 28461-done) by debbugs.gnu.org; 14 Sep 2017 18:01:05 +0000 Received: from localhost ([127.0.0.1]:41403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsYRk-0003qz-Q6 for submit@debbugs.gnu.org; Thu, 14 Sep 2017 14:01:04 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:56983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsYRh-0003qJ-0A for 28461-done@debbugs.gnu.org; Thu, 14 Sep 2017 14:01:01 -0400 Received: by mail-it0-f50.google.com with SMTP id g18so1109927itg.5 for <28461-done@debbugs.gnu.org>; Thu, 14 Sep 2017 11:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=bJkQIh9TR0M+kWCs1E8Rowh5l84aNv3UYLwzmSAb7GI=; b=iAsC8acF+UL4ne5z2EQSKdkrr0LneEAXQOkr0EMv5d2BO6HgaOHyCbJN7zaQBzzHJ0 QMU9oQ270yBCSNLAnYF4FWXyRjCr56IB2EEmhZe+/LRDE9vEln6Ms5vRLQpJBjXug5ey ulp4so3asveAJY3d+jpX5IN3cfwyHLQ7eG5rOrZKEtrv0O7JR7s0gfCwChAdpU7QVsMl 7tZ3ztEGGnAodIjkPpo2/LgppA4ObmzaUxIcFkVykrxoxVrbTuAO5bKRrMXdo9roS55k zIywvXZ6bOur5py/Rd+d6cqIs4fl6+GW+qQHMaWDmrPSzGH7YcNYMDkpO33Y5CMGbqkK nBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bJkQIh9TR0M+kWCs1E8Rowh5l84aNv3UYLwzmSAb7GI=; b=n9DSOZBnczlRbTv/yXB2kJRCKIQGY4Mit+cbbhDhpdFTvglH/mfEwhb24tbM9pbCHL JQ+wHXClku9b4L2FYWDf7bzZITgFZj0BbVTxNBxlyTea9Tk25Vf9SAIXcjMjNQrgiQl4 8eJm4H/hn4TO5qsPwwSywqwg3EkPdgp22V/NdoMPLbJminRUJH49AQ2SlyLoJNuaYAEU 6sy6pJI6T80cJBZxufFrbm2/J84p4BF+Ev33ZAOnwcWfF1XZZumuW6FZk5DEQkqv32Bm GP0eKWjkPcZ1vnvtAlAuTPiwwhZmpCXbP+4nd87zzYwJI5zr6YWRhqF9qfEEZn+9JFFT YUGg== X-Gm-Message-State: AHPjjUiTCNF/2NBxgzzxJdqk9XjPwhCAba1qeMYzWl+g2t2g5+0q5TBy HyijXIE0Hjb9bM7yLAzrBw== X-Google-Smtp-Source: AOwi7QByjlXRSmNrz6Uf7XOb6anKvCm2tN9R1NCTWq6WykKNKrZJYOdSnZM29IjnifQj2fVbosVmVg== X-Received: by 10.36.201.196 with SMTP id h187mr1285920itg.42.1505412055045; Thu, 14 Sep 2017 11:00:55 -0700 (PDT) Received: from [192.168.88.239] (moose.housegordon.com. [184.68.105.38]) by smtp.gmail.com with ESMTPSA id f68sm9192990iod.40.2017.09.14.11.00.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 11:00:54 -0700 (PDT) Subject: Re: bug#28461: erreurs To: Eric Mariaud , 28461-done@debbugs.gnu.org References: From: Assaf Gordon Message-ID: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> Date: Thu, 14 Sep 2017 12:00:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 28461-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) tag 28461 notabug stop Hello, On 2017-09-14 11:43 AM, Eric Mariaud wrote: > eric@Eric-Xub:~/Bureau$ expr 2 + 3 > 5 > eric@Eric-Xub:~/Bureau$ expr 2 * 3 > expr: erreur de syntaxe The asterisks ( * ) character has special meaning on the shell, which you can observe by comparing the output of: echo 2 + 3 vs echo 2 * 3 Technically, the shell replaces the '*' character with the list of all files in the current directory. The 'expr' program never sees it. Add single-quotes around the '*' character to send it as-is to 'expr': $ expr 2 '*' 3 6 Alternatively, Most modern shells support built-in basic arithmetic using the '$(())' syntax (dollar-sign and two parentheses): $ echo $((2*3)) 6 As such, I'm marking this as not-a-bug, but discussion can continue by replying to this thread. regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 01:45:57 2017 Received: (at 28461) by debbugs.gnu.org; 15 Sep 2017 05:45:57 +0000 Received: from localhost ([127.0.0.1]:41781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsjRt-0003Yn-9E for submit@debbugs.gnu.org; Fri, 15 Sep 2017 01:45:57 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:65048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsjRr-0003YV-Hi for 28461@debbugs.gnu.org; Fri, 15 Sep 2017 01:45:56 -0400 Received: from [192.168.101.10] ([91.12.169.143]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.183]) with ESMTPSA (Nemesis) id 0MKaKl-1dt0pP1Nyh-001xdT; Fri, 15 Sep 2017 07:45:48 +0200 Subject: Re: bug#28461: erreurs To: 28461@debbugs.gnu.org, assafgordon@gmail.com, eric.mariaud@gmail.com References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> From: Bernhard Voelker Message-ID: Date: Fri, 15 Sep 2017 07:45:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SCHOWEdEjoqtqdBkrXiM4+M8+CpR8C80hNdWEFPWMViApxh9VuO 1TTBL+BtXVE7ByGnitXV+VfDa+upuyVJIbTHvrjKOLVIIGNHMDfjYxeDSW1zB4bQCk7kpYJ 9uhfBnDqyr2RJvPH9Ah/Z+g7ns3YLfD8TY/mcED9yl0ZFyrWfjVg07uOmaXlLzyDeA47lPm smKxcYe492jdlWrssYQIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:lirm7izqmSU=:S9ODWmisb8iI8CI8nbysh4 VRdUNhMosW83GsD3dAq3OWCpnRRcqkxPYNCx/9TSaZNZazZrYlZj7iXgLr9uZrHOUQp8s1LBB snOR+Cu4gLaHrNZpquCJPb8q1qzlXu5Ta011LK9+nS/GvEtxjV9wEDqicE0qHQnHQG2JAhJO2 ga9TP1MOsyKA/8V9CtxIEWQ4zv75ls8eNFJdglsbSXDXIbzg8X9oX3rotP7fU2aIEJrfLcnkH 8IQLslZlUDKaRHlWzBmsI6fLQXyoaX3842a+OaiVdF1G4fcaKYJR85zlZeEX8oAqHfG5oAh0J fdJfjSUAgwmyDJ2XRWPwZg2zmeU7XLHBdkfj2r4Kb4H6UXF0OU1NL5XePF1fEZ6SmK55KFdgH eDwaVewBH7L7bSl+ZwexWjNlfoxzBqjZjJku4z4F+mEu1RKBiT3sa4Qe3g1UZ5TRhU/O0q0ZD HvXFDLt+DrGrB2eOE0IBH5Vqxne878G4k3Puk9XqR2OGYBx6wQ7tGBpQ70IcZdq8Ip/pNQ4sh Mc/2Zuwdo2h0CmK8mzsyOwRODCQ/t2QVUaApumHWI0FfKjMDGNWbK+vWnLJTAzBTiX/wlKRlF bUXpB+b3s/ntiz4jm4EvZ+KS30+aTiVWBVd/JJIukmPQim0DN8micDJ6E114rlhDYqVEA/yin I7LAY/F3C42uVj8fu+vswZWEs6dvBh6/r6dREDq0mdUo9XTscQMtf1UxSTgz3CLmeKA6ikaow KPIGDUhfArnC7VSwjJXBJTt7gzHMchooe8MNPkjqNuaHnZxxy8qfXvx2zeQ= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28461 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 09/14/2017 08:00 PM, Assaf Gordon wrote: > On 2017-09-14 11:43 AM, Eric Mariaud wrote: >> eric@Eric-Xub:~/Bureau$ expr 2 + 3 >> 5 >> eric@Eric-Xub:~/Bureau$ expr 2 * 3 >> expr: erreur de syntaxe > > The asterisks ( * ) character has special meaning on the shell, > which you can observe by comparing the output of: > > echo 2 + 3 > vs > echo 2 * 3 > > Technically, the shell replaces the '*' character with the list of > all files in the current directory. The 'expr' program never sees it. Well, we could try to improve the error diagnostics. I see in the code that expr returns "syntax error" without any more explanation in several places. It could at least say what it would expect or not expect in that place. And finally - when it comes to shell pattern globbing - it could do an extra check if the offending argument is an existing file similar to latest 'find' [1]: $ touch a b c $ ../find/find -name * find: paths must precede expression: `b' find: possible unquoted pattern after predicate `-name'? [1] https://git.sv.gnu.org/cgit/findutils.git/commit/?id=9530e31f6d WDYT? Thanks & have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 02:42:06 2017 Received: (at 28461) by debbugs.gnu.org; 15 Sep 2017 06:42:06 +0000 Received: from localhost ([127.0.0.1]:41796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dskKE-0004u5-6x for submit@debbugs.gnu.org; Fri, 15 Sep 2017 02:42:06 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:56881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dskKC-0004tZ-4J for 28461@debbugs.gnu.org; Fri, 15 Sep 2017 02:42:04 -0400 Received: by mail-it0-f52.google.com with SMTP id g18so2547251itg.5 for <28461@debbugs.gnu.org>; Thu, 14 Sep 2017 23:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=5NxQM1jsY+LtX1vjLZRD9D9Ytd8+yCgyeKtRaLGhO40=; b=LhzDAmHDb7hAdWGUQu6NDBam2WYQ5vMP6U9T6hmSv3CbovHL/lmGOvBLm4Sqwp3oo2 U6lIXuNL6IyEOViBgesfFsJ5y1cg1MCK4j+4JkclyQ1NZQcyRMZz9B4MEyaal2GkJnsu h0ZvDEJ8xPmAPOjJ6JUDTnNMZQo8PJcq8LIB2h180gias1jfIEZNBdTHjLFKFnc4DFpe Ru5DR65b/GtMPBlMm865LB/9ImkMNxUdTnX9e5KNr4OeR67nGr2Ie5Xr6pkMFgQhEFna braNg+atAvLPPNEFqRwDJMnDQuZTDxv+Vsq61NSM+VqIHSdADEnlgDURQEq8R4PQLNeJ Dwvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=5NxQM1jsY+LtX1vjLZRD9D9Ytd8+yCgyeKtRaLGhO40=; b=TkZXtAIBhrUJ8YHD/AVdYE/ip4x3EPOKSafZ96RKQ1aI1HD58c2ZJDz/3SVFlBnNaq BFPiLgj0+qqOTguTttbjSwjqCPhbrXq3+aVLGNq+APABSOgDXEUKmM1XzaYATyjKwN3j 1yyCfmWaTDulH/Feai4J/K/DJXLYCZF1Oi8PgRd+AXFrWm1ixCRpTciWKj4fQRbsGpF+ j1UocPKmQmN1aCO/gWsJAdYu6ACnKOlJv48zJtgyQuEuPye+5Moi3C9hEjnf4B25CDtS XVmLRMNfsvrpRCcW+75h1QC5Xk/gJx19yvTazNCGfvz6ZOSCv6yKyXFKGIAonC1f7kGl 3ECQ== X-Gm-Message-State: AHPjjUgg89Jcwcld/0Yjp4FayQMVpfqx5qq9Tk1Pc1MAbwanhW0oniOU tzcUxBeCngs3FGm44CU1V3Y= X-Google-Smtp-Source: AOwi7QDmUl1q8J0S+JpShsaUjUSmRPb+3IN2cHwoqS85311FUo+P0Hz18tzvNbzw2pqgG/41qQDk1g== X-Received: by 10.36.152.133 with SMTP id n127mr3969536itd.17.1505457718481; Thu, 14 Sep 2017 23:41:58 -0700 (PDT) Received: from [192.168.88.239] (moose.housegordon.com. [184.68.105.38]) by smtp.gmail.com with ESMTPSA id p71sm262548itc.20.2017.09.14.23.41.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 23:41:57 -0700 (PDT) Subject: Re: bug#28461: erreurs To: Bernhard Voelker , 28461@debbugs.gnu.org, eric.mariaud@gmail.com References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> From: Assaf Gordon Message-ID: Date: Fri, 15 Sep 2017 00:41:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------CF633D5E184358F817B77BA1" Content-Language: en-US X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28461 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This is a multi-part message in MIME format. --------------CF633D5E184358F817B77BA1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hello, On 2017-09-14 11:45 PM, Bernhard Voelker wrote: >> On 2017-09-14 11:43 AM, Eric Mariaud wrote: >>> eric@Eric-Xub:~/Bureau$ expr 2 * 3 >>> expr: erreur de syntaxe > > Well, we could try to improve the error diagnostics. > > WDYT? Very good idea. Perhaps something like the attached? (not fully tested...) -assaf --------------CF633D5E184358F817B77BA1 Content-Type: text/x-patch; name="0001-expr-add-detailed-syntax-error-messages.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-expr-add-detailed-syntax-error-messages.patch" >From 4bb5771832a397e2db3704feaf0ece52cdd65a55 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 15 Sep 2017 00:36:13 -0600 Subject: [PATCH] expr: add detailed syntax error messages Show offending parameter instead of a generic 'syntax error' message. Suggested by Bernhard Voelker in https://bugs.gnu.org/28461#13 . * src/expr.c (syntax_error): Remove. (required_more_args): New function. (eval7, main): Replace syntax_error call with detailed die message. * tests/misc/expr.pl: Add tests for new messages. --- src/expr.c | 36 +++++++++++++++++++++++------------- tests/misc/expr.pl | 17 ++++++++++++++++- 2 files changed, 39 insertions(+), 14 deletions(-) diff --git a/src/expr.c b/src/expr.c index 194b54b..8d796ea 100644 --- a/src/expr.c +++ b/src/expr.c @@ -413,12 +413,6 @@ or 0, 2 if EXPRESSION is syntactically invalid, and 3 if an error occurred.\n\ exit (status); } -/* Report a syntax error and exit. */ -static void -syntax_error (void) -{ - die (EXPR_INVALID, 0, _("syntax error")); -} #if ! HAVE_GMP /* Report an integer overflow for operation OP and exit. */ @@ -465,7 +459,9 @@ main (int argc, char **argv) v = eval (true); if (!nomoreargs ()) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: unexpected parameter %s"), + quotearg_n_style (0, locale_quoting_style, *args)); + printv (v); return null (v); @@ -659,6 +655,18 @@ nomoreargs (void) return *args == 0; } +/* Report missing operand. + There is an implicit assumption that there was a previous argument, + and (args-1) is valid. */ +static void +require_more_args (void) +{ + if (nomoreargs ()) + die (EXPR_INVALID, 0, _("syntax error: missing more parameters after %s"), + quotearg_n_style (0, locale_quoting_style, *(args-1))); +} + + #ifdef EVAL_TRACE /* Print evaluation trace and args remaining. */ @@ -759,19 +767,22 @@ eval7 (bool evaluate) #ifdef EVAL_TRACE trace ("eval7"); #endif - if (nomoreargs ()) - syntax_error (); + require_more_args (); if (nextarg ("(")) { v = eval (evaluate); + if (nomoreargs ()) + die (EXPR_INVALID, 0, _("syntax error: expecting ')' after %s"), + quotearg_n_style (0, locale_quoting_style, *(args-1))); if (!nextarg (")")) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: expecting ')' instead of %s"), + quotearg_n_style (0, locale_quoting_style, *args)); return v; } if (nextarg (")")) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: unexpected ')'")); return str_value (*args++); } @@ -792,8 +803,7 @@ eval6 (bool evaluate) #endif if (nextarg ("+")) { - if (nomoreargs ()) - syntax_error (); + require_more_args (); return str_value (*args++); } else if (nextarg ("length")) diff --git a/tests/misc/expr.pl b/tests/misc/expr.pl index c0d6f7c..1ebfe63 100755 --- a/tests/misc/expr.pl +++ b/tests/misc/expr.pl @@ -164,7 +164,7 @@ my @Tests = ['bre61', '"acd" : "a\\(b\\)?c\\1d"', {OUT => ''}, {EXIT => 1}], ['bre62', '-- "-5" : "-\\{0,1\\}[0-9]*\$"', {OUT => '2'}], - ['fail-b', '9 9', {ERR => "$prog: syntax error\n"}, + ['fail-b', '9 9', {ERR => "$prog: syntax error: unexpected parameter '9'\n"}, {EXIT => 2}], ['fail-c', {ERR => "$prog: missing operand\n" . "Try '$prog --help' for more information.\n"}, @@ -176,6 +176,21 @@ my @Tests = ['bignum-sub2', "$big_sum - $big", {OUT => $big_p1}], ['bignum-mul', "$big_p1 '*' $big", {OUT => $big_prod}], ['bignum-div', "$big_prod / $big", {OUT => $big_p1}], + + + # Test syntax error messages + ['se1', "2 a", {EXIT=>2}, + {ERR=>"$prog: syntax error: unexpected parameter 'a'\n"}], + ['se2', "2 '+'", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing more parameters after '+'\n"}], + ['se3', "2 :", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing more parameters after ':'\n"}], + ['se4', "length", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing more parameters after 'length'\n"}], + ['se5', "'(' 2 ", {EXIT=>2}, + {ERR=>"$prog: syntax error: expecting ')' after '2'\n"}], + ['se6', "'(' 2 a", {EXIT=>2}, + {ERR=>"$prog: syntax error: expecting ')' instead of 'a'\n"}], ); # If using big numbers fails, remove all /^bignum-/ tests -- 2.7.4 --------------CF633D5E184358F817B77BA1-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 23:37:33 2017 Received: (at 28461) by debbugs.gnu.org; 16 Sep 2017 03:37:33 +0000 Received: from localhost ([127.0.0.1]:43236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt3vB-0005ZP-Gw for submit@debbugs.gnu.org; Fri, 15 Sep 2017 23:37:33 -0400 Received: from mail.magicbluesmoke.com ([82.195.144.49]:53862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt3v9-0005ZF-A9 for 28461@debbugs.gnu.org; Fri, 15 Sep 2017 23:37:31 -0400 Received: from localhost.localdomain (c-73-158-116-184.hsd1.ca.comcast.net [73.158.116.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 4005494B8; Sat, 16 Sep 2017 04:37:29 +0100 (IST) Subject: Re: bug#28461: erreurs To: Assaf Gordon , Bernhard Voelker , 28461@debbugs.gnu.org, eric.mariaud@gmail.com References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> Date: Fri, 15 Sep 2017 20:37:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28461 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 14/09/17 23:41, Assaf Gordon wrote: > Hello, > > On 2017-09-14 11:45 PM, Bernhard Voelker wrote: >>> On 2017-09-14 11:43 AM, Eric Mariaud wrote: >>>> eric@Eric-Xub:~/Bureau$ expr 2 * 3 >>>> expr: erreur de syntaxe >> >> Well, we could try to improve the error diagnostics. >> >> WDYT? > > Very good idea. > > Perhaps something like the attached? (not fully tested...) > > -assaf > That's a good improvement! I'd change: s/missing more parameters after/missing parameter after/ This would be fine even in the case of multi param operations like 'match' and 'substr' thanks! Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 23:44:58 2017 Received: (at 28461) by debbugs.gnu.org; 16 Sep 2017 03:44:58 +0000 Received: from localhost ([127.0.0.1]:43245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt42M-0005jd-Ij for submit@debbugs.gnu.org; Fri, 15 Sep 2017 23:44:58 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:43345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt42L-0005jQ-3D for 28461@debbugs.gnu.org; Fri, 15 Sep 2017 23:44:57 -0400 Received: by mail-qk0-f177.google.com with SMTP id j5so3624540qkd.0 for <28461@debbugs.gnu.org>; Fri, 15 Sep 2017 20:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=os6vDKTKrU2ehIuj8MSV7ul3BPb+BPh4+JfbK5oPbwU=; b=MYbNGdfxLZLf7NlPBdRLXtFKxFkfbHynS5h+yHNrv0n+lRfCkB21s/yFnlAg02RbOX gXFledZDi2gMpddn7BWZOD9Kz+hKFG7BvqssUV2prF0bnnDd6nikHbpIV7x9mnOWktzT 16/tuGz+ayii3dUO8YzIQGXDI6s/cFDW1l5ON3LTdo1f370mumjg8F7v7PKU38YkUhwG p/WGmvIvb6H5FI6hFZE194hUMiA0ASlfdQdBGJV6eQcVmC4N2+1z5rHE1kd6VRpYYIts 8DiuGzDzQjMAMPMzRSzi73DcORiUUnqiIhte9W4tqaENkv25Hn9OUGweIod08CiCAfCB xapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=os6vDKTKrU2ehIuj8MSV7ul3BPb+BPh4+JfbK5oPbwU=; b=IJX6mbXeyFlJ5Fg7zvsgGDDOh++oTiGrJ7FzysTcyqI9OHP2uXQ+OgVU8qLmd8CkOZ iyP98/ollYmT2lphszo/67nqy0hs3Uzh2StJ4Q5unzdg1sOVGBORvw57gKxUEWnlTW3y /iHkCdakVfiVo83YiIR1fROiNwXGphga6TUCLDdg1oEoK18I2WZAR4o7QZ4gYbRWQzF9 VZ6a4l6Bqt4YaPOBCNieyNlQhbemmW004UAoWGVd+q+syaXBsAiyBXKPRv0lAvC+3X5x DCmmCiMVLjFSaEinRV+zwCPMwrGe2X5w+n0Ft8gn4SKQ5D5E2i86eq4hM+JEVOa7p8F6 HK0A== X-Gm-Message-State: AHPjjUh4myndfwWZyVvK7/WrnjfrjCg4CTz4O00NtwCuayYpWEcrm764 4gGvibo2iPy++Q278TsT0omB6YCsd9VELbJXJBs= X-Google-Smtp-Source: AOwi7QBxLP2tkwMCnNXM6L0GwShlxaJL5LnneQnQQD3flrC9dYz3AwOhUTWa88hpT7cmXi2eD5EUUSXxvzVJy+iEUmQ= X-Received: by 10.55.68.77 with SMTP id r74mr10506237qka.125.1505533491391; Fri, 15 Sep 2017 20:44:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.168.143 with HTTP; Fri, 15 Sep 2017 20:44:30 -0700 (PDT) In-Reply-To: <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> From: Jim Meyering Date: Fri, 15 Sep 2017 20:44:30 -0700 X-Google-Sender-Auth: iMJe9HnVpYA0ztfnzWivU6LWSnE Message-ID: Subject: Re: bug#28461: erreurs To: =?UTF-8?Q?P=C3=A1draig_Brady?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28461 Cc: 28461@debbugs.gnu.org, Assaf Gordon , Bernhard Voelker , eric.mariaud@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Fri, Sep 15, 2017 at 8:37 PM, P=C3=A1draig Brady wrot= e: ... > That's a good improvement! Indeed! > > I'd change: > > s/missing more parameters after/missing parameter after/ Or, perhaps use wording similar to what test does: ..._("missing argument after %s") From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 16 00:33:05 2017 Received: (at 28461) by debbugs.gnu.org; 16 Sep 2017 04:33:05 +0000 Received: from localhost ([127.0.0.1]:43265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt4mv-0006ql-LW for submit@debbugs.gnu.org; Sat, 16 Sep 2017 00:33:05 -0400 Received: from mail.magicbluesmoke.com ([82.195.144.49]:59812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt4mt-0006qd-QA for 28461@debbugs.gnu.org; Sat, 16 Sep 2017 00:33:04 -0400 Received: from localhost.localdomain (c-73-158-116-184.hsd1.ca.comcast.net [73.158.116.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 0A4794ACD; Sat, 16 Sep 2017 05:33:01 +0100 (IST) Subject: Re: bug#28461: erreurs To: Jim Meyering References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Fri, 15 Sep 2017 21:33:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28461 Cc: 28461@debbugs.gnu.org, Assaf Gordon , Bernhard Voelker , eric.mariaud@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 15/09/17 20:44, Jim Meyering wrote: > On Fri, Sep 15, 2017 at 8:37 PM, Pádraig Brady wrote: > ... >> That's a good improvement! > > Indeed! > >> >> I'd change: >> >> s/missing more parameters after/missing parameter after/ > > Or, perhaps use wording similar to what test does: > > ..._("missing argument after %s") better again From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 16 00:38:36 2017 Received: (at 28461) by debbugs.gnu.org; 16 Sep 2017 04:38:37 +0000 Received: from localhost ([127.0.0.1]:43268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt4sG-0006xz-9m for submit@debbugs.gnu.org; Sat, 16 Sep 2017 00:38:36 -0400 Received: from mail-yw0-f173.google.com ([209.85.161.173]:48332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt4dl-0006cV-No for 28461@debbugs.gnu.org; Sat, 16 Sep 2017 00:23:38 -0400 Received: by mail-yw0-f173.google.com with SMTP id v137so2492848ywg.5 for <28461@debbugs.gnu.org>; Fri, 15 Sep 2017 21:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EGuWXdqAW723EEVl5PSuHOrWFPSY4NMfTRmGeiD4bqM=; b=HGtH4OGdsqZ7DjmBBKhonD8I/1foYnRHk7PGrLEU/gS+a5ZJnRAWH6gLhiVimxS9VB t66sfyi519xOWIEDwliHf8sHuIajiIw8fcgTuyfACJP6C89Il0MXQMvQfzZKc+AE/5VH MWq7QZ3yqVzMwwngQpIWjfjj7BcL/KZvAHypyNEKPn+lEbZTZCSif2MM5yKnKtLHqcQT E+hEOSAnjL+/pOVyfOodxPIOfV1H/tmhXGX6Y1f7SzrEDbfwxivxlhvOaw6XkQRPAjzn LwoHazQP1nR3NpiDI7enuPVCyXLMt7luG3yq53b5o7FtqROpXQBphoXQn4RGHBGam2oh osJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EGuWXdqAW723EEVl5PSuHOrWFPSY4NMfTRmGeiD4bqM=; b=gne2ky7N6lzjYBCaSebpHw13KrF+dk0uXyKf2fcpLSelS7f8V+eTVHpwuIvfqY177B zAMc0KjraByexc0kbbB8O29uUWKIJ3VJpqnEaLXmWQp375cYUi8p7+ITdpyAo87PGN/R 0l8EqrYN8Nv3E2qs3ulONGaGbT17AMne5kHIabuEasjsbzB5o/Y9zFxJOkHIN3HE2yse 9USYFlPOcgvXO/fnQOa5s9ZPorOKGNfdQMsdBQNgFn8c3mVUYInJxric+t2UOrUIMXtQ sCxJAFJHTpJjlykwTiD7WIjY7BmAAyG2xhfvnr7ahhRwCWjvt/CRhxLJqCM2+LiI2/oK FfWg== X-Gm-Message-State: AHPjjUhf+NqrURJCKB2AtBa7PqJQPW0c93Wi4Lsw22LWwHsDUwMRVXM5 3YI1NoavqiYnOvXDfqt/1ot8rqxPb1DlUvTGU0c= X-Google-Smtp-Source: ADKCNb4O++C3zsxy0vYgBiEmXh2jZmSeOJSprR6qN/s+2fMWzLpWXY0FG3HeNlRfum3igHs459NSULEkI+EkQGExNXI= X-Received: by 10.37.185.140 with SMTP id r12mr20080101ybg.355.1505535812040; Fri, 15 Sep 2017 21:23:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.131.138 with HTTP; Fri, 15 Sep 2017 21:23:31 -0700 (PDT) In-Reply-To: References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> From: R0b0t1 Date: Fri, 15 Sep 2017 23:23:31 -0500 Message-ID: Subject: Re: bug#28461: erreurs To: Bernhard Voelker Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28461 X-Mailman-Approved-At: Sat, 16 Sep 2017 00:38:35 -0400 Cc: 28461@debbugs.gnu.org, assafgordon@gmail.com, eric.mariaud@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Fri, Sep 15, 2017 at 12:45 AM, Bernhard Voelker wrote: > And finally - when it comes to shell pattern globbing - it could > do an extra check if the offending argument is an existing file > similar to latest 'find' [1]: > > $ touch a b c > $ ../find/find -name * > find: paths must precede expression: `b' > find: possible unquoted pattern after predicate `-name'? > > [1] https://git.sv.gnu.org/cgit/findutils.git/commit/?id=9530e31f6d > > WDYT? > I think the proposed change is useful. For consistency's sake, I feel like I need to point out that I suggested a similar change to "rm" (check to make sure $HOME was not a target) and one of the arguments against such a check was that the file operations necessary to do so would take too much time. It may be a good idea to consider that in this case as well. I personally do not understand how this might be the case, but I admit to possessing no great intellect. Respectfully, R0b0t1 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 16 03:27:10 2017 Received: (at 28461) by debbugs.gnu.org; 16 Sep 2017 07:27:10 +0000 Received: from localhost ([127.0.0.1]:43304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt7VN-0002wA-TE for submit@debbugs.gnu.org; Sat, 16 Sep 2017 03:27:10 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:61443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt7VM-0002vv-Gp for 28461@debbugs.gnu.org; Sat, 16 Sep 2017 03:27:08 -0400 Received: from [192.168.101.10] ([91.12.169.143]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MKQQI-1dsZXP1XR0-001frW; Sat, 16 Sep 2017 09:27:01 +0200 Subject: Re: bug#28461: erreurs To: R0b0t1 References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> From: Bernhard Voelker Message-ID: <39eb50f7-1903-42f1-13f0-eb460e844b01@bernhard-voelker.de> Date: Sat, 16 Sep 2017 09:27:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NfUm2uOsafA9wTCywRo0CgDZnDZPeCpsypns3hFyiR9kwBKQ3HN ON75DpUhWx2pTuVttmEOf0StJKjJuF/Y/x0rPiTaPtwZj7yRfKwVB5eI0N36GDzu9eG4X8V knY9HC9C+yq4OX8PuF+8zm1KX+locbc2e48jF5LQTClWUZlz6lo8XD3J9Py1eCXdrXhLGhF yh2uAm8kDcYqQXpcJlfgQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4qWrlFHBe9E=:h+8t7TcmY0AWHfXstx+fnT Jiecg5kqBsIA5+sFpdpZnFCcTxGEafIeDXjbBbuUSTw2qFF7CdyIZnK2Zuzx8Ew4A6H7oLu79 nlH7X6YoZ5tabSS1NsPmzfhzupKM1xmxWbZFbzdU0GBsGbE22kY/PuPz+BBF/wDFA3Su/gtW6 9HjbpAuQeP8v3jL+BGLiKrHttua/85bKWD/E7NxIV+ZZ9dNLGBN4MPu5eRkjtcjLDNjHVgQF0 E83uZemgz/KATgOURJMoS5XkDY4mDj1JLo1sIS8+NZtOxQ8QRaNmXVsY2hsRaMWHTkWZNEnQT jZZ5HYs2skLftKWg11hhOKoUA18s3yxSVeiX0cVjwww3I9E71fiWnCa+sDPSFPG0pZtDkELH0 mdjwX8RWz/xwVfPek6cBlCx8hMyd1x6e8Cg/HkkXhpjZTnwT+H1O/qvLH7ngxtcDQjk32KZib cltNhex8lDZJ9r9yH/OCj0bq496I0xMcbE3Tojde9ru9nsXJND02f+xNparkfTqj3nvbikysL QyLD5InY4FMPNEpc5ZYVwAhA6t6ZSV5/qJaB1G37aLJgFf7nwQ5JqAk5B4/x96GQrp0j06aZM 8ffPLEa/b9vxGw5FgUjkyDtdknCL3nKeJixjh2vL/EvgE1us24Jq1R+Zyrvurfu2oiquSv79z QfjM0QaJFTCYifZftEvuoR6H8nXM1e+Y02noY3gafK1sJ/MvpP/jw3BWP6fyYcnK0HUHKUsou HJOw+vtR4bHVp7ihTO2Puz+ivYexmuckXfQOhuodnaPqcpIN6oI/39WpQFc= X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 28461 Cc: 28461@debbugs.gnu.org, assafgordon@gmail.com, eric.mariaud@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 09/16/2017 06:23 AM, R0b0t1 wrote: > For consistency's sake, I feel like I need to point out that I > suggested a similar change to "rm" (check to make sure $HOME was not a > target) and one of the arguments against such a check was that the > file operations necessary to do so would take too much time. It seems quite likely that the user forgot to quote the multiplier "*" argument. And expr is terminating anyway, so the extra check would just be executed once. Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 02:27:38 2017 Received: (at 28461) by debbugs.gnu.org; 17 Sep 2017 06:27:38 +0000 Received: from localhost ([127.0.0.1]:44413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtT3J-0002eo-T5 for submit@debbugs.gnu.org; Sun, 17 Sep 2017 02:27:38 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtT3H-0002eb-P6 for 28461@debbugs.gnu.org; Sun, 17 Sep 2017 02:27:36 -0400 Received: by mail-io0-f175.google.com with SMTP id z187so13285028ioz.12 for <28461@debbugs.gnu.org>; Sat, 16 Sep 2017 23:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=xDwhQdPflzA2W5V2cGSSB6wKsT2BZuxpuebM3VctFOQ=; b=d308PpEnNVzdoU50fFQ7+qTGzfm0icImoKQxs9mBdsV8SQUCgRkFIvbj7dv7sIlUEO 8sPCzbK0T40I5MoNUYQVZH2ugBtPh4hQvr675EJoKvJBz7zYqcmxcTpKcBjnvDJ3mSr9 hQwinY2r/GjlfhSAVtnjP7eOolvU3/zor99rhGg51kzIjcXsAX4CeYnc4eWL2F5vszgF EQCgua8FXKu/NKWVCp5b+KPcSFmNrrqlsPYBg1tWMz/Gop4YS9mIPPLSYKm7Uj9Pdhgs RdmF7DBQ7KOO8KmIvcyVbMauoXUKheq/UqtxZRWrb1Z/N7mEhkw9UI6R6oIy3bL6Zexb i4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=xDwhQdPflzA2W5V2cGSSB6wKsT2BZuxpuebM3VctFOQ=; b=DurUe2+sxJzh+QaD/qCMIRDsu3gNz1SBf4Vq4TsT+fkJMCtARMFY9qQTJCIL+Ie4Tm 9At5LXhDxolX/LPZoyIdy8nVVjRvsGoHL7rXFFBwjEDbi+sFckbfWLALXnCO75Pt/yqn kkQApeyqK0qOET7a69Gi1UwUv5Oj92yFZO+WNrjGQnwCM9YTqgj7a6fc+i2EFs3GtG5G K17sRwxUmmvQblIWwAoD+sYYVY4mQTk/WyZeqX4j+51OZY0B0ZALya5Heos0gEHgm2Cv oaif7frcDy15Z5A6lf6tEpN4qDHPTKrbP5exO13K+sT+Wlc3IajX76xSWWbzOni+7sy9 bvdQ== X-Gm-Message-State: AHPjjUjBmPIQ5O2kQNlWqp/MsQ7IwdjWNf+UN+vW+wZIUW6XvQMfn3HQ VhVuiviH+58rIw== X-Google-Smtp-Source: AOwi7QD5XW37ZzTe7ITUv/bw7dAzao8k0NV6GZI+yUbYf57/80apVk85xlKrbnSlfSTPZNtU0HTiuw== X-Received: by 10.107.135.72 with SMTP id j69mr15541810iod.210.1505629650155; Sat, 16 Sep 2017 23:27:30 -0700 (PDT) Received: from [192.168.88.239] (moose.housegordon.com. [184.68.105.38]) by smtp.gmail.com with ESMTPSA id j83sm2318497ioi.57.2017.09.16.23.27.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Sep 2017 23:27:29 -0700 (PDT) Subject: Re: bug#28461: erreurs To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Jim Meyering References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> From: Assaf Gordon Message-ID: <782b4c4e-7ec7-f22a-bb81-b7750844aee1@gmail.com> Date: Sun, 17 Sep 2017 00:27:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------74045514BF4461C59911EF1A" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28461 Cc: 28461@debbugs.gnu.org, Bernhard Voelker , eric.mariaud@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------74045514BF4461C59911EF1A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 2017-09-15 10:33 PM, Pádraig Brady wrote: > On 15/09/17 20:44, Jim Meyering wrote: >> Or, perhaps use wording similar to what test does: >> >> ..._("missing argument after %s") > > better again Thank you for all comments. Attached an updated patch with all instances of 'parameter' changed to 'argument'. regards, - assaf --------------74045514BF4461C59911EF1A Content-Type: text/x-patch; name="0001-expr-add-detailed-syntax-error-messages.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-expr-add-detailed-syntax-error-messages.patch" >From af73836848da7e391bcfc06008a34db5aa9ad304 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 15 Sep 2017 00:36:13 -0600 Subject: [PATCH] expr: add detailed syntax error messages Show offending argument instead of a generic 'syntax error' message. Suggested by Bernhard Voelker in https://bugs.gnu.org/28461#13 . * src/expr.c (syntax_error): Remove. (required_more_args): New function. (eval7, main): Replace syntax_error call with detailed die message. * tests/misc/expr.pl: Add tests for new messages. --- src/expr.c | 36 +++++++++++++++++++++++------------- tests/misc/expr.pl | 19 +++++++++++++++++-- 2 files changed, 40 insertions(+), 15 deletions(-) diff --git a/src/expr.c b/src/expr.c index 194b54b..a13a29a 100644 --- a/src/expr.c +++ b/src/expr.c @@ -413,12 +413,6 @@ or 0, 2 if EXPRESSION is syntactically invalid, and 3 if an error occurred.\n\ exit (status); } -/* Report a syntax error and exit. */ -static void -syntax_error (void) -{ - die (EXPR_INVALID, 0, _("syntax error")); -} #if ! HAVE_GMP /* Report an integer overflow for operation OP and exit. */ @@ -465,7 +459,9 @@ main (int argc, char **argv) v = eval (true); if (!nomoreargs ()) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: unexpected argument %s"), + quotearg_n_style (0, locale_quoting_style, *args)); + printv (v); return null (v); @@ -659,6 +655,18 @@ nomoreargs (void) return *args == 0; } +/* Report missing operand. + There is an implicit assumption that there was a previous argument, + and (args-1) is valid. */ +static void +require_more_args (void) +{ + if (nomoreargs ()) + die (EXPR_INVALID, 0, _("syntax error: missing argument after %s"), + quotearg_n_style (0, locale_quoting_style, *(args-1))); +} + + #ifdef EVAL_TRACE /* Print evaluation trace and args remaining. */ @@ -759,19 +767,22 @@ eval7 (bool evaluate) #ifdef EVAL_TRACE trace ("eval7"); #endif - if (nomoreargs ()) - syntax_error (); + require_more_args (); if (nextarg ("(")) { v = eval (evaluate); + if (nomoreargs ()) + die (EXPR_INVALID, 0, _("syntax error: expecting ')' after %s"), + quotearg_n_style (0, locale_quoting_style, *(args-1))); if (!nextarg (")")) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: expecting ')' instead of %s"), + quotearg_n_style (0, locale_quoting_style, *args)); return v; } if (nextarg (")")) - syntax_error (); + die (EXPR_INVALID, 0, _("syntax error: unexpected ')'")); return str_value (*args++); } @@ -792,8 +803,7 @@ eval6 (bool evaluate) #endif if (nextarg ("+")) { - if (nomoreargs ()) - syntax_error (); + require_more_args (); return str_value (*args++); } else if (nextarg ("length")) diff --git a/tests/misc/expr.pl b/tests/misc/expr.pl index c0d6f7c..b88914e 100755 --- a/tests/misc/expr.pl +++ b/tests/misc/expr.pl @@ -164,8 +164,8 @@ my @Tests = ['bre61', '"acd" : "a\\(b\\)?c\\1d"', {OUT => ''}, {EXIT => 1}], ['bre62', '-- "-5" : "-\\{0,1\\}[0-9]*\$"', {OUT => '2'}], - ['fail-b', '9 9', {ERR => "$prog: syntax error\n"}, - {EXIT => 2}], + ['fail-b', '9 9', + {ERR => "$prog: syntax error: unexpected argument '9'\n"}, {EXIT => 2}], ['fail-c', {ERR => "$prog: missing operand\n" . "Try '$prog --help' for more information.\n"}, {EXIT => 2}], @@ -176,6 +176,21 @@ my @Tests = ['bignum-sub2', "$big_sum - $big", {OUT => $big_p1}], ['bignum-mul', "$big_p1 '*' $big", {OUT => $big_prod}], ['bignum-div', "$big_prod / $big", {OUT => $big_p1}], + + + # Test syntax error messages + ['se1', "2 a", {EXIT=>2}, + {ERR=>"$prog: syntax error: unexpected argument 'a'\n"}], + ['se2', "2 '+'", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing argument after '+'\n"}], + ['se3', "2 :", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing argument after ':'\n"}], + ['se4', "length", {EXIT=>2}, + {ERR=>"$prog: syntax error: missing argument after 'length'\n"}], + ['se5', "'(' 2 ", {EXIT=>2}, + {ERR=>"$prog: syntax error: expecting ')' after '2'\n"}], + ['se6', "'(' 2 a", {EXIT=>2}, + {ERR=>"$prog: syntax error: expecting ')' instead of 'a'\n"}], ); # If using big numbers fails, remove all /^bignum-/ tests -- 2.7.4 --------------74045514BF4461C59911EF1A-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 20:47:57 2017 Received: (at 28461-done) by debbugs.gnu.org; 18 Sep 2017 00:47:57 +0000 Received: from localhost ([127.0.0.1]:45400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtkE9-0006ag-9t for submit@debbugs.gnu.org; Sun, 17 Sep 2017 20:47:57 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:49141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtkE7-0006aT-9u for 28461-done@debbugs.gnu.org; Sun, 17 Sep 2017 20:47:55 -0400 Received: by mail-qt0-f174.google.com with SMTP id q8so6184436qtb.5 for <28461-done@debbugs.gnu.org>; Sun, 17 Sep 2017 17:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7V1KTmJ5Z1YMGN1xMuvJ48kpJEXtvvqox0uroN727Ps=; b=gNYB7nk/SaB53Sy7+PSoJ9Hl0RyOtS4wUYqjB1zKTJbHi/cC95aTLoKM8EaM9EFtbT I4b+DfD8U8A/5KFci4FJEMaC2T0Yrz5lM0roKlha7elMsNOBiPY/DZO0Q8/hFCUTnzKr H7zi6tMNNJ8F5r/bvdy7afwF/dRp5oz36zAS1YlLO8ojirm3Ag7KOAMreNVZibW+Y3jC LMRC4yxukQlaYhAHsyaHdLZjx/rLZzsWFw76yiWe3UePmjiB7p8x9tzyLvpHyB5OkZgL de6SyS5sd7760nG5gu6rB8E2dogTJpdpamkiCxVVZ428t9IDVHYhf44MTElG7h1cMehc ddfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=7V1KTmJ5Z1YMGN1xMuvJ48kpJEXtvvqox0uroN727Ps=; b=nLmJtIDvrurkSMnv+YPt3QncUSnUyAD0+Sb9Aah9hbVoZ9BAIsw7jwTyOr/QPbrfil OCE5uQEDQWxQxEbweJ2sUNRNkKnUortNsgP6d8ScvkBKG+a2F5LYBE5796sxRLj3F8Ev tzb+9wiGL1yPjxneGjcyAU52iByBGJz3WAzIapNeNaY3Dqw3Pk8mLpFA0YDYKe6Uj2vq gqr/jFXYmC4xSt2sPxibxJ86NFCZT77LgZsujcrKCsdT9zaxtjN101cUxWglSZPf82u+ SdHw/eWMeugTID4/GXtwdoTezo4Om/qWJBYTVg9GcCv1KTJSzi7tvRKLTjthFzZzS8XI U1YQ== X-Gm-Message-State: AHPjjUiinbWlGgslnDrPPMT5hhRtzWiIfPxHqeUSgWIB1wM49VdCawLq OTJpwjjhnTh5bVUSNCbIZYe46rCceW/aYuCSL7o= X-Google-Smtp-Source: AOwi7QCCUz74v+2XoOl5YQ/mTl52PoYHSzV4hKzAN5OR9MXg+J5ypc7vRO2VevoJSDSp6O1hXiNTWooEQp+uWR5B2Ho= X-Received: by 10.200.16.6 with SMTP id z6mr8823287qti.267.1505695669670; Sun, 17 Sep 2017 17:47:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.168.143 with HTTP; Sun, 17 Sep 2017 17:47:28 -0700 (PDT) In-Reply-To: <782b4c4e-7ec7-f22a-bb81-b7750844aee1@gmail.com> References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> <782b4c4e-7ec7-f22a-bb81-b7750844aee1@gmail.com> From: Jim Meyering Date: Sun, 17 Sep 2017 17:47:28 -0700 X-Google-Sender-Auth: fHBH0qMDcN0CKRRIL6V9Rj_QeZA Message-ID: Subject: Re: bug#28461: erreurs To: Assaf Gordon Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28461-done Cc: 28461-done@debbugs.gnu.org, Bernhard Voelker , =?UTF-8?Q?P=C3=A1draig_Brady?= , Eric Mariaud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Sat, Sep 16, 2017 at 11:27 PM, Assaf Gordon wrote: ... > Attached an updated patch with all instances of 'parameter' > changed to 'argument'. Looks fine. Thank you! I marked the issue as "done". From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 20 02:00:08 2017 Received: (at 28461-done) by debbugs.gnu.org; 20 Sep 2017 06:00:08 +0000 Received: from localhost ([127.0.0.1]:48971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duY3K-000415-58 for submit@debbugs.gnu.org; Wed, 20 Sep 2017 02:00:06 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:50806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duY3I-000405-7D for 28461-done@debbugs.gnu.org; Wed, 20 Sep 2017 02:00:04 -0400 Received: by mail-io0-f181.google.com with SMTP id w94so3083769ioi.7 for <28461-done@debbugs.gnu.org>; Tue, 19 Sep 2017 23:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VaJRUyEjKwZZfLSwx0aP1hbXD7hp2AdyeiNi7X/TpgI=; b=eSo5pKxLLzdEnRPOx6ULarlz72NWPtgyV8shreCVN4pexX7eucyxdpO/YUPZJ10Uek UlxfV9EMrbt3sTPaLFNSCMF6+MBiqX63CbLV5JwyYMfyodk/5YlKEVvRmEJB+uRJ9WAf AZJEauLj3LBp4CAED8mvbQILcLelLoGhSDQKpEDqXj3AJHN53rm8kCCr0ucg2dTDQPqW 9awHgsReW5UcVWbh+9xJhO3rM0RsqSHZ0RhST+QAfmOPD8FSmKleDkkz6qxOvMVt8yhs IPVzvbgsJr8w6dftPNoND9/bxUZqHV/UUhI+Rfmhzm+EkD4sopWdDcraQd/qZxxYgA3W /Vsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VaJRUyEjKwZZfLSwx0aP1hbXD7hp2AdyeiNi7X/TpgI=; b=hzLPomxVV5JQatCLTRIPtW6OCXOZWy6hM1xzL4MMZaKBaY3rtrqMtwC9hWuqDc7vis 3btbrST4nmynxOI032/2N+iRdl+9foLX2/jpXybTZLkb0+0/ClIq9awvnJEiVvDBr/JA 3xt1hMorK1/p4cW2GitrgBvMbJS+zQ30xauyDTkz2mgkddlzEvteEeZt7qWphffIgoh8 oJm44vzhwWGxbgFYzllhWw2gDBh2yM8t7aO0jI1PNLMm8cx11ItnGJFXOIMCq7T1q76/ gWcR/lL+raV2o++C7ZXrXuBUG3317CN/eDBBA+7YB/v0yrPZDmC5AgkH46RV25o856rY 8Kcg== X-Gm-Message-State: AHPjjUhwC7c1cZhaRilaebWct1O7oVxEFsboS0OsoWS2ROVH9IJDgMLv sMP3T8+KFi4NTXEtG8PJC+U= X-Google-Smtp-Source: AOwi7QAC4B8CkuC32iZ19Zcvy5LJCR+zMN6ePCDOSnlK1f7fAh9ntPjDI2fGt3xeNCA4p7HK7mnoRw== X-Received: by 10.107.197.198 with SMTP id v189mr5447925iof.94.1505887198467; Tue, 19 Sep 2017 22:59:58 -0700 (PDT) Received: from [192.168.88.239] (moose.housegordon.com. [184.68.105.38]) by smtp.gmail.com with ESMTPSA id v188sm1852633itb.24.2017.09.19.22.59.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 22:59:57 -0700 (PDT) Subject: Re: bug#28461: erreurs To: Jim Meyering References: <2def9484-83b3-bb8a-536a-88c3e4465798@gmail.com> <8bcbb5dd-9c3f-bf73-e59f-bee8e475ea4a@draigBrady.com> <782b4c4e-7ec7-f22a-bb81-b7750844aee1@gmail.com> From: Assaf Gordon Message-ID: Date: Tue, 19 Sep 2017 23:59:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28461-done Cc: 28461-done@debbugs.gnu.org, Bernhard Voelker , =?UTF-8?Q?P=c3=a1draig_Brady?= , Eric Mariaud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 2017-09-17 06:47 PM, Jim Meyering wrote: > On Sat, Sep 16, 2017 at 11:27 PM, Assaf Gordon wrote: > ... >> Attached an updated patch with all instances of 'parameter' >> changed to 'argument'. > > Looks fine. Thank you! > I marked the issue as "done". Thank you all. Pushed here: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=454d7f31 regards, - assaf From unknown Fri Jun 13 10:37:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator