GNU bug report logs - #28434
25.2; Final "\ No newline at end of file" breaks Emacs patch handling.

Previous Next

Full log

Message #8 received at 28434 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Cc: 28434 <at> debbugs.gnu.org
Subject: Re: bug#28434: 25.2;
 Final "\ No newline at end of file" breaks Emacs patch handling.
Date: Mon, 24 Jun 2019 18:13:48 +0200

Oleksandr Gavenko <gavenkoa <at> gmail.com> writes:

> It's very annoying as I have no control over file content and sometime can't
> add final new line.

I think that's kind of unusual -- most text file formats can end in
newlines.

> Emacs commands in diff mode should tolerate ``\`` message about missing final
> new line.
>
> ediff-diff-ok-lines-regexp is:
>
>   "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No +newline\\|.*missing +newline\\|^?$\\)"
>
> and match that line.

I think if you need this, you should add it to that variable, but I
don't think this would be a good default.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.