GNU bug report logs - #28434
25.2; Final "\ No newline at end of file" breaks Emacs patch handling.

Previous Next

Package: emacs;

Reported by: Oleksandr Gavenko <gavenkoa <at> gmail.com>

Date: Tue, 12 Sep 2017 18:02:01 UTC

Severity: minor

Found in version 25.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 28434 <at> debbugs.gnu.org, npostavs <at> gmail.com, gavenkoa <at> gmail.com
Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling.
Date: Tue, 25 Jun 2019 05:41:46 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 25 Jun 2019 01:09:59 +0200
> Cc: 28434 <at> debbugs.gnu.org, Oleksandr Gavenko <gavenkoa <at> gmail.com>
> 
> Noam Postavsky <npostavs <at> gmail.com> writes:
> 
> >> I think if you need this, you should add it to that variable, but I
> >> don't think this would be a good default.
> >
> > Hmm, the "\ No newline at end of file" thing is a de facto standard, so
> > shouldn't Emacs recognize it by default?
> 
> Hm...  is it?  I've always thought that was Emacs telling me I was doing
> something wrong.  :-)

It comes from Diff.

> But if that's the case, then perhaps we should add it?

Yes, I think so.
This bug report was last modified 2 years and 359 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.