Subject: [bug#28429] [PATCH] gnu: Add John the Ripper.

From: [email-masked] (Ludovic Courtès)
Date: Wed, 13 Sep 2017 10:10:39 +0200

Hi Eric,

Eric Bavier <[email-masked]> skribis:

> * gnu/packages/password-utils.scm (john-the-ripper-jumbo): New variable.

[...]

> +       `(#:configure-flags
> +         (list (string-append
> +                "CFLAGS="

Is this to clear CFLAGS?  We should make sure to get “-O2 -g”.

> +                "-DJOHN_SYSTEMWIDE=1 "
> +                "-DJOHN_SYSTEMWIDE_EXEC='\"" %output "/libexec/john\"' "
> +                "-DJOHN_SYSTEMWIDE_HOME='\"" %output "/share/john\"'")
> +               "--disable-native-tests"
> +               "--disable-native-macro")

Perhaps add a comment on these two flags.

> +         #:tests? #f ;tests assume /etc/passwd has a pw_dir for the build user

/etc/passwd in the build environment has this line (see
nix/libstore/build.cc:1859):

  nixbld:x:%1%:%2%:Nix build user:/:/noshell

Isn’t it sufficient to have “/” as the home directory?

> +      (description "John the Ripper is a fast password cracker.  Its primary
> +purpose is to detect weak Unix passwords.  Besides several crypt(3) password

Rather @code{crypt}.

Otherwise LGTM, thank you!

Ludo’.