From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: "N. Raghavendra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 28428@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: "N. Raghavendra" Received: via spool by submit@debbugs.gnu.org id=B.15051694786526 (code B ref -1); Mon, 11 Sep 2017 22:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Sep 2017 22:37:58 +0000 Received: from localhost ([127.0.0.1]:34266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drXL3-0001hB-TO for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drXL1-0001gu-M4 for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drXKv-0002zJ-Dz for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drXKv-0002zF-AD for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drXKt-0002Ny-Sj for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drXKq-0002y9-Pf for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:47 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:56113 helo=homiemail-a83.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drXKq-0002xG-Fg for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:44 -0400 Received: from homiemail-a83.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTP id 872A68018C37 for ; Mon, 11 Sep 2017 15:37:41 -0700 (PDT) Received: from retrotexts.net (www.hri.res.in [220.227.103.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: raghu@retrotexts.net) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 330B48018C2E for ; Mon, 11 Sep 2017 15:37:41 -0700 (PDT) Received: by retrotexts.net (Postfix, from userid 1000) id 8416924025AB; Tue, 12 Sep 2017 04:07:35 +0530 (IST) From: "N. Raghavendra" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Date: Tue, 12 Sep 2017 04:07:35 +0530 Message-ID: <87377seua8.fsf@ailuros> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain I am using Emacs 26.0.50. In the cases that I tried, when there is no comment in the portion of the buffer between the search limit and point, `comment-search-backward' does not move point to the search limit before raising an error. This behaviour contradicts its docstring. My message to emacs-devel about this is at http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00193.html Attached are a patch that seems to fix the problem, and a file containing a test. Running the test without the change in the patch fails, and passes with the change: $ git checkout master $ emacs -Q -batch -l lisp/newcomment.el -l /tmp/test.el \ -f ert-run-tests-batch-and-exit ---------------------------------------------------------------------- (ert-test-failed ((should (= (point) limit)) :form (= 70 41) :value nil)) FAILED 1/1 test-comment-search-backward-absent ---------------------------------------------------------------------- $ git checkout test-comment-search-forward-absent $ emacs -Q -batch -l lisp/newcomment.el -l /tmp/test.el \ -f ert-run-tests-batch-and-exit ---------------------------------------------------------------------- Running 1 tests (2017-09-12 03:31:48+0530) passed 1/1 test-comment-search-backward-absent ---------------------------------------------------------------------- Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute, http://www.hri.res.in/ --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-comment-search-backword-move-point-when-there-is-no-comment.patch >From eb8e32c6fe4a3d08be8b856b3ff4a300a2e69d4b Mon Sep 17 00:00:00 2001 From: "N. Raghavendra" Date: Tue, 12 Sep 2017 01:41:16 +0530 Subject: [PATCH] comment-search-backword: move point when there is no comment * lisp/newcomment.el (comment-search-backward): Move point to LIMIT when there is no comment between LIMIT and point. --- lisp/newcomment.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/newcomment.el b/lisp/newcomment.el index 8772b523..d849fc1 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -525,7 +525,9 @@ comment-search-backward ;; comment-set-column) and to find the comment-start string (via ;; comment-beginning) in indent-new-comment-line, it should be harmless. (if (not (re-search-backward comment-start-skip limit t)) - (unless noerror (error "No comment")) + (progn + (goto-char limit) + (unless noerror (error "No comment"))) (beginning-of-line) (let* ((end (match-end 0)) (cs (comment-search-forward end t)) -- 2.7.4 --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=test.el Content-Transfer-Encoding: quoted-printable (ert-deftest test-comment-search-backward-absent () "Test `comment-search-backward' when there is no comment in context. Check that when there is no comment in the portion of the buffer between the search limit and point, it moves point to the search limit and raises an error." (with-temp-buffer (emacs-lisp-mode) (comment-normalize-vars) (insert "(require 'foo) \(bar) ; first comment ;; second comment \(provide 'baz)") (let ((limit (save-excursion (search-backward "second")))) (should (equal (should-error (comment-search-backward limit)) '(error "No comment"))) (should (=3D (point) limit))))) --=-=-=-- From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2017 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "N. Raghavendra" Cc: 28428@debbugs.gnu.org Received: via spool by 28428-submit@debbugs.gnu.org id=B28428.1506098463462 (code B ref 28428); Fri, 22 Sep 2017 16:42:01 +0000 Received: (at 28428) by debbugs.gnu.org; 22 Sep 2017 16:41:03 +0000 Received: from localhost ([127.0.0.1]:53105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvR0g-00007O-W1 for submit@debbugs.gnu.org; Fri, 22 Sep 2017 12:41:03 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvR0e-00006q-OU for 28428@debbugs.gnu.org; Fri, 22 Sep 2017 12:41:01 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8MGewid031218; Fri, 22 Sep 2017 12:40:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 3BB5F66257; Fri, 22 Sep 2017 12:40:58 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87377seua8.fsf@ailuros> Date: Fri, 22 Sep 2017 12:40:58 -0400 In-Reply-To: <87377seua8.fsf@ailuros> (N. Raghavendra's message of "Tue, 12 Sep 2017 04:07:35 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6122=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6122> : inlines <6084> : streams <1764136> : uri <2504775> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > (if (not (re-search-backward comment-start-skip limit t)) > - (unless noerror (error "No comment")) > + (progn > + (goto-char limit) > + (unless noerror (error "No comment"))) That looks fine, thank you. But I think the simpler patch below works as well: diff --git a/lisp/newcomment.el b/lisp/newcomment.el index be6dbe3a4c..e32966e596 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -524,7 +524,7 @@ comment-search-backward ;; comment-search-backward is only used to find the comment-column (in ;; comment-set-column) and to find the comment-start string (via ;; comment-beginning) in indent-new-comment-line, it should be harmless. - (if (not (re-search-backward comment-start-skip limit t)) + (if (not (re-search-backward comment-start-skip limit 'move)) (unless noerror (error "No comment")) (beginning-of-line) (let* ((end (match-end 0)) I wonder if there's code out there that depends on this behavior, tho, since AFAIK it's been behaving this way "forever". Stefan From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: "N. Raghavendra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2017 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 28428@debbugs.gnu.org Reply-To: "N. Raghavendra" Received: via spool by 28428-submit@debbugs.gnu.org id=B28428.15061025127297 (code B ref 28428); Fri, 22 Sep 2017 17:49:01 +0000 Received: (at 28428) by debbugs.gnu.org; 22 Sep 2017 17:48:32 +0000 Received: from localhost ([127.0.0.1]:53179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvS40-0001td-Mg for submit@debbugs.gnu.org; Fri, 22 Sep 2017 13:48:32 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:54161 helo=homiemail-a118.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvS3y-0001tU-D4 for 28428@debbugs.gnu.org; Fri, 22 Sep 2017 13:48:31 -0400 Received: from homiemail-a118.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTP id CDA9A60002003; Fri, 22 Sep 2017 10:48:27 -0700 (PDT) Received: from retrotexts.net (www.hri.res.in [220.227.103.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: raghu@retrotexts.net) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTPSA id 7202E60002002; Fri, 22 Sep 2017 10:48:27 -0700 (PDT) Received: by retrotexts.net (Postfix, from userid 1000) id 1F79024005B0; Fri, 22 Sep 2017 23:18:22 +0530 (IST) From: "N. Raghavendra" In-Reply-To: (Stefan Monnier's message of "Fri, 22 Sep 2017 12:40:58 -0400") References: <87377seua8.fsf@ailuros> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Date: Fri, 22 Sep 2017 23:18:22 +0530 Message-ID: <87poaieiah.fsf@hri.res.in> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) At 2017-09-22T12:40:58-04:00, Stefan Monnier wrote: > That looks fine, thank you. But I think the simpler patch below works > as well: > > - (if (not (re-search-backward comment-start-skip limit t)) > + (if (not (re-search-backward comment-start-skip limit 'move)) That's indeed nicer! Thanks for pointing out that the NOERROR arg of `re-search-backward' can be given a value outside {t,nil} to move point to LIMIT. It's a lesson to myself that I should read docstrings more carefully. > I wonder if there's code out there that depends on this behavior, tho, > since AFAIK it's been behaving this way "forever". As you say, it doesn't really matter; it's just that there is a discrepancy between the docstring specification of the effects of the function and the said effects, which would be good to remove. I came across it because I've been playing around with a major mode based on AUCTeX, and was writing ERT tests for some initialisation code I was using from AUCTeX. Perhaps such tests are the only places where these trivial errors matter. Regards, Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute, http://www.hri.res.in/ From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2017 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "N. Raghavendra" Cc: 28428@debbugs.gnu.org Received: via spool by 28428-submit@debbugs.gnu.org id=B28428.150610842516247 (code B ref 28428); Fri, 22 Sep 2017 19:28:02 +0000 Received: (at 28428) by debbugs.gnu.org; 22 Sep 2017 19:27:05 +0000 Received: from localhost ([127.0.0.1]:53245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTbN-0004Dz-6C for submit@debbugs.gnu.org; Fri, 22 Sep 2017 15:27:05 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:37863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTbK-0004Da-4N for 28428@debbugs.gnu.org; Fri, 22 Sep 2017 15:27:03 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8MJQwrZ026963; Fri, 22 Sep 2017 15:27:00 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 708FF66262; Fri, 22 Sep 2017 15:26:58 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87377seua8.fsf@ailuros> <87poaieiah.fsf@hri.res.in> Date: Fri, 22 Sep 2017 15:26:58 -0400 In-Reply-To: <87poaieiah.fsf@hri.res.in> (N. Raghavendra's message of "Fri, 22 Sep 2017 23:18:22 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6122=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6122> : inlines <6084> : streams <1764152> : uri <2504837> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> That looks fine, thank you. But I think the simpler patch below works >> as well: >> - (if (not (re-search-backward comment-start-skip limit t)) >> + (if (not (re-search-backward comment-start-skip limit 'move)) > That's indeed nicer! Thanks for pointing out that the NOERROR arg of > `re-search-backward' can be given a value outside {t,nil} to move point > to LIMIT. It's a lesson to myself that I should read docstrings more > carefully. I think it's too risky for the emacs-26 branch, but feel free to install it on master, Stefan From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: "N. Raghavendra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2017 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 28428@debbugs.gnu.org Reply-To: "N. Raghavendra" Received: via spool by 28428-submit@debbugs.gnu.org id=B28428.150611228422005 (code B ref 28428); Fri, 22 Sep 2017 20:32:01 +0000 Received: (at 28428) by debbugs.gnu.org; 22 Sep 2017 20:31:24 +0000 Received: from localhost ([127.0.0.1]:53272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvUbc-0005ir-9M for submit@debbugs.gnu.org; Fri, 22 Sep 2017 16:31:24 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:58599 helo=homiemail-a118.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvUbZ-0005ih-F7 for 28428@debbugs.gnu.org; Fri, 22 Sep 2017 16:31:22 -0400 Received: from homiemail-a118.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTP id B947A60002003; Fri, 22 Sep 2017 13:31:19 -0700 (PDT) Received: from retrotexts.net (www.hri.res.in [220.227.103.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: raghu@retrotexts.net) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTPSA id 63B6560002002; Fri, 22 Sep 2017 13:31:19 -0700 (PDT) Received: by retrotexts.net (Postfix, from userid 1000) id F1AAF24008BD; Sat, 23 Sep 2017 02:01:14 +0530 (IST) From: "N. Raghavendra" In-Reply-To: (Stefan Monnier's message of "Fri, 22 Sep 2017 15:26:58 -0400") References: <87377seua8.fsf@ailuros> <87poaieiah.fsf@hri.res.in> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Date: Sat, 23 Sep 2017 02:01:14 +0530 Message-ID: <87d16iear1.fsf@hri.res.in> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) At 2017-09-22T15:26:58-04:00, Stefan Monnier wrote: > I think it's too risky for the emacs-26 branch, but feel free to install > it on master, Do you mean that the change can be pushed to master? If so, do you want me to do anything about it? I guess someone with commit access will have to take over. Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute, http://www.hri.res.in/ From unknown Sat Sep 13 11:13:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "N. Raghavendra" Subject: bug#28428: closed (Re: bug#28428: comment-search-backward with no comments) Message-ID: References: <87377seua8.fsf@ailuros> X-Gnu-PR-Message: they-closed 28428 X-Gnu-PR-Package: emacs Reply-To: 28428@debbugs.gnu.org Date: Sat, 23 Sep 2017 21:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1506200882-30811-1" This is a multi-part message in MIME format... ------------=_1506200882-30811-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28428: comment-search-backward with no comments which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28428@debbugs.gnu.org. --=20 28428: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28428 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1506200882-30811-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28428-done) by debbugs.gnu.org; 23 Sep 2017 21:07:21 +0000 Received: from localhost ([127.0.0.1]:54970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvrdx-000808-6c for submit@debbugs.gnu.org; Sat, 23 Sep 2017 17:07:21 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvrdu-0007zz-Vk for 28428-done@debbugs.gnu.org; Sat, 23 Sep 2017 17:07:19 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8NL7Fgc001987; Sat, 23 Sep 2017 17:07:15 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1018566271; Sat, 23 Sep 2017 17:07:15 -0400 (EDT) From: Stefan Monnier To: "N. Raghavendra" Subject: Re: bug#28428: comment-search-backward with no comments Message-ID: References: <87377seua8.fsf@ailuros> <87poaieiah.fsf@hri.res.in> <87d16iear1.fsf@hri.res.in> Date: Sat, 23 Sep 2017 17:07:15 -0400 In-Reply-To: <87d16iear1.fsf@hri.res.in> (N. Raghavendra's message of "Sat, 23 Sep 2017 02:01:14 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6122=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6122> : inlines <6084> : streams <1764305> : uri <2505415> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28428-done Cc: 28428-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Version: 27.1 I pushed the patch to `master`. Stefan ------------=_1506200882-30811-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Sep 2017 22:37:58 +0000 Received: from localhost ([127.0.0.1]:34266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drXL3-0001hB-TO for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drXL1-0001gu-M4 for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drXKv-0002zJ-Dz for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drXKv-0002zF-AD for submit@debbugs.gnu.org; Mon, 11 Sep 2017 18:37:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drXKt-0002Ny-Sj for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drXKq-0002y9-Pf for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:47 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:56113 helo=homiemail-a83.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drXKq-0002xG-Fg for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 18:37:44 -0400 Received: from homiemail-a83.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTP id 872A68018C37 for ; Mon, 11 Sep 2017 15:37:41 -0700 (PDT) Received: from retrotexts.net (www.hri.res.in [220.227.103.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: raghu@retrotexts.net) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 330B48018C2E for ; Mon, 11 Sep 2017 15:37:41 -0700 (PDT) Received: by retrotexts.net (Postfix, from userid 1000) id 8416924025AB; Tue, 12 Sep 2017 04:07:35 +0530 (IST) From: "N. Raghavendra" To: bug-gnu-emacs@gnu.org Subject: comment-search-backward with no comments User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Date: Tue, 12 Sep 2017 04:07:35 +0530 Message-ID: <87377seua8.fsf@ailuros> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "N. Raghavendra" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain I am using Emacs 26.0.50. In the cases that I tried, when there is no comment in the portion of the buffer between the search limit and point, `comment-search-backward' does not move point to the search limit before raising an error. This behaviour contradicts its docstring. My message to emacs-devel about this is at http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00193.html Attached are a patch that seems to fix the problem, and a file containing a test. Running the test without the change in the patch fails, and passes with the change: $ git checkout master $ emacs -Q -batch -l lisp/newcomment.el -l /tmp/test.el \ -f ert-run-tests-batch-and-exit ---------------------------------------------------------------------- (ert-test-failed ((should (= (point) limit)) :form (= 70 41) :value nil)) FAILED 1/1 test-comment-search-backward-absent ---------------------------------------------------------------------- $ git checkout test-comment-search-forward-absent $ emacs -Q -batch -l lisp/newcomment.el -l /tmp/test.el \ -f ert-run-tests-batch-and-exit ---------------------------------------------------------------------- Running 1 tests (2017-09-12 03:31:48+0530) passed 1/1 test-comment-search-backward-absent ---------------------------------------------------------------------- Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute, http://www.hri.res.in/ --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-comment-search-backword-move-point-when-there-is-no-comment.patch >From eb8e32c6fe4a3d08be8b856b3ff4a300a2e69d4b Mon Sep 17 00:00:00 2001 From: "N. Raghavendra" Date: Tue, 12 Sep 2017 01:41:16 +0530 Subject: [PATCH] comment-search-backword: move point when there is no comment * lisp/newcomment.el (comment-search-backward): Move point to LIMIT when there is no comment between LIMIT and point. --- lisp/newcomment.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/newcomment.el b/lisp/newcomment.el index 8772b523..d849fc1 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -525,7 +525,9 @@ comment-search-backward ;; comment-set-column) and to find the comment-start string (via ;; comment-beginning) in indent-new-comment-line, it should be harmless. (if (not (re-search-backward comment-start-skip limit t)) - (unless noerror (error "No comment")) + (progn + (goto-char limit) + (unless noerror (error "No comment"))) (beginning-of-line) (let* ((end (match-end 0)) (cs (comment-search-forward end t)) -- 2.7.4 --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=test.el Content-Transfer-Encoding: quoted-printable (ert-deftest test-comment-search-backward-absent () "Test `comment-search-backward' when there is no comment in context. Check that when there is no comment in the portion of the buffer between the search limit and point, it moves point to the search limit and raises an error." (with-temp-buffer (emacs-lisp-mode) (comment-normalize-vars) (insert "(require 'foo) \(bar) ; first comment ;; second comment \(provide 'baz)") (let ((limit (save-excursion (search-backward "second")))) (should (equal (should-error (comment-search-backward limit)) '(error "No comment"))) (should (=3D (point) limit))))) --=-=-=-- ------------=_1506200882-30811-1-- From unknown Sat Sep 13 11:13:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28428: comment-search-backward with no comments Resent-From: "N. Raghavendra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2017 00:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 28428-done@debbugs.gnu.org Reply-To: "N. Raghavendra" Received: via spool by 28428-done@debbugs.gnu.org id=D28428.150621282416365 (code D ref 28428); Sun, 24 Sep 2017 00:28:02 +0000 Received: (at 28428-done) by debbugs.gnu.org; 24 Sep 2017 00:27:04 +0000 Received: from localhost ([127.0.0.1]:55021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvulE-0004Ft-Ez for submit@debbugs.gnu.org; Sat, 23 Sep 2017 20:27:04 -0400 Received: from sub5.mail.dreamhost.com ([208.113.200.129]:45289 helo=homiemail-a118.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvulB-0004FT-Uz for 28428-done@debbugs.gnu.org; Sat, 23 Sep 2017 20:27:03 -0400 Received: from homiemail-a118.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTP id 5825660002002; Sat, 23 Sep 2017 17:26:56 -0700 (PDT) Received: from retrotexts.net (www.hri.res.in [220.227.103.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: raghu@retrotexts.net) by homiemail-a118.g.dreamhost.com (Postfix) with ESMTPSA id E91A460002001; Sat, 23 Sep 2017 17:26:55 -0700 (PDT) Received: by retrotexts.net (Postfix, from userid 1000) id 98610240029D; Sun, 24 Sep 2017 05:56:50 +0530 (IST) From: "N. Raghavendra" In-Reply-To: (Stefan Monnier's message of "Sat, 23 Sep 2017 17:07:15 -0400") References: <87377seua8.fsf@ailuros> <87poaieiah.fsf@hri.res.in> <87d16iear1.fsf@hri.res.in> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Date: Sun, 24 Sep 2017 05:56:50 +0530 Message-ID: <87vak9c56d.fsf@hri.res.in> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) At 2017-09-23T17:07:15-04:00, Stefan Monnier wrote: > I pushed the patch to `master`. Perfect! Thanks, Raghu. -- N. Raghavendra , http://www.retrotexts.net/ Harish-Chandra Research Institute, http://www.hri.res.in/