GNU bug report logs - #28425
[PATCH 1/2] gnu: sqlite: Update to 3.20.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28425 in the body.
You can then email your comments to 28425 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH 1/2] gnu: sqlite: Update to 3.20.1.
Date: Tue, 12 Sep 2017 00:17:44 +0200

* gnu/packages/databases.scm (sqlite): Update to 3.20.1.
---
 gnu/packages/databases.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index ba365523d..37890a91f 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -754,7 +754,7 @@ for example from a shell script.")
 (define-public sqlite
   (package
    (name "sqlite")
-   (version "3.19.3")
+   (version "3.20.1")
    (source (origin
             (method url-fetch)
             (uri (let ((numeric-version
@@ -770,7 +770,7 @@ for example from a shell script.")
                                   numeric-version ".tar.gz")))
             (sha256
              (base32
-              "00b3l2qglpl1inx21fckiwxnfq5xf6441flc79rqg7zdvh1rq4h6"))))
+              "0hh7jnxfwvs2qlvmjwrgkvxb8sk4x8hj04m54fq9h1xw55dmjrpc"))))
    (build-system gnu-build-system)
    (inputs `(("readline" ,readline)))
    (arguments
-- 
2.14.1

Message #8 received at 28425 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 28425 <at> debbugs.gnu.org
Subject: Re: [bug#28425] [PATCH 1/2] gnu: sqlite: Update to 3.20.1.
Date: Tue, 12 Sep 2017 13:00:11 +0200

[Message part 1 (text/plain, inline)]

2017-09-12 0:17 GMT+02:00 Jelle Licht <jlicht <at> fsfe.org>:

> * gnu/packages/databases.scm (sqlite): Update to 3.20.1.
> ---
>  gnu/packages/databases.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index ba365523d..37890a91f 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -754,7 +754,7 @@ for example from a shell script.")
>  (define-public sqlite
>    (package
>     (name "sqlite")
> -   (version "3.19.3")
> +   (version "3.20.1")
>     (source (origin
>              (method url-fetch)
>              (uri (let ((numeric-version
> @@ -770,7 +770,7 @@ for example from a shell script.")
>                                    numeric-version ".tar.gz")))
>              (sha256
>               (base32
> -              "00b3l2qglpl1inx21fckiwxnfq5xf6441flc79rqg7zdvh1rq4h6"))))
> +              "0hh7jnxfwvs2qlvmjwrgkvxb8sk4x8hj04m54fq9h1xw55dmjrpc"))))
>     (build-system gnu-build-system)
>     (inputs `(("readline" ,readline)))
>     (arguments
> --
> 2.14.1
>
>
>
>
>

It just built successfully.

Are there any more checsks/tests I should perform in order to properly
review this ?

[Message part 2 (text/html, inline)]

Message #11 received at 28425 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Catonano <catonano <at> gmail.com>
Cc: 28425 <at> debbugs.gnu.org, Jelle Licht <jlicht <at> fsfe.org>
Subject: Re: [bug#28425] [PATCH 1/2] gnu: sqlite: Update to 3.20.1.
Date: Tue, 12 Sep 2017 15:24:02 +0200

Catonano <catonano <at> gmail.com> writes:

> 2017-09-12 0:17 GMT+02:00 Jelle Licht <jlicht <at> fsfe.org>:
>
>> * gnu/packages/databases.scm (sqlite): Update to 3.20.1.
>> ---
>>  gnu/packages/databases.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index ba365523d..37890a91f 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -754,7 +754,7 @@ for example from a shell script.")
>>  (define-public sqlite
>>    (package
>>     (name "sqlite")
>> -   (version "3.19.3")
>> +   (version "3.20.1")
>>     (source (origin
>>              (method url-fetch)
>>              (uri (let ((numeric-version
>> @@ -770,7 +770,7 @@ for example from a shell script.")
>>                                    numeric-version ".tar.gz")))
>>              (sha256
>>               (base32
>> -              "00b3l2qglpl1inx21fckiwxnfq5xf6441flc79rqg7zdvh1rq4h6"))))
>> +              "0hh7jnxfwvs2qlvmjwrgkvxb8sk4x8hj04m54fq9h1xw55dmjrpc"))))
>>     (build-system gnu-build-system)
>>     (inputs `(("readline" ,readline)))
>>     (arguments
>> --
>> 2.14.1
>>
>>
>>
>>
>>
>
> It just built successfully.
>
> Are there any more checsks/tests I should perform in order to properly
> review this ?

If you have the time, you could try building and using something which
depends on sqlite. I have verified python-apsw (my other patch) to work
properly already, but there are lots of dependents of sqlite which might
inadvertently break because of my patch.

Message #14 received at 28425 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 28425 <at> debbugs.gnu.org
Subject: Re: [bug#28425] [PATCH 1/2] gnu: sqlite: Update to 3.20.1.
Date: Tue, 12 Sep 2017 23:00:22 +0200

[Message part 1 (text/plain, inline)]

2017-09-12 15:24 GMT+02:00 Jelle Licht <jlicht <at> fsfe.org>:

>
> Catonano <catonano <at> gmail.com> writes:
>
> > 2017-09-12 0:17 GMT+02:00 Jelle Licht <jlicht <at> fsfe.org>:
> >
> >> * gnu/packages/databases.scm (sqlite): Update to 3.20.1.
> >> ---
> >>  gnu/packages/databases.scm | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> >> index ba365523d..37890a91f 100644
> >> --- a/gnu/packages/databases.scm
> >> +++ b/gnu/packages/databases.scm
> >> @@ -754,7 +754,7 @@ for example from a shell script.")
> >>  (define-public sqlite
> >>    (package
> >>     (name "sqlite")
> >> -   (version "3.19.3")
> >> +   (version "3.20.1")
> >>     (source (origin
> >>              (method url-fetch)
> >>              (uri (let ((numeric-version
> >> @@ -770,7 +770,7 @@ for example from a shell script.")
> >>                                    numeric-version ".tar.gz")))
> >>              (sha256
> >>               (base32
> >> -              "00b3l2qglpl1inx21fckiwxnfq5xf6
> 441flc79rqg7zdvh1rq4h6"))))
> >> +              "0hh7jnxfwvs2qlvmjwrgkvxb8sk4x8
> hj04m54fq9h1xw55dmjrpc"))))
> >>     (build-system gnu-build-system)
> >>     (inputs `(("readline" ,readline)))
> >>     (arguments
> >> --
> >> 2.14.1
> >>
> >>
> >>
> >>
> >>
> >
> > It just built successfully.
> >
> > Are there any more checsks/tests I should perform in order to properly
> > review this ?
>
> If you have the time, you could try building and using something which
> depends on sqlite. I have verified python-apsw (my other patch) to work
> properly already, but there are lots of dependents of sqlite which might
> inadvertently break because of my patch.
>

Jelle, I tried but core-updates is too much !

It was bootstrapping Guile 2.2.2 when I stopped it. And that can be a long
process, if I remember correctly

When I first reported to have built it successfully, I had branched from
master and git am'ed your patch there. So many things were available already

This second time I tried with the real core-updates branch

I'm afraid you'll need to set up your own Cuirass instance :-/

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.