Subject: [bug#28421] [PATCH] gnu: Add uim, uim-gtk and uim-qt.

From: [email-masked] (Ludovic Courtès)
Date: Tue, 26 Sep 2017 09:22:26 +0200

Hi Arun,

Arun Isaac <[email-masked]> skribis:

> * gnu/packages/xorg.scm (uim, uim-gtk, uim-qt): New variables.

[...]

> +    (home-page "https://github.com/uim/uim")
> +    (synopsis "Multilingual input method framework")
> +    (description "uim is a multilingual input method library and environment.
> +It provides a simple, easily extensible and high code-quality input method
> +development platform, and useful input method environment for users of desktop
> +and embedded platforms.")
> +    (license (list license:lgpl2.1+ ; scm/py.scm, pixmaps/*.{svg,png} (see pixmaps/README)
> +                   license:gpl2+ ; scm/pinyin-big5.scm
> +                   license:gpl3+ ; scm/elatin-rules.cm
> +                   license:public-domain ; scm/input-parse.scm, scm/match.scm
> +                   ;; gtk2/toolbar/eggtrayicon.{ch},
> +                   ;; qt3/chardict/kseparator.{cpp,h},
> +                   ;; qt3/pref/kseparator.{cpp,h}
> +                   license:lgpl2.0+
> +                   ;; pixmaps/*.{svg,png} (see pixmaps/README),
> +                   ;; all other files
> +                   license:bsd-3))))
> +
> +(define-public uim-gtk
> +  (package
> +    (inherit uim)
> +    (name "uim-gtk")
> +    (inputs
> +     `(("gtk" ,gtk+)
> +       ("gtk" ,gtk+-2)
> +       ,@(package-inputs uim)))
> +    (synopsis "uim built with GTK+ support")
> +    (description "This package contains uim built with GTK+ support.")))

What about “Multilingual input method framework (GTK+ support)” for the
synopsis, and leaving the description unchanged?

> +    (synopsis "uim built with Qt support")
> +    (description "This package contains uim built with Qt support.")))

Likewise here.

Otherwise LGTM.  Feel free to push with a change along these lines if
that’s fine with you.

Thanks for patiently working on this!

Ludo’.