GNU bug report logs - #28417
ptx does not terminate when matching a zero length sentence regex

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28417: closed (ptx does not terminate when matching a zero
 length sentence regex)
Date: Thu, 14 Sep 2017 06:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Sep 2017 08:38:49 +0200
with message-id <d9fb4e49-7d70-bb9e-1541-e12f61c9823b <at> bernhard-voelker.de>
and subject line Re: bug#28417: ptx does not terminate when matching a zero length sentence regex
has caused the debbugs.gnu.org bug report #28417,
regarding ptx does not terminate when matching a zero length sentence regex
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28417: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28417
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julian Büning <julian.buening <at> rwth-aachen.de>
To: <bug-coreutils <at> gnu.org>
Cc: Oscar Soria Dustmann <Oscar.SoriaDustmann <at> comsys.rwth-aachen.de>,
 Daniel Schemmel <daniel.schemmel <at> comsys.rwth-aachen.de>
Subject: ptx does not terminate when matching a zero length sentence regex
Date: Mon, 11 Sep 2017 17:04:43 +0200

observed behavior:

$ echo | ptx -S $ &
[1] 1000
$ jobs
[1]+  Running                 echo | ptx -S $ &

expected behavior:

$ echo | ptx -S $ &
[1] 1000
[1]+  Done                    echo | ptx -S $

ptx does not terminate in case the specified sentence regex can be
matched but has a match of length zero on input that is non-empty.

The following test cases show the same behavior:
$ echo | ptx -S ^
$ echo | ptx -S "a*"
$ echo | ptx -S "\(\)"
$ echo test | ptx -S "\n*"
$ echo foo > non_empty; ptx non_empty -S $
...

In ptx.c, find_occurs_in_text() calls re_search() and uses the length of
a match (which is falsely assumed to be greater than zero) to advance a
cursor through the input. For a match length of zero, the cursor is
never advanced.

When switching on the results of re_search(), a case 0 could be added.
One possible fix would be to then abort with an error message.

We found this behavior in version 8.27 and can reproduce it in version
8.25 as well as version 8.28.

This behavior was found using Symbolic Execution techniques developed in
the course of the SYMBIOSYS research project at COMSYS, RWTH Aachen
University. This research is supported by the European Research Council
(ERC) under the EU's Horizon 2020 Research and Innovation Programme
grant agreement n. 647295 (SYMBIOSYS).

Best regards,
Julian

[Message part 3 (message/rfc822, inline)]

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>,
 Julian Büning <julian.buening <at> rwth-aachen.de>,
 28417-done <at> debbugs.gnu.org
Cc: Oscar Soria Dustmann <Oscar.SoriaDustmann <at> comsys.rwth-aachen.de>,
 Daniel Schemmel <daniel.schemmel <at> comsys.rwth-aachen.de>
Subject: Re: bug#28417: ptx does not terminate when matching a zero length
 sentence regex
Date: Thu, 14 Sep 2017 08:38:49 +0200

On 09/14/2017 02:16 AM, Pádraig Brady wrote:
> +1

thanks for the review, pushed.

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.