GNU bug report logs - #28402
25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions

Previous Next

Full log

Message #58 received at 28402 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: larsi <at> gnus.org, 28402 <at> debbugs.gnu.org
Subject: Re: bug#28402: 25.2; shr.el uses shr-tag-img despite set
 shr-external-rendering-functions
Date: Fri, 06 Oct 2017 15:43:49 +0300

> Date: Thu, 5 Oct 2017 22:08:07 +0200
> From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 28402 <at> debbugs.gnu.org
> 
> I can imagine other variations of defsubst (such as defmacro and
> define-inline), but it would indeed be the easiest to roll back that
> part of the code.  What I'd additionally do is adding a comment
> explaining why there's two very similar snippets of code doing the same
> thing, otherwise the next person proposing a patch will change only one
> of them and be left head-scratching why it doesn't quite work.

Thanks, done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.