GNU bug report logs - #28402
25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 28402 <at> debbugs.gnu.org
Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Thu, 05 Oct 2017 22:10:52 +0200

Vasilij Schneidermann <v.schneidermann <at> gmail.com> writes:

> How deeply nested does typical HTML get anyways?

Very.

> I recall an exemplary comment from an article on browser rendering
> that pointed out that they bail out on degenerate cases, so perhaps
> it's better to add that to shr rather than hoping you never hit the
> stack limit by following a conservative coding style.

shr does check and bail.  Search for max-specpdl-size in shr.el.

> What I'd additionally do is adding a comment explaining why there's
> two very similar snippets of code doing the same thing, otherwise the
> next person proposing a patch will change only one of them and be left
> head-scratching why it doesn't quite work.

Sure; please submit a patch to do so.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.