GNU bug report logs - #28402
25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions

Previous Next

Full log

Message #37 received at 28402 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28402 <at> debbugs.gnu.org, v.schneidermann <at> gmail.com
Subject: Re: bug#28402: 25.2;
 shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Thu, 05 Oct 2017 13:18:37 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> -        (cond (external
>> -               (funcall external dom))
>> -              ((fboundp function)
>> -               (funcall function dom))
>> -              (t
>> -               (shr-generic dom)))
>> +	(shr-indirect-call tag-name dom)

[...]

> Wouldn't reverting it make the entire change rather pointless?

No, the other calls to shr-indirect are fine, and was what was missing.

> If the issue is with stack usage, we could increase the stack when
> shr-descend is called.  As for speed, the old code had such an
> indirection as well, albeit via funcall, no?

The old call calls virtually always ends up with

(funcall function dom)

The new code calls shr-indirect-call which will will then 

(funcall function dom)

So one extra function call for each node.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.