GNU bug report logs - #28402
25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28402: closed (25.2; shr.el uses shr-tag-img despite set
 shr-external-rendering-functions)
Date: Thu, 05 Oct 2017 10:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 05 Oct 2017 13:02:27 +0300
with message-id <8360btykss.fsf <at> gnu.org>
and subject line Re: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
has caused the debbugs.gnu.org bug report #28402,
regarding 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28402: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28402
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: larsi <at> gnus.org
Subject: 25.2;
 shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Sat, 9 Sep 2017 21:39:39 +0200

I'm using shr.el for a package and override `shr-tag-img` by let-binding
`shr-external-rendering-functions` to an alist containing an alternative
rendering function that deals better with local images.  Despite this
`shr-tag-img` is still directly called when rendering tables with images
inside them.  The same problem applies to other directly called
rendering functions, as opposed to indirectly called ones as seen in
`shr-descend`, the function honoring `shr-external-rendering-functions`.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: v.schneidermann <at> gmail.com, larsi <at> gnus.org
Cc: 28402-done <at> debbugs.gnu.org
Subject: Re: bug#28402: 25.2;
 shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Thu, 05 Oct 2017 13:02:27 +0300

> Date: Fri, 29 Sep 2017 10:31:15 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: larsi <at> gnus.org, 28402 <at> debbugs.gnu.org
> 
> If no objections are voiced in a few days, I will push to the emacs-26
> branch.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.