Subject: bug#28402: closed (Re: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 05 Oct 2017 10:04:02 +0000

Your bug report

#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
28402: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28402
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
From: Eli Zaretskii <[email-masked]>
To: [email-masked], [email-masked]
Cc: [email-masked]
Date: Thu, 05 Oct 2017 13:02:27 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Fri, 29 Sep 2017 10:31:15 +0300
> From: Eli Zaretskii <[email-masked]>
> Cc: [email-masked], [email-masked]
> 
> If no objections are voiced in a few days, I will push to the emacs-26
> branch.

Done.

Subject: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
From: Vasilij Schneidermann <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Sat, 9 Sep 2017 21:39:39 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

I'm using shr.el for a package and override `shr-tag-img` by let-binding
`shr-external-rendering-functions` to an alist containing an alternative
rendering function that deals better with local images.  Despite this
`shr-tag-img` is still directly called when rendering tables with images
inside them.  The same problem applies to other directly called
rendering functions, as opposed to indirectly called ones as seen in
`shr-descend`, the function honoring `shr-external-rendering-functions`.