Subject: [bug#28378] [PATCH] gnu: Add heimdall.

From: [email-masked] (Ludovic Courtès)
Date: Wed, 20 Sep 2017 22:34:23 +0200

Hi Julien,

Julien Lepiller <[email-masked]> skribis:

> From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <[email-masked]>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.
>
> Co-Authored-By: Danny Milosavljevic <[email-masked]>

It LGTM.  I don’t see why libpit.a is needed, but I’ll let you decide.  :-)

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")

Why not keep the default “RelWithDebInfo”?

Thanks!

Ludo’.