GNU bug report logs - #28377
[PATCH 00/10] Allow users to specify the UUID of disk images

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28377: closed ([PATCH 00/10] Allow users to specify the UUID
 of disk images)
Date: Mon, 11 Sep 2017 20:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 11 Sep 2017 22:53:04 +0200
with message-id <871sndarf3.fsf <at> gnu.org>
and subject line Re: [PATCH 09/10] vm: Allow users to specify a UUID for the root partition.
has caused the debbugs.gnu.org bug report #28377,
regarding [PATCH 00/10] Allow users to specify the UUID of disk images
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28377: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28377
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: [PATCH 00/10] Allow users to specify the UUID of disk images
Date: Wed,  6 Sep 2017 23:51:30 +0200

Hello!

This is a followup to
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27735#31>: it’s about
making it possible to specify the UUID of the root partition of the disk
image.

To get there, this patch series does a few things:

  1. Give a 2nd argument to ‘uuid->string’ et al., which is the name of
     the UUID format.

  2. Move UUID-related code to (gnu system uuid).

  3. Introduce a <uuid> record type that ties together a bytevector and
     a symbol specifying the UUID type (DCE, ISO9660, etc.).  This
     allows ‘uuid->string’ to generate a string in the “right” format as
     expected by tools such as GRUB.

  4. Finally, generate a UUID for generated images.

Tested with both an ISO and an ext4/qcow2 image.

Feedback welcome!

Ludo’.

Ludovic Courtès (10):
  vm: Allow partitions to be initialized with a given UUID.
  file-systems: Add UUID type dictionaries.
  services: base: Import the closure of (gnu build file-systems).
  file-systems: Introduce (gnu system uuid).
  services: file-system: Use 'file-system->spec'.
  system: Introduce a disjoint UUID type.
  system: Serialize the UUID type in the "parameters" file.
  uuid: 'uuid' macro supports more UUID types.
  vm: Allow users to specify a UUID for the root partition.
  vm: Generate a UUID to identify the root file system.

 gnu/bootloader/grub.scm       |   4 +-
 gnu/build/file-systems.scm    | 130 +--------------------
 gnu/build/vm.scm              |  28 +++--
 gnu/local.mk                  |   1 +
 gnu/services/base.scm         |  15 +--
 gnu/system.scm                |  48 +++++---
 gnu/system/file-systems.scm   |  26 ++---
 gnu/system/mapped-devices.scm |   7 +-
 gnu/system/uuid.scm           | 265 ++++++++++++++++++++++++++++++++++++++++++
 gnu/system/vm.scm             |  63 ++++++++--
 10 files changed, 393 insertions(+), 194 deletions(-)
 create mode 100644 gnu/system/uuid.scm

-- 
2.14.1

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 28377-done <at> debbugs.gnu.org
Subject: Re: [PATCH 09/10] vm: Allow users to specify a UUID for the root
 partition.
Date: Mon, 11 Sep 2017 22:53:04 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> On Thu,  7 Sep 2017 00:17:55 +0200
> Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> +partition; likewise FILE-SYSTEM-UUID, if true, is the UUID of the root
>
>                                             ^^^ ??      ^^^^^^ which is it? 
>
> Probably meant "not #f".

Yes.  In Scheme only #f is false; any other value is true.

I’ve replaced “is the UUID…” by “specifies the UUID…”, which is
hopefully clearer.

I’ve now pushed the whole series.  Thanks for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.