GNU bug report logs - #28373
[PATCH] New variable controls whether dired confirms to kill buffers visiting deleted files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28373: closed ([PATCH] New variable controls whether dired
 confirms to kill buffers visiting deleted files)
Date: Fri, 08 Sep 2017 09:42:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 08 Sep 2017 12:41:04 +0300
with message-id <83mv65y1cf.fsf <at> gnu.org>
and subject line Re: bug#28373: [PATCH] New variable controls whether dired confirms to kill buffers visiting deleted files
has caused the debbugs.gnu.org bug report #28373,
regarding [PATCH] New variable controls whether dired confirms to kill buffers visiting deleted files
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28373: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28373
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] New variable controls whether dired confirms to kill buffers
 visiting deleted files
Date: Wed, 06 Sep 2017 10:42:37 -0500

[Message part 3 (text/plain, inline)]

Hello,

This is a patch to include a new variable that, when set to nil, makes dired kill buffers visiting deleted files without confirmation.

There are apparently some people interested in this:

https://emacs.stackexchange.com/questions/30676/how-to-always-kill-dired-buffer-when-deleting-a-folder

I read through the CONTRIBUTE file, but please let me know if something is wrong with the commit message and I can redo it.

Alex

[0001-Add-dired-confirm-killing-deleted-buffers.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 28373-done <at> debbugs.gnu.org
Subject: Re: bug#28373: [PATCH] New variable controls whether dired confirms
 to kill buffers visiting deleted files
Date: Fri, 08 Sep 2017 12:41:04 +0300

> From: Alex Branham <alex.branham <at> gmail.com>
> Cc: 28373 <at> debbugs.gnu.org
> Date: Wed, 06 Sep 2017 13:11:45 -0500
> 
> Thanks for the review. I think I've addressed the things you've brought up; specific replies below.

Thanks, pushed to the master branch.

Two minor nits for the future:

 . please always mention the bug number in the commit log message
 . the NEWS entry should be marked with "+++" only if the new feature
   is described in the appropriate manual; otherwise it should be
   either marked with "---" (if it doesn't need to be in the manual),
   or not marked at all (which is a signal for the maintainers to
   consider documenting it at some future point).  This is explained
   at the beginning of NEWS.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.