From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 06:21:07 2017 Received: (at submit) by debbugs.gnu.org; 6 Sep 2017 10:21:07 +0000 Received: from localhost ([127.0.0.1]:52302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpXSF-0008HN-2T for submit@debbugs.gnu.org; Wed, 06 Sep 2017 06:21:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpXSE-0008Gd-7I for submit@debbugs.gnu.org; Wed, 06 Sep 2017 06:21:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpXS8-0005TB-2i for submit@debbugs.gnu.org; Wed, 06 Sep 2017 06:21:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpXS7-0005Sv-Us for submit@debbugs.gnu.org; Wed, 06 Sep 2017 06:20:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpXS6-0008Mb-Ms for guix-patches@gnu.org; Wed, 06 Sep 2017 06:20:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpXS1-0005Nr-IW for guix-patches@gnu.org; Wed, 06 Sep 2017 06:20:58 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpXS1-0005Nh-Ee for guix-patches@gnu.org; Wed, 06 Sep 2017 06:20:53 -0400 Received: from ip-80-113-14-101.ip.prioritytelecom.net ([80.113.14.101]:60478 helo=yellowstone) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpXRy-0002yB-6V for guix-patches@gnu.org; Wed, 06 Sep 2017 06:20:51 -0400 User-agent: mu4e 0.9.18; emacs 25.2.1 From: Roel Janssen To: guix-patches Subject: [PATCH] gnu: emacs-ess: Include the etc directory in the build Message-ID: <874lsgyvra.fsf@gnu.org> Date: Wed, 06 Sep 2017 12:20:41 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-emacs-ess-Include-the-etc-directory-in-the-build.patch >From f8ae717ae7dd5db7f7c0c477b7c871b843607de5 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Wed, 6 Sep 2017 12:14:18 +0200 Subject: [PATCH] gnu: emacs-ess: Include the etc directory in the build output. * gnu/packages/emacs.scm (emacs-ess): Also copy the etc directory. --- gnu/packages/emacs.scm | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index bc01d5777..1e29f357c 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -3209,22 +3209,25 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg")))) (build-system gnu-build-system) (arguments - `(#:tests? #f ; There is no test suite. - #:make-flags (list (string-append "PREFIX=" %output) - (string-append "LISPDIR=" %output - "/share/emacs/site-lisp/guix.d/ess")) - #:phases - (modify-phases %standard-phases - (delete 'configure) - (add-before 'build 'more-shebang-patching - (lambda* (#:key inputs #:allow-other-keys) - (substitute* "Makeconf" - (("SHELL = /bin/sh") - (string-append "SHELL = " (which "sh")))))) - ;; FIXME: the texlive-union insists on regenerating fonts. It stores - ;; them in HOME, so it needs to be writeable. - (add-before 'build 'set-HOME - (lambda _ (setenv "HOME" "/tmp") #t))))) + (let ((base-directory "/share/emacs/site-lisp/guix.d/ess")) + `(#:tests? #f ; There is no test suite. + #:make-flags (list (string-append "PREFIX=" %output) + (string-append "ETCDIR=" %output "/" + ,base-directory "/etc") + (string-append "LISPDIR=" %output "/" + ,base-directory)) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'more-shebang-patching + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makeconf" + (("SHELL = /bin/sh") + (string-append "SHELL = " (which "sh")))))) + ;; FIXME: the texlive-union insists on regenerating fonts. It stores + ;; them in HOME, so it needs to be writeable. + (add-before 'build 'set-HOME + (lambda _ (setenv "HOME" "/tmp") #t)))))) (inputs `(("emacs" ,emacs-minimal) ("r-minimal" ,r-minimal))) -- 2.14.1 --=-=-= Content-Type: text/plain Dear Guix, When loading ESS "the standard way": (require 'ess-site) it fails to load because it cannot find the "etc" directory that should ship with this package. This patch puts that directory and its contents (as generated by the build system) into $PROFILE/share/emacs/site-lisp/guix.d/ess/etc. After this change, I was able to load ESS "the standard way". Thanks for your time. Kind regards, Roel Janssen --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 20:32:44 2017 Received: (at 28365) by debbugs.gnu.org; 7 Sep 2017 00:32:45 +0000 Received: from localhost ([127.0.0.1]:53619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpkkO-0000Yl-O3 for submit@debbugs.gnu.org; Wed, 06 Sep 2017 20:32:44 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:61452 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpkkN-0000Yb-Cl for 28365@debbugs.gnu.org; Wed, 06 Sep 2017 20:32:43 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 9B802A7162; Wed, 6 Sep 2017 20:32:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=d/uXgkXJJXrR6gDOB/a6yjzri8E=; b=fnsAOF NhKadkHJvyL9dVPAqiAmB8CSMvdG9oiwTKzH2NprQGuMYWU2wBES76CDHKfMFKzu +pllc9Zoghhyxw9SSa5IJtGEZmXH2lLtiMs11IHyvQ27JWeLY+sEenPA+v2hagVr eMfaHGvsO7ymQaHEM/QidoozSTG6NPVnLeMR4= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 933F9A7161; Wed, 6 Sep 2017 20:32:40 -0400 (EDT) Received: from localhost (unknown [24.60.167.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id E11EAA715F; Wed, 6 Sep 2017 20:32:39 -0400 (EDT) From: Kyle Meyer To: Roel Janssen , 28365@debbugs.gnu.org Subject: Re: [bug#28365] [PATCH] gnu: emacs-ess: Include the etc directory in the build In-Reply-To: <874lsgyvra.fsf@gnu.org> References: <874lsgyvra.fsf@gnu.org> Date: Wed, 06 Sep 2017 20:32:38 -0400 Message-ID: <87wp5bpcux.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 0E061D8E-9364-11E7-9BF1-FE4B1A68708C-24757444!pb-smtp1.pobox.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=qoxDZTDfZTdS7+tNDf7yhGp7xQvaSo6IVqsT52Nss6s=; b=f0qk7ldUvSzIds2sUQhsX2V6ZlfrOLazFm4gnSSMeI8zKXEgMgABnNfRXjtKMlT0AiBkHtrY2nAKwyYmXc7kl9i3vlee6u8nSO3imXlhDWU/e5VSoDr0db+X2lpQrTLpGRUHDc5MPzRfTS0Jo7FsmW/Uwp89KAvwZwsZC5kDMyU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28365 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Roel Janssen writes: > When loading ESS "the standard way": > (require 'ess-site) > > it fails to load because it cannot find the "etc" directory that should > ship with this package. Thanks, I hit this too. Here's a fix that I have locally but hadn't sent yet. -- >8 -- diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 9c0f9bc89..a47e90a40 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -3206,7 +3206,14 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") version ".tgz")) (sha256 (base32 - "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg")))) + "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg")) + (modules '((guix build utils))) + (snippet + ;; Add an entry to ess-etc-directory-list that is relative to + ;; guix.d/. + '(substitute* "lisp/ess-site.el" + (("^ '\\(\"\\.\\./etc/ess/\"" line) + (string-append line " \"../../../etc/ess/\"")))))) (build-system gnu-build-system) (arguments `(#:tests? #f ; There is no test suite. -- >8 -- That teaches ess-etc-directory-list about $PROFILE/share/emacs/etc/. I prefer your solution because I think it's less fragile. I just have a minor comment on the patch description. > Subject: [PATCH] gnu: emacs-ess: Include the etc directory in the build > output. > > * gnu/packages/emacs.scm (emacs-ess): Also copy the etc directory. That doesn't seem quite right because the etc directory is already included in the build; it's under $PROFILE/share/emacs/etc/. Perhaps this should instead say something like "Relocate the etc directory so that ESS can find it." -- Kyle From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 04:05:54 2017 Received: (at 28365-done) by debbugs.gnu.org; 7 Sep 2017 08:05:54 +0000 Received: from localhost ([127.0.0.1]:53790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dprow-0002wY-DN for submit@debbugs.gnu.org; Thu, 07 Sep 2017 04:05:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dprou-0002wJ-J1 for 28365-done@debbugs.gnu.org; Thu, 07 Sep 2017 04:05:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dproh-0000Py-MR for 28365-done@debbugs.gnu.org; Thu, 07 Sep 2017 04:05:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dproh-0000Pr-JF; Thu, 07 Sep 2017 04:05:39 -0400 Received: from ip-80-113-14-101.ip.prioritytelecom.net ([80.113.14.101]:13333 helo=yellowstone) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dproh-00026f-0N; Thu, 07 Sep 2017 04:05:39 -0400 References: <874lsgyvra.fsf@gnu.org> <87wp5bpcux.fsf@kyleam.com> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Roel Janssen To: Kyle Meyer Subject: Re: [bug#28365] [PATCH] gnu: emacs-ess: Include the etc directory in the build Message-ID: <87pob3q6hf.fsf@gnu.org> In-reply-to: <87wp5bpcux.fsf@kyleam.com> Date: Thu, 07 Sep 2017 10:05:31 +0200 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28365-done Cc: 28365-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Kyle Meyer writes: > Roel Janssen writes: > >> When loading ESS "the standard way": >> (require 'ess-site) >> >> it fails to load because it cannot find the "etc" directory that should >> ship with this package. > > Thanks, I hit this too. Here's a fix that I have locally but hadn't > sent yet. > > -- >8 -- > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 9c0f9bc89..a47e90a40 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -3206,7 +3206,14 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") > version ".tgz")) > (sha256 > (base32 > - "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg")))) > + "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg")) > + (modules '((guix build utils))) > + (snippet > + ;; Add an entry to ess-etc-directory-list that is relative to > + ;; guix.d/. > + '(substitute* "lisp/ess-site.el" > + (("^ '\\(\"\\.\\./etc/ess/\"" line) > + (string-append line " \"../../../etc/ess/\"")))))) > (build-system gnu-build-system) > (arguments > `(#:tests? #f ; There is no test suite. > -- >8 -- > > That teaches ess-etc-directory-list about $PROFILE/share/emacs/etc/. I > prefer your solution because I think it's less fragile. > > I just have a minor comment on the patch description. > >> Subject: [PATCH] gnu: emacs-ess: Include the etc directory in the build >> output. >> >> * gnu/packages/emacs.scm (emacs-ess): Also copy the etc directory. > > That doesn't seem quite right because the etc directory is already > included in the build; it's under $PROFILE/share/emacs/etc/. Perhaps > this should instead say something like "Relocate the etc directory so > that ESS can find it." You're right. I didn't know that the directory was at $PROFILE/share/emacs/etc/. So I adjusted the commit message and pushed in eaff063aa0f478f23b78c5db8ba0d465b3f691cd. Thanks! Kind regards, Roel Janssen From unknown Wed Aug 20 05:43:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator