GNU bug report logs - #28360
[PATCH] gnu: nginx: Enable HTTP/2.0 (ngx_http_v2_module).

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28360 in the body.
You can then email your comments to 28360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: nginx: Enable HTTP/2.0 (ngx_http_v2_module).
Date: Tue,  5 Sep 2017 18:43:47 +0200

* gnu/packages/web.scm (nginx)[arguments]: Add ‘--with-http_v2_module’ flag.
---

Guix,

The following adds v2 listener support to our nginx package.
The majority of legitimate web traffic to my boxes is already over
HTTP/2.0 (Guix itself being the lone exception).

The protocol won't be spoken by default until upstream decides to do so;
I just got tired of maintaining this huge patch locally.

Kind regards,

T G-R

 gnu/packages/web.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index ac65a8536..377e366e2 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -162,6 +162,7 @@ and its related documentation.")
              (let ((flags
                     (list (string-append "--prefix=" (assoc-ref outputs "out"))
                           "--with-http_ssl_module"
+                          "--with-http_v2_module"
                           "--with-pcre-jit"
                           "--with-debug"
                           ;; Even when not cross-building, we pass the
-- 
2.13.1

Message #8 received at 28360 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 28360 <at> debbugs.gnu.org
Subject: Re: [bug#28360] [PATCH] gnu: nginx: Enable HTTP/2.0
 (ngx_http_v2_module).
Date: Tue, 5 Sep 2017 13:13:58 -0400

[Message part 1 (text/plain, inline)]

On Tue, Sep 05, 2017 at 06:43:47PM +0200, Tobias Geerinckx-Rice wrote:
> * gnu/packages/web.scm (nginx)[arguments]: Add ‘--with-http_v2_module’ flag.
> ---
> 
> Guix,
> 
> The following adds v2 listener support to our nginx package.
> The majority of legitimate web traffic to my boxes is already over
> HTTP/2.0 (Guix itself being the lone exception).
> 
> The protocol won't be spoken by default until upstream decides to do so;
> I just got tired of maintaining this huge patch locally.

This gigantic patch LGTM :)

> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index ac65a8536..377e366e2 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -162,6 +162,7 @@ and its related documentation.")
>               (let ((flags
>                      (list (string-append "--prefix=" (assoc-ref outputs "out"))
>                            "--with-http_ssl_module"
> +                          "--with-http_v2_module"
>                            "--with-pcre-jit"
>                            "--with-debug"
>                            ;; Even when not cross-building, we pass the
> -- 
> 2.13.1
> 
> 
> 
> 

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 28360-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: leo <at> famulari.name
Cc: 28360-done <at> debbugs.gnu.org
Subject: Re: [bug#28360] [PATCH] gnu: nginx: Enable HTTP/2.0
 (ngx_http_v2_module).
Date: Tue, 5 Sep 2017 20:58:13 +0200

[Message part 1 (text/plain, inline)]

Leo,

Leo Famulari wrote on 05/09/17 at 19:13:
> This gigantic patch LGTM :)

Thanks! Pushed.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.