GNU bug report logs - #28356
[PATCH 0/1] doc: Replace server-list with server-blocks.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28356 in the body.
You can then email your comments to 28356 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] doc: Replace server-list with server-blocks.
Date: Tue, 05 Sep 2017 14:13:45 +0300

From 2799970350073812c2d458d9750649cdf7f23315 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Tue, 5 Sep 2017 14:09:56 +0300
Subject: [PATCH 0/1] Replace server-list with server-blocks.

Following documentation example I got this error
--8<---------------cut here---------------start------------->8---
natsu <at> magnolia ~/src/guix$ guix system build --fallback /home/natsu/dotfiles/guix/system-magnolia.scm
/home/natsu/dotfiles/guix/system-magnolia.scm:241:28: error: extraneous field initializers (server-list)
--8<---------------cut here---------------end--------------->8---

Oleg Pykhalov (1):
  doc: Replace server-list with server-blocks.

 doc/guix.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.14.1

Message #8 received at 28356 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: bug#28356 <28356 <at> debbugs.gnu.org>
Subject: [PATCH 1/1] doc: Replace server-list with server-blocks.
Date: Tue, 05 Sep 2017 14:15:30 +0300

[0001-doc-Replace-server-list-with-server-blocks.patch (text/x-patch, inline)]

From 2799970350073812c2d458d9750649cdf7f23315 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Tue, 5 Sep 2017 14:04:14 +0300
Subject: [PATCH 1/1] doc: Replace server-list with server-blocks.

* doc/guix.texi (Web Services): Replace 'server-list' with 'server-blocks'.
---
 doc/guix.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index e7a88e19f..9ac52535b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14038,7 +14038,7 @@ A simple example configuration is given below.
 @example
 (service nginx-service-type
          (nginx-configuration
-           (server-list
+           (server-blocks
              (list (nginx-server-configuration
                      (server-name '("www.example.com"))
                      (root "/srv/http/www.example.com")
@@ -14086,7 +14086,7 @@ The directory to which NGinx will write log files.
 The directory in which NGinx will create a pid file, and write temporary
 files.
 
-@item @code{server-list} (default: @code{'()})
+@item @code{server-blocks} (default: @code{'()})
 A list of @dfn{server blocks} to create in the generated configuration
 file, the elements should be of type
 @code{<nginx-server-configuration>}.
@@ -14097,7 +14097,7 @@ HTTPS.
 @example
 (service nginx-service-type
          (nginx-configuration
-           (server-list
+           (server-blocks
              (list (nginx-server-configuration
                      (server-name '("www.example.com"))
                      (root "/srv/http/www.example.com")
@@ -14122,7 +14122,7 @@ requests with two servers.
 (service
   nginx-service-type
   (nginx-configuration
-    (server-list
+    (server-blocks
       (list (nginx-server-configuration
               (server-name '("www.example.com"))
               (root "/srv/http/www.example.com")
@@ -14144,7 +14144,7 @@ requests with two servers.
 @item @code{config-file} (default: @code{#f})
 If the @var{config-file} is provided, this will be used, rather than
 generating a configuration file from the provided @code{log-directory},
-@code{run-directory}, @code{server-list} and @code{upstream-list}.  For
+@code{run-directory}, @code{server-blocks} and @code{upstream-list}.  For
 proper operation, these arguments should match what is in
 @var{config-file} to ensure that the directories are created when the
 service is activated.
-- 
2.14.1

Message #11 received at 28356 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: bug#28356 <28356 <at> debbugs.gnu.org>
Subject: Re: [bug#28356] [PATCH 1/1] doc: Replace server-list with
 server-blocks.
Date: Thu, 7 Sep 2017 06:58:52 +0100

[Message part 1 (text/plain, inline)]

On Tue, 05 Sep 2017 14:15:30 +0300
Oleg Pykhalov <go.wigust <at> gmail.com> wrote:

> From 2799970350073812c2d458d9750649cdf7f23315 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Tue, 5 Sep 2017 14:04:14 +0300
> Subject: [PATCH 1/1] doc: Replace server-list with server-blocks.
> 
> * doc/guix.texi (Web Services): Replace 'server-list' with
> 'server-blocks'. ---
>  doc/guix.texi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guix.texi b/doc/guix.texi
> index e7a88e19f..9ac52535b 100644

I'm having problems applying this:

error: sha1 information is lacking or useless (doc/guix.texi).
error: could not build fake ancestor

I think this might be happening, as I don't have something locally that
coresponds to e7a88e19f. Is this patch on some version of guix.texi
that hasn't made it in to the master branch yet?

> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14038,7 +14038,7 @@ A simple example configuration is given below.
>  @example
>  (service nginx-service-type
>           (nginx-configuration
> -           (server-list
> +           (server-blocks
>               (list (nginx-server-configuration
>                       (server-name '("www.example.com"))
>                       (root "/srv/http/www.example.com")
> @@ -14086,7 +14086,7 @@ The directory to which NGinx will write log
> files. The directory in which NGinx will create a pid file, and write
> temporary files.
>  
> -@item @code{server-list} (default: @code{'()})
> +@item @code{server-blocks} (default: @code{'()})
>  A list of @dfn{server blocks} to create in the generated
> configuration file, the elements should be of type
>  @code{<nginx-server-configuration>}.
> @@ -14097,7 +14097,7 @@ HTTPS.
>  @example
>  (service nginx-service-type
>           (nginx-configuration
> -           (server-list
> +           (server-blocks
>               (list (nginx-server-configuration
>                       (server-name '("www.example.com"))
>                       (root "/srv/http/www.example.com")
> @@ -14122,7 +14122,7 @@ requests with two servers.
>  (service
>    nginx-service-type
>    (nginx-configuration
> -    (server-list
> +    (server-blocks
>        (list (nginx-server-configuration
>                (server-name '("www.example.com"))
>                (root "/srv/http/www.example.com")
> @@ -14144,7 +14144,7 @@ requests with two servers.
>  @item @code{config-file} (default: @code{#f})
>  If the @var{config-file} is provided, this will be used, rather than
>  generating a configuration file from the provided
> @code{log-directory}, -@code{run-directory}, @code{server-list} and
> @code{upstream-list}.  For +@code{run-directory},
> @code{server-blocks} and @code{upstream-list}.  For proper operation,
> these arguments should match what is in @var{config-file} to ensure
> that the directories are created when the service is activated.

Thanks for spotting this. Obviously I missed it when removing the
nginx-service procedure.

It looks like this is also a problem elsewhere in the docs, as I can
see a few more instances of server-list. Also, it looks like
upstream-list has exactly the same problem. I think it would be good to
fix all of the server-list bits in this patch at least. Could you add
them?

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 28356 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: bug#28356 <28356 <at> debbugs.gnu.org>
Subject: Re: [bug#28356] [PATCH 1/1] doc: Replace server-list with
 server-blocks.
Date: Thu, 07 Sep 2017 10:46:29 +0300

[Message part 1 (text/plain, inline)]

Hello Christopher,

Christopher Baines <mail <at> cbaines.net> writes:

> On Tue, 05 Sep 2017 14:15:30 +0300
> Oleg Pykhalov <go.wigust <at> gmail.com> wrote:
>
>> From 2799970350073812c2d458d9750649cdf7f23315 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Tue, 5 Sep 2017 14:04:14 +0300
>> Subject: [PATCH 1/1] doc: Replace server-list with server-blocks.
>> 
>> * doc/guix.texi (Web Services): Replace 'server-list' with
>> 'server-blocks'. ---
>>  doc/guix.texi | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/doc/guix.texi b/doc/guix.texi
>> index e7a88e19f..9ac52535b 100644
>
> I'm having problems applying this:
>
> error: sha1 information is lacking or useless (doc/guix.texi).
> error: could not build fake ancestor
>
> I think this might be happening, as I don't have something locally that
> coresponds to e7a88e19f. Is this patch on some version of guix.texi
> that hasn't made it in to the master branch yet?

Yes, sorry for that.

>> …
> Thanks for spotting this. Obviously I missed it when removing the
> nginx-service procedure.
>
> It looks like this is also a problem elsewhere in the docs, as I can
> see a few more instances of server-list. Also, it looks like
> upstream-list has exactly the same problem. I think it would be good to
> fix all of the server-list bits in this patch at least. Could you add
> them?

Sure, I replaced all instances in which Emacs (query-replace) found in
doc/guix.texi.

[0001-doc-Replace-server-list-with-server-blocks.patch (text/x-patch, attachment)]

Message #19 received at 28356-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28356-done <at> debbugs.gnu.org
Subject: Re: [bug#28356] [PATCH 1/1] doc: Replace server-list with
 server-blocks.
Date: Sun, 10 Sep 2017 12:02:09 +0100

[Message part 1 (text/plain, inline)]

On Thu, 07 Sep 2017 10:46:29 +0300
Oleg Pykhalov <go.wigust <at> gmail.com> wrote:

> Hello Christopher,
> 
> Christopher Baines <mail <at> cbaines.net> writes:
> 
> > On Tue, 05 Sep 2017 14:15:30 +0300
> > Oleg Pykhalov <go.wigust <at> gmail.com> wrote:
> >  
> >> From 2799970350073812c2d458d9750649cdf7f23315 Mon Sep 17 00:00:00
> >> 2001 From: Oleg Pykhalov <go.wigust <at> gmail.com>
> >> Date: Tue, 5 Sep 2017 14:04:14 +0300
> >> Subject: [PATCH 1/1] doc: Replace server-list with server-blocks.
> >> 
> >> * doc/guix.texi (Web Services): Replace 'server-list' with
> >> 'server-blocks'. ---
> >>  doc/guix.texi | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/doc/guix.texi b/doc/guix.texi
> >> index e7a88e19f..9ac52535b 100644  
> >
> > I'm having problems applying this:
> >
> > error: sha1 information is lacking or useless (doc/guix.texi).
> > error: could not build fake ancestor
> >
> > I think this might be happening, as I don't have something locally
> > that coresponds to e7a88e19f. Is this patch on some version of
> > guix.texi that hasn't made it in to the master branch yet?  
> 
> Yes, sorry for that.
> 
> >> …  
> > Thanks for spotting this. Obviously I missed it when removing the
> > nginx-service procedure.
> >
> > It looks like this is also a problem elsewhere in the docs, as I can
> > see a few more instances of server-list. Also, it looks like
> > upstream-list has exactly the same problem. I think it would be
> > good to fix all of the server-list bits in this patch at least.
> > Could you add them?  
> 
> Sure, I replaced all instances in which Emacs (query-replace) found in
> doc/guix.texi.

Awesome, I've now pushed this, along with another patch that fixes the
same issue for upstream-list/upstream-blocks.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.