From unknown Sun Jun 22 03:57:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28335] [PATCH] vm: Remove redundant conditional in system-disk-image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28335@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150443636417714 (code B ref -1); Sun, 03 Sep 2017 11:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Sep 2017 10:59:24 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSce-0004be-0Q for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doScc-0004bR-Qw for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doScT-0006t0-3P for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1doScT-0006sv-0J for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doScO-0005PJ-3P for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doScJ-0006oK-Ol for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:08 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:59346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doScJ-0006nq-IN for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:03 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id DBD0913D2BD; Sun, 3 Sep 2017 11:59:02 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id BC5C613D2BC for ; Sun, 3 Sep 2017 11:59:02 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 385a11f4 for ; Sun, 3 Sep 2017 10:59:02 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:59:02 +0100 Message-Id: <20170903105902.3961-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/system/vm.scm (system-disk-image): Remove redundant conditional for #:file-system-type when calling qemu-image. --- gnu/system/vm.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 4494af003..b3da11876 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -403,10 +403,7 @@ to USB sticks meant to be read-only." (operating-system-bootloader os)) #:disk-image-size disk-image-size #:disk-image-format "raw" - #:file-system-type (if (string=? "iso9660" - file-system-type) - "ext4" - file-system-type) + #:file-system-type file-system-type #:file-system-label root-label #:copy-inputs? #t #:register-closures? #t -- 2.14.1 From unknown Sun Jun 22 03:57:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28335] [PATCH] vm: Remove redundant conditional in system-disk-image. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Sep 2017 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28335@debbugs.gnu.org Received: via spool by 28335-submit@debbugs.gnu.org id=B28335.150452908831110 (code B ref 28335); Mon, 04 Sep 2017 12:45:02 +0000 Received: (at 28335) by debbugs.gnu.org; 4 Sep 2017 12:44:48 +0000 Received: from localhost ([127.0.0.1]:47930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doqkC-00085i-GZ for submit@debbugs.gnu.org; Mon, 04 Sep 2017 08:44:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doqkA-00085U-U2 for 28335@debbugs.gnu.org; Mon, 04 Sep 2017 08:44:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doqk0-0002Kp-S0 for 28335@debbugs.gnu.org; Mon, 04 Sep 2017 08:44:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doqk0-0002Kk-Of; Mon, 04 Sep 2017 08:44:36 -0400 Received: from [193.50.110.184] (port=32998 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1doqk0-0003Kd-6D; Mon, 04 Sep 2017 08:44:36 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170903105902.3961-1-mail@cbaines.net> Date: Mon, 04 Sep 2017 14:44:34 +0200 In-Reply-To: <20170903105902.3961-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 3 Sep 2017 11:59:02 +0100") Message-ID: <87efrm4or1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Baines skribis: > * gnu/system/vm.scm (system-disk-image): Remove redundant conditional for > #:file-system-type when calling qemu-image. OK! Ludo=E2=80=99. From unknown Sun Jun 22 03:57:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#28335: closed (Re: [bug#28335] [PATCH] vm: Remove redundant conditional in system-disk-image.) Message-ID: References: <20170904223557.11ba9cb0@cbaines.net> <20170903105902.3961-1-mail@cbaines.net> X-Gnu-PR-Message: they-closed 28335 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28335@debbugs.gnu.org Date: Mon, 04 Sep 2017 21:37:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1504561023-22484-1" This is a multi-part message in MIME format... ------------=_1504561023-22484-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28335: [PATCH] vm: Remove redundant conditional in system-disk-image. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28335@debbugs.gnu.org. --=20 28335: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28335 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1504561023-22484-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28335-done) by debbugs.gnu.org; 4 Sep 2017 21:36:04 +0000 Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doz2J-0005om-Un for submit@debbugs.gnu.org; Mon, 04 Sep 2017 17:36:04 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:45900 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doz2H-0005oH-DU for 28335-done@debbugs.gnu.org; Mon, 04 Sep 2017 17:36:02 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 88EC413D44F; Mon, 4 Sep 2017 22:36:00 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 86ECF13D431; Mon, 4 Sep 2017 22:35:58 +0100 (BST) Date: Mon, 4 Sep 2017 22:35:57 +0100 From: Christopher Baines To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28335] [PATCH] vm: Remove redundant conditional in system-disk-image. Message-ID: <20170904223557.11ba9cb0@cbaines.net> In-Reply-To: <87efrm4or1.fsf@gnu.org> References: <20170903105902.3961-1-mail@cbaines.net> <87efrm4or1.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Qc_nyYL8fUp5vuUGDILX6CT"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28335-done Cc: 28335-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/Qc_nyYL8fUp5vuUGDILX6CT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 04 Sep 2017 14:44:34 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > * gnu/system/vm.scm (system-disk-image): Remove redundant > > conditional for #:file-system-type when calling qemu-image. =20 >=20 > OK! Pushed as 4138e782dcfea675ebc2347cbd4ea9abeb9dff36 :) --Sig_/Qc_nyYL8fUp5vuUGDILX6CT Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmtxz1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfvcg//X9yPHGyL1PfdURoK1GUt8C1wtTHWKC1RWnRYqu9BE46dAfRp581iSGsB UJgEs0aLnZiHkLBoQuTbp2KhbE4c4LAJ6rNigzTrEoNticTU62lm5FljdCgysXTn Gh1MQ5oNZCzi/KmZIqBfYDE0/M//RCvpA7ZG1ui0IW2EvzorOYpgL3KZooGire5F NoApOqmqCQXqj3wEmQSm06Rz/y7/LO4wbZKeoZdTkLhXI9xCoGqXt2q7juhsLgEb mcw0uddeGRQh27pHvv/WWKmX59wkO/T7z1i+dRIUjBjEbc531QEQXYa5/V41Ol6g 0Bj7ltR58PMo1O3qWVC+wDPuw+posx609mjge137oKyMD26G/Cmjx7FXfJY81c3m PwXwA0TUjSGJNHk5yipRVFrqn8NImO7zN5VTdzZGFRPBOacpb3q3uvCpstBPGMcQ /tqUuwWu4b1Xb1CCdg88WsKUGuLfU715vzJjasg8XYNpf+NrVtCfFOPfa2MCkCz9 oFnoQg9dZpyu4MsbNPDeg6kDB7Jm6s4Q/XTZt5CWkH4WfOmgHz/xyhqSXdZSmk5g SAP+DxNBA3EkJEjNqp9697xOObvo0s1AytVEmJeo7hG38ZBZOxPk/FMwFvsZETiB 7JDK47YUt67Jkd4lWVYvKaY0+bZNdSmvY8/nOzD8r5Zt8lsn0Z4= =pz+P -----END PGP SIGNATURE----- --Sig_/Qc_nyYL8fUp5vuUGDILX6CT-- ------------=_1504561023-22484-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Sep 2017 10:59:24 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSce-0004be-0Q for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doScc-0004bR-Qw for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doScT-0006t0-3P for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1doScT-0006sv-0J for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:59:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doScO-0005PJ-3P for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doScJ-0006oK-Ol for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:08 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:59346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doScJ-0006nq-IN for guix-patches@gnu.org; Sun, 03 Sep 2017 06:59:03 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id DBD0913D2BD; Sun, 3 Sep 2017 11:59:02 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id BC5C613D2BC for ; Sun, 3 Sep 2017 11:59:02 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 385a11f4 for ; Sun, 3 Sep 2017 10:59:02 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] vm: Remove redundant conditional in system-disk-image. Date: Sun, 3 Sep 2017 11:59:02 +0100 Message-Id: <20170903105902.3961-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/system/vm.scm (system-disk-image): Remove redundant conditional for #:file-system-type when calling qemu-image. --- gnu/system/vm.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 4494af003..b3da11876 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -403,10 +403,7 @@ to USB sticks meant to be read-only." (operating-system-bootloader os)) #:disk-image-size disk-image-size #:disk-image-format "raw" - #:file-system-type (if (string=? "iso9660" - file-system-type) - "ext4" - file-system-type) + #:file-system-type file-system-type #:file-system-label root-label #:copy-inputs? #t #:register-closures? #t -- 2.14.1 ------------=_1504561023-22484-1--