From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 15:21:11 2017 Received: (at submit) by debbugs.gnu.org; 2 Sep 2017 19:21:11 +0000 Received: from localhost ([127.0.0.1]:43916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doDyh-0006Dh-0S for submit@debbugs.gnu.org; Sat, 02 Sep 2017 15:21:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doDye-0006DT-Gc for submit@debbugs.gnu.org; Sat, 02 Sep 2017 15:21:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doDyT-0007az-Vl for submit@debbugs.gnu.org; Sat, 02 Sep 2017 15:21:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1doDyT-0007as-Rp for submit@debbugs.gnu.org; Sat, 02 Sep 2017 15:20:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doDyO-0002sT-7l for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2017 15:20:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doDyI-0007Nx-Q3 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2017 15:20:52 -0400 Received: from aibo.runbox.com ([91.220.196.211]:55702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doDyI-0007Hi-6d for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2017 15:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:Subject:To:From; bh=3BmGJw0WcgirzKymQGjWYwzTQOwFCn7GDvSdHB0RBhw=; b=OGEFlhhZlyj6CwnOeJGsKJzofS Zt/2juozuC1ZoB+aCI4pC5KoZpMA8hEh/oFTHL6BOiZW8ndaP/3fTo7phNXJ6430+TOh7HjaWAxhL 57qiwDIuP7V8uOJlWTWd1/nnYmXeJuK9YDfb4TsO2d9HF3Kh3EfRJhVtOGbO3PiPOZRG51lw9/Ajw /hSU/aLl3N9vaDvGIytNcUj3x6wUScgQ9eCoNXIxhDZ7DN16Hcy7Bi2D1oRLBoX3ewgHn4tW/ml1x AfdlVJlHu8e3FViibFIY90JEAOeFl3WosdMFQ3GaCqiFpmkahexazP8R4I4nN+XFgN8j7XtPltvV3 fLw3Ow7g==; Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1doDy8-0001nA-EL for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2017 21:20:36 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1doDxu-0000AF-1S for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2017 21:20:22 +0200 From: Gemini Lasswell To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Backtrace not printed when ERT test fails Date: Sat, 02 Sep 2017 12:20:09 -0700 Message-ID: <87a82caowm.fsf@chinook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) ERT used to print a backtrace for every failed test, but recently that stopped happening. I git bisected and found that the commit which introduced the problem is ead545824e, "Improve ert backtrace recording". Here's the test I've been using to reproduce the problem: (require 'ert) (defun div0 (n) (/ n (- n n))) (ert-deftest failing-test () "Check if backtrace works" (should (div0 1))) When running the test interactively, pressing b at the test in ERT's results buffer shows an empty backtrace. And here is the output of running "make -C test fail" with the code above saved in test/lisp/fail.el: make: Entering directory '/home/gemini/src/emacs/test' make[1]: Entering directory '/home/gemini/src/emacs/test' GEN lisp/fail.log Running 1 tests (2017-09-02 11:46:08-0700) Test failing-test backtrace: Test failing-test condition: (arith-error) FAILED 1/1 failing-test Ran 1 tests, 0 results as expected, 1 unexpected (2017-09-02 11:46:08-0700) 1 unexpected results: FAILED failing-test make[1]: *** [Makefile:149: lisp/fail.log] Error 1 make[1]: Leaving directory '/home/gemini/src/emacs/test' make: *** [Makefile:198: lisp/fail] Error 2 make: Leaving directory '/home/gemini/src/emacs/test' In GNU Emacs 26.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.22.8) of 2017-09-02 built on chinook Repository revision: ead545824e511ab18d18b5223eab80e1f4fe3d64 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 Recent messages: Guessed variable =E2=80=99python-indent=E2=80=99 (2) You should have a section marked ";;; Commentary:" The first line should be of the form: ";;; package --- Summary" You can run the command =E2=80=98eval-buffer=E2=80=99 with M-x ev-b RET Ran 1 tests, 0 results were as expected, 1 unexpected You can run the command =E2=80=98ert=E2=80=99 with M-x ert RET Ran 1 tests, 0 results were as expected, 1 unexpected mouse-2, RET: Reveal test result mouse-2, RET: Expand/collapse test result Configured using: 'configure --prefix=3D/home/gemini/src/emacs/out --with-modules --with-x-toolkit=3Dgtk3 --with-xft --config-cache' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ERT-View Minor modes in effect: ivy-mode: t global-flycheck-mode: t pyvenv-mode: t beacon-mode: t shell-dirtrack-mode: t imagex-auto-adjust-mode: t volatile-highlights-mode: t region-state-mode: t ws-butler-global-mode: t ws-butler-mode: t show-smartparens-global-mode: t smartparens-global-mode: t smartparens-global-strict-mode: t which-key-mode: t modalka-global-mode: t modalka-mode: t global-auto-revert-mode: t winner-mode: t savehist-mode: t override-global-mode: t cl-old-struct-compat-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (ert ewoc debug colir counsel swiper ivy flx delsel ivy-overlay ffap shadow sort mail-extr emacsbug flycheck sji-sunset-day-theme guess-style company-capf company-files mu4e desktop frameset mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-context mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions rfc2368 smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils doc-view jka-compr mu4e-lists mu4e-vars message rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs mailabbrev mail-utils gmm-utils mailheader hl-line mu4e-meta company-tern dash-functional tern company-jedi jedi-core python-environment epc ctable concurrent deferred company-c-headers nix-mode yasnippet highlight-indentation flymake help-fns radix-tree elpy pyvenv elpy-django elpy-refactor smartparens-python python tramp-sh json map grep files-x slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime-company company pcase slime compile arc-mode archive-mode pp hyperspec browse-url nameless lisp-mnt ace-window avy beacon smex ido tramp tramp-compat tramp-loaddefs trampver shell parse-time image+ ledger-mode ledger-check ledger-schedule ledger-xact ledger-texi ledger-test ledger-sort ledger-report ledger-reconcile ledger-post ledger-occur ledger-init ledger-fontify ledger-state ledger-navigate ledger-fonts ledger-exec ledger-context ledger-complete ledger-commodities esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-groups eshell esh-module esh-mode esh-arg esh-util cus-edit cus-start cus-load ledger-regex rx deft wid-edit debbugs soap-client mm-decode mm-bodies mm-encode url-http tls gnutls url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm subr-x puny url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap warnings rng-xsd rng-dt rng-util xsd-regexp xml rainbow-mode color s ucs-normalize hydra lv column-enforce-mode etags xref project volatile-highlights region-state ws-butler smartparens-config smartparens thingatpt dash which-key modalka quail smart-mode-line-respectful-theme smart-mode-line rich-minority sji-sunset-night-theme color-theme-sji-sunset advice dired+ image-dired image-mode image-file dired-x dired-aux dired dired-loaddefs autorevert filenotify winner savehist cap-words superword subword org-clock org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint ansi-color ring ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs cl-extra help-mode use-package diminish bind-key easy-mmode finder-inf edmacro kmacro slime-autoloads info cl package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 638543 375725) (symbols 48 55060 42) (miscs 40 246 528) (strings 32 151320 46615) (string-bytes 1 4521307) (vectors 16 81725) (vector-slots 8 1291449 454954) (floats 8 404 736) (intervals 56 1261 463) (buffers 976 17)) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 17:29:00 2017 Received: (at 28333) by debbugs.gnu.org; 2 Sep 2017 21:29:00 +0000 Received: from localhost ([127.0.0.1]:44085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doFyN-0000gb-Uj for submit@debbugs.gnu.org; Sat, 02 Sep 2017 17:29:00 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doFyM-0000gK-6K for 28333@debbugs.gnu.org; Sat, 02 Sep 2017 17:28:58 -0400 Received: by mail-oi0-f44.google.com with SMTP id n18so23323363oig.2 for <28333@debbugs.gnu.org>; Sat, 02 Sep 2017 14:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1iG3kpgO7xNZZJDnexffbq0VK/XCCA+Rtbk0AE7wU5s=; b=SdMMUXGGG+avbCKqmGQfaAhP5jfIpdLyPHWxicPpQA7NbXo5aidJHzzvX3yap/GyFm kdMUjscQjIZ3uK8mq642S1dxw98MunpepQCGN3DIapZb3yZYO5xp8biLcKHCFJ8J8dKh IHh83YzYjb06TSTHyHQF7ngtR+SheR1p4j1ZkxAqcLLbXGm5MC/V8Iit1OSXoSLQD4to TmX0aXxjy1nTtWc5mMNRh3ndU31vmHfH8gsMGL92SNTZLRDrQSy89KnUktfm8Dx1CKt1 Xfo05Hb9Aokq8/nTpffW3h9708FTtDo+iohTtadiZZDB0YgaPN3P4rd48pQUp/ce9tBp 7yKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1iG3kpgO7xNZZJDnexffbq0VK/XCCA+Rtbk0AE7wU5s=; b=ZljKRR6dAuvWIuxnKoiT8KgLExrhrAbvy0mnC8Kfpyx8ayxhQvOuPurCwUlGsUmGbP XF8VES18jrFWe1P1q3EZlZ3+y82aRVp8VtuULB/3RVl6OiJbWHPqdWDmrOKbYkfqdBL5 WhWoU5J/CAw9B+gUhDJafTgNqi2SZ47iQKAAkiD/eq8c07JktyIVd63G8fzVCsFZCn8t LAuibW9CEFAsLiU+PTC7Ij0bDTdNGc+IbzbU94DCSWP8hc9JujW37WrZyYPAhcCU0zZH 8IgFsGizq8Fb4TwlHo3wONDyesMRBpXaQ15YCHUxunPdV2YFauXEk3P196kBMu/PbynP bedg== X-Gm-Message-State: AHPjjUgnmbjx6rvTzMbEUW2ll9Ede2yKI3tybs07TZLudhMX17SKk9FJ mE3vpE+zaOreeD2OcGl9dwVan6oiJg== X-Google-Smtp-Source: ADKCNb4rD3num59/+clda05R6XfJxye9iHfa6occAR1fzPZI2tuj/n0pmhlwFeOhoyOGMw6iVgt/vJ7MnLLinx6LA6g= X-Received: by 10.202.78.85 with SMTP id c82mr4935999oib.96.1504387732518; Sat, 02 Sep 2017 14:28:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.17.199 with HTTP; Sat, 2 Sep 2017 14:28:51 -0700 (PDT) In-Reply-To: <87a82caowm.fsf@chinook> References: <87a82caowm.fsf@chinook> From: Noam Postavsky Date: Sat, 2 Sep 2017 17:28:51 -0400 X-Google-Sender-Auth: rDSCi26X2idH8sePjYiUpK_8ImI Message-ID: Subject: Re: bug#28333: 26.0.50; Backtrace not printed when ERT test fails To: Gemini Lasswell Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 28333 Cc: 28333@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tag 28333 confirmed quit On Sat, Sep 2, 2017 at 3:20 PM, Gemini Lasswell wrote: > ERT used to print a backtrace for every failed test, but recently that > stopped happening. I git bisected and found that the commit which > introduced the problem is ead545824e, "Improve ert backtrace > recording". Hah, ironic isn't it. The problem is this code here: ;; Grab the frames starting from `signal', frames below ;; that are all from the debugger. (backtrace (backtrace-frames 'signal)) When the error comes from division by 0, there is `signal' frame at all, hence we store `nil' as the backtrace. Maybe this could be fixed with something equivalent to the following? --- i/lisp/emacs-lisp/ert.el +++ w/lisp/emacs-lisp/ert.el @@ -739,7 +739,8 @@ ert--run-test-debugger ;; ;; Grab the frames starting from `signal', frames below ;; that are all from the debugger. - (backtrace (backtrace-frames 'signal)) + (backtrace (or (backtrace-frames 'signal) + (cdr (backtrace-frames 'ert--run-test-debugger)))) (infos (reverse ert--infos))) (setf (ert--test-execution-info-result info) (cl-ecase type From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 14 19:39:33 2017 Received: (at 28333) by debbugs.gnu.org; 14 Sep 2017 23:39:33 +0000 Received: from localhost ([127.0.0.1]:41667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsdjJ-0003Nd-IH for submit@debbugs.gnu.org; Thu, 14 Sep 2017 19:39:33 -0400 Received: from aibo.runbox.com ([91.220.196.211]:53758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsdjH-0003NT-PY for 28333@debbugs.gnu.org; Thu, 14 Sep 2017 19:39:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Date:In-reply-to:Message-ID: Subject:Cc:To:From:References; bh=2o8ANKmFCLTaVyzXYjgGzuoo6Vs5Smy2XaBaDP/xBQ4=; b=QTzZ8QdFCP42oiDfM57E60wG6p Lm4rWWFMPkPKVjCwrhNiuAD8JbbjHm2HmeVWCbw7UVgNqPVxgdvDP40UIdDHk/v37dVXggPYOQQyA aSjRKud7ssTEb1s/OTMCdnl9Vwuk0rarKhSeR4SakXXDfgwDf/00RnD/h/JMHKT24+90pH5Vl6AGe b235a6A1iZXIL2C8CEff4/u0Ty1pD1GkOtKLipnD8IB8dXK2V5gf7pKuVMnN0irc8LF/chIatqt7p mzu+6Dznmjw2smca60t1Co8Dna9Fo2w7BFc4WUcQ8lE25kgW+Me/im87OxTufCfovs8W0txCcq/dz PyJIQ34A==; Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dsdjB-0003hH-SS; Fri, 15 Sep 2017 01:39:25 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dsdj2-0001cL-LE; Fri, 15 Sep 2017 01:39:17 +0200 References: <87a82caowm.fsf@chinook> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Gemini Lasswell To: Noam Postavsky Subject: Re: bug#28333: 26.0.50; Backtrace not printed when ERT test fails Message-ID: <87377on96c.fsf@runbox.com> In-reply-to: Date: Thu, 14 Sep 2017 16:39:07 -0700 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28333 Cc: 28333@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: > Maybe this could be fixed with something equivalent to the following? I've been running this for a few days and haven't seen any more missing backtraces. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 11:48:49 2017 Received: (at 28333) by debbugs.gnu.org; 23 Sep 2017 15:48:49 +0000 Received: from localhost ([127.0.0.1]:54768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvmfg-0006e4-OK for submit@debbugs.gnu.org; Sat, 23 Sep 2017 11:48:48 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:44854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvmfe-0006dh-HC; Sat, 23 Sep 2017 11:48:47 -0400 Received: by mail-it0-f44.google.com with SMTP id d192so3073879itd.1; Sat, 23 Sep 2017 08:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=7Nxg67FkhKryTUnfY+jNSs0rdLFEswkA6SGsEAVIrjA=; b=XPjA2AmTxum9xujAz2bRPethXMrRtXp/BiUcxJKez/HGqrNXuYKkYyT59SdRYWsB++ ZtvKpPYmJOzVJ/P0GKVVyMe7AIdgR71+nVmnTc201DL4oscovqibifFkJpsmDVAX7mQx HpGuQpoDoMY7rP/JxC6YAuwiT3MIP3eQkQzvXzZczQZ5fsFj4/CdlTSTh+uZm7xDM1k5 3VCh5V1hljlG/FmvLBLkPBd/CFnqKsJw3BFqggt1un0mdB7K8Sz2xdU8esjIaiI6kNn7 +wJAR922+4dPLXXGB9Dc6SW60OCWuOqz7nYV6pD4OAKTmSkIgZaETbXLTxpzQrs5/lpe p5NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=7Nxg67FkhKryTUnfY+jNSs0rdLFEswkA6SGsEAVIrjA=; b=rmoC0gazJaTcUQilWP/fC0JRH7vixK32XekKQkb4W94REYXocqhk9HYxZL6RYUrKgT a6mzIfkOEVseezNrqQulxZ2QHCweUrS7bRMSbuTNFp3hzGALUDAzQ2lHbEPZiHM/XsKq PqW3KnQIaVlNlUb9AO095ealf3QSKLq37+m58w5CZR82NBiDSiOBW3U58biBl0BhNWf6 LCVJRlnK/lHXRw6whNFVqPRf0MEsH4R4qeWan4q/mQaHFfuXPy1eYD2LR+En8w4LDrs0 uqexu9hs8qnm542/5VJAC9bVjPBY1pIxBfGfH2WIt1Y36F9iokXtL6EOKpYr1/yAZxMV L3Vg== X-Gm-Message-State: AHPjjUhh1q2NBPA/rgf39Vj/wk6AfrLuLvBTjs8em+uOsQmW85icyJYR jcHu6oS0/uwJEvmovIs0yIh9HA== X-Google-Smtp-Source: AOwi7QAwr9JIxVzUFa4qszDJiNXj8+oAm2LDvK60++UzVFqn7+ygkrAp0qBf0dqvsjfwAwrc2CrRLg== X-Received: by 10.36.28.69 with SMTP id c66mr12643066itc.103.1506181720407; Sat, 23 Sep 2017 08:48:40 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l195sm1977239itl.2.2017.09.23.08.48.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Sep 2017 08:48:39 -0700 (PDT) From: Noam Postavsky To: Gemini Lasswell Subject: Re: bug#28333: 26.0.50; Backtrace not printed when ERT test fails In-Reply-To: <87377on96c.fsf@runbox.com> (Gemini Lasswell's message of "Thu, 14 Sep 2017 16:39:07 -0700") References: <87a82caowm.fsf@chinook> <87377on96c.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Date: Sat, 23 Sep 2017 11:48:38 -0400 Message-ID: <87wp4pmn55.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28333 Cc: 28333@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain tags 28333 + patch quit Gemini Lasswell writes: > Noam Postavsky writes: > >> Maybe this could be fixed with something equivalent to the following? > > I've been running this for a few days and haven't seen any more missing > backtraces. Actually, I think it's giving one extra frame. Using `debugger' as the BASE seems to cover both cases nicely: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-ert-backtrace-saving-for-non-signal-ed-errors-Bu.patch Content-Description: patch >From 847ed811022f4d4fe43f2d5e14660f93538423dd Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 23 Sep 2017 11:40:14 -0400 Subject: [PATCH] Fix ert backtrace saving for non-`signal'ed errors (Bug#28333) * lisp/emacs-lisp/ert.el (ert--run-test-debugger): Take the frames above the `debugger' frame, rather than assuming there will be a `signal' frame. --- lisp/emacs-lisp/ert.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el index d4276221ba..83acbacb88 100644 --- a/lisp/emacs-lisp/ert.el +++ b/lisp/emacs-lisp/ert.el @@ -742,9 +742,8 @@ ert--run-test-debugger ;; backtrace ready for printing is important for batch ;; use. ;; - ;; Grab the frames starting from `signal', frames below - ;; that are all from the debugger. - (backtrace (backtrace-frames 'signal)) + ;; Grab the frames above the debugger. + (backtrace (cdr (backtrace-frames debugger))) (infos (reverse ert--infos))) (setf (ert--test-execution-info-result info) (cl-ecase type -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 20:11:49 2017 Received: (at 28333) by debbugs.gnu.org; 29 Sep 2017 00:11:49 +0000 Received: from localhost ([127.0.0.1]:37301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxiuD-0007Yf-LK for submit@debbugs.gnu.org; Thu, 28 Sep 2017 20:11:49 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:50834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxiuB-0007YM-Nx; Thu, 28 Sep 2017 20:11:48 -0400 Received: by mail-it0-f53.google.com with SMTP id y138so312493itc.5; Thu, 28 Sep 2017 17:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=r69fQhslGJ7BA/nWQ0JhLvqsxauMaedbxjsawhqIvPI=; b=cNZur5uGYJv7+y+WG6YP34YwHZqLZ2MGfe6mCGhZHJyDnJlj5VLaKlDL2k6vh8ylwL D1LEnG6wluiurG7l9qP8BbSI6pHis6mTyX/5RaO2dJt/fCQcSqIjZcJ2vIh4msuB4EA/ Q1JdPzvPgdilAJP6IjeGl5Hq7x/YbkWO95/B4SoYslga5CD2OyivSuT6C+B4FE4ON7jL A6xUG4R/vurDKHV+LM8LWDm8UCISgQNJa/HDvPNwpgDkWsbuRuSYXPjTuOn5O0GA8zVE VyFDi1ttuWl8NO1ZcQbOGAyrCAnRogcSQm+V1j+ijqKGG6ZrCJV0ZE6cmKeCX7xkEzEm QLiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=r69fQhslGJ7BA/nWQ0JhLvqsxauMaedbxjsawhqIvPI=; b=T9k9ZsUvuGK/GFljLsn4R/cEk3sIaR1HvkEIt3TFDTsWgOF5A41tP4kSKJl40fNS7i mgHr5e2Vnis9lG6249XKwTWaY6nkEC/KBMQTVdcyj64h59KUlmsFkMbl9pfH7p7Vs9cl IKXArCTxcCQUDW6N5LJzjov7L0bnRnoD2HiLN0sV9O+WgydX6c84vmW5hzp3p2ohu4A2 wxJ9bR0+ojjjqNRviXADHMAeTNNdjqxG2FIUGehX8rySzbC4aG8sU7mprHb3cd/irrp3 Xk7R6eNE17rC95bwqubhc73xXsgr3ZCCxdLtrnk6lQdWdnWJD6WkLO6IVkxU6bVYRdjZ U+lA== X-Gm-Message-State: AMCzsaXJwwasIKFzzMcjpryN9ntWn6yieG+jaEzJ1HR9hJOUGzMo6SQD 7PxX5j0jfdc+E5YraigXoU+jFw== X-Google-Smtp-Source: AOwi7QDYzMJJLogfTaoQRbzG1jz4Wuu5frYBsvmekefh8+dX28cSQvyZABf5Q0ea0jPfXt3Ua+o+vw== X-Received: by 10.36.91.132 with SMTP id g126mr4799375itb.122.1506643901951; Thu, 28 Sep 2017 17:11:41 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q26sm1212677ioi.58.2017.09.28.17.11.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Sep 2017 17:11:41 -0700 (PDT) From: Noam Postavsky To: Gemini Lasswell Subject: Re: bug#28333: 26.0.50; Backtrace not printed when ERT test fails References: <87a82caowm.fsf@chinook> <87377on96c.fsf@runbox.com> <87wp4pmn55.fsf@users.sourceforge.net> Date: Thu, 28 Sep 2017 20:11:39 -0400 In-Reply-To: <87wp4pmn55.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 23 Sep 2017 11:48:38 -0400") Message-ID: <878tgyfjno.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28333 Cc: 28333@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 28333 fixed close 28333 quit Noam Postavsky writes: > Actually, I think it's giving one extra frame. Using `debugger' as the > BASE seems to cover both cases nicely: Pushed to emacs-26. [1: af130f900f]: 2017-09-28 19:57:24 -0400 Fix ert backtrace saving for non-`signal'ed errors (Bug#28333) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=af130f900fc499f71ea22f10ba055a75ce35ed4e From unknown Thu Jun 19 14:26:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator