From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Leo , 2833@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 31 Mar 2009 14:40:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12385099364332 (code B ref -1); Tue, 31 Mar 2009 14:40:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 31 Mar 2009 14:32:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.2 required=4.0 tests=FOURLA,MURPHY_SEX_L2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2VEWCbx004326 for ; Tue, 31 Mar 2009 07:32:13 -0700 Received: from mail.gnu.org ([199.232.76.166]:57675 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lof0d-00005H-Ot for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 10:32:11 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Lof0d-0005ih-25 for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 10:32:11 -0400 Received: from ppsw-5.csi.cam.ac.uk ([131.111.8.135]:44006) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lof0c-0005iH-KE for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 10:32:10 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:4870 helo=localhost) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Lof0a-0002CC-J3 (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Tue, 31 Mar 2009 15:32:08 +0100 From: Leo To: emacs-pretest-bug@gnu.org Date: Tue, 31 Mar 2009 15:32:02 +0100 Message-ID: <83bprhg3vh.fsf@cam.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) I think there's a bug in direcotry variables code, that is, changing the directory variables would require a restart of Emacs for them to take effect. A recipe to reproduce: 1. Create a dir and write the following to file .dir-locals in the dir created: ((latex-mode . ((fill-column . 78) (coding . "latin-1")))) 2. Open or create a .tex file in that dir 3. C-h v fill-column RET to check the value 4. Change 78 to another value say 75 5. Re-open the .tex file and you will see fill-column has a value 78 NOT 75 In my view, this makes the `Directory Variables' feature much less useful. Any fix? In GNU Emacs 23.0.92.1 (i386-mingw-nt5.1.2600) of 2009-03-31 on BREPNB Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENG value of $XMODIFIERS: nil locale-coding-system: cp1252 default-enable-multibyte-characters: t Major mode: LaTeX/P Minor modes in effect: reftex-mode: t TeX-PDF-mode: t dired-omit-mode: t recentf-mode: t icomplete-mode: t savehist-mode: t display-time-mode: t xterm-mouse-mode: t delete-selection-mode: t global-auto-revert-mode: t minibuffer-depth-indicate-mode: t which-function-mode: t show-paren-mode: t rcirc-track-minor-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-f . d i 8 C-x C-s C-h i m e m a m f i l e SPC v a r SPC SPC SPC l SPC l ^ q 8 C-x C-s C-x k M-x r e p o r Recent messages: Applying style hooks... done Type "q" to delete this window. Applying style hooks... done Type "q" to delete this window. Composing main Info directory...done Reverting buffer `.dir-locals.el'. From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Stefan Monnier , 2833@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 01 Apr 2009 01:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12385484835044 (code B ref -1); Wed, 01 Apr 2009 01:20:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Apr 2009 01:14:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n311EeGx005036 for ; Tue, 31 Mar 2009 18:14:41 -0700 Received: from mail.gnu.org ([199.232.76.166]:60250 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lop2N-0003J2-A5 for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 21:14:39 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Lop2M-0004W8-OB for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 21:14:39 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:10565) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lop2M-0004W1-HP for emacs-pretest-bug@gnu.org; Tue, 31 Mar 2009 21:14:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqgEAPdc0klFxIfy/2dsb2JhbACBU8xwg3oGhH8 X-IronPort-AV: E=Sophos;i="4.39,304,1235970000"; d="scan'208";a="36020982" Received: from 69-196-135-242.dsl.teksavvy.com (HELO ceviche.home) ([69.196.135.242]) by ironport2-out.teksavvy.com with ESMTP; 31 Mar 2009 21:14:37 -0400 Received: by ceviche.home (Postfix, from userid 20848) id C5C177057A; Tue, 31 Mar 2009 21:14:37 -0400 (EDT) From: Stefan Monnier To: Leo Cc: 2833@debbugs.gnu.org, emacs-pretest-bug@gnu.org Message-ID: References: <83bprhg3vh.fsf@cam.ac.uk> Date: Tue, 31 Mar 2009 21:14:37 -0400 In-Reply-To: <83bprhg3vh.fsf@cam.ac.uk> (Leo's message of "Tue, 31 Mar 2009 15:32:02 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. > 1. Create a dir and write the following to file .dir-locals in the dir > created: > ((latex-mode . ((fill-column . 78) > (coding . "latin-1")))) > 2. Open or create a .tex file in that dir > 3. C-h v fill-column RET to check the value > 4. Change 78 to another value say 75 How do you change it? with C-x f ? > 5. Re-open the .tex file and you will see fill-column has a value 78 > NOT 75 How do you "re-open" it? Stefan From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Leo , 2833@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 01 Apr 2009 10:10:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.12385801237445 (code B ref 2833); Wed, 01 Apr 2009 10:10:05 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 1 Apr 2009 10:02:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-0.csi.cam.ac.uk (ppsw-0.csi.cam.ac.uk [131.111.8.130]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n31A1x3B007439 for <2833@emacsbugs.donarmstrong.com>; Wed, 1 Apr 2009 03:02:01 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:57920) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES256-SHA:256) id 1LoxGg-0006YW-25 (Exim 4.70) (return-path ); Wed, 01 Apr 2009 11:01:58 +0100 From: Leo To: Stefan Monnier Cc: 2833@debbugs.gnu.org References: <83bprhg3vh.fsf@cam.ac.uk> Date: Wed, 01 Apr 2009 11:01:58 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 31 Mar 2009 21:14:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-04-01 02:14 +0100, Stefan Monnier wrote: >> 1. Create a dir and write the following to file .dir-locals in the dir >> created: > >> ((latex-mode . ((fill-column . 78) >> (coding . "latin-1")))) > >> 2. Open or create a .tex file in that dir >> 3. C-h v fill-column RET to check the value >> 4. Change 78 to another value say 75 > > How do you change it? with C-x f ? Sorry I wasn't clear. I mean change the value in .dir-locals and save the file. >> 5. Re-open the .tex file and you will see fill-column has a value 78 >> NOT 75 > > How do you "re-open" it? Kill that buffer and open the file again using C-x C-f. > Stefan -- .: Leo :. [ sdl.web AT gmail.com ] .: I use Emacs :. From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Chong Yidong , 2833@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 02 Apr 2009 18:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.12386981499086 (code B ref 2833); Thu, 02 Apr 2009 18:55:05 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 2 Apr 2009 18:49:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n32In6tE009079 for <2833@emacsbugs.donarmstrong.com>; Thu, 2 Apr 2009 11:49:07 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 19ED657E21E; Thu, 2 Apr 2009 14:50:42 -0400 (EDT) From: Chong Yidong To: Tom Tromey Cc: 2833@debbugs.gnu.org Date: Thu, 02 Apr 2009 14:50:42 -0400 Message-ID: <87skkqzy7x.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I think there's a bug in directory variables code, that is, changing > the directory variables would require a restart of Emacs for them to > take effect. Tom, could you please take a shot at implementing this? It may be too late in the release to put this in 23.1 (depending on how complicated the change turns out to be), but this problem definitely needs fixing at some point. I guess this is what the following comment in files.el is referring to: (defun dir-locals-read-from-file (file) "Load a variables FILE and register a new class and instance. FILE is the name of the file holding the variables to apply. The new class name is the same as the directory in which FILE is found. Returns the new class name." (with-temp-buffer ;; We should probably store the modtime of FILE and then ;; reload it whenever it changes. (insert-file-contents file) From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: Re: 23.0.92; Bug in Directory Variables Reply-To: Chong Yidong , 2833@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 07 Apr 2009 04:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.12390786527758 (code B ref 2833); Tue, 07 Apr 2009 04:40:05 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 7 Apr 2009 04:30:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=RERE autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n374UnE4007751 for <2833@emacsbugs.donarmstrong.com>; Mon, 6 Apr 2009 21:30:50 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 8E44857E18A; Tue, 7 Apr 2009 00:32:29 -0400 (EDT) From: Chong Yidong To: emacs-devel@gnu.org Cc: 2833@debbugs.gnu.org Date: Tue, 07 Apr 2009 00:32:29 -0400 Message-ID: <87r605f5ia.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Could someone please take a stab at bug#2833? This should not be difficult, but I have no time for it at the moment. Basically, one needs to change dir-locals-read-from-file so that it records the modtime of each directory variables file, and dir-locals-find-file so that it checked if the cache is stale and refreshes it if necessary. (Tom Tromey, the author of the code, is not responding to email.) From cyd@stupidchicken.com Mon Apr 6 21:31:38 2009 Received: (at control) by emacsbugs.donarmstrong.com; 7 Apr 2009 04:31:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n374VaGx007785 for ; Mon, 6 Apr 2009 21:31:37 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7204957E18A; Tue, 7 Apr 2009 00:33:16 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 2833 serious Date: Tue, 07 Apr 2009 00:33:16 -0400 Message-ID: <87ocv9f5gz.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 2833 serious thanks From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Chong Yidong , 2833@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 03:05:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123924588627223 (code B ref 2833); Thu, 09 Apr 2009 03:05:06 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 02:58:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n392w26b027205 for <2833@emacsbugs.donarmstrong.com>; Wed, 8 Apr 2009 19:58:04 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id DAB5C57E247; Wed, 8 Apr 2009 22:59:44 -0400 (EDT) From: Chong Yidong To: emacs-devel@gnu.org Cc: 2833@debbugs.gnu.org Date: Wed, 08 Apr 2009 22:59:44 -0400 Message-ID: <87fxgicz1b.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii The following patch changes the directory local variables code so that the cache stores the file atime. Before using each cache entry, we check that against the file modtime. This is not an ideal time to make changes of this sort, but I think this problem (i.e., inability to detect changes in .dir-locals.el files) is quite a serious one. So please help me review this patch. *** trunk/lisp/files.el.~1.1044.~ 2009-04-08 10:42:40.000000000 -0400 --- trunk/lisp/files.el 2009-04-08 22:50:03.000000000 -0400 *************** *** 3187,3194 **** (defvar dir-locals-class-alist '() "Alist mapping class names (symbols) to variable lists.") ! (defvar dir-locals-directory-alist '() ! "Alist mapping directory roots to variable classes.") (defsubst dir-locals-get-class-variables (class) "Return the variable list for CLASS." --- 3187,3199 ---- (defvar dir-locals-class-alist '() "Alist mapping class names (symbols) to variable lists.") ! (defvar dir-locals-directory-cache '() ! "List of cached directory roots for directory-local variable files. ! Each element in this list has the form (DIR ATIME CLASS), where ! DIR is the name of the directory, ATIME is the time when this ! cache entry was created (as a floating point number, per ! `float-time'), and CLASS is the name of a project class (a ! symbol).") (defsubst dir-locals-get-class-variables (class) "Return the variable list for CLASS." *************** *** 3241,3247 **** (setq directory (file-name-as-directory (expand-file-name directory))) (unless (assq class dir-locals-class-alist) (error "No such class `%s'" (symbol-name class))) ! (push (cons directory class) dir-locals-directory-alist)) (defun dir-locals-set-class-variables (class variables) "Map the type CLASS to a list of variable settings. --- 3246,3252 ---- (setq directory (file-name-as-directory (expand-file-name directory))) (unless (assq class dir-locals-class-alist) (error "No such class `%s'" (symbol-name class))) ! (push (list directory (float-time) class) dir-locals-directory-cache)) (defun dir-locals-set-class-variables (class variables) "Map the type CLASS to a list of variable settings. *************** *** 3284,3295 **** across different environments and users.") (defun dir-locals-find-file (file) ! "Find the directory-local variables FILE. ! This searches upward in the directory tree. ! If a local variables file is found, the file name is returned. ! If the file is already registered, a cons from ! `dir-locals-directory-alist' is returned. ! Otherwise this returns nil." (setq file (expand-file-name file)) (let* ((dir-locals-file-name (if (eq system-type 'ms-dos) --- 3289,3304 ---- across different environments and users.") (defun dir-locals-find-file (file) ! "Find the directory-local variables for FILE. ! This searches upward in the directory tree from FILE. ! ! If the file is already registered and has not been modified since ! we added it to `dir-locals-directory-cache', this returns a cons ! cell of the form (DIRECTORY . CLASS), using the entry in ! `dir-locals-directory-cache'. ! Otherwise, if a local variables file is found, the file name is ! returned. ! Otherwise, this returns nil." (setq file (expand-file-name file)) (let* ((dir-locals-file-name (if (eq system-type 'ms-dos) *************** *** 3300,3318 **** ;; `locate-dominating-file' may have abbreviated the name. (when locals-file (setq locals-file (expand-file-name dir-locals-file-name locals-file))) ! (dolist (elt dir-locals-directory-alist) (when (and (eq t (compare-strings file nil (length (car elt)) (car elt) nil nil (memq system-type '(windows-nt cygwin ms-dos)))) (> (length (car elt)) (length (car dir-elt)))) (setq dir-elt elt))) ! (if (and locals-file dir-elt) ! (if (> (length (file-name-directory locals-file)) ! (length (car dir-elt))) ! locals-file ! dir-elt) ! (or locals-file dir-elt)))) (defun dir-locals-read-from-file (file) "Load a variables FILE and register a new class and instance. --- 3309,3338 ---- ;; `locate-dominating-file' may have abbreviated the name. (when locals-file (setq locals-file (expand-file-name dir-locals-file-name locals-file))) ! ;; Find the best cached value in `dir-locals-directory-cache'. ! (dolist (elt dir-locals-directory-cache) (when (and (eq t (compare-strings file nil (length (car elt)) (car elt) nil nil (memq system-type '(windows-nt cygwin ms-dos)))) (> (length (car elt)) (length (car dir-elt)))) (setq dir-elt elt))) ! (let ((use-cache (and dir-elt ! (or (null locals-file) ! (<= (length (file-name-directory locals-file)) ! (length (car dir-elt))))))) ! (if use-cache ! ;; Check the validity of the cache. ! (if (and (file-readable-p (car dir-elt)) ! (< (float-time (nth 5 (file-attributes (car dir-elt)))) ! (nth 1 dir-elt))) ! ;; This cache entry is OK. ! (cons (nth 0 dir-elt) (nth 2 dir-elt)) ! ;; This cache entry is invalid; clear it. ! (setq dir-locals-directory-cache ! (delq dir-elt dir-locals-directory-cache)) ! locals-file) ! locals-file)))) (defun dir-locals-read-from-file (file) "Load a variables FILE and register a new class and instance. From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: David De La Harpe Golden , 2833@debbugs.gnu.org Resent-From: David De La Harpe Golden Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 11:10:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123927499923072 (code B ref 2833); Thu, 09 Apr 2009 11:10:06 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 11:03:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from harpegolden.net (harpegolden.net [65.99.215.13]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39B3Ee6023064 for <2833@emacsbugs.donarmstrong.com>; Thu, 9 Apr 2009 04:03:15 -0700 Received: from [87.198.47.25] (87-198-47-25.ptr.magnet.ie [87.198.47.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "David De La Harpe Golden", Issuer "David De La Harpe Golden Personal CA rev 3" (verified OK)) by harpegolden.net (Postfix) with ESMTP id E2CD481E2; Thu, 9 Apr 2009 12:03:13 +0100 (IST) Message-ID: <49DDD5E4.2000500@harpegolden.net> Date: Thu, 09 Apr 2009 12:03:00 +0100 From: David De La Harpe Golden User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Chong Yidong CC: emacs-devel@gnu.org, 2833@debbugs.gnu.org References: <87fxgicz1b.fsf@cyd.mit.edu> In-Reply-To: <87fxgicz1b.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Chong Yidong wrote: > The following patch changes the directory local variables code so that > the cache stores the file atime. Before using each cache entry, we > check that against the file modtime. > > This is not an ideal time to make changes of this sort, but I think this > problem (i.e., inability to detect changes in .dir-locals.el files) is > quite a serious one. So please help me review this patch. > I suspect the systems where a problem with the patch will be most noticeable will be windoze, since there's an extra file attributes call? I have a suspicion you almost might as well abandon the caching given the scary timings we've seen for that in the past. I could be wrong though. From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Leo , 2833@debbugs.gnu.org Resent-From: Leo Original-Sender: news Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 11:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.1239276726750 (code B ref -1); Thu, 09 Apr 2009 11:35:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Apr 2009 11:32:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39BW1fK000734 for ; Thu, 9 Apr 2009 04:32:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrsUD-0006W9-F3 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:32:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrsU8-0006RS-J7 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:32:00 -0400 Received: from [199.232.76.173] (port=38074 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrsU8-0006R8-Bj for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:31:56 -0400 Received: from main.gmane.org ([80.91.229.2]:39830 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrsU8-00077b-0J for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 07:31:56 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LrsTw-0002ra-TS for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 11:31:45 +0000 Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 09 Apr 2009 11:31:44 +0000 Received: from sdl.web by smaug.linux.pwf.cam.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 09 Apr 2009 11:31:44 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Date: Thu, 09 Apr 2009 12:31:34 +0100 Organization: University of Cambridge Lines: 24 Message-ID: References: <87fxgicz1b.fsf__3338.94516011259$1239247537$gmane$org@cyd.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: smaug.linux.pwf.cam.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:6hflOOSLc58kAcAkjIL0j4lOCBM= Sender: news X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) On 2009-04-09 03:59 +0100, Chong Yidong wrote: > The following patch changes the directory local variables code so that > the cache stores the file atime. Before using each cache entry, we > check that against the file modtime. > > This is not an ideal time to make changes of this sort, but I think this > problem (i.e., inability to detect changes in .dir-locals.el files) is > quite a serious one. So please help me review this patch. Hi Yidong, Thank you for working on this. Why not put the change in CVS so that anybody who uses it can test it? Best wishes, Leo -- .: Leo :. [ sdl.web AT gmail.com ] .: I use Emacs :. www.git-scm.com git - the one true version control system From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Stefan Monnier , 2833@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 14:35:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123928725228182 (code B ref 2833); Thu, 09 Apr 2009 14:35:06 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 14:27:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.6 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD, MURPHY_DRUGS_REL8,XIRONPORT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39ERSAr028167 for <2833@emacsbugs.donarmstrong.com>; Thu, 9 Apr 2009 07:27:29 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar4FAJOi3UlMCqib/2dsb2JhbACBUs00g3sGhRE X-IronPort-AV: E=Sophos;i="4.40,160,1238990400"; d="scan'208";a="36825206" Received: from 76-10-168-155.dsl.teksavvy.com (HELO pastel.home) ([76.10.168.155]) by ironport2-out.teksavvy.com with ESMTP; 09 Apr 2009 10:27:22 -0400 Received: by pastel.home (Postfix, from userid 20848) id 537A6804C; Thu, 9 Apr 2009 10:27:22 -0400 (EDT) From: Stefan Monnier To: Chong Yidong Cc: 2833@debbugs.gnu.org Message-ID: References: <87fxgicz1b.fsf@cyd.mit.edu> Date: Thu, 09 Apr 2009 10:27:22 -0400 In-Reply-To: <87fxgicz1b.fsf@cyd.mit.edu> (Chong Yidong's message of "Wed, 08 Apr 2009 22:59:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > The following patch changes the directory local variables code so that > the cache stores the file atime. Before using each cache entry, we > check that against the file modtime. I'm not sure this is the right thing to do: - We don't know that the (float-time) is in sync with the filesystem's time, so the check may not work right. Better check the file's current mtime against the file's mtime when it was last read. - the variable you changed could previously be setq in the .emacs, whereas you changed it into an internal var. FWIW, here's the patch I was working on instead. Stefan --- files.el.~1.1044.~ 2009-04-08 20:09:55.000000000 -0400 +++ files.el 2009-04-09 10:24:53.000000000 -0400 @@ -3314,21 +3314,31 @@ dir-elt) (or locals-file dir-elt)))) +(defvar dir-locals--file-cache nil + "Cache of dir-locals files's contents.") + (defun dir-locals-read-from-file (file) "Load a variables FILE and register a new class and instance. FILE is the name of the file holding the variables to apply. The new class name is the same as the directory in which FILE is found. Returns the new class name." + (let ((mtime (nth 5 (file-attributes file))) + (cache (assoc file dir-locals--file-cache))) + (unless (equal (nth 1 cache) mtime) + (setq dir-locals--file-cache (delq cache dir-locals--file-cache)) + (setq cache nil)) + (if cache + (nth 2 cache) + (let ((val (with-temp-buffer - ;; We should probably store the modtime of FILE and then - ;; reload it whenever it changes. (insert-file-contents file) (let* ((dir-name (file-name-directory file)) (class-name (intern dir-name)) (variables (read (current-buffer)))) (dir-locals-set-class-variables class-name variables) - (dir-locals-set-directory-class dir-name class-name) - class-name))) + class-name)))) + (push (list file mtime val) dir-locals--file-cache) + val)))) (declare-function c-postprocess-file-styles "cc-mode" ()) From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Chong Yidong , 2833@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 15:25:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123929031412619 (code B ref 2833); Thu, 09 Apr 2009 15:25:06 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 15:18:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39FIVfB012608 for <2833@emacsbugs.donarmstrong.com>; Thu, 9 Apr 2009 08:18:32 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 76EF157E24C; Thu, 9 Apr 2009 11:20:13 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Cc: 2833@debbugs.gnu.org References: <87fxgicz1b.fsf@cyd.mit.edu> Date: Thu, 09 Apr 2009 11:20:13 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 09 Apr 2009 10:27:22 -0400") Message-ID: <87eiw1vope.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier writes: > - We don't know that the (float-time) is in sync with the filesystem's > time, so the check may not work right. Better check the file's > current mtime against the file's mtime when it was last read. Yes, good point. > - the variable you changed could previously be setq in the .emacs, > whereas you changed it into an internal var. It was always a defvar instead of a defcustom. I don't think it makes sense for it to be user-customizable. > FWIW, here's the patch I was working on instead. Is this patch complete? By the time dir-locals-read-from-file is called, hack-dir-local-variables has already decided that there is no cached value. Conversely, if there is a cached value, it will be used without calling dir-locals-read-from-file. So we need to change dir-locals-find-file as well (which is what my patch did). From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Chong Yidong , 2833@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 11 Apr 2009 15:40:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123946380730071 (code B ref 2833); Sat, 11 Apr 2009 15:40:08 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 11 Apr 2009 15:30:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3BFU4WZ029852 for <2833@emacsbugs.donarmstrong.com>; Sat, 11 Apr 2009 08:30:05 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 3195A57E21E; Sat, 11 Apr 2009 11:31:48 -0400 (EDT) From: Chong Yidong To: Leo Cc: 2833@debbugs.gnu.org Date: Sat, 11 Apr 2009 11:31:48 -0400 Message-ID: <87ws9rtdej.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've checked the patch into CVS, with the change suggested by Stefan (comparing the file mtime directly instead of comparing it to the system time). Does it solve the problem for you? From unknown Sat Jun 21 03:14:34 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2833: 23.0.92; Bug in Directory Variables Reply-To: Leo , 2833@debbugs.gnu.org Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 12 Apr 2009 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123954255216788 (code B ref 2833); Sun, 12 Apr 2009 13:30:03 +0000 Received: (at 2833) by emacsbugs.donarmstrong.com; 12 Apr 2009 13:22:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-5.csi.cam.ac.uk (ppsw-5.csi.cam.ac.uk [131.111.8.135]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3CDMO9H016769 for <2833@emacsbugs.donarmstrong.com>; Sun, 12 Apr 2009 06:22:25 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:60267) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES256-SHA:256) id 1Lszdf-0001eQ-GW (Exim 4.70) (return-path ); Sun, 12 Apr 2009 14:22:23 +0100 From: Leo To: Chong Yidong Cc: 2833@debbugs.gnu.org References: <87ws9rtdej.fsf@cyd.mit.edu> Date: Sun, 12 Apr 2009 14:22:22 +0100 In-Reply-To: <87ws9rtdej.fsf@cyd.mit.edu> (Chong Yidong's message of "Sat, 11 Apr 2009 11:31:48 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-04-11 16:31 +0100, Chong Yidong wrote: > I've checked the patch into CVS, with the change suggested by Stefan > (comparing the file mtime directly instead of comparing it to the system > time). > > Does it solve the problem for you? It worked perfectly. Many thanks. -- .: Leo :. [ sdl.web AT gmail.com ] .: I use Emacs :. www.git-scm.com git - the one true version control system From cyd@stupidchicken.com Sun Apr 12 08:20:51 2009 Received: (at control) by emacsbugs.donarmstrong.com; 12 Apr 2009 15:20:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3CFKimc017348 for ; Sun, 12 Apr 2009 08:20:45 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 933C857E21A; Sun, 12 Apr 2009 11:22:29 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 2833 Date: Sun, 12 Apr 2009 11:22:29 -0400 Message-ID: <87skkd6gne.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii close 2833 thanks