From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 05:11:52 2017 Received: (at submit) by debbugs.gnu.org; 2 Sep 2017 09:11:52 +0000 Received: from localhost ([127.0.0.1]:41383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do4Sw-00047L-PI for submit@debbugs.gnu.org; Sat, 02 Sep 2017 05:11:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do4Sv-000476-E5 for submit@debbugs.gnu.org; Sat, 02 Sep 2017 05:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do4Sl-0002ep-Kx for submit@debbugs.gnu.org; Sat, 02 Sep 2017 05:11:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1do4Sl-0002ea-Gv for submit@debbugs.gnu.org; Sat, 02 Sep 2017 05:11:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do4Sg-0006Wf-Lp for guix-patches@gnu.org; Sat, 02 Sep 2017 05:11:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do4Sb-0002Zs-IV for guix-patches@gnu.org; Sat, 02 Sep 2017 05:11:30 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do4Sb-0002Zm-F6; Sat, 02 Sep 2017 05:11:25 -0400 Received: from peder.onsbrabantnet.nl ([88.159.206.46]:39318 helo=localhost.localdomain) by fencepost.gnu.org with esmtpa (Exim 4.82) (envelope-from ) id 1do4SX-0001lx-KO; Sat, 02 Sep 2017 05:11:23 -0400 From: Jan Nieuwenhuizen To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-bash-completion. Date: Sat, 2 Sep 2017 11:11:12 +0200 Message-Id: <20170902091112.1336-1-janneke@gnu.org> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --- gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 612126eb3..f6165ba54 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -59,6 +59,7 @@ #:use-module (guix build-system trivial) #:use-module (gnu packages) #:use-module (gnu packages audio) + #:use-module (gnu packages bash) #:use-module (gnu packages code) #:use-module (gnu packages guile) #:use-module (gnu packages gtk) @@ -5444,3 +5445,27 @@ key. Optionally, a mouse pop-up can be added by binding version of Idris, and some features may rely on the latest Git version of Idris.") (license license:gpl3+))) + +(define-public emacs-batch-completion + (package + (name "emacs-bash-completion") + (version "20170901.1445") + (source + (origin + (method url-fetch) + (uri (string-append + "http://melpa.org/packages/bash-completion-" + version + ".tar")) + (sha256 + (base32 + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr")))) + (native-inputs `(("bash" ,bash))) + (build-system emacs-build-system) + (home-page "https://github.com/szermatt/emacs-bash-completion") + (synopsis "BASH completion for the shell buffer") + (description + "@code{bash-completion} defines dynamic completion hooks for shell-mode +and shell-command prompts that are based on bash completion. +") + (license license:gpl3+))) -- Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 05:15:35 2017 Received: (at 28327) by debbugs.gnu.org; 2 Sep 2017 09:15:36 +0000 Received: from localhost ([127.0.0.1]:41394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do4WY-0004DH-Pe for submit@debbugs.gnu.org; Sat, 02 Sep 2017 05:15:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do4WX-0004D6-Dc for 28327@debbugs.gnu.org; Sat, 02 Sep 2017 05:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do4WN-0004oG-GA for 28327@debbugs.gnu.org; Sat, 02 Sep 2017 05:15:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do4WF-0004f6-9l; Sat, 02 Sep 2017 05:15:11 -0400 Received: from peder.onsbrabantnet.nl ([88.159.206.46]:39320 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1do4WE-0007gR-EN; Sat, 02 Sep 2017 05:15:10 -0400 From: Jan Nieuwenhuizen To: 28327@debbugs.gnu.org Subject: Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. Organization: AvatarAcademy.nl References: <20170902091112.1336-1-janneke@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sat, 02 Sep 2017 11:15:08 +0200 In-Reply-To: <20170902091112.1336-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 2 Sep 2017 11:11:12 +0200") Message-ID: <87lglxxy03.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28327 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Jan Nieuwenhuizen writes: > --- > gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 612126eb3..f6165ba54 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -59,6 +59,7 @@ > #:use-module (guix build-system trivial) > #:use-module (gnu packages) > #:use-module (gnu packages audio) > + #:use-module (gnu packages bash) > #:use-module (gnu packages code) > #:use-module (gnu packages guile) > #:use-module (gnu packages gtk) > @@ -5444,3 +5445,27 @@ key. Optionally, a mouse pop-up can be added by b= inding > version of Idris, and some features may rely on the latest Git version of > Idris.") > (license license:gpl3+))) > + > +(define-public emacs-batch-completion Oops, I really meant to type `emacs-bash-completion' here. > + (package > + (name "emacs-bash-completion") > + (version "20170901.1445") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://melpa.org/packages/bash-completion-" > + version > + ".tar")) > + (sha256 > + (base32 > + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr")))) > + (native-inputs `(("bash" ,bash))) > + (build-system emacs-build-system) > + (home-page "https://github.com/szermatt/emacs-bash-completion") > + (synopsis "BASH completion for the shell buffer") > + (description > + "@code{bash-completion} defines dynamic completion hooks for shell-= mode > +and shell-command prompts that are based on bash completion. > +") > + (license license:gpl3+))) --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 14:48:42 2017 Received: (at 28327) by debbugs.gnu.org; 4 Sep 2017 18:48:42 +0000 Received: from localhost ([127.0.0.1]:49254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dowQL-0001vd-Ub for submit@debbugs.gnu.org; Mon, 04 Sep 2017 14:48:42 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:38040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dowQK-0001vQ-LR for 28327@debbugs.gnu.org; Mon, 04 Sep 2017 14:48:41 -0400 Received: by mail-lf0-f54.google.com with SMTP id q132so4222830lfe.5 for <28327@debbugs.gnu.org>; Mon, 04 Sep 2017 11:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5w7qUN02sXNexRe8Bf8rKbrVEZv9j29BcocgNQ5xrqc=; b=dCrU9PZhPSLc/c+T3+33EUOTK+dY9zFEe0cD9FbIj7yFhk1ts9iO1mXpLRwYIX2Au3 dj0mjv6+VFQ+vGofK4kEdO2yA4wjXiVgg0xUYXn/vLNjlehjPUEwol71nD5YjobdgIgC 86ugWLJFpAo7MJOz+gffcHce5m69ucsAtdDmKT2zlWSjmp0SVfGjur6FidJfEzdbZLfy tKwy/qj0M+CGX8uJR3iX7K6Nz7IfwV2pl7t0al7ab5ZvwCKcJXWWKtyzypZmXqyE0W8g VyouwQ4dZ03i55crh7T5iql6bXmfx1fzbiQSf3Lkc+tXXbmT8qlWZhG14ntps/8mcWc1 dkJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5w7qUN02sXNexRe8Bf8rKbrVEZv9j29BcocgNQ5xrqc=; b=FygahGhVrEgZXe0hqSWbZ855Kz1jO44kIjJuVuBSO0Jt2Qs3rQJr5ZJHgJY9+QQC7E CF9UmQfkBb3JJDDKf2pknLkXUzOy9tYAlydmgAoriuEu+duFclnl4OVV/z3kjMS3iLV8 BTH9mUeT7K66Y/hRFJl7O3SEFbSRWaIUSn97tGYRGN6lvKS7zZgqjVH0sVsUBuY/jnJr i4GhvUNKOZ3/hU8W9k/RTzz+z9Ea4kRF7d39ZDdc6f9LAOAJoopBnXVDUxLAfQMMSlAA 6EmJZobaCAopba9EUNgsFkXXVh4WBBAkX+v7EOsNIJSFDugulxuDxjVm0SSjIk+es2gG duwg== X-Gm-Message-State: AHPjjUjF//GFHqOB+G/aJgIIguzR+1GYKeJwxJQqgM0q9SczQifz4hU4 5cqBF72tzBahDJqm X-Google-Smtp-Source: ADKCNb4fOg+pnkyjnl+3G4yi2GT1kn7bx5dC/m0zlBMDjBGABFvy4fMezPSjKCPqiPSytWmN5M6jug== X-Received: by 10.46.33.202 with SMTP id h71mr476351lji.56.1504550914466; Mon, 04 Sep 2017 11:48:34 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id u83sm1357399lff.47.2017.09.04.11.48.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Sep 2017 11:48:33 -0700 (PDT) From: Alex Kost To: Jan Nieuwenhuizen Subject: Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. References: <20170902091112.1336-1-janneke@gnu.org> Date: Mon, 04 Sep 2017 21:48:42 +0300 In-Reply-To: <20170902091112.1336-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 2 Sep 2017 11:11:12 +0200") Message-ID: <87r2vmwb91.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28327 Cc: 28327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Jan Nieuwenhuizen (2017-09-02 11:11 +0200) wrote: > --- > gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 612126eb3..f6165ba54 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -59,6 +59,7 @@ > #:use-module (guix build-system trivial) > #:use-module (gnu packages) > #:use-module (gnu packages audio) > + #:use-module (gnu packages bash) > #:use-module (gnu packages code) > #:use-module (gnu packages guile) > #:use-module (gnu packages gtk) > @@ -5444,3 +5445,27 @@ key. Optionally, a mouse pop-up can be added by b= inding > version of Idris, and some features may rely on the latest Git version of > Idris.") > (license license:gpl3+))) > + > +(define-public emacs-batch-completion > + (package > + (name "emacs-bash-completion") > + (version "20170901.1445") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://melpa.org/packages/bash-completion-" Please use the source directly from the upstream, i.e.: https://github.com/szermatt/emacs-bash-completion/archive/v2.0.0.tar.gz There is a problem with MELPA: when there will be a new commit in the repo, the new melpa tarball will be generated and the previous one ("20170901.1445") will be *removed*, so this package will lose its source. > + version > + ".tar")) I wouldn't leave =E2=80=98version=E2=80=99 and =E2=80=98".tar"=E2=80=99 on = separate lines, but it's a matter of taste :-) > + (sha256 > + (base32 > + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr")))) > + (native-inputs `(("bash" ,bash))) You probably meant to make this package call this "bash" (btw it should be 'input', not 'native-input') from store, but this is not enough. You also need to patch 'bash-completion-prog' variable using 'emacs-substitute-variables' procedure (see (gnu packages emacs) module for the examples). > + (build-system emacs-build-system) > + (home-page "https://github.com/szermatt/emacs-bash-completion") > + (synopsis "BASH completion for the shell buffer") > + (description > + "@code{bash-completion} defines dynamic completion hooks for shell-= mode > +and shell-command prompts that are based on bash completion. > +") Please put this quote and parenthesis to the previous line. > + (license license:gpl3+))) I see GPL 2 or later in "bash-completion.el". --=20 Alex From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 13:53:25 2017 Received: (at 28327) by debbugs.gnu.org; 6 Sep 2017 17:53:25 +0000 Received: from localhost ([127.0.0.1]:53308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpeVq-0007tt-C1 for submit@debbugs.gnu.org; Wed, 06 Sep 2017 13:53:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpeVo-0007tg-Ml for 28327@debbugs.gnu.org; Wed, 06 Sep 2017 13:53:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpeVf-0000HX-Fw for 28327@debbugs.gnu.org; Wed, 06 Sep 2017 13:53:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpeVT-0008Mi-Ih; Wed, 06 Sep 2017 13:52:55 -0400 Received: from peder.onsbrabantnet.nl ([88.159.206.46]:56154 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpeVT-0008LF-1g; Wed, 06 Sep 2017 13:52:55 -0400 From: Jan Nieuwenhuizen To: Alex Kost Subject: Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. Organization: AvatarAcademy.nl References: <20170902091112.1336-1-janneke@gnu.org> <87r2vmwb91.fsf@gmail.com> X-Url: http://AvatarAcademy.nl Date: Wed, 06 Sep 2017 19:52:51 +0200 In-Reply-To: <87r2vmwb91.fsf@gmail.com> (Alex Kost's message of "Mon, 04 Sep 2017 21:48:42 +0300") Message-ID: <877exb90jw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28327 Cc: 28327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Kost writes: > Jan Nieuwenhuizen (2017-09-02 11:11 +0200) wrote: > >> --- >> gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) > Please use the source directly from the upstream, i.e.: > > https://github.com/szermatt/emacs-bash-completion/archive/v2.0.0.tar.gz Ok! > There is a problem with MELPA: when there will be a new commit in the > repo, the new melpa tarball will be generated and the previous one > ("20170901.1445") will be *removed*, so this package will lose its > source. Ugh...how reproducible! I didn't know (or investigate...), thanks for the explanation. >> + version >> + ".tar")) > > I wouldn't leave =E2=80=98version=E2=80=99 and =E2=80=98".tar"=E2=80=99 o= n separate lines, but it's a > matter of taste :-) I like your suggestion. >> + (sha256 >> + (base32 >> + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr")))) >> + (native-inputs `(("bash" ,bash))) > > You probably meant to make this package call this "bash" (btw it should > be 'input', not 'native-input') from store, but this is not enough. Indeed. It took me quite a while of debugging until I finally stumbled upon bash-minimal. Google had a very hard time telling me how complete or compgen could not exist. > You also need to patch 'bash-completion-prog' variable using > 'emacs-substitute-variables' procedure (see (gnu packages emacs) > module for the examples). I have added something here and built package works and looks okay... Because adding bash to (native-)inputs already made that 'emacs-substitute-variables' is set to bash instead of bash-minimal, I don't really know how to test it. >> + (build-system emacs-build-system) >> + (home-page "https://github.com/szermatt/emacs-bash-completion") >> + (synopsis "BASH completion for the shell buffer") >> + (description >> + "@code{bash-completion} defines dynamic completion hooks for shell= -mode >> +and shell-command prompts that are based on bash completion. >> +") > > Please put this quote and parenthesis to the previous line. Ok. >> + (license license:gpl3+))) > > I see GPL 2 or later in "bash-completion.el". I used guix import elpa --archive=3Dmelpa and didn't check. It seems we cannot rely on that! New version attached, still 13 of the 30 lines were unchanged, wow...thanks for all your helpful remarks! Greetings, janneke --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-emacs-bash-completion.patch Content-Transfer-Encoding: quoted-printable >From 14649caae21669adcc495b109b8d328f5b71c2e9 Mon Sep 17 00:00:00 2001 From: Jan Nieuwenhuizen Date: Sat, 2 Sep 2017 10:54:14 +0200 Subject: [PATCH] gnu: Add emacs-bash-completion. * gnu/packages/emacs.scm (emacs-bash-completion): New variable. --- gnu/packages/emacs.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 9c0f9bc89..a4157a3db 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -59,6 +59,7 @@ #:use-module (guix build-system trivial) #:use-module (gnu packages) #:use-module (gnu packages audio) + #:use-module (gnu packages bash) #:use-module (gnu packages code) #:use-module (gnu packages guile) #:use-module (gnu packages gtk) @@ -5575,3 +5576,35 @@ It is meant to quickly generate linear ranges, e.g. = 5, 6, 7, 8. Some elisp proficiency is an advantage, since you can transform your numeric range wi= th an elisp expression.") (license license:gpl3+))) + +(define-public emacs-bash-completion + (package + (name "emacs-bash-completion") + (version "2.0.0") + (source + (origin + (method url-fetch) + (uri (string-append + "https://github.com/szermatt/emacs-bash-completion/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "0mkci4a1fy8z4cmry8mx5vsx4f16a8r454slnh7lqzidnhfi63hj")))) + (inputs `(("bash" ,bash))) + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'install 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((bash (assoc-ref inputs "bash"))) + (emacs-substitute-variables "bash-completion.el" + ("bash-completion-prog" (string-append bash "/bin/bash"))= )) + #t))))) + (home-page "https://github.com/szermatt/emacs-bash-completion") + (synopsis "BASH completion for the shell buffer") + (description + "@code{bash-completion} defines dynamic completion hooks for shell-mode +and shell-command prompts that are based on bash completion.") + (license license:gpl2+))) --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 15:44:12 2017 Received: (at 28327) by debbugs.gnu.org; 9 Sep 2017 19:44:12 +0000 Received: from localhost ([127.0.0.1]:57906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqlfo-0005r2-JL for submit@debbugs.gnu.org; Sat, 09 Sep 2017 15:44:12 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqlfm-0005qp-Ls for 28327@debbugs.gnu.org; Sat, 09 Sep 2017 15:44:11 -0400 Received: by mail-wr0-f194.google.com with SMTP id u48so2624566wrf.4 for <28327@debbugs.gnu.org>; Sat, 09 Sep 2017 12:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LwgJUbJ7QZYPWZyIThd7YOQMHgT5bdgs8aXkry8ILsw=; b=nb6FFFyXG6jAT4KPDU6138aSZJ0r72ZVxJTtnKN0feB8FKwmFUtm3Usb8GkCMXfrUa HPLLEdHEqShhBSB9LeQljt/n9tN247mKWqY9dtai7WWFIPPicHnlG0AW62YxoGOLOIgV lVi1Yz1QfJ0m8+RXSWW07OlQabmDOK/0mYgcDtH8jcMO5J546yAsCxi+CDTcTIqg/Vk6 qLJTCvN0b7J+RSZvnO3iwMHMZbCtJ45ldxFGN0Ee6+Q/GZyaWPG0NL5oVofpyAn0YRqG 2K5dM5DmZ8d/dOyBZzrh/LM/gik5sJfxOt/TcdR5sqxRIGqj8NveZ4a1wpqSW63Rrg4n H9Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LwgJUbJ7QZYPWZyIThd7YOQMHgT5bdgs8aXkry8ILsw=; b=ZEc8i0MYlw3Kiozos0tUD1Nd6xtqCQMiEwLmw9VQ7RvEtLNVVeXlXX7cGq8pOw5lqw YnAhNhtDuYtv5MpmCza+YWwJkF/IZ4BFxfUywhikVuT5gkSFSBsziUc7/E2N2PVbSw3w Tldmbs6y1eOBpnNqm7DiAiDPxeWiZPPaT0rPDpDZ52tgMsVQDkPIZDe1kGayRRY71fQ1 aTFiUeV364bkXxtxMNNUT1lwj8+IBY2KSZlmEeanmDcYUzgGalWrFook4HDRlfpwa5On jGofO0qyHUvJrw9swKYCxvebWLUnccOL8oQlgBd5a5ZM6B+9cP1A/MucXaoGZBG6zpD3 3ZGQ== X-Gm-Message-State: AHPjjUjwVcSy1wjFxMO4drSiIspyt6M0MI/rhruGvxIt8EpuRu7nzXwC Cm86ZgABRps2nFkN X-Google-Smtp-Source: ADKCNb7MUPIpSOeNSKIejyZlGi+0q8hN+yNW+4coh3wwMnRbILAJhq0bJC20P3pgSHNqpdSPcVxhew== X-Received: by 10.223.173.204 with SMTP id w70mr5219629wrc.281.1504986244421; Sat, 09 Sep 2017 12:44:04 -0700 (PDT) Received: from leviafan ([217.107.194.134]) by smtp.gmail.com with ESMTPSA id v82sm6645826wmd.44.2017.09.09.12.44.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Sep 2017 12:44:03 -0700 (PDT) From: Alex Kost To: Jan Nieuwenhuizen Subject: Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. References: <20170902091112.1336-1-janneke@gnu.org> <87r2vmwb91.fsf@gmail.com> <877exb90jw.fsf@gnu.org> Date: Sat, 09 Sep 2017 22:44:17 +0300 In-Reply-To: <877exb90jw.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 06 Sep 2017 19:52:51 +0200") Message-ID: <87fubvslm6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 28327 Cc: 28327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Jan Nieuwenhuizen (2017-09-06 19:52 +0200) wrote: > Alex Kost writes: [...] >> You also need to patch 'bash-completion-prog' variable using >> 'emacs-substitute-variables' procedure (see (gnu packages emacs) >> module for the examples). > > I have added something here and built package works and looks okay... Now it looks OK for me as well :-) > Because adding bash to (native-)inputs already made that > 'emacs-substitute-variables' is set to bash instead of bash-minimal, I > don't really know how to test it. I see that with your patch, 'bash-completion-prog' has the value "/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash' ('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name). [...] >>> + (license license:gpl3+))) >> >> I see GPL 2 or later in "bash-completion.el". > > I used guix import elpa --archive=melpa and didn't check. It seems we > cannot rely on that! We definitely shouldn't rely on it, as the importer always puts 'gpl3+': http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234 > New version attached, still 13 of the 30 lines were unchanged, > wow...thanks for all your helpful remarks! The patch looks good for me, thank you! -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 16:45:57 2017 Received: (at 28327-done) by debbugs.gnu.org; 10 Sep 2017 20:45:57 +0000 Received: from localhost ([127.0.0.1]:59791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr976-0000sx-Oj for submit@debbugs.gnu.org; Sun, 10 Sep 2017 16:45:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr975-0000sl-MD for 28327-done@debbugs.gnu.org; Sun, 10 Sep 2017 16:45:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr96x-0002sP-Fe for 28327-done@debbugs.gnu.org; Sun, 10 Sep 2017 16:45:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr96k-0002m1-8U; Sun, 10 Sep 2017 16:45:34 -0400 Received: from peder.onsbrabantnet.nl ([88.159.206.46]:42380 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dr96j-0001ZF-FQ; Sun, 10 Sep 2017 16:45:33 -0400 From: Jan Nieuwenhuizen To: Alex Kost Subject: Re: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. Organization: AvatarAcademy.nl References: <20170902091112.1336-1-janneke@gnu.org> <87r2vmwb91.fsf@gmail.com> <877exb90jw.fsf@gnu.org> <87fubvslm6.fsf@gmail.com> X-Url: http://AvatarAcademy.nl Date: Sun, 10 Sep 2017 22:45:31 +0200 In-Reply-To: <87fubvslm6.fsf@gmail.com> (Alex Kost's message of "Sat, 09 Sep 2017 22:44:17 +0300") Message-ID: <87tw0a5llg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28327-done Cc: 28327-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Kost writes: >> I have added something here and built package works and looks okay... > > Now it looks OK for me as well :-) Good! > I see that with your patch, 'bash-completion-prog' has the value > "/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash' > ('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name). Also good, thanks for checking. >> I used guix import elpa --archive=3Dmelpa and didn't check. It seems we >> cannot rely on that! > > We definitely shouldn't rely on it, as the importer always puts 'gpl3+': > > http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234 Great! > The patch looks good for me, thank you! Pushed to master as 4aafce22ab74007c69aecc474816d83e64d22646 janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From unknown Tue Aug 19 07:28:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator