From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 15:06:31 2017 Received: (at submit) by debbugs.gnu.org; 31 Aug 2017 19:06:31 +0000 Received: from localhost ([127.0.0.1]:38016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnUnP-0008Fa-6h for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:06:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnUnN-0008FN-1n for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:06:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnUnG-00033c-6f for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:06:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnUnG-00033Y-3L for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:06:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnUnD-0006Ix-Uf for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnUnB-00032o-MD for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:06:19 -0400 Received: from mail-ua0-x234.google.com ([2607:f8b0:400c:c08::234]:33906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnUnB-00032Y-Ev for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:06:17 -0400 Received: by mail-ua0-x234.google.com with SMTP id l11so1656503uaf.1 for ; Thu, 31 Aug 2017 12:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=d+BE/7lWpx1bOfjrOyl3ZGp8BIaKjqTt31kqjHNevFE=; b=ADNxSVbnl7THKAXSl+Mi5tLls0SYgLrL6aWS+yP8Kwbb6YAnIXCgM54pgDuJ+2WcwZ AxDIU/kKigZXzH5j1KJyDxh9niatWMGHt6388vJHZZU5DibddkhZehe7POZFrktBSgZw t1mW5C80e1QGrGBr+yIMkQEW4uCl0w9IcWSa+mqFGq6SRkWAU26I2kCU45WOKhsqUd9F 0OhCKMVZqvbFrp/4VLwwrCD3qTp1bIH8l1+o/p5b6mlEx5pP1csj72gljtCoCToFBuKE iBt0Nhwjk3IwOJguyQwPwyz+TizuEZlh2AX977xCyXfIXnILnXibjxd//ukYdf2EhyL6 ioIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=d+BE/7lWpx1bOfjrOyl3ZGp8BIaKjqTt31kqjHNevFE=; b=LlVSBU5Izt+pi7djgrykm3kLbKOqgwXrUTrkaIzkF6aaLwYK1Wkn3LOZN0LFLAjGqr p3PhJ0qUBZlTPbIrGaZ8143FBZsfwTuq8X8dxzgumDiTXLufGRtkLaOtxhiHLVBqvcjb 64kL+brlZBDo1UCJAfMuvmy88U64bO3x8phT2Mk87/Wt65opXfvFdKDAVTqw8Cp5IgAJ a0JwrysrPUbGwFFHkFnuG8/3zXj3RDzXh7MYLc3KeGZUs/TNfPOhBhlBL1/w4SKvllA8 vliFn9C4ioYt8/MK32tFFRNZIuwjUnmJTcPthe5Jp1aoPMBy9pcxYYzWY9I8OFfP5VBV /91Q== X-Gm-Message-State: AHYfb5gSHRO3NMRiX/OxR4rWETaVUy2DOsvVlDQJCNf3eeMRr18kvI7O jxZdZ4ZN2g3kYo3ZXhP1IKUqMEBOB/fK X-Google-Smtp-Source: ADKCNb6WpLwprUw1xG/qh22XCqahxq37S72R00mGIEs1SH+kuzTjqKM7b9ez871zMR+Jr+U0NMbrqRtazStp2Ddsl9g= X-Received: by 10.176.78.157 with SMTP id l29mr3925341uah.2.1504206375345; Thu, 31 Aug 2017 12:06:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.171.202 with HTTP; Thu, 31 Aug 2017 12:06:14 -0700 (PDT) From: Anders Lindgren Date: Thu, 31 Aug 2017 21:06:14 +0200 Message-ID: Subject: 25.2; Improve syntax highlighting in bat-mode To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="f403043ed118abead9055811561c" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --f403043ed118abead9055811561c Content-Type: text/plain; charset="UTF-8" Hi! I've noticed some problems with syntax highlighting in bat-mode. In addition, I have two improvement suggestions. Problem 1: bat-mode highlights variables surrounded by "%":s, as in "%alpha%". However, when the variable contains an underscore, as in "%alpha_beta%", only "alpha" is highlighted. Problem 2: Similarly, bat-mode highlights variables defined using "set". As with problem 1 above, it does not handle words with underscore. Concretely, in "set alpha_beta=value", only "alpha" is highlighted. Problem 3: bat-mode highlights keywords like "in". Unfortunately, it also highlights the word "in" when used as a file extension. For example "xxx alpha.in". Improvement suggestion 1: In bat scripts, the command "echo" can be used to print strings to the console. Unlike in shell scripts, the argument to "echo" does not require quotes. It would be nice if Emacs would highlight anything after "echo" as a string (using font-lock-string-face). Improvement suggestion 2: In bat scripts, variable substitution is performed inside quoted strings, for example: xxx "hello %alpha goodbye" Unfortunately, emacs does not highlight this, which I hereby propose that it should. I had plans to fix all of the above myself. Unfortunately, my Emacs todo-list is too long for my available time, so Richard S. suggested that I report this here, in case someone else would have more time than I do. Anyway, problem 1 and 2 can probably be fixed by adapting a regexp. Problem 3 should easily be fixed by using a custom font-lock syntax table, where "." is seen as a word character, or possibly a symbol character. Improvement suggestion 1 could probably be handled by a simple rule matching echo + space + whatever and highlight "whatever" using font-lock-string-face. All of these are easy to fix. Improvement suggestion 2 raises the bar to "medium", as it would require replacing the current rexexp rule with one written in elisp. The rule will need to use the "prepend" (not "t") override flag to add font-lock-variable-name-face to the variable name in top of the string face. However, the code must ensure that it does not do this for comments. Side note: Typically, the "prepend" override flag is preferred over "t", as the end result will mix face properties from both the new and old faces. Concretely, I use a string face with a red foreground and a grey background. With the "prepend" flag, the variable name will be drawn using yellow from font-lock-variable-name-face but the background will still be grey, matching the rest of the string. -- Anders Lindgren In GNU Emacs 25.2.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2017-04-21 built on builder10-9.porkrind.org Windowing system distributor 'Apple', version 10.3.1504 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LC_CTYPE: UTF-8 value of $LANG: en_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: Bat Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. next-line: End of buffer Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode cl-loaddefs pcase cl-lib mail-prsvr mail-utils vc-dispatcher vc-svn bat-mode easymenu time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 196862 6811) (symbols 48 19646 0) (miscs 40 53 163) (strings 32 15415 5200) (string-bytes 1 442636) (vectors 16 33051) (vector-slots 8 651956 5657) (floats 8 162 94) (intervals 56 216 0) (buffers 976 19)) --f403043ed118abead9055811561c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

I've noticed some pr= oblems with syntax highlighting in bat-mode. In addition, I have two improv= ement suggestions.

Problem 1:

=
bat-mode highlights variables surrounded by "%":s, as in &qu= ot;%alpha%". However, when the variable contains an underscore, as in = "%alpha_beta%", only "alpha" is highlighted.
=
Problem 2:

Similarly, bat-mode high= lights variables defined using "set". As with problem 1 above, it= does not handle words with underscore. Concretely, in "set alpha_beta= =3Dvalue", only "alpha" is highlighted.

=
Problem 3:

bat-mode highlights keywords like = "in". Unfortunately, it also highlights the word "in" w= hen used as a file extension. For example "xxx alpha.in".

Improvement suggestion 1:=

In bat scripts, the command "echo" can = be used to print strings to the console. Unlike in shell scripts, the argum= ent to "echo" does not require quotes. It would be nice if Emacs = would highlight anything after "echo" as a string (using font-loc= k-string-face).

Improvement suggestion 2:

In bat scripts, variable substitution is performed inside = quoted strings, for example:

=C2=A0 =C2=A0 xxx &qu= ot;hello %alpha goodbye"

Unfortunately, emacs= does not highlight this, which I hereby propose that it should.
=

I had plans to fix all of the above myself. U= nfortunately, my Emacs todo-list is too long for my available time, so Rich= ard S. suggested that I report this here, in case someone else would have m= ore time than I do.

Anyway, problem 1 and 2 can pr= obably be fixed by adapting a regexp. Problem 3 should easily be fixed by u= sing a custom font-lock syntax table, where "." is seen as a word= character, or possibly a symbol character. Improvement suggestion 1 could = probably be handled by a simple rule matching echo + space + whatever and h= ighlight "whatever" using font-lock-string-face. All of these are= easy to fix.

Improvement suggestion 2 raises the = bar to "medium", as it would require replacing the current rexexp= rule with one written in elisp. The rule will need to use the "prepen= d" (not "t") override flag to add font-lock-variable-name-fa= ce to the variable name in top of the string face. However, the code must e= nsure that it does not do this for comments.

Side = note: Typically, the "prepend" override flag is preferred over &q= uot;t", as the end result will mix face properties from both the new a= nd old faces. Concretely, I use a string face with a red foreground and a g= rey background. With the "prepend" flag, the variable name will b= e drawn using yellow from font-lock-variable-name-face but the background w= ill still be grey, matching the rest of the string.

=C2=A0 =C2=A0 -- Anders Lindgren


=
In GNU Emacs 25.2.1 (x86_64-apple-darwin13.4.0, NS appkit-12= 65.21 Version 10.9.5 (Build 13F1911))
=C2=A0of 2017-04-21 built o= n builder10-9.porkrind.org<= /div>
Windowing system distributor 'Apple', version 10.3.1504
Configured using:
=C2=A0'configure --with-ns '--= enable-locallisppath=3D/Library/Application
=C2=A0Support/Emacs/$= {version}/site-lisp:/Library/Application
=C2=A0Support/Emacs/site= -lisp' --with-modules'

Configured features= :
NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Important settings:
=C2=A0 value of $LC_C= TYPE: UTF-8
=C2=A0 value of $LANG: en_SE.UTF-8
=C2=A0 l= ocale-coding-system: utf-8-unix

Major mode: Bat

Minor modes in effect:
=C2=A0 tooltip-mode= : t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-= mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode= : t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mod= e: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-m= ode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composit= ion-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-= compression-mode: t
=C2=A0 line-number-mode: t
=C2=A0 t= ransient-mark-mode: t

Recent messages:
F= or information about GNU Emacs and the GNU system, type C-h C-a.
= next-line: End of buffer

Load-path shadows:
<= div>None found.

Features:
(shadow sort m= ail-extr emacsbug message dired format-spec rfc822 mml
mml-sec pa= ssword-cache epg epg-config gnus-util mm-decode mm-bodies
mm-enco= de mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rf= c2047 rfc2045 ietf-drums mm-util help-fns help-mode cl-loaddefs pcase
=
cl-lib mail-prsvr mail-utils vc-dispatcher vc-svn bat-mode easymenu
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-h= ooks
lisp-float-type mwheel ns-win ucs-normalize term/common-win = tool-bar dnd
fontset image regexp-opt fringe tabulated-list newco= mment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-e= shadow timer select
scroll-bar mouse jit-lock font-lock syntax fa= cemenu font-core frame
cl-generic cham georgian utf-8-lang misc-l= ang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms= cp51932 hebrew greek romanian
slovak czech european ethiopic ind= ian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook= help simple abbrev minibuffer
cl-preloaded nadvice loaddefs butt= on faces cus-face macroexp files
text-properties overlay sha1 md5= base64 format env code-pages mule
custom widget hashtable-print-= readable backquote kqueue cocoa ns
multi-tty make-network-process= emacs)

Memory information:
((conses 16 = 196862 6811)
=C2=A0(symbols 48 19646 0)
=C2=A0(miscs 40= 53 163)
=C2=A0(strings 32 15415 5200)
=C2=A0(string-by= tes 1 442636)
=C2=A0(vectors 16 33051)
=C2=A0(vector-sl= ots 8 651956 5657)
=C2=A0(floats 8 162 94)
=C2=A0(inter= vals 56 216 0)
=C2=A0(buffers 976 19))

<= br>
--f403043ed118abead9055811561c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 15:28:19 2017 Received: (at submit) by debbugs.gnu.org; 31 Aug 2017 19:28:19 +0000 Received: from localhost ([127.0.0.1]:38050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnV8T-0000KH-VY for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:28:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnV8R-0000Js-Lc for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnV8L-0004MZ-KI for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:28:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnV8L-0004MR-H3 for submit@debbugs.gnu.org; Thu, 31 Aug 2017 15:28:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnV8K-0002nt-Ab for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:28:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnV8H-0004LZ-7V for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:28:08 -0400 Received: from [195.159.176.226] (port=33271 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnV8H-0004L2-03 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 15:28:05 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dnV7x-0003Ae-Us for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2017 21:27:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Achim Gratz Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode Date: Thu, 31 Aug 2017 21:27:43 +0200 Organization: Linux Private Site Lines: 13 Message-ID: <87wp5jr100.fsf@Rainer.invalid> References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cancel-Lock: sha1:dfV20UH+ONyJv+MoQdFA6RCrb1E= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Anders Lindgren writes: > I've noticed some problems with syntax highlighting in bat-mode. Consider joining this report with bug#18405. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ DIY Stuff: http://Synth.Stromeko.net/DIY.html From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 09:43:42 2017 Received: (at 28311) by debbugs.gnu.org; 22 Sep 2017 13:43:42 +0000 Received: from localhost ([127.0.0.1]:52407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvOF4-0000G0-Ca for submit@debbugs.gnu.org; Fri, 22 Sep 2017 09:43:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvOF2-0000Fh-PG for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 09:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvOEw-00006M-Tk for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 09:43:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvOEn-0008U2-Ag; Fri, 22 Sep 2017 09:43:25 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4576 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvOEm-0001E2-NX; Fri, 22 Sep 2017 09:43:25 -0400 Date: Fri, 22 Sep 2017 16:43:20 +0300 Message-Id: <83fubedf2f.fsf@gnu.org> From: Eli Zaretskii To: Achim Gratz , Anders Lindgren In-reply-to: <87wp5jr100.fsf@Rainer.invalid> (message from Achim Gratz on Thu, 31 Aug 2017 21:27:43 +0200) Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Achim Gratz > Date: Thu, 31 Aug 2017 21:27:43 +0200 > > Anders Lindgren writes: > > I've noticed some problems with syntax highlighting in bat-mode. > > Consider joining this report with bug#18405. I've picked the lower-hanging fruit and fixed some of the problems reported in these two bug reports on the emacs-26 branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 13:01:34 2017 Received: (at 28311) by debbugs.gnu.org; 22 Sep 2017 17:01:34 +0000 Received: from localhost ([127.0.0.1]:53123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvRKY-0000en-7h for submit@debbugs.gnu.org; Fri, 22 Sep 2017 13:01:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvRKW-0000eX-To for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 13:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvRKQ-0003DY-Al for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 13:01:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvRK4-0002gB-GA; Fri, 22 Sep 2017 13:01:04 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dvRK3-0003SW-Nv; Fri, 22 Sep 2017 13:01:03 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> X-Spook: Suspicious substance Sarin BLU-97 A/B Small Pox E. Coli X-Ran: eD}Q|B3lx{$*0E(_Y[d{0|pU`}Q9Oqn%{_zV*5kSz;b;|%pj,(Q|EYv!Q!U%q2?l?e[7#y X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 22 Sep 2017 13:01:03 -0400 In-Reply-To: <83fubedf2f.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Sep 2017 16:43:20 +0300") Message-ID: <8epoaik6r4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, Achim Gratz , Anders Lindgren , 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Running 5 tests (2017-09-22 09:57:54-0700) passed 1/5 bat-test-fill-paragraph-comment hfy batch mode ( *temp*-973592:bat-mode) Test bat-test-fontification-iter-var-1 backtrace: signal(ert-test-failed (((should (equal (bat-test-fontify "echo %%a\ ert-fail(((should (equal (bat-test-fontify "echo %%a\necho %%~dp1\ne (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form (let (form-description-19) (if (unwind-protect (setq value-17 (apply (let ((value-17 'ert-form-evaluation-aborted-18)) (let (form-descrip (let* ((fn-15 (function equal)) (args-16 (condition-case err (let (( (closure (t) nil (let* ((fn-15 (function equal)) (args-16 (condition ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name bat-test-fontification-iter-var-1 :do ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test ert-run-tests(t #f(compiled-function (event-type &rest event-args) # ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/bat-mode-t command-line() normal-top-level() Test bat-test-fontification-iter-var-1 condition: (ert-test-failed ((should (equal (bat-test-fontify "echo %%a echo %%~dp1 echo %%~$PATH:I") "echo %%a echo %%~dp1 echo %%~$PATH:I")) :form (equal #("echo %%a echo %%~dp1 echo %%~$PATH:I" 22 26 (face font-lock-builtin-face) 64 65 (face font-lock-variable-name-face) 95 99 (face font-lock-builtin-face) 137 141 (face font-lock-variable-name-face) 171 175 (face font-lock-builtin-face) 213 221 (face font-lock-variable-name-face)) "echo %%a echo %%~dp1 echo %%~$PATH:I") :value nil :explanation (arrays-of-different-length 228 263 #("echo %%a echo %%~dp1 echo %%~$PATH:I" 22 26 (face font-lock-builtin-face) 64 65 (face font-lock-variable-name-face) 95 99 (face font-lock-builtin-face) 137 141 (face font-lock-variable-name-face) 171 175 (face font-lock-builtin-face) 213 221 (face font-lock-variable-name-face)) "echo %%a echo %%~dp1 echo %%~$PATH:I" first-mismatch-at 109))) FAILED 2/5 bat-test-fontification-iter-var-1 hfy batch mode ( *temp*-454955:bat-mode) passed 3/5 bat-test-fontification-var-decl hfy batch mode ( *temp*-493544:bat-mode) passed 4/5 bat-test-fontification-var-delayed-exp hfy batch mode ( *temp*-832943:bat-mode) passed 5/5 bat-test-fontification-var-exp Ran 5 tests, 4 results as expected, 1 unexpected (2017-09-22 09:57:54-0700) 1 unexpected results: FAILED bat-test-fontification-iter-var-1 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 13:43:05 2017 Received: (at 28311-done) by debbugs.gnu.org; 22 Sep 2017 17:43:05 +0000 Received: from localhost ([127.0.0.1]:53173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvRyj-0001l5-0d for submit@debbugs.gnu.org; Fri, 22 Sep 2017 13:43:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvRyf-0001kS-DA for 28311-done@debbugs.gnu.org; Fri, 22 Sep 2017 13:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvRyW-0005Ii-8r for 28311-done@debbugs.gnu.org; Fri, 22 Sep 2017 13:42:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvRyM-0005Dn-2D; Fri, 22 Sep 2017 13:42:42 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4799 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvRyK-0004SE-90; Fri, 22 Sep 2017 13:42:41 -0400 Date: Fri, 22 Sep 2017 20:42:28 +0300 Message-Id: <83a81md3zv.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <8epoaik6r4.fsf@fencepost.gnu.org> (message from Glenn Morris on Fri, 22 Sep 2017 13:01:03 -0400) Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311-done Cc: 28311-done@debbugs.gnu.org, Stromeko@nexgo.de, andlind@gmail.com, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: Achim Gratz , Anders Lindgren , 28311@debbugs.gnu.org, 18405@debbugs.gnu.org > Date: Fri, 22 Sep 2017 13:01:03 -0400 > > > Running 5 tests (2017-09-22 09:57:54-0700) > passed 1/5 bat-test-fill-paragraph-comment > hfy batch mode ( *temp*-973592:bat-mode) > Test bat-test-fontification-iter-var-1 backtrace: Thanks, fixed. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 15:04:29 2017 Received: (at 28311) by debbugs.gnu.org; 22 Sep 2017 19:04:29 +0000 Received: from localhost ([127.0.0.1]:53224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTFU-0003hi-GU for submit@debbugs.gnu.org; Fri, 22 Sep 2017 15:04:29 -0400 Received: from mail-vk0-f46.google.com ([209.85.213.46]:44892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTFS-0003hS-57; Fri, 22 Sep 2017 15:04:26 -0400 Received: by mail-vk0-f46.google.com with SMTP id d12so1048148vkf.1; Fri, 22 Sep 2017 12:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LVl6parrpvP+hJWBXywN82VHiNDCCV0i1W/Vl9neEME=; b=sxZjIj7KET3v6IWBh+cMjYXw5GwIlHQjkHj92nj9jHlEq5dlPTjH1U6g3ix5sFN8D6 STYGV4ftqqouhgmBRtw2tdohJb2sm2wNL2Wif616F/N1C+6qD/JkTbu3wHh9ht/D8rIj 6yDW1+ohDNjDBJxhLiM4JXspZ10uYHxlKvZmEVaQzrP9V+zlZUnyS+Bq9fdB6Bv+o9Q2 ilvj6v6RECW8xhq4QSLLQD+VrmQVLGl8/kB3XwGkW0zeLmTEKhS8JiYHcljVPV21jqg/ ARSlqIVkhWkg5D5MFlhzyCvZjMh8H628tq3owqBGCrn8Zi7/TrfIVyQbk+PpngHtic1t dzfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LVl6parrpvP+hJWBXywN82VHiNDCCV0i1W/Vl9neEME=; b=VVweUPNU/ickNvVBJnZF8kk9c/CnrdK/JbaYozWKqjR9gZ49WUMIK9mmOqSAzE/6vU flYTiON4GkDxq4e0jFOvVwIDAzom9eo+WIkl24wh2X0oFkIgzq8oS20cHvxUwpRbMUuX Sjr/DGsvtSsjLz+gp64WU5s7r2PMmsivaomG6r9FO5lG+9G+JqpHtehWFb/KiR/ecBll aX+ixdKBvNuZJseIUzKz6nCDheuL5F4XZCSf4ZVwoZRHih0Uo90/n7o9E0sSYL/UD9Ao lm1l3Gz4hzL83LlrmDuo2AEiPLShKJ/eO4K22h5aGQ5y6scCYhF+cmo1LKeDXfyRQ5Im LWbg== X-Gm-Message-State: AHPjjUgbx4RFsJlvKDgNK/7wLsjeVrafs0JTwsa8hhS6DoIVKOMmnNIa 1oJGEmORQU7yERSOOwwQRXCHQLix9EHE5Vulpus= X-Google-Smtp-Source: AOwi7QBqTAJiCFr5qnu0znvUvjaG6RGdUzEFD1zQO0EHkZx0rPcBnAl/wOnju7irydAQINEghCfA1cVHnYSiTud93KM= X-Received: by 10.31.237.2 with SMTP id l2mr127289vkh.91.1506107060593; Fri, 22 Sep 2017 12:04:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.171.202 with HTTP; Fri, 22 Sep 2017 12:04:19 -0700 (PDT) In-Reply-To: <8epoaik6r4.fsf@fencepost.gnu.org> References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> From: Anders Lindgren Date: Fri, 22 Sep 2017 21:04:19 +0200 Message-ID: Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode To: Glenn Morris Content-Type: multipart/alternative; boundary="94eb2c09470657298d0559cbe091" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, Eli Zaretskii , Achim Gratz , 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --94eb2c09470657298d0559cbe091 Content-Type: text/plain; charset="UTF-8" Hi! Unfortunately, I can't comment on the actual error found, as I wasn't involved in the fix... Anyway, I am positively glad that you have tests for font-lock rules. However, using htmlfontify for this doesn't seem like the best tool for this. 1) The output of htmlfontify may change in the future, in which case you will need to rewrite all your tests, 2) HTML is hard to read, and 3) The ert explainer doesn't really help you here. If example, in this case all it tells you is that the resulting html strings have different lengths. On other words, it may work for snippets like this, but it would not scale well. A couple of years ago I wrote a tool, faceup (https://github.com/ Lindydancer/faceup), specifically for testing highlighting in Emacs using ert. It uses a simple markup language, so the result is easier to read than when using HTML. The reference text can be used inline (like in your test) or stored in a corresponding ".faceup" file, which makes it possible to test files thousands of lines long. When a test fails, the ert explainer will tell you which lines contained errors, what that lines contained, and what they should contain, so it's much easier to find errors. I have successfully used this is several of my font-lock packages. In addition, I've accumulated a number of source files in various programming languages in a regression test suite for font-lock (https://github.com/ Lindydancer/font-lock-regression-suite). If you would like to modernise your font-lock test, I would be happy to contribute it to Emacs (as I suggested in bug#16063). -- Anders On Fri, Sep 22, 2017 at 7:01 PM, Glenn Morris wrote: > > Running 5 tests (2017-09-22 09:57:54-0700) > passed 1/5 bat-test-fill-paragraph-comment > hfy batch mode ( *temp*-973592:bat-mode) > Test bat-test-fontification-iter-var-1 backtrace: > signal(ert-test-failed (((should (equal (bat-test-fontify "echo %%a\ > ert-fail(((should (equal (bat-test-fontify "echo %%a\necho %%~dp1\ne > (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form > (let (form-description-19) (if (unwind-protect (setq value-17 (apply > (let ((value-17 'ert-form-evaluation-aborted-18)) (let (form-descrip > (let* ((fn-15 (function equal)) (args-16 (condition-case err (let (( > (closure (t) nil (let* ((fn-15 (function equal)) (args-16 (condition > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name bat-test-fontification-iter-var-1 :do > ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test > ert-run-tests(t #f(compiled-function (event-type &rest event-args) # > ert-run-tests-batch(nil) > ert-run-tests-batch-and-exit(nil) > eval((ert-run-tests-batch-and-exit nil)) > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/bat-mode-t > command-line() > normal-top-level() > Test bat-test-fontification-iter-var-1 condition: > (ert-test-failed > ((should > (equal > (bat-test-fontify "echo %%a > echo %%~dp1 > echo %%~$PATH:I") > "echo %% class=\"variable-name\">a > echo %%~dp1 span> > echo %%~$ class=\"variable-name\">PATH:I span>")) > :form > (equal > #("echo %% class=\"variable-name\">a > echo %%~dp1 span> > echo %%~$PATH:I" > 22 26 > (face font-lock-builtin-face) > 64 65 > (face font-lock-variable-name-face) > 95 99 > (face font-lock-builtin-face) > 137 141 > (face font-lock-variable-name-face) > 171 175 > (face font-lock-builtin-face) > 213 221 > (face font-lock-variable-name-face)) > "echo %% class=\"variable-name\">a > echo %%~dp1 span> > echo %%~$ class=\"variable-name\">PATH:I span>") > :value nil :explanation > (arrays-of-different-length 228 263 > #("echo > %%a > echo %%~dp1 span> > echo %%~$PATH:I" > 22 26 > (face font-lock-builtin-face) > 64 65 > (face font-lock-variable-name-face) > 95 99 > (face font-lock-builtin-face) > 137 141 > (face font-lock-variable-name-face) > 171 175 > (face font-lock-builtin-face) > 213 221 > (face font-lock-variable-name-face)) > "echo > %%a > echo %%~dp1 span> > echo %%~$ class=\"variable-name\">PATH:I" > first-mismatch-at 109))) > FAILED 2/5 bat-test-fontification-iter-var-1 > hfy batch mode ( *temp*-454955:bat-mode) > passed 3/5 bat-test-fontification-var-decl > hfy batch mode ( *temp*-493544:bat-mode) > passed 4/5 bat-test-fontification-var-delayed-exp > hfy batch mode ( *temp*-832943:bat-mode) > passed 5/5 bat-test-fontification-var-exp > > Ran 5 tests, 4 results as expected, 1 unexpected (2017-09-22 09:57:54-0700) > > 1 unexpected results: > FAILED bat-test-fontification-iter-var-1 > > --94eb2c09470657298d0559cbe091 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

Unfortunately, I can't comment = on the actual error found, as I wasn't involved in the fix...

Anyway, I am positively glad that you have tests for font-l= ock rules. However, using htmlfontify for this doesn't seem like the be= st tool for this. 1) The output of htmlfontify may change in the future, in= which case you will need to rewrite all your tests, 2) HTML is hard to rea= d, and 3) The ert explainer doesn't really help you here. If example, i= n this case all it tells you is that the resulting html strings have differ= ent lengths. On other words, it may work for snippets like this, but it wou= ld not scale well.

A couple of years ago I wrote a= tool, faceup (https://github.com/Lindydancer/faceup), specifically for t= esting highlighting in Emacs using ert. It uses a simple markup language, s= o the result is easier to read than when using HTML. The reference text can= be used inline (like in your test) or stored in a corresponding ".fac= eup" file, which makes it possible to test files thousands of lines lo= ng. When a test fails, the ert explainer will tell you which lines containe= d errors, what that lines contained, and what they should contain, so it= 9;s much easier to find errors. I have successfully used this is several of= my font-lock packages. In addition, I've accumulated a number of sourc= e files in various programming languages in a regression test suite for fon= t-lock (https://github.com/Lindydancer/font-lock-reg= ression-suite).

If you would like to modernise= your font-lock test, I would be happy to contribute it to Emacs (as I sugg= ested in bug#16063).

=C2=A0 =C2=A0 -- Anders
=

On Fri, Sep= 22, 2017 at 7:01 PM, Glenn Morris <rgm@gnu.org> wrote:

Running 5 tests (2017-09-22 09:57:54-0700)
=C2=A0 =C2=A0passed=C2=A0 1/5=C2=A0 bat-test-fill-paragraph-comment hfy batch mode ( *temp*-973592:bat-mode)
Test bat-test-fontification-iter-var-1 backtrace:
=C2=A0 signal(ert-test-failed (((should (equal (bat-test-fontify "echo= %%a\
=C2=A0 ert-fail(((should (equal (bat-test-fontify "echo %%a\necho %%~d= p1\ne
=C2=A0 (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form=
=C2=A0 (let (form-description-19) (if (unwind-protect (setq value-17 (apply=
=C2=A0 (let ((value-17 'ert-form-evaluation-aborted-18)) (let (for= m-descrip
=C2=A0 (let* ((fn-15 (function equal)) (args-16 (condition-case err (let ((=
=C2=A0 (closure (t) nil (let* ((fn-15 (function equal)) (args-16 (condition=
=C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert= -test
=C2=A0 ert-run-test(#s(ert-test :name bat-test-fontification-iter-var-= 1 :do
=C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-= test
=C2=A0 ert-run-tests(t #f(compiled-function (event-type &rest event-arg= s) #
=C2=A0 ert-run-tests-batch(nil)
=C2=A0 ert-run-tests-batch-and-exit(nil)
=C2=A0 eval((ert-run-tests-batch-and-exit nil))
=C2=A0 command-line-1(("-L" ":." "-l" "e= rt" "-l" "lisp/progmodes/bat-mode-t
=C2=A0 command-line()
=C2=A0 normal-top-level()
Test bat-test-fontification-iter-var-1 condition:
=C2=A0 =C2=A0 (ert-test-failed
=C2=A0 =C2=A0 =C2=A0((should
=C2=A0 =C2=A0 =C2=A0 =C2=A0(equal
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (bat-test-fontify "echo %%a
echo %%~dp1
echo %%~$PATH:I")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "<span class=3D\"builtin\">= ;echo</span> %%<span class=3D\"variable-name\">a</= span>
<span class=3D\"builtin\">echo</span> %%~dp<span c= lass=3D\"variable-name\">1</span>
<span class=3D\"builtin\">echo</span> %%~$<span cl= ass=3D\"variable-name\">PATH</span>:<span class= =3D\"variable-name\">I</span>"))
=C2=A0 =C2=A0 =C2=A0 :form
=C2=A0 =C2=A0 =C2=A0 (equal
=C2=A0 =C2=A0 =C2=A0 =C2=A0#("<span class=3D\"builtin\"&g= t;echo</span> %%<span class=3D\"variable-name\">a<= /span>
<span class=3D\"builtin\">echo</span> %%<span clas= s=3D\"variable-name\">~dp1</span>
<span class=3D\"builtin\">echo</span> %%<span clas= s=3D\"variable-name\">~$PATH:I</span>" 22 26 (face font-lock-builtin-face)
64 65
(face font-lock-variable-name-face)
95 99
(face font-lock-builtin-face)
137 141
(face font-lock-variable-name-face)
171 175
(face font-lock-builtin-face)
213 221
(face font-lock-variable-name-face))
=C2=A0 =C2=A0 =C2=A0 =C2=A0"<span class=3D\"builtin\">= echo</span> %%<span class=3D\"variable-name\">a</<= wbr>span>
<span class=3D\"builtin\">echo</span> %%~dp<span c= lass=3D\"variable-name\">1</span>
<span class=3D\"builtin\">echo</span> %%~$<span cl= ass=3D\"variable-name\">PATH</span>:<span class= =3D\"variable-name\">I</span>")
=C2=A0 =C2=A0 =C2=A0 :value nil :explanation
=C2=A0 =C2=A0 =C2=A0 (arrays-of-different-length 228 263
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #("<span class=3D\&qu= ot;builtin\">echo</span> %%<span class=3D\"variable-n= ame\">a</span>
<span class=3D\"builtin\">echo</span> %%<span clas= s=3D\"variable-name\">~dp1</span>
<span class=3D\"builtin\">echo</span> %%<span clas= s=3D\"variable-name\">~$PATH:I</span>" 22 26 (face font-lock-builtin-face)
64 65
(face font-lock-variable-name-face)
95 99
(face font-lock-builtin-face)
137 141
(face font-lock-variable-name-face)
171 175
(face font-lock-builtin-face)
213 221
(face font-lock-variable-name-face))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "<span class=3D\"= ;builtin\">echo</span> %%<span class=3D\"variable-nam= e\">a</span>
<span class=3D\"builtin\">echo</span> %%~dp<span c= lass=3D\"variable-name\">1</span>
<span class=3D\"builtin\">echo</span> %%~$<span cl= ass=3D\"variable-name\">PATH</span>:<span class= =3D\"variable-name\">I</span>" first-mismatch-= at 109)))
=C2=A0 =C2=A0FAILED=C2=A0 2/5=C2=A0 bat-test-fontification-iter-var-1<= br> hfy batch mode ( *temp*-454955:bat-mode)
=C2=A0 =C2=A0passed=C2=A0 3/5=C2=A0 bat-test-fontification-var-decl hfy batch mode ( *temp*-493544:bat-mode)
=C2=A0 =C2=A0passed=C2=A0 4/5=C2=A0 bat-test-fontification-var-delayed= -exp
hfy batch mode ( *temp*-832943:bat-mode)
=C2=A0 =C2=A0passed=C2=A0 5/5=C2=A0 bat-test-fontification-var-exp

Ran 5 tests, 4 results as expected, 1 unexpected (2017-09-22 09:57:54-0700)=

1 unexpected results:
=C2=A0 =C2=A0FAILED=C2=A0 bat-test-fontification-iter-var-1


--94eb2c09470657298d0559cbe091-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 15:15:43 2017 Received: (at 28311) by debbugs.gnu.org; 22 Sep 2017 19:15:43 +0000 Received: from localhost ([127.0.0.1]:53240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTQM-0003xk-Sx for submit@debbugs.gnu.org; Fri, 22 Sep 2017 15:15:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvTQL-0003xY-Ls for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 15:15:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvTQC-0000RY-0O for 28311@debbugs.gnu.org; Fri, 22 Sep 2017 15:15:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvTQ1-0000MM-FC; Fri, 22 Sep 2017 15:15:21 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4877 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvTPx-0004ZH-Of; Fri, 22 Sep 2017 15:15:21 -0400 Date: Fri, 22 Sep 2017 22:14:56 +0300 Message-Id: <8360caczpr.fsf@gnu.org> From: Eli Zaretskii To: Anders Lindgren In-reply-to: (message from Anders Lindgren on Fri, 22 Sep 2017 21:04:19 +0200) Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, rgm@gnu.org, Stromeko@nexgo.de, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Anders Lindgren > Date: Fri, 22 Sep 2017 21:04:19 +0200 > Cc: Eli Zaretskii , Achim Gratz , 28311@debbugs.gnu.org, > 18405@debbugs.gnu.org > > If you would like to modernise your font-lock test, I would be happy to contribute it to Emacs (as I suggested in > bug#16063). Why wouldn't we want that? Please go ahead, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 08:50:35 2017 Received: (at 28311) by debbugs.gnu.org; 23 Sep 2017 12:50:36 +0000 Received: from localhost ([127.0.0.1]:53604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvjtD-0007l9-Oq for submit@debbugs.gnu.org; Sat, 23 Sep 2017 08:50:35 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:55995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvjtC-0007ks-EO; Sat, 23 Sep 2017 08:50:34 -0400 Received: by mail-vk0-f52.google.com with SMTP id i1so1738585vke.12; Sat, 23 Sep 2017 05:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d0Tx3mZe0EYOzTSsg7Z9+AP0AojX7Jn76n0/OORwQ58=; b=gs6HH7N0bfeCNgbPT9tEudFrsRLgg0IKZO8po++8TTpIWM9k3tY9Ssf1/2BGbLT4b8 4qcVhVotuOz0FkFV0dLtmEg2WRQEdA5lBenNz4vyEmU0UOOctAe2/USJabEpgX6wkmEX sBrBSjH/ABxvJwv1cI015Ttl6tKzOkSQwNuYZv0yCmX/3JrfTSqRchhRwt/5pdKCghUe ZFhaRhxF1xLRCbq1I+AbPfpyAOqLG3gcaETxs6+Ulf5l5nqkFUi8OFFkat2HUHGM4ZQm 0FP1oOy9XvXNBJH6ulRYHxLaGyuLXcZ5tUfDxuxPhgUCMURZxK6WvwNUMfxTfXZdjYbh nKdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d0Tx3mZe0EYOzTSsg7Z9+AP0AojX7Jn76n0/OORwQ58=; b=Sl5Bj81RHrdr3CmM2ySh10qWZIBReMWSMgYLzC/aF+CYJxFyjS1uE8odTz/rIIwGoN NPnOL3ntWeM86M8tsqUJA8qncn0qXnaltvbDvzXdd1UANTEXOC9D7zeGMWUargqPtCM3 +e+RgyizOMRZwxh8CAMmD/4x4OmrWPvMjrVAAvuZNrjSaPH8vPxuQvdDoJ7iLeOkooFU T9jyYnKtKWOWxVEJOCn8fKmt70MNpffqj++W88obJiTGFpIu7ZTdGrch4y3gpVHASCcL uvlDEs/trG7oNt9sQlHD/BXpoLko1nZeFItOCvzjmXwLTPy2DfjfO8s3/TenQtwxjSmS 109w== X-Gm-Message-State: AHPjjUj6FYmpbjp27du8KIzfwVEsELyex//8Eiqx3flgT7xYGioMsdrB XQMjRsV/98KiI24x7w9oq8lFL9o2x7ue2ffReUk= X-Google-Smtp-Source: AOwi7QAXS0yETLcNdO3QQZgeAYiXyxC4k4QkRlePdJBU19UKLTyATTWMuSnyMxHoMrJpBq+SJ9e0sSnbexxSEOW70Ck= X-Received: by 10.31.7.142 with SMTP id 136mr1855085vkh.10.1506171028864; Sat, 23 Sep 2017 05:50:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.171.202 with HTTP; Sat, 23 Sep 2017 05:50:27 -0700 (PDT) In-Reply-To: <8360caczpr.fsf@gnu.org> References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> <8360caczpr.fsf@gnu.org> From: Anders Lindgren Date: Sat, 23 Sep 2017 14:50:27 +0200 Message-ID: Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode To: Eli Zaretskii Content-Type: multipart/alternative; boundary="001a1143d50c25864b0559dac55f" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, Glenn Morris , Stromeko@nexgo.de, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a1143d50c25864b0559dac55f Content-Type: text/plain; charset="UTF-8" > > > If you would like to modernise your font-lock test, I would be happy to > contribute it to Emacs (as I suggested in > > bug#16063). > > Why wouldn't we want that? Please go ahead, and thanks. > Thanks! In which branch should I add it, master or Emacs-26? I guess it should go into lisp/emacs-lisp, as "ert.el" is located there. -- Anders --001a1143d50c25864b0559dac55f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> If you would like to moder= nise your font-lock test, I would be happy to contribute it to Emacs (as I = suggested in
> bug#16063).

Why wouldn't we want that?=C2=A0 Please go ahead, and thanks.

Thanks! In which br= anch should I add it, master or Emacs-26?
<= br>
I guess it should go into lisp/emacs-li= sp, as "ert.el" is located there.

=C2=A0 =C2=A0 -- Anders

--001a1143d50c25864b0559dac55f-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 09:09:59 2017 Received: (at 28311) by debbugs.gnu.org; 23 Sep 2017 13:09:59 +0000 Received: from localhost ([127.0.0.1]:53623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvkBz-0008EX-Cv for submit@debbugs.gnu.org; Sat, 23 Sep 2017 09:09:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvkBx-0008EB-Oy for 28311@debbugs.gnu.org; Sat, 23 Sep 2017 09:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvkBr-0004tS-Ty for 28311@debbugs.gnu.org; Sat, 23 Sep 2017 09:09:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvkBh-0004r6-5Y; Sat, 23 Sep 2017 09:09:41 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvkBc-0003q1-7D; Sat, 23 Sep 2017 09:09:38 -0400 Date: Sat, 23 Sep 2017 16:09:20 +0300 Message-Id: <831smxblz3.fsf@gnu.org> From: Eli Zaretskii To: Anders Lindgren In-reply-to: (message from Anders Lindgren on Sat, 23 Sep 2017 14:50:27 +0200) Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> <8360caczpr.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, rgm@gnu.org, Stromeko@nexgo.de, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Anders Lindgren > Date: Sat, 23 Sep 2017 14:50:27 +0200 > Cc: Glenn Morris , Stromeko@nexgo.de, 28311@debbugs.gnu.org, > 18405@debbugs.gnu.org > > Why wouldn't we want that? Please go ahead, and thanks. > > Thanks! In which branch should I add it, master or Emacs-26? How large is it? Also, is it supposed to be used outside of the ert context? > I guess it should go into lisp/emacs-lisp, as "ert.el" is located there. Probably. Actually, why not make it part of ert, say, ert-faces.el? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 14:05:43 2017 Received: (at 28311) by debbugs.gnu.org; 23 Sep 2017 18:05:43 +0000 Received: from localhost ([127.0.0.1]:54844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvooB-0003QD-Ea for submit@debbugs.gnu.org; Sat, 23 Sep 2017 14:05:43 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:48109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvoo9-0003Pw-VZ; Sat, 23 Sep 2017 14:05:42 -0400 Received: by mail-vk0-f47.google.com with SMTP id c82so1949837vkd.4; Sat, 23 Sep 2017 11:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qISntXW1tieGzs17Txsd0Z540H5YoxD0Q2AEJphDoOA=; b=D+Qn3G/3SUzVm+ETk6n3x04ynek3C+Kyar1NX9nl8Hpwr1vKbuoXp354vU72D4O6YA yCAliRG+r2iOQ7rHRpHICIfbnWRDTdczD8E5S5ihq/PE0cg/dE2//rDV6phHmfheJG10 0Sz7czSufWVjllRkxzwirgujy9MSE1NEZVF+4hnbXOxEgDZh0AGGcdaFOM0zV1hWePEc tuQ6CmdHxJXHkxRbmu0/Yw+zfMraUmxxRNUQZonJ6AeBVyyP5iR/Q1Q2czhRAWne+5M2 zJ8k+5frDZffS7dTdtPTNxinLyoy3g4GvJoxT6qsuXB2kvsxQtYVI+i8W10OcRFk1Usv FiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qISntXW1tieGzs17Txsd0Z540H5YoxD0Q2AEJphDoOA=; b=dvAG3KNmfTB8quO9cz5SV4v/wPf8ntgrDIUUe8jVSBfj88VPIDo/0wEO8Dx4ZOeQ8Y TUyziLtFS1y9NqeKafOx4I/dLXKMP/ZLL08527kKyPJKq1333iRzsg0WF21+kAei4DPm GvyTV4lZhTgAY/rqMdMcktQth2bGt3PMQweGVVCfehzOOAaQavUBFoI3cNIgJRnEhpcz k9k4Q4dYI4RjeOj6hL23NAbNCbmENhDchycaap04+H9W+lcI7Ai79KhFw/4J/NaXhtod YE2LoaBwiHRmYYDt4nu0lQ6EiCTSXHNXW/udIzGJxFWn7y5XmkPFZFUztCok2N86ByUd zNMw== X-Gm-Message-State: AHPjjUj4jNiO5igyykZc/0mZjgt6Sg6jI6bB6Fskarj7AdTLtHUSFPJn F+9hmQkzuUMoGSd8IWgXWCd2NHBdj3tC8nieoqQ= X-Google-Smtp-Source: AOwi7QB0ghSbMKxpwfpdChpN7xXCO3oUX4hA/DH44Mx0V+Szuep6VHBNqlcf9ZP3q9MddawTA+YlFwRV8JLi61ExbQo= X-Received: by 10.31.109.195 with SMTP id i186mr2568660vkc.118.1506189936545; Sat, 23 Sep 2017 11:05:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.171.202 with HTTP; Sat, 23 Sep 2017 11:05:35 -0700 (PDT) In-Reply-To: <831smxblz3.fsf@gnu.org> References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> <8360caczpr.fsf@gnu.org> <831smxblz3.fsf@gnu.org> From: Anders Lindgren Date: Sat, 23 Sep 2017 20:05:35 +0200 Message-ID: Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode To: Eli Zaretskii Content-Type: multipart/alternative; boundary="94eb2c0958d221d5760559df2c81" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, Glenn Morris , Achim Gratz , 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --94eb2c0958d221d5760559df2c81 Content-Type: text/plain; charset="UTF-8" > > > Thanks! In which branch should I add it, master or Emacs-26? > > How large is it? Also, is it supposed to be used outside of the ert > context? > The main source file is about 45 KB, with additional 15KB of test files. It can be used outside the ERT context, as the markup language is generic. I can think of many applications for it, like use it as the storage format for a word-processor like mode, where the user can apply bold, italics etc. > I guess it should go into lisp/emacs-lisp, as "ert.el" is located there. > > Probably. Actually, why not make it part of ert, say, ert-faces.el? > As it can be used outside of ert, I would prefer the current name. -- Anders --94eb2c0958d221d5760559df2c81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Thanks! In which branch sh= ould I add it, master or Emacs-26?

How large is it?=C2=A0 Also, is it supposed to be used outside of th= e ert
context?

The main source file is about = 45 KB, with additional 15KB of test files.

It can = be used outside the ERT context, as the markup language is generic. I can t= hink of many applications for it, like use it as the storage format for a w= ord-processor like mode, where the user can apply bold, italics etc.
<= div>=C2=A0

> I guess it should go into lisp/emacs-lisp, as "ert.el" is lo= cated there.

Probably.=C2=A0 Actually, why not make it part of ert, say, ert-face= s.el?

As it can be used o= utside of ert, I would prefer the current name.

=C2=A0 =C2=A0 =C2=A0-- Anders
--94eb2c0958d221d5760559df2c81-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 14:18:25 2017 Received: (at 28311) by debbugs.gnu.org; 23 Sep 2017 18:18:25 +0000 Received: from localhost ([127.0.0.1]:54865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvp0T-0003jw-8c for submit@debbugs.gnu.org; Sat, 23 Sep 2017 14:18:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvp0R-0003jk-JE for 28311@debbugs.gnu.org; Sat, 23 Sep 2017 14:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvp0J-0006iY-BX for 28311@debbugs.gnu.org; Sat, 23 Sep 2017 14:18:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvp0A-0006dn-OJ; Sat, 23 Sep 2017 14:18:06 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3239 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvp07-0000tZ-VE; Sat, 23 Sep 2017 14:18:06 -0400 Date: Sat, 23 Sep 2017 21:17:46 +0300 Message-Id: <83o9q19t4l.fsf@gnu.org> From: Eli Zaretskii To: Anders Lindgren In-reply-to: (message from Anders Lindgren on Sat, 23 Sep 2017 20:05:35 +0200) Subject: Re: bug#28311: 25.2; Improve syntax highlighting in bat-mode References: <87wp5jr100.fsf@Rainer.invalid> <83fubedf2f.fsf@gnu.org> <8epoaik6r4.fsf@fencepost.gnu.org> <8360caczpr.fsf@gnu.org> <831smxblz3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28311 Cc: 28311@debbugs.gnu.org, rgm@gnu.org, Stromeko@nexgo.de, 18405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Anders Lindgren > Date: Sat, 23 Sep 2017 20:05:35 +0200 > Cc: Glenn Morris , Achim Gratz , 28311@debbugs.gnu.org, > 18405@debbugs.gnu.org > > > Thanks! In which branch should I add it, master or Emacs-26? > > How large is it? Also, is it supposed to be used outside of the ert > context? > > The main source file is about 45 KB, with additional 15KB of test files. > > It can be used outside the ERT context, as the markup language is generic. I can think of many applications > for it, like use it as the storage format for a word-processor like mode, where the user can apply bold, italics > etc. In that case, I guess master is the right place. Thanks. From unknown Sun Jun 22 15:25:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator