GNU bug report logs - #28288
[PATCH] Test and fix the ISO Image Installer

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28288 <at> debbugs.gnu.org
Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image.
Date: Tue, 05 Sep 2017 15:17:32 +0200

Hi!

Christopher Baines <mail <at> cbaines.net> skribis:

> This mimics the functionality in the root-partition-initializer used in
> creating the QEMU image. This helps when trying to run guix system init from
> the generated ISO image.
>
> * gnu/build/vm.scm (make-iso9660-image): Add support for registering closures.

[...]

> +    (when register-closures?
> +      (display "registering closures...\n")
> +      (for-each (lambda (closure)
> +                  (register-closure
> +                   "/tmp/root"
> +                   (string-append "/xchg/" closure)
> +                   #:deduplicate? #f))
> +                closures))

Was there any specific reason for #:deduplicate? #f here?

Otherwise LGTM!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.