GNU bug report logs - #28288
[PATCH] Test and fix the ISO Image Installer

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Wed, 30 Aug 2017 06:18:02 UTC

Severity: important

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log

Message #20 received at 28288 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28288 <at> debbugs.gnu.org
Subject: Re: [bug#28288] [PATCH 2/2] WIP
Date: Wed, 30 Aug 2017 20:26:37 +0200

> +    ;; XXX: 'guix-register' wants to palpate the things it registers, so
> +    ;; bind-mount the store on the target.
> +    (mkdir-p target-store)
> +    (mount (%store-directory) target-store "" MS_BIND)

What does this do?

gnu/build/vm.scm make-iso9660-image already provides /gnu/store a few lines down:

    (unless (zero? (apply system*
                          `(,grub-mkrescue "-o" ,target
                            ,(string-append "boot/grub/grub.cfg=" config-file)
                            ,(string-append "gnu/store=" os-drv "/..")
                                            ^^^^

Maybe I'm missing something...

Otherwise LGTM!
This bug report was last modified 7 years and 260 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.