Subject: Re: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image.

From: [email-masked] (Ludovic Courtès)
Date: Tue, 05 Sep 2017 15:17:32 +0200

Hi!

Christopher Baines <[email-masked]> skribis:

> This mimics the functionality in the root-partition-initializer used in
> creating the QEMU image. This helps when trying to run guix system init from
> the generated ISO image.
>
> * gnu/build/vm.scm (make-iso9660-image): Add support for registering closures.

[...]

> +    (when register-closures?
> +      (display "registering closures...\n")
> +      (for-each (lambda (closure)
> +                  (register-closure
> +                   "/tmp/root"
> +                   (string-append "/xchg/" closure)
> +                   #:deduplicate? #f))
> +                closures))

Was there any specific reason for #:deduplicate? #f here?

Otherwise LGTM!

Ludo’.