From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH] Test and fix the ISO Image Installer Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 06:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15040738543328 (code B ref -1); Wed, 30 Aug 2017 06:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Aug 2017 06:17:34 +0000 Received: from localhost ([127.0.0.1]:33139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwJi-0000rc-BP for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwJg-0000rN-Jl for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmwJa-0002bl-Dz for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmwJa-0002bc-AH for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmwJZ-00066V-61 for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmwJR-0002Zf-6y for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:22 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:55411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmwJR-0002ZT-0J for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:17 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 3D09F13D273; Wed, 30 Aug 2017 07:17:15 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 1A72213D272 for ; Wed, 30 Aug 2017 07:17:15 +0100 (BST) Date: Wed, 30 Aug 2017 07:17:14 +0100 From: Christopher Baines Message-ID: <20170830071714.75f88e47@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/8C64yxQAygrtxBFH+=Knl.6"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Sig_/8C64yxQAygrtxBFH+=Knl.6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hey, So at the GNU Hackers Meeting, I attempted to build the installer system as an ISO image, and test installing Guix on a Bytemark VM with this. I encountered problems, and therefore set about writing a system test to see if this could be reproduced. The failures did seem reproducible locally, and Ludo helped with some code changes. I'll send the work in progress patches to this bug. --Sig_/8C64yxQAygrtxBFH+=Knl.6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmmWGpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcfXw/4mzuu9gs9Rki31SrV6LmMxsaQN2ZT7HuEfDQQmX5Gu+74pVTgnbGveytW QFfRhfnfrtN702p86RTTpWE7vC6JNMzyHo4Qk8SCTCjuzuemTiMazCIB07UCa9lZ Vv3D6HcR8RgVuK4Y7PE86PgG4aRtprYn09Ie1OkDe/B/+4WRr/TVDOx9KKSRgFr9 jW+Ewo416nsbxn2QFgwUNkLQ/m0ikUH8ekaZ9vtIJIp1bGFKSY9aIG53ezfPOZud x3PvCt1sdU+Y/KCPIXVD96h6nzY1Bf2P62M3Ji4qam5wGor9ZCtAHFWjRAaTJnHv dKZQi6d1YrDyzUR9sshWhfYJmsymbHc/N0Kyq2ZAC4AZrBCLL2lxxdZIX3cdsvq7 0a6rxdZ63YE5UtatCNPK2jOLQM9BRWWjhWcFhgwfgqAz9Mu7UPgfk1/wZtJcSsum eQCoeJv5Ntax77WAtONQUO5TE9WCHRibZOYxaN/8hHOy1C9rQ7mwwONELLFGeTGl W3lcTnNn6I2BHTrd/auc5Bmx3c7rDCzsMmewqDY6LnKPjkg8UFN/cUxxB/EIVvrS +ysIv7NbNNs+r3BunGaE75DFkKOaqF2SgtSCP7Y42rMK/LvbAkJN6Ynmvbc4W+q3 O+gFXTZzGwPxs7mpaNFB9ZWocZqEXvtnEiQDvyYqXrr/Q+wSGg== =w858 -----END PGP SIGNATURE----- --Sig_/8C64yxQAygrtxBFH+=Knl.6-- From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/2] tests: Add test for installing from an ISO Image. References: <20170830071714.75f88e47@cbaines.net> In-Reply-To: <20170830071714.75f88e47@cbaines.net> Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.15040740153612 (code B ref 28288); Wed, 30 Aug 2017 06:21:02 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 06:20:15 +0000 Received: from localhost ([127.0.0.1]:33146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwMI-0000wB-Oy for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:20:14 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:40699 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwMG-0000vv-UA for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 02:20:13 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id B597D13D274; Wed, 30 Aug 2017 07:20:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 74A7C13D272 for <28288@debbugs.gnu.org>; Wed, 30 Aug 2017 07:20:11 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d76ba195 for <28288@debbugs.gnu.org>; Wed, 30 Aug 2017 06:20:11 +0000 (UTC) From: Christopher Baines Date: Wed, 30 Aug 2017 07:20:09 +0100 Message-Id: <20170830062010.11902-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/tests/install.scm (%test-iso-image-installer): New variable. (run-install): Add #:installation-disk-image-file-system-type as a keyword argument. --- gnu/tests/install.scm | 48 +++++++++++++++++++++++++++++++++++++----------- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 866bf885c..7596347a3 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -37,6 +37,7 @@ #:use-module (guix utils) #:export (%test-installed-os %test-installed-extlinux-os + %test-iso-image-installer %test-separate-store-os %test-separate-home-os %test-raid-root-os @@ -196,6 +197,7 @@ reboot\n") (kernel-arguments '("console=ttyS0"))) #:imported-modules '((gnu services herd) (guix combinators)))) + (installation-disk-image-file-system-type "ext4") (target-size (* 1200 MiB))) "Run SCRIPT (a shell script following the GuixSD installation procedure) in OS to install TARGET-OS. Return a VM image of TARGET-SIZE bytes containing @@ -213,7 +215,9 @@ packages defined in installation-os." (image (system-disk-image (operating-system-with-gc-roots os (list target)) - #:disk-image-size (* 1500 MiB)))) + #:disk-image-size (* 1500 MiB) + #:file-system-type + installation-disk-image-file-system-type))) (define install (with-imported-modules '((guix build utils) (gnu build marionette)) @@ -229,16 +233,24 @@ packages defined in installation-os." (define marionette (make-marionette - (cons (which #$(qemu-command system)) - (cons* "-no-reboot" "-m" "800" - "-drive" - (string-append "file=" #$image - ",if=virtio,readonly") - "-drive" - (string-append "file=" #$output ",if=virtio") - (if (file-exists? "/dev/kvm") - '("-enable-kvm") - '()))))) + `(,(which #$(qemu-command system)) + "-no-reboot" + "-m" "800" + ,@(case installation-disk-image-file-system-type + (("ext4") + `("-drive" + ,(string-append "file=" #$image + ",if=virtio,readonly"))) + (("iso9660") '("-cdrom" #$image)) + (else + (error + "unsupported installation-disk-image-file-system-type" + installation-disk-image-file-system-type))) + "-drive" + ,(string-append "file=" #$output ",if=virtio") + ,@(if (file-exists? "/dev/kvm") + '("-enable-kvm") + '())))) (pk 'uname (marionette-eval '(uname) marionette)) @@ -312,6 +324,20 @@ per %test-installed-os, this test is expensive in terms of CPU and storage.") (run-basic-test %minimal-extlinux-os command "installed-extlinux-os"))))) +(define %test-iso-image-installer + (system-test + (name "iso-image-installer") + (description + "") + (value + (mlet* %store-monad ((image (run-install + %minimal-os + %minimal-os-source + #:installation-disk-image-file-system-type + "iso9660")) + (command (qemu-command/writable-image image))) + (run-basic-test %minimal-os command name))))) + ;;; ;;; Separate /home. -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.15040740173621 (code B ref 28288); Wed, 30 Aug 2017 06:21:02 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 06:20:17 +0000 Received: from localhost ([127.0.0.1]:33148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwMJ-0000wD-0a for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:20:15 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:40700 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwMG-0000vw-Tq for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 02:20:13 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id CBF7A13D272; Wed, 30 Aug 2017 07:20:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED,BAYES_00, SUBJ_ALL_CAPS autolearn=no autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 9053D13D273 for <28288@debbugs.gnu.org>; Wed, 30 Aug 2017 07:20:11 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e69d47b0 for <28288@debbugs.gnu.org>; Wed, 30 Aug 2017 06:20:11 +0000 (UTC) From: Christopher Baines Date: Wed, 30 Aug 2017 07:20:10 +0100 Message-Id: <20170830062010.11902-2-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170830062010.11902-1-mail@cbaines.net> References: <20170830062010.11902-1-mail@cbaines.net> X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: --- gnu/build/vm.scm | 19 +++++++++++++++++-- gnu/system/vm.scm | 16 +++++++++++----- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 727494ad9..e2659cb5e 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -366, 12 +366, 27 @@ SYSTEM-DIRECTORY is the name of the directory of the 'system' derivation." (error "failed to create GRUB EFI image")))) [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 SUBJ_ALL_CAPS Subject is all capitals X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: --- gnu/build/vm.scm | 19 +++++++++++++++++-- gnu/system/vm.scm | 16 +++++++++++----- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 727494ad9..e2659cb5e 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -366,12 +366,27 @@ SYSTEM-DIRECTORY is the name of the directory of the 'system' derivation." (error "failed to create GRUB EFI image")))) [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 SUBJ_ALL_CAPS Subject is all capitals --- gnu/build/vm.scm | 19 +++++++++++++++++-- gnu/system/vm.scm | 16 +++++++++++----- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 727494ad9..e2659cb5e 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -366,12 +366,27 @@ SYSTEM-DIRECTORY is the name of the directory of the 'system' derivation." (error "failed to create GRUB EFI image")))) (define* (make-iso9660-image grub config-file os-drv target - #:key (volume-id "GuixSD_image") (volume-uuid #f)) + #:key (volume-id "GuixSD_image") (volume-uuid #f) + register-closures? (closures '())) "Given a GRUB package, creates an iso image as TARGET, using CONFIG-FILE as GRUB configuration and OS-DRV as the stuff in it." - (let ((grub-mkrescue (string-append grub "/bin/grub-mkrescue"))) + (let ((grub-mkrescue (string-append grub "/bin/grub-mkrescue")) + (target-store (string-append "/tmp/root" (%store-directory)))) (mkdir-p "/tmp/root/var/run") (mkdir-p "/tmp/root/run") + + ;; XXX: 'guix-register' wants to palpate the things it registers, so + ;; bind-mount the store on the target. + (mkdir-p target-store) + (mount (%store-directory) target-store "" MS_BIND) + + (when register-closures? + (display "registering closures...\n") + (for-each (lambda (closure) + (register-closure target + (string-append "/xchg/" closure))) + closures)) + (unless (zero? (apply system* `(,grub-mkrescue "-o" ,target ,(string-append "boot/grub/grub.cfg=" config-file) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 4494af003..b106dff0a 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -192,6 +192,7 @@ made available under the /xchg CIFS share." os-drv bootcfg-drv bootloader + register-closures? (inputs '())) "Return a bootable, stand-alone iso9660 image. @@ -207,8 +208,13 @@ INPUTS is a list of inputs (as for packages)." (let ((inputs '#$(append (list qemu parted e2fsprogs dosfstools xorriso) (map canonical-package - (list sed grep coreutils findutils gawk)))) + (list sed grep coreutils findutils gawk)) + (if register-closures? (list guix) '()))) + + (graphs '#$(match inputs + (((names . _) ...) + names))) ;; This variable is unused but allows us to add INPUTS-TO-COPY ;; as inputs. (to-register @@ -222,6 +228,8 @@ INPUTS is a list of inputs (as for packages)." #$bootcfg-drv #$os-drv "/xchg/guixsd.iso" + #:register-closures? #$register-closures? + #:closures graphs #:volume-id #$file-system-label #:volume-uuid #$file-system-uuid) (reboot)))) @@ -391,6 +399,7 @@ to USB sticks meant to be read-only." #:file-system-label root-label #:file-system-uuid #f #:os-drv os-drv + #:register-closures? #t #:bootcfg-drv bootcfg #:bootloader (bootloader-configuration-bootloader (operating-system-bootloader os)) @@ -403,10 +412,7 @@ to USB sticks meant to be read-only." (operating-system-bootloader os)) #:disk-image-size disk-image-size #:disk-image-format "raw" - #:file-system-type (if (string=? "iso9660" - file-system-type) - "ext4" - file-system-type) + #:file-system-type file-system-type #:file-system-label root-label #:copy-inputs? #t #:register-closures? #t -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 06:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Cc: Danny Milosavljevic Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.15040746924740 (code B ref 28288); Wed, 30 Aug 2017 06:32:02 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 06:31:32 +0000 Received: from localhost ([127.0.0.1]:33156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwXE-0001EO-Fy for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:31:32 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:40707 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwXC-0001EF-4B for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 02:31:30 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id DD93D13D273; Wed, 30 Aug 2017 07:31:26 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 1D84713D272; Wed, 30 Aug 2017 07:31:17 +0100 (BST) Date: Wed, 30 Aug 2017 07:31:13 +0100 From: Christopher Baines Message-ID: <20170830073113.426bf8d3@cbaines.net> In-Reply-To: <20170830062010.11902-2-mail@cbaines.net> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/sytQ9MR2gm.onuXu3EtbCGS"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/sytQ9MR2gm.onuXu3EtbCGS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Currently, I get the following error when running this test. registering closures... error: initialising database schema: disk I/O error ERROR: In procedure scm-error: ERROR: failed to register store items "/xchg/system" I also need the patch from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28273 otherwise I can't even run the test. Danny, I guess you have been looking at installing from an ISO image as well, as I spotted you added it to the release target. Have you been able to successfully use it yet? When attempting to use it initially, I encountered a problem where a glibc in the store was partially deleted. /var/guix/db/db.sqlite also initially didn't exist, which the WIP patch here attempts to address.=20 --Sig_/sytQ9MR2gm.onuXu3EtbCGS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmmW7FfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdqaBAAi9jYJNv3jjrcuCXPLMOKmFy/mwY/qJc5tDHsQ+6Y7pQHyKxM5jvvf47e 2lfBSNR1nxVcRnIWSZR+D7ROiZ17Pojy/ipcNkKpJ8KmKrrpnz0Vd1Hj3eBSVufF MndqI+AWIY04DM5IsZ7m/FChlFctRhN9kk5pCjHfmjC/M7qv/EetJpePyyA1tYHX KBao1otepFbQ7DT5u7jj+rT+vnzducTM71zdpi8AsXRSCy0zxBtkAcHamdwgSp59 tI6SkA8QW4N1uWmL+nkX+93taq3I9JhGpG+2OfdGBOf0XXavtbURPPO646KyAB5f mT/lCpgBI9htZ6goLgNuBR9qVs41G3zKjSngz1xLsMatU45j+yulC2FDk9qb0jA1 N1vDSB+YmowjEH+HHjN8SNKuWXcW4+AQ9ZbCEHmmCt9mBQRix24cx2UWQbWnhpCV PXZyiNgapupvM0eIdrMBKxdeHp0zlFs/QWXd4H5BjcweG37X76/A6eM30Fl+jNTG 74VSKeyyALiIV2Lq8UinRjw7ldqmLRDxW4eTOHUe706sFm/kqxBljp+iea2pmwtT jD/r2yy6cqp/ka110QSMq2PRcP3hXrX36iYJFIGElBasMNXQhxQu+EOJLoyP/l3z cL7e8F8SeGLsjkpmPShcZ5wsV2qokI4StaMuBHeLl8V4AUrN5vs= =vQ6g -----END PGP SIGNATURE----- --Sig_/sytQ9MR2gm.onuXu3EtbCGS-- From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 08:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150408228716594 (code B ref 28288); Wed, 30 Aug 2017 08:39:02 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 08:38:07 +0000 Received: from localhost ([127.0.0.1]:33265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmyVj-0004Ja-1j for submit@debbugs.gnu.org; Wed, 30 Aug 2017 04:38:07 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:39360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmyVg-0004JR-Gs for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 04:38:05 -0400 Received: from localhost (unknown [193.170.94.190]) by dd1012.kasserver.com (Postfix) with ESMTPSA id EC7621CA02C0; Wed, 30 Aug 2017 10:38:00 +0200 (CEST) Date: Wed, 30 Aug 2017 10:38:00 +0200 From: Danny Milosavljevic Message-ID: <20170830103800.09ea6e31@scratchpost.org> In-Reply-To: <20170830073113.426bf8d3@cbaines.net> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> <20170830073113.426bf8d3@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Christopher, On Wed, 30 Aug 2017 07:31:13 +0100 Christopher Baines wrote: > Currently, I get the following error when running this test. > > registering closures... > error: initialising database schema: disk I/O error > ERROR: In procedure scm-error: > ERROR: failed to register store items "/xchg/system" > > > I also need the patch from > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28273 otherwise I can't > even run the test. > > Danny, I guess you have been looking at installing from an ISO image as > well, as I spotted you added it to the release target. Have you been > able to successfully use it yet? Does that mean with the wip-installer-2 branch? Otherwise in master I always tested it using gnu/system/install.scm until it has booted up successfully, which it did. I've asked about the installation part before but there was no response. > When attempting to use it initially, I encountered a problem where a > glibc in the store was partially deleted. /var/guix/db/db.sqlite also > initially didn't exist, which the WIP patch here attempts to address. Hmm, do you have logs of the release creation process? Maybe xorriso complained? From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150411760610503 (code B ref 28288); Wed, 30 Aug 2017 18:27:01 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 18:26:46 +0000 Received: from localhost ([127.0.0.1]:34940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn7hO-0002jL-NO for submit@debbugs.gnu.org; Wed, 30 Aug 2017 14:26:46 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:36028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn7hM-0002jC-Dw for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 14:26:44 -0400 Received: from localhost (178.113.186.98.wireless.dyn.drei.com [178.113.186.98]) by dd1012.kasserver.com (Postfix) with ESMTPSA id A7B5C1CA02C0; Wed, 30 Aug 2017 20:26:41 +0200 (CEST) Date: Wed, 30 Aug 2017 20:26:37 +0200 From: Danny Milosavljevic Message-ID: <20170830202637.6b6ace8b@scratchpost.org> In-Reply-To: <20170830062010.11902-2-mail@cbaines.net> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > + ;; XXX: 'guix-register' wants to palpate the things it registers, so > + ;; bind-mount the store on the target. > + (mkdir-p target-store) > + (mount (%store-directory) target-store "" MS_BIND) What does this do? gnu/build/vm.scm make-iso9660-image already provides /gnu/store a few lines down: (unless (zero? (apply system* `(,grub-mkrescue "-o" ,target ,(string-append "boot/grub/grub.cfg=" config-file) ,(string-append "gnu/store=" os-drv "/..") ^^^^ Maybe I'm missing something... Otherwise LGTM! From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: ludo@gnu.org, 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150413381617659 (code B ref 28288); Wed, 30 Aug 2017 22:57:02 +0000 Received: (at 28288) by debbugs.gnu.org; 30 Aug 2017 22:56:56 +0000 Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnBuq-0004ak-6M for submit@debbugs.gnu.org; Wed, 30 Aug 2017 18:56:56 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:41482 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnBun-0004ac-UI for 28288@debbugs.gnu.org; Wed, 30 Aug 2017 18:56:54 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id C0BF914759F; Wed, 30 Aug 2017 23:56:51 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 183E714759E; Wed, 30 Aug 2017 23:56:51 +0100 (BST) Date: Wed, 30 Aug 2017 23:56:47 +0100 From: Christopher Baines Message-ID: <20170830235647.1def024c@cbaines.net> In-Reply-To: <20170830103800.09ea6e31@scratchpost.org> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> <20170830073113.426bf8d3@cbaines.net> <20170830103800.09ea6e31@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/upctJQ6=ndg=.BhJQQTYrzq"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/upctJQ6=ndg=.BhJQQTYrzq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 30 Aug 2017 10:38:00 +0200 Danny Milosavljevic wrote: > Hi Christopher, >=20 > On Wed, 30 Aug 2017 07:31:13 +0100 > Christopher Baines wrote: >=20 > > Currently, I get the following error when running this test. > >=20 > > registering closures... > > error: initialising database schema: disk I/O error > > ERROR: In procedure scm-error: > > ERROR: failed to register store items "/xchg/system" > >=20 > >=20 > > I also need the patch from > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28273 otherwise I > > can't even run the test. > >=20 > > Danny, I guess you have been looking at installing from an ISO > > image as well, as I spotted you added it to the release target. > > Have you been able to successfully use it yet? =20 >=20 > Does that mean with the wip-installer-2 branch? I've just been testing with the master branch, and with the changes I sent to this bug. Are there any changes on the wip-installer-2 that are not solely related to the installer (which if I understand correctly is something more complicated than running guix system init). > Otherwise in master I always tested it using gnu/system/install.scm > until it has booted up successfully, which it did. >=20 > I've asked about the installation part before but there was no > response. Ok, that's good to know. I would guess it's pretty close now, great work on moving the ISO stuff forward! > > When attempting to use it initially, I encountered a problem where a > > glibc in the store was partially deleted. /var/guix/db/db.sqlite > > also initially didn't exist, which the WIP patch here attempts to > > address. =20 >=20 > Hmm, do you have logs of the release creation process? Maybe xorriso > complained? =46rom talking to Ludo at the GHM, I think there is some extra steps needed to make installing from the ISO possible, but I don't yet understand this. I'll CC Ludo, as he might be able to explain better. --Sig_/upctJQ6=ndg=.BhJQQTYrzq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmnQq9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdB8xAAnBSNLrJl/3YXua8Xi42talpiWmAcJHH9i5fcrArKUC+Z6ANR9lB8eLD4 UIolLVj3LEg8imcFVIhg3anUqo3kZgP7lYo6LnpD6kA19zF8Jya0MlqXoDbFbrHJ rPPmxzedhzUM/elI32Mc0z0jy4Z+O4ashEnFYHETd6k7MMpwRUXxaVlGYjb0EL80 pUQ4Vne67WhI7DDC693oR7L19lZW5AmOTUG+F5dnLvmg3L9lMoBYOTWp535T0L7H 72Q1yklgTVB02VsZA8jDaSkag3i108kzaYWteo8tLjVjh00ifDK3F7UBGbLJeBMP VgidFHaiwiNCNiyIQqevE7Y0nqejY0/UHgfJH0HpxLaz9QZgaONU7EA1tvkRQsbx Aflq+GcKm00be7UIFGqMsApJyHNMOCUQuIFucMWkM9TNiGl0apR7IVAOjklUifkK ZCOg8Y+6EeZcgJZ9BQ2/DfJTxl9sPAuUaavwtOWZQ8ZSyhdelEysuZ+vfX6/kaXC uqcpcpnqViAX9SxKoapLbLvbz0w4+XLWDIZwcobMBL2q8xJM6umeTSb44XV2CSwX sXxKutr+jclG/syjyVunmiA2YLO5kSTmYeD8/3GeYiCackdqZrFzPyR2XMJdik/j lmPYpV+dOpcX5RkGppT+Jf27hqsqAe8VxwJY56CxYjHseeQC2yc= =o73k -----END PGP SIGNATURE----- --Sig_/upctJQ6=ndg=.BhJQQTYrzq-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 06:28:04 2017 Received: (at control) by debbugs.gnu.org; 31 Aug 2017 10:28:04 +0000 Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnMhg-0007he-7m for submit@debbugs.gnu.org; Thu, 31 Aug 2017 06:28:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnMhd-0007h3-SD for control@debbugs.gnu.org; Thu, 31 Aug 2017 06:28:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnMhV-0002qB-Oa for control@debbugs.gnu.org; Thu, 31 Aug 2017 06:27:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnMhV-0002q5-Lv for control@debbugs.gnu.org; Thu, 31 Aug 2017 06:27:53 -0400 Received: from [193.50.110.184] (port=45934 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dnMhV-0002ZO-4R for control@debbugs.gnu.org; Thu, 31 Aug 2017 06:27:53 -0400 Date: Thu, 31 Aug 2017 12:27:51 +0200 Message-Id: <87val4uj4o.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #28288 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) severity 28288 important From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 31 Aug 2017 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: ludo@gnu.org, 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150418469626494 (code B ref 28288); Thu, 31 Aug 2017 13:05:01 +0000 Received: (at 28288) by debbugs.gnu.org; 31 Aug 2017 13:04:56 +0000 Received: from localhost ([127.0.0.1]:36492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnP9T-0006tG-TY for submit@debbugs.gnu.org; Thu, 31 Aug 2017 09:04:56 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:46712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnP9R-0006t6-SJ for 28288@debbugs.gnu.org; Thu, 31 Aug 2017 09:04:54 -0400 Received: from localhost (77.118.176.103.wireless.dyn.drei.com [77.118.176.103]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 841D61CA02C0; Thu, 31 Aug 2017 15:04:51 +0200 (CEST) Date: Thu, 31 Aug 2017 15:04:48 +0200 From: Danny Milosavljevic Message-ID: <20170831150448.41b0f41e@scratchpost.org> In-Reply-To: <20170830235647.1def024c@cbaines.net> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> <20170830073113.426bf8d3@cbaines.net> <20170830103800.09ea6e31@scratchpost.org> <20170830235647.1def024c@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, 30 Aug 2017 23:56:47 +0100 Christopher Baines wrote: > I've just been testing with the master branch, and with the changes I > sent to this bug. Are there any changes on the wip-installer-2 that are > not solely related to the installer No >(which if I understand correctly is something more complicated than running guix system init). Yes From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/2] WIP Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 31 Aug 2017 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150421605313901 (code B ref 28288); Thu, 31 Aug 2017 21:48:01 +0000 Received: (at 28288) by debbugs.gnu.org; 31 Aug 2017 21:47:33 +0000 Received: from localhost ([127.0.0.1]:38234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnXJF-0003c9-7C for submit@debbugs.gnu.org; Thu, 31 Aug 2017 17:47:33 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:42401 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnXJD-0003c1-RX for 28288@debbugs.gnu.org; Thu, 31 Aug 2017 17:47:32 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 8A34913D287; Thu, 31 Aug 2017 22:47:29 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 329B213D286; Thu, 31 Aug 2017 22:47:29 +0100 (BST) Date: Thu, 31 Aug 2017 22:47:28 +0100 From: Christopher Baines Message-ID: <20170831224728.59e79444@cbaines.net> In-Reply-To: <20170831150448.41b0f41e@scratchpost.org> References: <20170830062010.11902-1-mail@cbaines.net> <20170830062010.11902-2-mail@cbaines.net> <20170830073113.426bf8d3@cbaines.net> <20170830103800.09ea6e31@scratchpost.org> <20170830235647.1def024c@cbaines.net> <20170831150448.41b0f41e@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/5h2thJwWoSCIuXAXK.H0XHA"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/5h2thJwWoSCIuXAXK.H0XHA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 31 Aug 2017 15:04:48 +0200 Danny Milosavljevic wrote: > On Wed, 30 Aug 2017 23:56:47 +0100 > Christopher Baines wrote: >=20 > > I've just been testing with the master branch, and with the changes > > I sent to this bug. Are there any changes on the wip-installer-2 > > that are not solely related to the installer =20 >=20 > No >=20 > >(which if I understand correctly is something more complicated than > >running guix system init). =20 >=20 > Yes Great, ok, good to know I haven't missed anything. I'll hopefully be able to make some time soonish to take a look at getting the ISO image in to a state where running guix system init from it works, unless someone beats me to it! --Sig_/5h2thJwWoSCIuXAXK.H0XHA Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmog/BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xd8eQ//RhGH89BwqPRQCF8lenUNLiDL4sjWgfTGuYGneJneMWt9vqSVr6sj6yVw e0F1QmVgSDyfdIbHw6rs/h78WWC2ETMLMdMwpsddka5HjR13Tis+pNS9Jvv++Wva OMQoHH80C6z6VoOnqGb/xVJMDWoO/cHYwmMCW4VHX6X9GGhj/Y7XtKHHHwr5eMl/ BfWnNnkZ4+Eb3Xh7DtGSZiqIbnEWZNU4UT6BCKonfc1cDk4Grb6eFO9xq+e4BPcC IuTQMUXgLkaxpIay6gGS6bLeseuAgXnQk5rp4EuaSrRnztwAOxmuxvX3FwM7edg9 Xtm7jmCIURHf3fotPgROQhxtVsdxSlcY6173ZJoWLPaIRrI+z2sYbtO7Ojk8lpvJ cGkMiWqiNvreQeCVhWeBjQNpZ3sZRzrzVyY9RwXg/UEwX4YICjqbpfM30AZPzSXW yngSgRvU0nuJTX7w81TZfNfuhZNu8+m9ZaS8Tz2Jl3Fk9iGywHJkvc/QV/sDoZwg e27cPN/9zeauH8uqHS9rjn32digRcXZHQkqOdNjPeBMIOX5c8v6bYn5JV3Hunb1b TdrTykGOXleZh1A+cveqAhD97cdc0llMtNjwyksdNzbUr4563oxokl1nh/evBsbC nkMKF/hG3iqqlYH4Q0Xxfq85FdfXOY3NJ0AUzLV+03t65OseB68= =LqV3 -----END PGP SIGNATURE----- --Sig_/5h2thJwWoSCIuXAXK.H0XHA-- From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 3/5] vm: Add support for registering closures to iso9660-image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443584616914 (code B ref 28288); Sun, 03 Sep 2017 10:51:02 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:50:46 +0000 Received: from localhost ([127.0.0.1]:44836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUI-0004Oj-1S for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44612 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUF-0004OB-Jb for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id D7D8C13D2BC; Sun, 3 Sep 2017 11:50:42 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 8408B13D2BE for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:50:42 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b2df93ce for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 10:50:42 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:50:39 +0100 Message-Id: <20170903105041.2925-3-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/system/vm.scm (iso9660-image): Add support for registering closures. --- gnu/system/vm.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 4494af003..fc55935aa 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -192,6 +192,7 @@ made available under the /xchg CIFS share." os-drv bootcfg-drv bootloader + register-closures? (inputs '())) "Return a bootable, stand-alone iso9660 image. @@ -207,8 +208,13 @@ INPUTS is a list of inputs (as for packages)." (let ((inputs '#$(append (list qemu parted e2fsprogs dosfstools xorriso) (map canonical-package - (list sed grep coreutils findutils gawk)))) + (list sed grep coreutils findutils gawk)) + (if register-closures? (list guix) '()))) + + (graphs '#$(match inputs + (((names . _) ...) + names))) ;; This variable is unused but allows us to add INPUTS-TO-COPY ;; as inputs. (to-register @@ -222,6 +228,8 @@ INPUTS is a list of inputs (as for packages)." #$bootcfg-drv #$os-drv "/xchg/guixsd.iso" + #:register-closures? #$register-closures? + #:closures graphs #:volume-id #$file-system-label #:volume-uuid #$file-system-uuid) (reboot)))) -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. References: <20170830071714.75f88e47@cbaines.net> In-Reply-To: <20170830071714.75f88e47@cbaines.net> Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443584616921 (code B ref 28288); Sun, 03 Sep 2017 10:51:02 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:50:46 +0000 Received: from localhost ([127.0.0.1]:44838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUI-0004Ol-7p for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44611 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUF-0004OA-JH for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id B5AC113D2C1; Sun, 3 Sep 2017 11:50:42 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 6179013D2BC for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:50:42 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d78f46ec for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 10:50:42 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:50:37 +0100 Message-Id: <20170903105041.2925-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This mimics the functionality in the root-partition-initializer used in creating the QEMU image. This helps when trying to run guix system init from the generated ISO image. * gnu/build/vm.scm (make-iso9660-image): Add support for registering closures. --- gnu/build/vm.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 727494ad9..606257d8c 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -366,12 +366,27 @@ SYSTEM-DIRECTORY is the name of the directory of the 'system' derivation." (error "failed to create GRUB EFI image")))) (define* (make-iso9660-image grub config-file os-drv target - #:key (volume-id "GuixSD_image") (volume-uuid #f)) + #:key (volume-id "GuixSD_image") (volume-uuid #f) + register-closures? (closures '())) "Given a GRUB package, creates an iso image as TARGET, using CONFIG-FILE as GRUB configuration and OS-DRV as the stuff in it." - (let ((grub-mkrescue (string-append grub "/bin/grub-mkrescue"))) + (let ((grub-mkrescue (string-append grub "/bin/grub-mkrescue")) + (target-store (string-append "/tmp/root" (%store-directory)))) (mkdir-p "/tmp/root/var/run") (mkdir-p "/tmp/root/run") + + (mkdir-p target-store) + (mount (%store-directory) target-store "" MS_BIND) + + (when register-closures? + (display "registering closures...\n") + (for-each (lambda (closure) + (register-closure + "/tmp/root" + (string-append "/xchg/" closure) + #:deduplicate? #f)) + closures)) + (unless (zero? (apply system* `(,grub-mkrescue "-o" ,target ,(string-append "boot/grub/grub.cfg=" config-file) -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/5] vm: Create /mnt in the generated ISO image in make-iso9660-image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443584616928 (code B ref 28288); Sun, 03 Sep 2017 10:51:03 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:50:46 +0000 Received: from localhost ([127.0.0.1]:44840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUI-0004Os-He for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44614 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUG-0004OE-0J for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id A2B6413D2BD; Sun, 3 Sep 2017 11:50:42 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 72D8513D2BD for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:50:42 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 8c39b43c for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 10:50:42 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:50:38 +0100 Message-Id: <20170903105041.2925-2-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is used in the installation process, as the mountpoint for the target filesystem. * gnu/build/vm.scm (make-iso9660-image): Create /mnt within the generated ISO image. --- gnu/build/vm.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 606257d8c..f6228b40b 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -374,6 +374,7 @@ GRUB configuration and OS-DRV as the stuff in it." (target-store (string-append "/tmp/root" (%store-directory)))) (mkdir-p "/tmp/root/var/run") (mkdir-p "/tmp/root/run") + (mkdir-p "/tmp/root/mnt") (mkdir-p target-store) (mount (%store-directory) target-store "" MS_BIND) @@ -393,6 +394,10 @@ GRUB configuration and OS-DRV as the stuff in it." ,(string-append "gnu/store=" os-drv "/..") "var=/tmp/root/var" "run=/tmp/root/run" + ;; /mnt is used as part of the installation + ;; process, as the mount point for the target + ;; filesystem, so create it. + "mnt=/tmp/root/mnt" "--" ;; Store two copies of the headers. ;; The resulting ISO-9660 image has a DOS MBR and -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443584716936 (code B ref 28288); Sun, 03 Sep 2017 10:51:03 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:50:47 +0000 Received: from localhost ([127.0.0.1]:44842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUI-0004Oz-PT for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:47 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44613 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUF-0004OC-JY for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 04D0313D2BE; Sun, 3 Sep 2017 11:50:43 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id B158E13D2C0 for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:50:42 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 096a11e1 for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 10:50:42 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:50:41 +0100 Message-Id: <20170903105041.2925-5-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/tests/install.scm (%test-iso-image-installer): New variable. (run-install): Add #:installation-disk-image-file-system-type as a keyword argument. --- gnu/tests/install.scm | 110 +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 99 insertions(+), 11 deletions(-) diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm index 866bf885c..93c8a89cd 100644 --- a/gnu/tests/install.scm +++ b/gnu/tests/install.scm @@ -37,6 +37,7 @@ #:use-module (guix utils) #:export (%test-installed-os %test-installed-extlinux-os + %test-iso-image-installer %test-separate-store-os %test-separate-home-os %test-raid-root-os @@ -196,6 +197,7 @@ reboot\n") (kernel-arguments '("console=ttyS0"))) #:imported-modules '((gnu services herd) (guix combinators)))) + (installation-disk-image-file-system-type "ext4") (target-size (* 1200 MiB))) "Run SCRIPT (a shell script following the GuixSD installation procedure) in OS to install TARGET-OS. Return a VM image of TARGET-SIZE bytes containing @@ -213,7 +215,9 @@ packages defined in installation-os." (image (system-disk-image (operating-system-with-gc-roots os (list target)) - #:disk-image-size (* 1500 MiB)))) + #:disk-image-size (* 1500 MiB) + #:file-system-type + installation-disk-image-file-system-type))) (define install (with-imported-modules '((guix build utils) (gnu build marionette)) @@ -229,16 +233,25 @@ packages defined in installation-os." (define marionette (make-marionette - (cons (which #$(qemu-command system)) - (cons* "-no-reboot" "-m" "800" - "-drive" - (string-append "file=" #$image - ",if=virtio,readonly") - "-drive" - (string-append "file=" #$output ",if=virtio") - (if (file-exists? "/dev/kvm") - '("-enable-kvm") - '()))))) + `(,(which #$(qemu-command system)) + "-no-reboot" + "-m" "800" + #$@(cond + ((string=? "ext4" installation-disk-image-file-system-type) + `("-drive" + ,(file-append "file=" image + ",if=virtio,readonly"))) + ((string=? "iso9660" installation-disk-image-file-system-type) + `("-cdrom" ,image)) + (else + (error + "unsupported installation-disk-image-file-system-type:" + installation-disk-image-file-system-type))) + "-drive" + ,(string-append "file=" #$output ",if=virtio") + ,@(if (file-exists? "/dev/kvm") + '("-enable-kvm") + '())))) (pk 'uname (marionette-eval '(uname) marionette)) @@ -313,6 +326,81 @@ per %test-installed-os, this test is expensive in terms of CPU and storage.") "installed-extlinux-os"))))) +;;; +;;; Installation through an ISO image. +;;; + +(define-os-with-source (%minimal-os-on-vda %minimal-os-on-vda-source) + ;; The OS we want to install. + (use-modules (gnu) (gnu tests) (srfi srfi-1)) + + (operating-system + (host-name "liberigilo") + (timezone "Europe/Paris") + (locale "en_US.UTF-8") + + (bootloader (grub-configuration (target "/dev/vda"))) + (kernel-arguments '("console=ttyS0")) + (file-systems (cons (file-system + (device "my-root") + (title 'label) + (mount-point "/") + (type "ext4")) + %base-file-systems)) + (users (cons (user-account + (name "alice") + (comment "Bob's sister") + (group "users") + (supplementary-groups '("wheel" "audio" "video")) + (home-directory "/home/alice")) + %base-user-accounts)) + (services (cons (service marionette-service-type + (marionette-configuration + (imported-modules '((gnu services herd) + (guix combinators))))) + %base-services)))) + +(define %simple-installation-script-for-/dev/vda + ;; Shell script of a simple installation. + "\ +. /etc/profile +set -e -x +guix --version + +export GUIX_BUILD_OPTIONS=--no-grafts +guix build isc-dhcp +parted --script /dev/vda mklabel gpt \\ + mkpart primary ext2 1M 3M \\ + mkpart primary ext2 3M 1G \\ + set 1 boot on \\ + set 1 bios_grub on +mkfs.ext4 -L my-root /dev/vda2 +mount /dev/vda2 /mnt +df -h /mnt +herd start cow-store /mnt +mkdir /mnt/etc +cp /etc/target-config.scm /mnt/etc/config.scm +guix system init /mnt/etc/config.scm /mnt --no-substitutes +sync +reboot\n") + +(define %test-iso-image-installer + (system-test + (name "iso-image-installer") + (description + "") + (value + (mlet* %store-monad ((image (run-install + %minimal-os-on-vda + %minimal-os-on-vda-source + #:script + %simple-installation-script-for-/dev/vda + #:installation-disk-image-file-system-type + "iso9660")) + (command (qemu-command/writable-image image))) + (run-basic-test %minimal-os-on-vda command name))))) + + ;;; ;;; Separate /home. ;;; -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 4/5] vm: Call iso9660-image with #:register-closures? as #t. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:51:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443584716942 (code B ref 28288); Sun, 03 Sep 2017 10:51:05 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:50:47 +0000 Received: from localhost ([127.0.0.1]:44844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUJ-0004P7-3Y for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:47 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44615 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSUG-0004OR-K0 for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:50:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 2208613D2C0; Sun, 3 Sep 2017 11:50:44 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 9596B13D2BF for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:50:42 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 8f49d7b4 for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 10:50:42 +0000 (UTC) From: Christopher Baines Date: Sun, 3 Sep 2017 11:50:40 +0100 Message-Id: <20170903105041.2925-4-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/system/vm.scm (system-disk-image): Call iso9660-image with #:register-closures? as #t. --- gnu/system/vm.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index fc55935aa..9cd973385 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -399,6 +399,7 @@ to USB sticks meant to be read-only." #:file-system-label root-label #:file-system-uuid #f #:os-drv os-drv + #:register-closures? #t #:bootcfg-drv bootcfg #:bootloader (bootloader-configuration-bootloader (operating-system-bootloader os)) -- 2.14.1 From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150443632717639 (code B ref 28288); Sun, 03 Sep 2017 10:59:02 +0000 Received: (at 28288) by debbugs.gnu.org; 3 Sep 2017 10:58:47 +0000 Received: from localhost ([127.0.0.1]:44860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSc2-0004aQ-64 for submit@debbugs.gnu.org; Sun, 03 Sep 2017 06:58:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44626 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doSbz-0004aG-KJ for 28288@debbugs.gnu.org; Sun, 03 Sep 2017 06:58:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 1393613D2BD; Sun, 3 Sep 2017 11:58:42 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 954BF13D2BC for <28288@debbugs.gnu.org>; Sun, 3 Sep 2017 11:58:41 +0100 (BST) Date: Sun, 3 Sep 2017 11:58:38 +0100 From: Christopher Baines Message-ID: <20170903115838.0bc74483@cbaines.net> In-Reply-To: <20170903105041.2925-5-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-5-mail@cbaines.net> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Fhjhdk12Ke=CA688aYSgRv."; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/Fhjhdk12Ke=CA688aYSgRv. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 3 Sep 2017 11:50:41 +0100 Christopher Baines wrote: > * gnu/tests/install.scm (%test-iso-image-installer): New variable. > (run-install): Add #:installation-disk-image-file-system-type as a > keyword argument. > --- > gnu/tests/install.scm | 110 > +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 99 > insertions(+), 11 deletions(-) This test now passes! I've also successfully generated an ISO image that I used to install GuixSD to a Bytemark VM [1]. Most of the changes are educated guesses, mostly from copying the code relating to QEMU images, so it would good to get some review of these. 1: https://www.bytemark.co.uk/cloud-hosting/ --Sig_/Fhjhdk12Ke=CA688aYSgRv. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmr4F5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XezBQ/9FNUWhMFPImQn8HHLbMtaMa2Qdd8j5U6nZvbGuyqcBU/YnG0F03MQddUI n+RnwGu6vkdIAr+Mpyj5fjrYjJ651nfl5exfaiEia6A/swgCNR23LkdsbYB9dOI3 2qZZZwhG8MHUjm9cpLSKfrPcGpbCN/OZ0dTxm74bFO4G+Ngg8vWXmof35o4AVp0S Jt1nYW+Gh7cgHEBUruBFzm9r9GY2sy443lVO/PueJHjTkvpCs1+949QWhnmB09eP 6DSQGxH8FRe/b525RfdhTodTlXgC8zm7GmSGXPHzoGAAK79V7R/+dHkFA3bRMuto Urd5h0ZtL4oyOF9YTnl8QGcqmX8cv6il8U9DylY/kFv2Do0IW0C6phcF+G12GovG tBjivLS1K7HOOs+6+0nAaBA58u30Yco6CvZh7RxmvV9PGUsI4Q30Jn4G1QeSM/qp Hm3es321OqwKR6iwT0JjltRMZi1pLFSna5umOAYzSQdsi70eXBiaWv6SJ/xX0Yc1 B/J2+WpSw7sBUZdrDdHH+ZArhFTTitzav2AJsrwlNRM7DQP3Cdu72C9jJ0DBTO5/ tFfNgIVqW8bmtvOJyeFoRpT39dVnnlvgz3hpstdel5jb2kTw5muwuTwA4KX+XbEI h67lh8T0V75KZWtKjy3rOU36e+9Y6AiAW4DGakRrcjLccQa8djI= =1e8G -----END PGP SIGNATURE----- --Sig_/Fhjhdk12Ke=CA688aYSgRv.-- From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 4/5] vm: Call iso9660-image with #:register-closures? as #t. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461622122863 (code B ref 28288); Tue, 05 Sep 2017 12:57:01 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 12:57:01 +0000 Received: from localhost ([127.0.0.1]:50522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDPY-0005we-P1 for submit@debbugs.gnu.org; Tue, 05 Sep 2017 08:57:00 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:49988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDPX-0005wW-2p for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 08:56:59 -0400 Received: from localhost (77.118.238.206.wireless.dyn.drei.com [77.118.238.206]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 58D611CA020C; Tue, 5 Sep 2017 14:56:57 +0200 (CEST) Date: Tue, 5 Sep 2017 14:56:54 +0200 From: Danny Milosavljevic Message-ID: <20170905145654.507c1c51@scratchpost.org> In-Reply-To: <20170903105041.2925-4-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-4-mail@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 3/5] vm: Add support for registering closures to iso9660-image. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461626122939 (code B ref 28288); Tue, 05 Sep 2017 12:58:01 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 12:57:41 +0000 Received: from localhost ([127.0.0.1]:50526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDQD-0005xv-1p for submit@debbugs.gnu.org; Tue, 05 Sep 2017 08:57:41 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDQA-0005xm-Uc for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 08:57:39 -0400 Received: from localhost (77.118.238.206.wireless.dyn.drei.com [77.118.238.206]) by dd1012.kasserver.com (Postfix) with ESMTPSA id DE4B61CA020C; Tue, 5 Sep 2017 14:57:37 +0200 (CEST) Date: Tue, 5 Sep 2017 14:57:36 +0200 From: Danny Milosavljevic Message-ID: <20170905145736.3956109f@scratchpost.org> In-Reply-To: <20170903105041.2925-3-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-3-mail@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 2/5] vm: Create /mnt in the generated ISO image in make-iso9660-image. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461629423012 (code B ref 28288); Tue, 05 Sep 2017 12:59:02 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 12:58:14 +0000 Received: from localhost ([127.0.0.1]:50530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDQk-0005z6-A7 for submit@debbugs.gnu.org; Tue, 05 Sep 2017 08:58:14 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDQh-0005yx-GY for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 08:58:13 -0400 Received: from localhost (77.118.238.206.wireless.dyn.drei.com [77.118.238.206]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 708C81CA020C; Tue, 5 Sep 2017 14:58:10 +0200 (CEST) Date: Tue, 5 Sep 2017 14:58:04 +0200 From: Danny Milosavljevic Message-ID: <20170905145804.4a65b5bc@scratchpost.org> In-Reply-To: <20170903105041.2925-2-mail@cbaines.net> References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-2-mail@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461747032049 (code B ref 28288); Tue, 05 Sep 2017 13:18:02 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 13:17:50 +0000 Received: from localhost ([127.0.0.1]:50579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDjh-0008Kr-OL for submit@debbugs.gnu.org; Tue, 05 Sep 2017 09:17:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDjg-0008Ke-Td for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:17:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpDjS-0003x2-9Y for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:17:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpDjS-0003wi-69; Tue, 05 Sep 2017 09:17:34 -0400 Received: from [193.50.110.184] (port=41216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpDjR-0002yT-Fb; Tue, 05 Sep 2017 09:17:33 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> Date: Tue, 05 Sep 2017 15:17:32 +0200 In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 3 Sep 2017 11:50:37 +0100") Message-ID: <877exds2s3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! Christopher Baines skribis: > This mimics the functionality in the root-partition-initializer used in > creating the QEMU image. This helps when trying to run guix system init f= rom > the generated ISO image. > > * gnu/build/vm.scm (make-iso9660-image): Add support for registering clos= ures. [...] > + (when register-closures? > + (display "registering closures...\n") > + (for-each (lambda (closure) > + (register-closure > + "/tmp/root" > + (string-append "/xchg/" closure) > + #:deduplicate? #f)) > + closures)) Was there any specific reason for #:deduplicate? #f here? Otherwise LGTM! Ludo=E2=80=99. From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461751632137 (code B ref 28288); Tue, 05 Sep 2017 13:19:01 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 13:18:36 +0000 Received: from localhost ([127.0.0.1]:50584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDkS-0008MH-0X for submit@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDkP-0008M5-Rk for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpDkG-0004X9-7c for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpDkG-0004X5-3x; Tue, 05 Sep 2017 09:18:24 -0400 Received: from [193.50.110.184] (port=41218 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpDkF-00035E-OB; Tue, 05 Sep 2017 09:18:23 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-5-mail@cbaines.net> <20170903115838.0bc74483@cbaines.net> Date: Tue, 05 Sep 2017 15:18:22 +0200 In-Reply-To: <20170903115838.0bc74483@cbaines.net> (Christopher Baines's message of "Sun, 3 Sep 2017 11:58:38 +0100") Message-ID: <873781s2qp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Baines skribis: > On Sun, 3 Sep 2017 11:50:41 +0100 > Christopher Baines wrote: > >> * gnu/tests/install.scm (%test-iso-image-installer): New variable. >> (run-install): Add #:installation-disk-image-file-system-type as a >> keyword argument. >> --- >> gnu/tests/install.scm | 110 >> +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 99 >> insertions(+), 11 deletions(-) > > This test now passes! I've also successfully generated an ISO image > that I used to install GuixSD to a Bytemark VM [1]. Woohoo, really nice! \o/ Thanks for persevering! Ludo=E2=80=99. From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 4/5] vm: Call iso9660-image with #:register-closures? as #t. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2017 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: Christopher Baines , 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150461753832174 (code B ref 28288); Tue, 05 Sep 2017 13:19:02 +0000 Received: (at 28288) by debbugs.gnu.org; 5 Sep 2017 13:18:58 +0000 Received: from localhost ([127.0.0.1]:50587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDko-0008Ms-89 for submit@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpDkm-0008Mg-8F for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpDkX-0004jz-Si for 28288@debbugs.gnu.org; Tue, 05 Sep 2017 09:18:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpDkX-0004ju-QK; Tue, 05 Sep 2017 09:18:41 -0400 Received: from [193.50.110.184] (port=41220 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpDkX-00037C-C0; Tue, 05 Sep 2017 09:18:41 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-4-mail@cbaines.net> <20170905145654.507c1c51@scratchpost.org> Date: Tue, 05 Sep 2017 15:18:39 +0200 In-Reply-To: <20170905145654.507c1c51@scratchpost.org> (Danny Milosavljevic's message of "Tue, 5 Sep 2017 14:56:54 +0200") Message-ID: <87y3ptqo5s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > LGTM! +1! Excellent. Ludo'. From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Sep 2017 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150468154011990 (code B ref 28288); Wed, 06 Sep 2017 07:06:02 +0000 Received: (at 28288) by debbugs.gnu.org; 6 Sep 2017 07:05:40 +0000 Received: from localhost ([127.0.0.1]:52193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpUP5-00037J-VR for submit@debbugs.gnu.org; Wed, 06 Sep 2017 03:05:40 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:47224 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpUP3-00037B-TL for 28288@debbugs.gnu.org; Wed, 06 Sep 2017 03:05:38 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 423ED13E41F; Wed, 6 Sep 2017 08:05:37 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 299E713E41E; Wed, 6 Sep 2017 08:05:36 +0100 (BST) Date: Wed, 6 Sep 2017 08:05:32 +0100 From: Christopher Baines Message-ID: <20170906080515.4764be7b@cbaines.net> In-Reply-To: <877exds2s3.fsf@gnu.org> References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/CKeCvlMRM//bV31ZLQ2B3G0"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/CKeCvlMRM//bV31ZLQ2B3G0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 05 Sep 2017 15:17:32 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi! >=20 > Christopher Baines skribis: >=20 > > This mimics the functionality in the root-partition-initializer > > used in creating the QEMU image. This helps when trying to run guix > > system init from the generated ISO image. > > > > * gnu/build/vm.scm (make-iso9660-image): Add support for > > registering closures. =20 >=20 > [...] >=20 > > + (when register-closures? > > + (display "registering closures...\n") > > + (for-each (lambda (closure) > > + (register-closure > > + "/tmp/root" > > + (string-append "/xchg/" closure) > > + #:deduplicate? #f)) > > + closures)) =20 >=20 > Was there any specific reason for #:deduplicate? #f here? Yep, the image creation process fails if this is not specified. error: cannot link `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025r0y6= lqfs0' to `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firmware= /b43-open': Invalid cross-device link There is probably another way around this though. I'm not sure what impact skipping the deduplication has on the size of the image. > Otherwise LGTM! >=20 > Ludo=E2=80=99. --Sig_/CKeCvlMRM//bV31ZLQ2B3G0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmvnjxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfJ/w/+KF+vED7ESj9+SI91bVgaGeUoTa1iMI9IZypuknPkjntJPiobGCAx5P2y Iq7b/y+svPgQEPNdXI7yOacbKrz8UyY7prnXgAuQeE73u+bPiKef999fCRVRVkUv qWeNXMNCL9FlqHz4ASQxlsAKqVW974w2e2fgO6qYyeR6gVoV1+Cqe0rJS4EG0dK9 YgTKu+3WXepGhsAOU2LEqCYo3+PTCROjjx6Xb2Y25G2I7WZOIquyUjR++78X7+h6 BBmRY3kZ1IUA4NQ48IssbIpf9voB7rD6j/XYppDncKqSSoic3CwueczsyakF5LaT xODRlTJiI8U3JUtrdhDlWuivfl0HQu9cXjzTqPxpspgoL01O0K0Ma3gm7a/fmCg+ rfs+iGJj8kgvyCaMIxe/UzRvFTHdpcUA1kbD4nIL6d4DaPWcR30g719Fb+2Yeidy am3Wg1xC30cWqztNfLnklVeRY8oLFDGq8oORFiObpjB4bm8p3IEF7FHtFWjuj5kc Y3N4WkfXQS6OHZyq4XDDv17qPMq2npsc9cS7/1YiBLjUOA+vmkqwBxYv5yJPjxIp /wY5ZyDlHB3S1tpWdG4/sUAzaSd3DNV5KjyI7Oq8ZWqGfbUufg860JTaq3o6T1/W XxSHsQ6kr+yZsPXW08pmE0fQebcgTIJ7U/yC9uBhWJv9klKNGRE= =AC6Y -----END PGP SIGNATURE----- --Sig_/CKeCvlMRM//bV31ZLQ2B3G0-- From unknown Sun Jun 22 17:15:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#28288: closed (Re: [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image.) Message-ID: References: <20170906084649.5835480e@cbaines.net> <20170830071714.75f88e47@cbaines.net> X-Gnu-PR-Message: they-closed 28288 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28288@debbugs.gnu.org Date: Wed, 06 Sep 2017 07:47:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1504684021-15708-1" This is a multi-part message in MIME format... ------------=_1504684021-15708-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28288: [PATCH] Test and fix the ISO Image Installer which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28288@debbugs.gnu.org. --=20 28288: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28288 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1504684021-15708-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28288-done) by debbugs.gnu.org; 6 Sep 2017 07:46:55 +0000 Received: from localhost ([127.0.0.1]:52208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpV30-00044z-Na for submit@debbugs.gnu.org; Wed, 06 Sep 2017 03:46:54 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:47246 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpV2y-00044r-K2 for 28288-done@debbugs.gnu.org; Wed, 06 Sep 2017 03:46:53 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 01AEB13E421; Wed, 6 Sep 2017 08:46:51 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 0C23B13E41E; Wed, 6 Sep 2017 08:46:50 +0100 (BST) Date: Wed, 6 Sep 2017 08:46:49 +0100 From: Christopher Baines To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=), Danny Milosavljevic Subject: Re: [bug#28288] [PATCH 5/5] tests: Add test for installing from an ISO Image. Message-ID: <20170906084649.5835480e@cbaines.net> In-Reply-To: <873781s2qp.fsf@gnu.org> References: <20170903105041.2925-1-mail@cbaines.net> <20170903105041.2925-5-mail@cbaines.net> <20170903115838.0bc74483@cbaines.net> <873781s2qp.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/tF8x7S/e9az.9TKjK3.X7ti"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28288-done Cc: 28288-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/tF8x7S/e9az.9TKjK3.X7ti Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 05 Sep 2017 15:18:22 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > On Sun, 3 Sep 2017 11:50:41 +0100 > > Christopher Baines wrote: > > =20 > >> * gnu/tests/install.scm (%test-iso-image-installer): New variable. > >> (run-install): Add #:installation-disk-image-file-system-type as > >> a keyword argument. > >> --- > >> gnu/tests/install.scm | 110 > >> +++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, > >> 99 insertions(+), 11 deletions(-) =20 > > > > This test now passes! I've also successfully generated an ISO image > > that I used to install GuixSD to a Bytemark VM [1]. =20 >=20 > Woohoo, really nice! \o/ >=20 > Thanks for persevering! Danny, Ludo, thanks for reviewing :) I've now pushed these changes. --Sig_/tF8x7S/e9az.9TKjK3.X7ti Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmvp+lfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xf5WxAApqKcpX6cGIRvUvkr17Sj1S5gahcddKUvsWLBo+I4yEMIz0GrNzZSd7eD vskZUBh9WAfCjGHBwO7+3gs/56OefK+2sn30k9JKqjmLOwQYS6wlaeAySEVTN4KT Hl6IGKK5Deb92Jal41EtiSzntv+zCmjTmWYI1T7QYBzFP+Fl+4xHwLezVwjKeDVU CN4jqabRMnAcdc9z7iNdINf0gqDXv137jPpJ3Z9+/ONFHhe4mPIPxLY0ChOl7wIv arnLLvs/gTMVapFS60L8M/9bPVbT2275GIn1KoZDXyTQ6ySQoOANCfDx3RS/8gPS Ka2KKn4TYkr5cIV/bL+b8DQdFI8eGBJT255lVpR90Bc+EdD1dX2EfUvZRQhQAjvg SN52biPO+xB+pi+tg3/dRLZoaJW3ckGKq+c9LLjXCma/Yx4sdLR13rRlqjbASK8G mplHV4e6oyGM2jrom225tsWkl4vJCqpzcZOZKEVl9iihVBCpBVSiXHkBUaBbFojR hyame2bkbzzYW7CuphPfQZHgVByQrsOY/XLFDbsceU7dgFNEZ8cGt9Ylf499YNYw YDsA+YPNzqQP68U+qFhEXRpxG2yZJGWRgdKFmgig6QnUIecyD6PkLBhMOLPmT4K2 h6DsC3Bl/ONFTCJtzfASqQHeSvB1TYbpiyG3kgyK1jmfwNlVOMM= =q8sS -----END PGP SIGNATURE----- --Sig_/tF8x7S/e9az.9TKjK3.X7ti-- ------------=_1504684021-15708-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Aug 2017 06:17:34 +0000 Received: from localhost ([127.0.0.1]:33139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwJi-0000rc-BP for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmwJg-0000rN-Jl for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmwJa-0002bl-Dz for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmwJa-0002bc-AH for submit@debbugs.gnu.org; Wed, 30 Aug 2017 02:17:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmwJZ-00066V-61 for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmwJR-0002Zf-6y for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:22 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:55411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmwJR-0002ZT-0J for guix-patches@gnu.org; Wed, 30 Aug 2017 02:17:17 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 3D09F13D273; Wed, 30 Aug 2017 07:17:15 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 1A72213D272 for ; Wed, 30 Aug 2017 07:17:15 +0100 (BST) Date: Wed, 30 Aug 2017 07:17:14 +0100 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] Test and fix the ISO Image Installer Message-ID: <20170830071714.75f88e47@cbaines.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/8C64yxQAygrtxBFH+=Knl.6"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Sig_/8C64yxQAygrtxBFH+=Knl.6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hey, So at the GNU Hackers Meeting, I attempted to build the installer system as an ISO image, and test installing Guix on a Bytemark VM with this. I encountered problems, and therefore set about writing a system test to see if this could be reproduced. The failures did seem reproducible locally, and Ludo helped with some code changes. I'll send the work in progress patches to this bug. --Sig_/8C64yxQAygrtxBFH+=Knl.6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmmWGpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcfXw/4mzuu9gs9Rki31SrV6LmMxsaQN2ZT7HuEfDQQmX5Gu+74pVTgnbGveytW QFfRhfnfrtN702p86RTTpWE7vC6JNMzyHo4Qk8SCTCjuzuemTiMazCIB07UCa9lZ Vv3D6HcR8RgVuK4Y7PE86PgG4aRtprYn09Ie1OkDe/B/+4WRr/TVDOx9KKSRgFr9 jW+Ewo416nsbxn2QFgwUNkLQ/m0ikUH8ekaZ9vtIJIp1bGFKSY9aIG53ezfPOZud x3PvCt1sdU+Y/KCPIXVD96h6nzY1Bf2P62M3Ji4qam5wGor9ZCtAHFWjRAaTJnHv dKZQi6d1YrDyzUR9sshWhfYJmsymbHc/N0Kyq2ZAC4AZrBCLL2lxxdZIX3cdsvq7 0a6rxdZ63YE5UtatCNPK2jOLQM9BRWWjhWcFhgwfgqAz9Mu7UPgfk1/wZtJcSsum eQCoeJv5Ntax77WAtONQUO5TE9WCHRibZOYxaN/8hHOy1C9rQ7mwwONELLFGeTGl W3lcTnNn6I2BHTrd/auc5Bmx3c7rDCzsMmewqDY6LnKPjkg8UFN/cUxxB/EIVvrS +ysIv7NbNNs+r3BunGaE75DFkKOaqF2SgtSCP7Y42rMK/LvbAkJN6Ynmvbc4W+q3 O+gFXTZzGwPxs7mpaNFB9ZWocZqEXvtnEiQDvyYqXrr/Q+wSGg== =w858 -----END PGP SIGNATURE----- --Sig_/8C64yxQAygrtxBFH+=Knl.6-- ------------=_1504684021-15708-1-- From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Sep 2017 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.150470405523074 (code B ref 28288); Wed, 06 Sep 2017 13:21:01 +0000 Received: (at 28288) by debbugs.gnu.org; 6 Sep 2017 13:20:55 +0000 Received: from localhost ([127.0.0.1]:52478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpaGF-000606-7i for submit@debbugs.gnu.org; Wed, 06 Sep 2017 09:20:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpaGC-0005zs-Us for 28288@debbugs.gnu.org; Wed, 06 Sep 2017 09:20:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpaG6-0002wN-Sk for 28288@debbugs.gnu.org; Wed, 06 Sep 2017 09:20:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpaG6-0002wJ-PE; Wed, 06 Sep 2017 09:20:46 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=43566 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dpaG6-00006E-AA; Wed, 06 Sep 2017 09:20:46 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org> <20170906080515.4764be7b@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 20 Fructidor an 225 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 06 Sep 2017 15:20:44 +0200 In-Reply-To: <20170906080515.4764be7b@cbaines.net> (Christopher Baines's message of "Wed, 6 Sep 2017 08:05:32 +0100") Message-ID: <87wp5c0xqr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Baines skribis: > On Tue, 05 Sep 2017 15:17:32 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Hi! >>=20 >> Christopher Baines skribis: >>=20 >> > This mimics the functionality in the root-partition-initializer >> > used in creating the QEMU image. This helps when trying to run guix >> > system init from the generated ISO image. >> > >> > * gnu/build/vm.scm (make-iso9660-image): Add support for >> > registering closures.=20=20 >>=20 >> [...] >>=20 >> > + (when register-closures? >> > + (display "registering closures...\n") >> > + (for-each (lambda (closure) >> > + (register-closure >> > + "/tmp/root" >> > + (string-append "/xchg/" closure) >> > + #:deduplicate? #f)) >> > + closures))=20=20 >>=20 >> Was there any specific reason for #:deduplicate? #f here? > > Yep, the image creation process fails if this is not specified. > > error: cannot link > `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025r0= y6lqfs0' > to > `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firmwa= re/b43-open': > Invalid cross-device link Hmm, OK. Looks like it=E2=80=99s trying to deduplicate between /tmp/root a= nd some other store. (Or are we using a bind mount here?) > There is probably another way around this though. I'm not sure what > impact skipping the deduplication has on the size of the image. It probably doesn=E2=80=99t matter much, so it=E2=80=99s not a blocker IMO. Maybe leave an XXX comment mentioning the cross-device link issue. Thanks! Ludo=E2=80=99. From unknown Sun Jun 22 17:15:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to make-iso9660-image. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Sep 2017 10:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28288 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 28288@debbugs.gnu.org Received: via spool by 28288-submit@debbugs.gnu.org id=B28288.15050403376569 (code B ref 28288); Sun, 10 Sep 2017 10:46:01 +0000 Received: (at 28288) by debbugs.gnu.org; 10 Sep 2017 10:45:37 +0000 Received: from localhost ([127.0.0.1]:58435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqzk9-0001ht-FF for submit@debbugs.gnu.org; Sun, 10 Sep 2017 06:45:37 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:53111 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqzk6-0001hj-TC for 28288@debbugs.gnu.org; Sun, 10 Sep 2017 06:45:35 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 43ABA13E4A7; Sun, 10 Sep 2017 11:45:34 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (194.85.159.143.dyn.plus.net [143.159.85.194]) by mira.cbaines.net (Postfix) with ESMTPSA id 9FE2913E4A6; Sun, 10 Sep 2017 11:45:33 +0100 (BST) Date: Sun, 10 Sep 2017 11:45:32 +0100 From: Christopher Baines Message-ID: <20170910114532.58628283@cbaines.net> In-Reply-To: <87wp5c0xqr.fsf@gnu.org> References: <20170830071714.75f88e47@cbaines.net> <20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org> <20170906080515.4764be7b@cbaines.net> <87wp5c0xqr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/FhBGLbEj_ybSwWRQU=MXXi4"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/FhBGLbEj_ybSwWRQU=MXXi4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 06 Sep 2017 15:20:44 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > On Tue, 05 Sep 2017 15:17:32 +0200 > > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > =20 > >> Hi! > >>=20 > >> Christopher Baines skribis: > >> =20 > >> > This mimics the functionality in the root-partition-initializer > >> > used in creating the QEMU image. This helps when trying to run > >> > guix system init from the generated ISO image. > >> > > >> > * gnu/build/vm.scm (make-iso9660-image): Add support for > >> > registering closures. =20 > >>=20 > >> [...] > >> =20 > >> > + (when register-closures? > >> > + (display "registering closures...\n") > >> > + (for-each (lambda (closure) > >> > + (register-closure > >> > + "/tmp/root" > >> > + (string-append "/xchg/" closure) > >> > + #:deduplicate? #f)) > >> > + closures)) =20 > >>=20 > >> Was there any specific reason for #:deduplicate? #f here? =20 > > > > Yep, the image creation process fails if this is not specified. > > > > error: cannot link > > `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025= r0y6lqfs0' > > to > > `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firm= ware/b43-open': > > Invalid cross-device link =20 >=20 > Hmm, OK. Looks like it=E2=80=99s trying to deduplicate between /tmp/root= and > some other store. (Or are we using a bind mount here?) I think there is a bind mount in use here, so maybe that has something to do with it. > > There is probably another way around this though. I'm not sure what > > impact skipping the deduplication has on the size of the image. =20 >=20 > It probably doesn=E2=80=99t matter much, so it=E2=80=99s not a blocker IM= O. >=20 > Maybe leave an XXX comment mentioning the cross-device link issue. Yep, I'll put in a comment :) --Sig_/FhBGLbEj_ybSwWRQU=MXXi4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlm1F8xfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XewhQ/+LlfUZtsQ0zvNhcjJ0DCCK7uHbL27VgBnJhYbbq37WEWOjXTx8y2/MtTG 6o0KBhoudHLjy375ktzSpu9zfI76qFsHUiPbosB4XlelJWrfNZpjVCM8Ro4nmeFj Md+lmDbpCmVKsG1obwwPLvOHRYeziKv50tq5sNbgikvHOepBNgk6WMXiJ9QeiSl9 zT/VzOLXgpo6eIWY6/UYUUJfOqBbq3WUQiq3vDD8dmUViTE/2SMPUXYozeTo4iTL m7bFTcsf1mBc2SVKEze36IEtctmXG4CSl3wqPtQADtN44/FeVuEf4Nr80Xb+6eYl jlh2mA0NIZR9Qn22cuAs5Ovil41alLf5Yhwn3s655QTEMbY5tVsVMAoN4w+YdihR 7M7QcSrPnTtndCWcmRfuqkX4FwPgDGZHhId1obf6zjSrNNZKEIGUmNFqPgDHb4Mb QkASak5pser3OSNtWTgyicF9l4uPey24U1/iehgIwLni4dKh7Tc5fOki8mfkS7Eh t8Aw8Oh8n+ihNmgkP4ysDoLdCKQnxrS4vnfQN5Disc/TITvyK1z6pp0S5f5m7IgD d03qpls9DjmPvvVcJVKE+OK/q2GrtjCzOPzn534JHAa+07Fha7qUQTUieUGGiuTv Ody6GYXbvGJ3yabDXq1uW9OqXTGMjEnQMnRs0xWUhsVD3p20FfQ= =9AZJ -----END PGP SIGNATURE----- --Sig_/FhBGLbEj_ybSwWRQU=MXXi4--