From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Aug 2017 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 28285@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150404398823327 (code B ref -1); Tue, 29 Aug 2017 22:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Aug 2017 21:59:48 +0000 Received: from localhost ([127.0.0.1]:32981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmoXx-000648-F6 for submit@debbugs.gnu.org; Tue, 29 Aug 2017 17:59:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmoXv-00063i-5h for submit@debbugs.gnu.org; Tue, 29 Aug 2017 17:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmoXo-00075O-Oj for submit@debbugs.gnu.org; Tue, 29 Aug 2017 17:59:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmoXo-00075J-Kx for submit@debbugs.gnu.org; Tue, 29 Aug 2017 17:59:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmoXn-0003g2-4q for guix-patches@gnu.org; Tue, 29 Aug 2017 17:59:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmoXk-00073b-10 for guix-patches@gnu.org; Tue, 29 Aug 2017 17:59:35 -0400 Received: from lepiller.eu ([89.234.186.109]:39230 helo=localhost) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmoXj-00072U-N5 for guix-patches@gnu.org; Tue, 29 Aug 2017 17:59:31 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by localhost (OpenSMTPD) with ESMTPSA id 20853379 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Tue, 29 Aug 2017 21:59:29 +0000 (UTC) Date: Tue, 29 Aug 2017 23:58:29 +0200 From: Julien Lepiller Message-ID: <20170829235829.7a4f55cd@lepiller.eu> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/7R.4QRy/D=HKhgQnmuJNA=5" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --MP_/7R.4QRy/D=HKhgQnmuJNA=5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, this patch adds heimdall, a tool I just used to flash replicant on my smartphone :) --MP_/7R.4QRy/D=HKhgQnmuJNA=5 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-Add-heimdall.patch >From 415b94e8fc61fba9353094a3eceb22bb2a6563b6 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Tue, 29 Aug 2017 23:54:16 +0200 Subject: [PATCH] gnu: Add heimdall. * gnu/packages/android.scm (heimdall): New variable. --- gnu/packages/android.scm | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index be3f50add..93c3281dd 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -23,12 +23,16 @@ (define-module (gnu packages android) #:use-module (guix packages) #:use-module (guix git-download) + #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module ((guix licenses) #:prefix license:) #:use-module (gnu packages) + #:use-module (gnu packages compression) #:use-module (gnu packages gnupg) + #:use-module (gnu packages libusb) #:use-module (gnu packages python) + #:use-module (gnu packages qt) #:use-module (gnu packages ssh) #:use-module (gnu packages version-control) #:use-module (gnu packages tls)) @@ -399,3 +403,39 @@ parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.") (license license:asl2.0))) + +(define-public heimdall + (package + (name "heimdall") + (version "1.4.2") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/Benjamin-Dobell/Heimdall" + "/archive/v" version ".tar.gz")) + (sha256 + (base32 + "1y7gwg3lipyp2zcysm2vid1qg5nwin9bxbvgzs28lz2rya4fz6sq")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f; no tests + #:phases + (modify-phases %standard-phases + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (mkdir-p bin) + (copy-file "bin/heimdall" (string-append bin "/heimdall")) + (copy-file "bin/heimdall-frontend" + (string-append bin "/heimdall-frontend")))))))) + (inputs + `(("libusb" ,libusb) + ("qt" ,qt) + ("zlib" ,zlib))) + (home-page "http://glassechidna.com.au/heimdall/") + (synopsis "Flash firmware onto Samsung mobile devices") + (description "Heimdall is a tool suite used to flash firmware (aka ROMs) +onto Samsung mobile devices. Heimdall connects to a mobile device over USB and +interacts with low-level software running on the device, known as Loke. Loke +and Heimdall communicate via the custom Samsung-developed protocol typically +referred to as the 'Odin 3 protocol'.") + (license license:expat))) -- 2.14.1 --MP_/7R.4QRy/D=HKhgQnmuJNA=5-- From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: Jonathan Brielmaier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 08:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 28285@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150408082114100 (code B ref -1); Wed, 30 Aug 2017 08:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Aug 2017 08:13:41 +0000 Received: from localhost ([127.0.0.1]:33246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmy85-0003fM-Ar for submit@debbugs.gnu.org; Wed, 30 Aug 2017 04:13:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmy83-0003f9-N6 for submit@debbugs.gnu.org; Wed, 30 Aug 2017 04:13:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmy7x-00035o-SE for submit@debbugs.gnu.org; Wed, 30 Aug 2017 04:13:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44643) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmy7x-00035g-P8 for submit@debbugs.gnu.org; Wed, 30 Aug 2017 04:13:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmy7w-0007qa-OL for guix-patches@gnu.org; Wed, 30 Aug 2017 04:13:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmy7t-000348-KM for guix-patches@gnu.org; Wed, 30 Aug 2017 04:13:32 -0400 Received: from mout.web.de ([217.72.192.78]:49369) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmy7t-00033U-A4 for guix-patches@gnu.org; Wed, 30 Aug 2017 04:13:29 -0400 Received: from [192.168.178.21] ([95.208.248.62]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LqDQS-1dII4s2JYO-00dmDo for ; Wed, 30 Aug 2017 10:13:26 +0200 References: <20170829235829.7a4f55cd@lepiller.eu> From: Jonathan Brielmaier Message-ID: Date: Wed, 30 Aug 2017 10:13:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170829235829.7a4f55cd@lepiller.eu> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:scIJjtS0UhQWFip5z4m1PFysMQskvEFjxfABSmBQ7VSM8Udh9ky spmxGQ0wGbzzoJiRnBNh9OWSmDN0c2GFvNc1LvXHXLiAp43t2BM+vyHCovbgrrpH5PgDj6c oB+u/ravls/aduUctazz2tAhyXagyzf2ebXzTE8YWlwRhKUMxVMybKwiQw4HPgqDMqUhpNY dQJNtRBuBl7snvKdTifJw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5Al1Iu7RccA=:z7cWMFNqqDpWiL19ma+gun X+1ESxupaYyqmMQlu/suIMqKUWd3x3wbvLfvnHGnqh3+SUjcI8kiguUE7/4BPp4u5KJ4fFxXe jRLzWyMzqqZwQn/vV917z5cYvbDKxUyPWonYikHPmI0M8q3RC64kZALkE5dHOiBRj+XsnX/Fa gvNj+htBAkTGhXP+o+CJYkw0v0nlTGrXr2K8Qs5pC1IGdrwb5jVAg/rt4g/54DheCXuabEU5P GmDJz1mtAVwQhTjLTNCkGfcR0updmML+6xTPSnAxMV02mV39Pg2Tptyzok4Ng4hDeeOiJ43WJ kL3cJoBQZnUP5OK//EeVc4e8ZTjkLQ/X/+r+0WtebWOiEp/pAfHRMpRRDebOOfiyDSz5gpmaC 2xPXzd4eH0Ro77gM++9YL2Az+V4KHjtuEMm7+upIgUZ1I5jkm35PuUin1/kAxiTNjES3XFqO3 mUxkZGW/p2rsN/H59LLevhbnaOBt2oV19MmRgbfBR0SvPHWpKzsJhECIzdrfe2h31jsThe3j3 b+FJA/RnDDILTlKaoNMPdN2tXp1lHJjMCrRCciKY/c1KX9GSwCF4r5BqC3tlK01MLY7M1XN+/ DrYPhMrYhtpunSxegjyIlx92IdJ///8cldifAQ6ANyefyvnOgqcIVTkVWEu3bxAFWgR9FXk19 JVMDYY2jifwU2C6BgQPg91Rv6oPzV14aPKrdXKX1s35s30op1h07LfR6AbHddhMhy443G5vuf kPQsTGBmNDGCZGIX+YKJy16+wnY6ChpZRPsDqhbXJMf8brkKtGqaYUiS/ZArl9ib+6FQeOS9c w+qhL0N8GdJTjNiArJQ93pHPZeHE/Qz78w3P4zDGdiubR9Q7NA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Maybe we could do it in "flashing-tools.scm". Am 29.08.2017 um 23:58 schrieb Julien Lepiller: > Hi, > > this patch adds heimdall, a tool I just used to flash replicant on my > smartphone :) > From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Aug 2017 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller , 28285@debbugs.gnu.org Received: via spool by 28285-submit@debbugs.gnu.org id=B28285.150412115622904 (code B ref 28285); Wed, 30 Aug 2017 19:26:01 +0000 Received: (at 28285) by debbugs.gnu.org; 30 Aug 2017 19:25:56 +0000 Received: from localhost ([127.0.0.1]:35026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn8cd-0005xM-TP for submit@debbugs.gnu.org; Wed, 30 Aug 2017 15:25:56 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn8cb-0005xD-R2 for 28285@debbugs.gnu.org; Wed, 30 Aug 2017 15:25:54 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 363DA21CA2; Wed, 30 Aug 2017 15:25:53 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 30 Aug 2017 15:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=+LCK/tYAg434UmIlkvo8ce/P66NgTu0JGNDL9Jqk5 kw=; b=C1C4dmQJAsLvqS7jMOlJ54P2yVwEOO/38bzzfcP1CdYNsRbH8kOttSfz7 4wSkTGvkxL+yfjRwwUoByMwH5rL6hg614FWHXAyiLrcXDAG+3uIsLDAivsciYTWU 3UeWfC8nWiRsWvxksxuZP/pO3fXZuhFFj2XSYkqU1eq2KHVtl5nAHvjV9Udi7MGK esQ9RiVVcsiqyO8piANpw3+hYa58dMcUuxeUNvYNFCjXHT4nrm51EhAwoRojePao ppCMkjDTlWz/Ul24W9oqhFcJcuXCG4sCF6Vxc3OrZrGIYWCe6jmAvTRqDv6QC9Nv UoHbUxsuYhNlBP1aL3nIztuomopjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=+LCK/tYAg434UmIlkv o8ce/P66NgTu0JGNDL9Jqk5kw=; b=kuQv5ZK6Z2MzTQ3hIKEl8rMzJRd6U4PXrZ uiQ/wV/J1gpg0vsuBm20irr9QOGNJAAHyX6ocwI+WkwW+2IJUE/vsm8W6RfnRUHz HqioWwX24w50DcaJ+5q7oX47i9/Tcm3Ugd3x2V4jKG+o8VR/fTVOaw0AdErdXZQL ZekawseIsRscH634rDdeIHR7AAJgmimTsMsjVxPv82aPNUHbxABuKinhN1YOK4aC iIo6WEch7GhBSC+Det6zGU6nsbXLaYTW8OeNVgG+lsnQOeGOiiipaRS7sCkXVTPu 91x7BLLZ7I/ffTJ0kUgkqbiQ0zTEHMh7JBo81sOVUVz95mE+w46A== X-ME-Sender: X-Sasl-enc: clg4mLOmJsbdh8fGkQdOde2OAtkiwAHqQBkt1itQq2vR 1504121152 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id BD272240B1; Wed, 30 Aug 2017 15:25:52 -0400 (EDT) From: Marius Bakke In-Reply-To: <20170829235829.7a4f55cd@lepiller.eu> References: <20170829235829.7a4f55cd@lepiller.eu> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Wed, 30 Aug 2017 21:25:51 +0200 Message-ID: <87d17cluww.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Julien Lepiller writes: > Hi, > > this patch adds heimdall, a tool I just used to flash replicant on my > smartphone :) Cool! > * gnu/packages/android.scm (heimdall): New variable. I agree with Jonathan that 'flashing-tools.scm' is better suited. [...] > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) > + (mkdir-p bin) > + (copy-file "bin/heimdall" (string-append bin "/heimdall")) > + (copy-file "bin/heimdall-frontend" > + (string-append bin "/heimdall-frontend")))))))) (copy-file ...) has an unspecified return value[0], so please add a #t at the end of this phase for determinism. > + (inputs > + `(("libusb" ,libusb) > + ("qt" ,qt) Can you try to use the modular qt packages here (qtbase and friends), instead of the 'qt' monolith? The latter is not well maintained and will be removed eventually. > + ("zlib" ,zlib))) > + (home-page "http://glassechidna.com.au/heimdall/") > + (synopsis "Flash firmware onto Samsung mobile devices") > + (description "Heimdall is a tool suite used to flash firmware (aka ROMs) > +onto Samsung mobile devices. Heimdall connects to a mobile device over USB and > +interacts with low-level software running on the device, known as Loke. Loke > +and Heimdall communicate via the custom Samsung-developed protocol typically > +referred to as the 'Odin 3 protocol'.") `guix lint` should complain about the single quotes, no? Escaped double quotes are okay, though. LGTM with these cosmetic changes. [0] https://www.gnu.org/software/guile/manual/guile.html#File-System --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmnET8ACgkQoqBt8qM6 VPqQkQgAt5Rmtyc8ZpcSJZUIpUuZ3EMyd5D6vkLNd/ke88UD+Tt0Krt4SwUxhDTu 22KTVzwdBEs0HlJw30FOGdY1m42G79ee658GTYqk4R5GAaNPOJjB/bJ9YXp3Q0VA b0IZdRq/AmKCyl1JKeVRmnrasnRHI6LiCsY3686I4boW8Yu4JHi3xl6NzjSPOe92 WuFBjR6o/BVJIk/m/u5cRoYgfRThqKxHQ9fbz/FqtIrkEUxDTSX4+GUnbB+rQ4mn lilOoGtA20usMJq/jOZMaZRY0rJAqOn2u01wUEt8/tY6PtOiC1730Em/OssCuavO em+chLiGc/QgYFVJr7Q/dul5WhyrZQ== =5ebQ -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2017 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 28285@debbugs.gnu.org Received: via spool by 28285-submit@debbugs.gnu.org id=B28285.15044576646622 (code B ref 28285); Sun, 03 Sep 2017 16:55:02 +0000 Received: (at 28285) by debbugs.gnu.org; 3 Sep 2017 16:54:24 +0000 Received: from localhost ([127.0.0.1]:46661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doYA6-0001if-Kt for submit@debbugs.gnu.org; Sun, 03 Sep 2017 12:54:24 -0400 Received: from lepiller.eu ([89.234.186.109]:38718 helo=localhost) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doYA1-0001iS-Hx for 28285@debbugs.gnu.org; Sun, 03 Sep 2017 12:54:17 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by localhost (OpenSMTPD) with ESMTPSA id 6c096a23 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <28285@debbugs.gnu.org>; Sun, 3 Sep 2017 16:54:12 +0000 (UTC) Date: Sun, 3 Sep 2017 18:53:06 +0200 From: Julien Lepiller Message-ID: <20170903185259.4c056094@lepiller.eu> In-Reply-To: <87d17cluww.fsf@fastmail.com> References: <20170829235829.7a4f55cd@lepiller.eu> <87d17cluww.fsf@fastmail.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/RBuqsrDy+THuq8pnFq41TdJ" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Wed, 30 Aug 2017 21:25:51 +0200, Marius Bakke a =?UTF-8?Q?=C3=A9crit?= : > Julien Lepiller writes: > > > Hi, > > > > this patch adds heimdall, a tool I just used to flash replicant on > > my smartphone :) > > Cool! > > > * gnu/packages/android.scm (heimdall): New variable. > > I agree with Jonathan that 'flashing-tools.scm' is better suited. > > [...] Ok. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.com] 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Wed, 30 Aug 2017 21:25:51 +0200, Marius Bakke a =?UTF-8?Q?=C3=A9crit?= : > Julien Lepiller writes: > > > Hi, > > > > this patch adds heimdall, a tool I just used to flash replicant on > > my smartphone :) > > Cool! > > > * gnu/packages/android.scm (heimdall): New variable. > > I agree with Jonathan that 'flashing-tools.scm' is better suited. > > [...] Ok. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: pjrc.com] 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain --MP_/RBuqsrDy+THuq8pnFq41TdJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Le Wed, 30 Aug 2017 21:25:51 +0200, Marius Bakke a =C3=A9crit : > Julien Lepiller writes: >=20 > > Hi, > > > > this patch adds heimdall, a tool I just used to flash replicant on > > my smartphone :) =20 >=20 > Cool! >=20 > > * gnu/packages/android.scm (heimdall): New variable. =20 >=20 > I agree with Jonathan that 'flashing-tools.scm' is better suited. >=20 > [...] Ok. >=20 > > + (replace 'install > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((bin (string-append (assoc-ref outputs "out") > > "/bin"))) > > + (mkdir-p bin) > > + (copy-file "bin/heimdall" (string-append bin > > "/heimdall")) > > + (copy-file "bin/heimdall-frontend" > > + (string-append bin > > "/heimdall-frontend")))))))) =20 >=20 > (copy-file ...) has an unspecified return value[0], so please add a #t > at the end of this phase for determinism. Done. >=20 > > + (inputs > > + `(("libusb" ,libusb) > > + ("qt" ,qt) =20 >=20 > Can you try to use the modular qt packages here (qtbase and friends), > instead of the 'qt' monolith? The latter is not well maintained and > will be removed eventually. only qtbase is needed it seems. Done. >=20 > > + ("zlib" ,zlib))) > > + (home-page "http://glassechidna.com.au/heimdall/") > > + (synopsis "Flash firmware onto Samsung mobile devices") > > + (description "Heimdall is a tool suite used to flash firmware > > (aka ROMs) +onto Samsung mobile devices. Heimdall connects to a > > mobile device over USB and +interacts with low-level software > > running on the device, known as Loke. Loke +and Heimdall > > communicate via the custom Samsung-developed protocol typically > > +referred to as the 'Odin 3 protocol'.") =20 >=20 > `guix lint` should complain about the single quotes, no? Escaped > double quotes are okay, though. It doesn't. I'm not sure what you mean with escaped double quotes. \" or \\\"? >=20 > LGTM with these cosmetic changes. I had to change the import of licenses and license field of all packages because heimdall depends on zlib, which is also a license name. Should I mention that in the commit message too? Should it be in a separate commit? >=20 > [0] https://www.gnu.org/software/guile/manual/guile.html#File-System --MP_/RBuqsrDy+THuq8pnFq41TdJ Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-Add-heimdall.patch =46rom 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Tue, 29 Aug 2017 23:54:16 +0200 Subject: [PATCH] gnu: Add heimdall. * gnu/packages/flashing-tools.scm (heimdall): New variable. --- gnu/packages/flashing-tools.scm | 58 +++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.= scm index 127fc795a..ac19696ca 100644 --- a/gnu/packages/flashing-tools.scm +++ b/gnu/packages/flashing-tools.scm @@ -5,6 +5,7 @@ ;;; Copyright =C2=A9 2016 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2016 Efraim Flashner ;;; Copyright =C2=A9 2017 Jonathan Brielmaier +;;; Copyright =C2=A9 2017 Julien Lepiller ;;; ;;; This file is part of GNU Guix. ;;; @@ -22,19 +23,22 @@ ;;; along with GNU Guix. If not, see . =20 (define-module (gnu packages flashing-tools) - #:use-module (guix licenses) + #:use-module ((guix licenses) #:prefix license:) #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix packages) #:use-module (gnu packages) + #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (gnu packages bison) + #:use-module (gnu packages compression) #:use-module (gnu packages flex) #:use-module (gnu packages elf) #:use-module (gnu packages pkg-config) #:use-module (gnu packages libusb) #:use-module (gnu packages libftdi) #:use-module (gnu packages pciutils) + #:use-module (gnu packages qt) #:use-module (gnu packages autotools) #:use-module (gnu packages admin)) =20 @@ -81,7 +85,7 @@ verifying and erasing flash chips. It is designed to fla= sh BIOS/EFI/coreboot/firmware/optionROM images on mainboards, network/graphics/storage controller cards, and various other programmer devices.") - (license gpl2))) + (license license:gpl2))) =20 (define-public 0xffff (package @@ -112,7 +116,7 @@ programmer devices.") for FIASCO images. It supports generating, unpacking, editing and flashing of FIASCO images for Maemo devices. Use it with care. It can brick your device.") - (license gpl3+))) + (license license:gpl3+))) =20 (define-public avrdude (package @@ -140,7 +144,7 @@ brick your device.") "AVRDUDE is a utility to download/upload/manipulate the ROM and EEPROM contents of AVR microcontrollers using the in-system programming technique (ISP).") - (license gpl2+))) + (license license:gpl2+))) =20 (define-public dfu-programmer (package @@ -166,7 +170,7 @@ technique (ISP).") "Dfu-programmer is a multi-platform command-line programmer for Atmel (8051, AVR, XMEGA & AVR32) chips with a USB bootloader supporting ISP.") - (license gpl2+))) + (license license:gpl2+))) =20 (define-public dfu-util (package @@ -193,7 +197,7 @@ ranges from small devices like micro-controller boards = up to mobile phones. With dfu-util you are able to download firmware to your device or upload firmware from it.") (home-page "http://dfu-util.sourceforge.net/") - (license gpl2+))) + (license license:gpl2+))) =20 (define-public teensy-loader-cli ;; The repo does not tag versions nor does it use releases, but a commit @@ -244,7 +248,7 @@ HalfKay bootloader is running, so you can upload new pr= ograms and run them. You need to add the udev rules to make the Teensy update available for non-root users.") (home-page "https://www.pjrc.com/teensy/loader_cli.html") - (license gpl3)))) + (license license:gpl3)))) =20 (define-public rkflashtool (let ((commit "094bd6410cb016e487e2ccb1050c59eeac2e6dd1") @@ -278,4 +282,42 @@ non-root users.") (description "Allows flashing of Rockchip based embedded linux devic= es. The list of currently supported devices is: RK2818, RK2918, RK2928, RK3026, RK3036, RK3066, RK312X, RK3168, RK3188, RK3288, RK3368.") - (license bsd-2)))) + (license license:bsd-2)))) + +(define-public heimdall + (package + (name "heimdall") + (version "1.4.2") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/Benjamin-Dobell/Heim= dall" + "/archive/v" version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1y7gwg3lipyp2zcysm2vid1qg5nwin9bxbvgzs28lz2rya4fz6sq")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f; no tests + #:phases + (modify-phases %standard-phases + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (mkdir-p bin) + (copy-file "bin/heimdall" (string-append bin "/heimdall")) + (copy-file "bin/heimdall-frontend" + (string-append bin "/heimdall-frontend")) + #t)))))) + (inputs + `(("libusb" ,libusb) + ("qtbase" ,qtbase) + ("zlib" ,zlib))) + (home-page "http://glassechidna.com.au/heimdall/") + (synopsis "Flash firmware onto Samsung mobile devices") + (description "Heimdall is a tool suite used to flash firmware (aka ROM= s) +onto Samsung mobile devices. Heimdall connects to a mobile device over US= B and +interacts with low-level software running on the device, known as Loke. L= oke +and Heimdall communicate via the custom Samsung-developed protocol typical= ly +referred to as the \"Odin 3 protocol\".") + (license license:expat))) --=20 2.14.1 --MP_/RBuqsrDy+THuq8pnFq41TdJ-- From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Sep 2017 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 28285@debbugs.gnu.org Received: via spool by 28285-submit@debbugs.gnu.org id=B28285.150453499115937 (code B ref 28285); Mon, 04 Sep 2017 14:24:01 +0000 Received: (at 28285) by debbugs.gnu.org; 4 Sep 2017 14:23:11 +0000 Received: from localhost ([127.0.0.1]:48979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dosHO-00048z-NH for submit@debbugs.gnu.org; Mon, 04 Sep 2017 10:23:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dosHM-00048k-2y for 28285@debbugs.gnu.org; Mon, 04 Sep 2017 10:23:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dosHC-0000pW-3N for 28285@debbugs.gnu.org; Mon, 04 Sep 2017 10:23:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dosHB-0000pS-Uv; Mon, 04 Sep 2017 10:22:58 -0400 Received: from [193.50.110.184] (port=36154 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dosHB-0004hX-A3; Mon, 04 Sep 2017 10:22:57 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170829235829.7a4f55cd@lepiller.eu> <87d17cluww.fsf@fastmail.com> <20170903185259.4c056094@lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 Fructidor an 225 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 04 Sep 2017 16:22:55 +0200 In-Reply-To: <20170903185259.4c056094@lepiller.eu> (Julien Lepiller's message of "Sun, 3 Sep 2017 18:53:06 +0200") Message-ID: <87wp5ezgow.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, Julien Lepiller skribis: > I had to change the import of licenses and license field of all > packages because heimdall depends on zlib, which is also a license > name. Should I mention that in the commit message too? Should it be in > a separate commit? IMO it=E2=80=99s marginely better as a separate commit, but no big deal. > From 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Tue, 29 Aug 2017 23:54:16 +0200 > Subject: [PATCH] gnu: Add heimdall. > > * gnu/packages/flashing-tools.scm (heimdall): New variable. [...] > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/bin")= )) > + (mkdir-p bin) > + (copy-file "bin/heimdall" (string-append bin "/heimdall")) > + (copy-file "bin/heimdall-frontend" > + (string-append bin "/heimdall-frontend")) You can write these as: (install-file "bin/heimdall" bin) =E2=80=A6 and also remove (mkdir-p bin). OK with these changes! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 04:06:23 2017 Received: (at control) by debbugs.gnu.org; 7 Sep 2017 08:06:23 +0000 Received: from localhost ([127.0.0.1]:53799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dprpO-0002y9-Tu for submit@debbugs.gnu.org; Thu, 07 Sep 2017 04:06:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dprpN-0002xw-6I for control@debbugs.gnu.org; Thu, 07 Sep 2017 04:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dprpC-0000jr-NZ for control@debbugs.gnu.org; Thu, 07 Sep 2017 04:06:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dprpC-0000jj-Jx for control@debbugs.gnu.org; Thu, 07 Sep 2017 04:06:10 -0400 Received: from [193.50.110.57] (port=54502 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dprpC-0002rC-1t for control@debbugs.gnu.org; Thu, 07 Sep 2017 04:06:10 -0400 Date: Thu, 07 Sep 2017 10:06:08 +0200 Message-Id: <87r2vjylu7.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #28378 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 28378 28285 From unknown Mon Jun 23 07:53:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28285] Add heimdall Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Sep 2017 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28285 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 28285@debbugs.gnu.org Received: via spool by 28285-submit@debbugs.gnu.org id=B28285.15048745014044 (code B ref 28285); Fri, 08 Sep 2017 12:42:01 +0000 Received: (at 28285) by debbugs.gnu.org; 8 Sep 2017 12:41:41 +0000 Received: from localhost ([127.0.0.1]:55467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqIbN-00013A-9C for submit@debbugs.gnu.org; Fri, 08 Sep 2017 08:41:41 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqIbL-000132-SI for 28285@debbugs.gnu.org; Fri, 08 Sep 2017 08:41:40 -0400 Received: from localhost (unknown [193.170.94.190]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 72F1C1CA00D7; Fri, 8 Sep 2017 14:41:38 +0200 (CEST) Date: Fri, 8 Sep 2017 14:41:36 +0200 From: Danny Milosavljevic Message-ID: <20170908144136.5f4fbd8e@scratchpost.org> In-Reply-To: <20170829235829.7a4f55cd@lepiller.eu> References: <20170829235829.7a4f55cd@lepiller.eu> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Julien, On Tue, 29 Aug 2017 23:58:29 +0200 Julien Lepiller wrote: > this patch adds heimdall, a tool I just used to flash replicant on my > smartphone :) There are udev rules in ./heimdall/60-heimdall.rules which we might want to install too. And there's a libpit.a - not sure whether it makes sense to install it (whether it has public API). Thoughts?