From unknown Fri Jun 20 18:16:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28281 <28281@debbugs.gnu.org> To: bug#28281 <28281@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add os-prober. Reply-To: bug#28281 <28281@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:16:52 +0000 retitle 28281 [PATCH] gnu: Add os-prober. reassign 28281 guix-patches submitter 28281 Arun Isaac severity 28281 normal tag 28281 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 15:07:19 2017 Received: (at submit) by debbugs.gnu.org; 29 Aug 2017 19:07:19 +0000 Received: from localhost ([127.0.0.1]:32849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmlr4-0004ey-Sy for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:07:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmlr3-0004ek-3H for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:07:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmlqw-0000YD-Fr for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:07:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmlqw-0000Y9-CR for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:07:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmlqu-0001uf-RY for guix-patches@gnu.org; Tue, 29 Aug 2017 15:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmlqq-0000WP-JC for guix-patches@gnu.org; Tue, 29 Aug 2017 15:07:08 -0400 Received: from o125.p8.mailjet.com ([87.253.233.125]:40075) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmlqq-0000W3-71 for guix-patches@gnu.org; Tue, 29 Aug 2017 15:07:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=pr8tijZjZh0udCw8sU92A1A02mLzMk52dT6RDZbT0NA=; b=Y6lrrQYmUH8xZVNQ4UJZVBY2tzwsHtLS95Ii6EL2JnmtsykNkOvgvjrv3 si7Im9up3ksUUjpVPvBVXujG84/wWzET01WYhHf4ii/RLtpwnBgJZYolESuU uHD+wrIRb8MzH2L4MSsNDlGYJe2wBbZ/Atk1CDyfITuHPJISXqXmWA= Message-Id: From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] gnu: Add os-prober. Date: Wed, 30 Aug 2017 00:36:28 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAPIjTtawAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZpbtVyCYfvOSgTemX2K3e_AjVPAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/bootloaders.scm (os-prober): New variable. --- gnu/packages/bootloaders.scm | 66 ++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 66 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index f66d0bb3f..57d284be6 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -395,3 +395,69 @@ also initializes the boards (RAM etc).") =20 (define-public u-boot-odroid-c2 (make-u-boot-package "odroid-c2" "aarch64-linux-gnu")) + +(define-public os-prober + (package + (name "os-prober") + (version "1.76") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://debian/pool/main/o/os-prober/os-probe= r_" + version ".tar.xz")) + (sha256 + (base32 + "1vb45i76bqivlghrq7m3n07qfmmq4wxrkplqx8gywj011rhq19fk")))) + (build-system gnu-build-system) + (arguments + `(#:modules ((guix build gnu-build-system) + (guix build utils) + (ice-9 ftw) ; for ftw + (ice-9 regex) ; for string-match + (srfi srfi-2) ; for and-let* + (srfi srfi-26)) ; for cut + #:make-flags (list "CC=3Dgcc") + #:tests? #f ; no tests + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (substitute* (find-files ".") + (("/usr") (assoc-ref outputs "out"))) + (substitute* (find-files "." "50mounted-tests$") + (("mkdir") "mkdir -p")) + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (lib (string-append out "/lib")) + (share (string-append out "/share"))) + (for-each (cut install-file <> bin) + (list "linux-boot-prober" "os-prober")) + (install-file "newns" (string-append lib "/os-prober")) + (install-file "common.sh" (string-append share "/os-prober"= )) + (install-file "os-probes/mounted/powerpc/20macosx" + (string-append lib "/os-probes/mounted")) + (for-each + (lambda (directory) + (ftw directory + (lambda (file stat flag) + (when (eq? flag 'regular) + (and-let* ((result (or (string-match "/common/"= file) + (string-match "/x86/" fi= le)))) + (install-file + file (dirname + (string-append + lib "/" (substring file 0 (match:star= t result 0)) + (substring file (1- (match:end result= 0)))))))) + #t))) + (list "os-probes" "linux-boot-probes")) + #t)))))) + (home-page "https://joeyh.name/code/os-prober") + (synopsis "Detect other operating systems") + (description "os-prober probes disks on the system for other operating +systems so that they can be added to the bootloader. It also works out ho= w to +boot existing GNU/Linux systems and detects what distribution is installed= in +order to add a suitable bootloader menu entry.") + (license license:gpl2+))) --=20 2.13.4 = From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 15:20:16 2017 Received: (at 28281) by debbugs.gnu.org; 29 Aug 2017 19:20:16 +0000 Received: from localhost ([127.0.0.1]:32858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmm3c-00050L-5Z for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:20:16 -0400 Received: from o166.p8.mailjet.com ([87.253.233.166]:50297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <043754c7.AEMAPNAHSUQAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZpb5t@bnc3.mailjet.com>) id 1dmm3a-00050C-RS for 28281@debbugs.gnu.org; Tue, 29 Aug 2017 15:20:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=mQnPefX4AiR7QFXQH1+PmxFEzYwp8fjdjFq1n5W/5NA=; b=IstWf8wsEEyylEkhsMKyGW0w4B+PTTxFnDrqvOndqafJyD803vFQP6cdf dx8td4ktp2Wbyv5hXUjk5QeqhJDeXhsVHf0aCGwMiOZNvEldEDczA/AQPaP6 XOMnh0TYS2EHIs8ZYFrh7qnC4EcsU5tWsYpyCmrns956YXQPb0bqxA= Message-Id: <043754c7.AEMAPNAHSUQAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZpb5t@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 28281@debbugs.gnu.org Subject: Re: bug#28281: Acknowledgement ([PATCH] gnu: Add os-prober.) Date: Wed, 30 Aug 2017 00:49:38 +0530 In-reply-to: References: X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAPNAHSUQAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZpb5tHggU2FlLSlenh94S4r2F1wAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28281 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) It would be good if someone with a dual boot installation actually verifies that os-prober is able to detect the other operating system. I believe you just have to run os-prober as root without any command-line arguments. # os-prober More detailed instructions are in the README file of the source tarball. = From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 09:26:04 2017 Received: (at 28281) by debbugs.gnu.org; 31 Aug 2017 13:26:04 +0000 Received: from localhost ([127.0.0.1]:36535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnPTw-0000sK-G2 for submit@debbugs.gnu.org; Thu, 31 Aug 2017 09:26:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnPTu-0000rz-Bx for 28281@debbugs.gnu.org; Thu, 31 Aug 2017 09:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPTj-0004cc-KG for 28281@debbugs.gnu.org; Thu, 31 Aug 2017 09:25:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPTj-0004cW-9F; Thu, 31 Aug 2017 09:25:51 -0400 Received: from [193.50.110.184] (port=46338 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dnPTh-0000aA-QK; Thu, 31 Aug 2017 09:25:50 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [bug#28281] [PATCH] gnu: Add os-prober. References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 31 Aug 2017 15:25:48 +0200 In-Reply-To: (Arun Isaac's message of "Wed, 30 Aug 2017 00:36:28 +0530") Message-ID: <87lglzrhr7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi! Arun Isaac skribis: > * gnu/packages/bootloaders.scm (os-prober): New variable. [...] > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (lib (string-append out "/lib")) > + (share (string-append out "/share"))) > + (for-each (cut install-file <> bin) > + (list "linux-boot-prober" "os-prober")) > + (install-file "newns" (string-append lib "/os-prober")) > + (install-file "common.sh" (string-append share "/os-probe= r")) > + (install-file "os-probes/mounted/powerpc/20macosx" > + (string-append lib "/os-probes/mounted")) > + (for-each > + (lambda (directory) > + (ftw directory > + (lambda (file stat flag) > + (when (eq? flag 'regular) > + (and-let* ((result (or (string-match "/common= /" file) > + (string-match "/x86/" = file)))) > + (install-file > + file (dirname > + (string-append > + lib "/" (substring file 0 (match:st= art result 0)) > + (substring file (1- (match:end resu= lt 0)))))))) > + #t))) For clarity, what about (1) using =E2=80=98find-files=E2=80=99 instead of = =E2=80=98ftw=E2=80=99, and (2) separating code that builds the list of files from code that calls =E2=80=98install-file=E2=80=99? So something like: (define (candidate-files directory) (find-files directory (lambda (file stat) (and (eq? (stat:kind stat) 'regular) =E2=80=A6)))) (for-each (lambda (file) (install-file file =E2=80=A6)) (append-map candidate-files (list "os-probes" "linux-boot-probes"))) WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 13:41:46 2017 Received: (at 28281) by debbugs.gnu.org; 31 Aug 2017 17:41:46 +0000 Received: from localhost ([127.0.0.1]:37923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnTTO-00068w-B1 for submit@debbugs.gnu.org; Thu, 31 Aug 2017 13:41:46 -0400 Received: from o127.p8.mailjet.com ([87.253.233.127]:48020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnTTM-00068o-KH for 28281@debbugs.gnu.org; Thu, 31 Aug 2017 13:41:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=uonxJz3I4Q9OhyNYstMaixMI/qILysTWhR5We+ecPg4=; b=oAMCZktHLMBSGmwYOKnyQo9aG3dTm4/0X1gGrx35oXV/NBF3QVgRkVzID O23hSZr1TA2aEkIkv9XT7WOcb5pKfZsBCX7IYNpgMVjBkLaxDb9r8Zw90AjB 9EKDaQoop149j/thKrut25cF8zrWdP8oHY7YSNInv20E2RnDHqL58w= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: Ludovic =?iso-8859-1?q?Court=E8s?= Subject: Re: [bug#28281] [PATCH] gnu: Add os-prober. Date: Thu, 31 Aug 2017 23:11:26 +0530 In-reply-to: <87lglzrhr7.fsf@gnu.org> References: <87lglzrhr7.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAPWOEMfwAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZqEpX7QGeM0Q5RiioXou05W6MsgAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > For clarity, what about (1) using ‘find-files’ instead of ‘ftw’ I started with something like that and switched to `ftw' for slightly shorter code. But, I guess clarity is more important. > (2) separating code that builds the list of files from code that calls > ‘install-file’? Sure, will do. I'll send an updated patch with both changes incorporated. This package is really so messed up. I don't know why they couldn't have just provided us with a Makefile for installation. Sigh... From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 13:17:02 2017 Received: (at 28281) by debbugs.gnu.org; 9 Sep 2017 17:17:02 +0000 Received: from localhost ([127.0.0.1]:57754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqjNO-0002Nk-JP for submit@debbugs.gnu.org; Sat, 09 Sep 2017 13:17:02 -0400 Received: from o122.p8.mailjet.com ([87.253.233.122]:50820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <3627911f.AEEAQGfVIqcAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCIK@bnc3.mailjet.com>) id 1dqjNM-0002NF-6F for 28281@debbugs.gnu.org; Sat, 09 Sep 2017 13:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=iZWjQWOljNq7al1n0DoFe0rVAQkzV7PyALmWZsg/g/Y=; b=BpYjuelSA85ah9Uo95gPgzEyu+PXkjCipei7TbBVVGn1JKTAIrrAlHvJt cdxX1xqlKfZWuPVATfchIauxEEPP3WpnvUXTOMEwZqdfA8Redm6zqgbLOQkh jswC0C6CVxKMGsoYT5Ziyc96YeYGu2MPk4pNruovMNZfXSB4XmEpLc= Message-Id: <3627911f.AEEAQGfVIqcAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCIK@mailjet.com> From: Arun Isaac To: 28281@debbugs.gnu.org Subject: [PATCH] gnu: Add os-prober. Date: Sat, 9 Sep 2017 22:46:35 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAQGfVIqcAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCIKP4DHolW-TAeLE2PJOh7LzwAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28281 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/bootloaders.scm (os-prober): New variable. --- gnu/packages/bootloaders.scm | 69 ++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 69 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index f66d0bb3f..613537a5d 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -395,3 +395,72 @@ also initializes the boards (RAM etc).") =20 (define-public u-boot-odroid-c2 (make-u-boot-package "odroid-c2" "aarch64-linux-gnu")) + +(define-public os-prober + (package + (name "os-prober") + (version "1.76") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://debian/pool/main/o/os-prober/os-probe= r_" + version ".tar.xz")) + (sha256 + (base32 + "1vb45i76bqivlghrq7m3n07qfmmq4wxrkplqx8gywj011rhq19fk")))) + (build-system gnu-build-system) + (arguments + `(#:modules ((guix build gnu-build-system) + (guix build utils) + (ice-9 regex) ; for string-match + (srfi srfi-26)) ; for cut + #:make-flags (list "CC=3Dgcc") + #:tests? #f ; no tests + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (substitute* (find-files ".") + (("/usr") (assoc-ref outputs "out"))) + (substitute* (find-files "." "50mounted-tests$") + (("mkdir") "mkdir -p")) + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (define (find-files-non-recursive directory) + (find-files directory + (lambda (file stat) + (string-match (string-append "^" directory "/= [^/]*$") + file)) + #:directories? #t)) + + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (lib (string-append out "/lib")) + (share (string-append out "/share"))) + (for-each (cut install-file <> bin) + (list "linux-boot-prober" "os-prober")) + (install-file "newns" (string-append lib "/os-prober")) + (install-file "common.sh" (string-append share "/os-prober"= )) + (install-file "os-probes/mounted/powerpc/20macosx" + (string-append lib "/os-probes/mounted")) + (for-each + (lambda (directory) + (for-each + (lambda (file) + (let ((destination (string-append lib "/" directory + "/" (basename file)= ))) + (mkdir-p (dirname destination)) + (copy-recursively file destination))) + (append (find-files-non-recursive (string-append direct= ory "/common")) + (find-files-non-recursive (string-append direct= ory "/x86"))))) + (list "os-probes" "os-probes/mounted" "os-probes/init" + "linux-boot-probes" "linux-boot-probes/mounted")) + #t)))))) + (home-page "https://joeyh.name/code/os-prober") + (synopsis "Detect other operating systems") + (description "os-prober probes disks on the system for other operating +systems so that they can be added to the bootloader. It also works out ho= w to +boot existing GNU/Linux systems and detects what distribution is installed= in +order to add a suitable bootloader menu entry.") + (license license:gpl2+))) --=20 2.14.1 = From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 13:24:42 2017 Received: (at 28281) by debbugs.gnu.org; 9 Sep 2017 17:24:42 +0000 Received: from localhost ([127.0.0.1]:57761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqjUo-0002ZF-EC for submit@debbugs.gnu.org; Sat, 09 Sep 2017 13:24:42 -0400 Received: from o167.p8.mailjet.com ([87.253.233.167]:54828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <9ef18175.AEQAP00oGCsAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCPY@bnc3.mailjet.com>) id 1dqjUn-0002Z6-1n for 28281@debbugs.gnu.org; Sat, 09 Sep 2017 13:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=WjqXQZ3CllIAMLNXXkFeuRkLZZnmRDgCqYOml45rYH0=; b=KA7s3r7HsBSvDS7eehMwy4vA0FaFHdJjBV56dAXvFXZ4c/3cbDIRSpfOv +PmtQbmhZsnQyrG8TAyf81DWSbQdyS5wlS1l7Gx56KouC9U8lweM8TIXwVdr O6a/uyKfh+hd9Kdf2N/1PYq51Dlnvze1YoCCEuartAz3mAWpEhiYVI= Message-Id: <9ef18175.AEQAP00oGCsAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCPY@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 28281@debbugs.gnu.org Subject: Re: [PATCH] gnu: Add os-prober. Date: Sat, 09 Sep 2017 22:54:27 +0530 In-reply-to: <20170909171635.7968-1-arunisaac@systemreboot.net> References: <20170909171635.7968-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAP00oGCsAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtCPYohdqNrcvTfuFUsmmDptygAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28281 Cc: Ludovic =?iso-8859-1?q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Here's an updated patch. > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (define (find-files-non-recursive directory) > + (find-files directory > + (lambda (file stat) > + (string-match (string-append "^" directory = "/[^/]*$") > + file)) > + #:directories? #t)) Do you think it would be a good idea to add a #:recursive? keyword argument to `find-files' in (guix build utils), instead of creating this `find-files-non-recursive-function' here? > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (lib (string-append out "/lib")) > + (share (string-append out "/share"))) > + (for-each (cut install-file <> bin) > + (list "linux-boot-prober" "os-prober")) > + (install-file "newns" (string-append lib "/os-prober")) > + (install-file "common.sh" (string-append share "/os-probe= r")) > + (install-file "os-probes/mounted/powerpc/20macosx" > + (string-append lib "/os-probes/mounted")) > + (for-each > + (lambda (directory) > + (for-each > + (lambda (file) > + (let ((destination (string-append lib "/" directory > + "/" (basename fil= e)))) > + (mkdir-p (dirname destination)) > + (copy-recursively file destination))) > + (append (find-files-non-recursive (string-append dire= ctory "/common")) > + (find-files-non-recursive (string-append dire= ctory "/x86"))))) > + (list "os-probes" "os-probes/mounted" "os-probes/init" > + "linux-boot-probes" "linux-boot-probes/mounted")) > + #t)))))) I have used `find-files' instead of `ftw', as you suggested. The install procedure is clearer now. but still remains quite messy. It is not simple enough to separate the "candidate-files" and "install-file" logic. WDYT? Will the above code do? = From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 09:06:06 2017 Received: (at 28281) by debbugs.gnu.org; 10 Sep 2017 13:06:07 +0000 Received: from localhost ([127.0.0.1]:58557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr1w6-0006kr-NW for submit@debbugs.gnu.org; Sun, 10 Sep 2017 09:06:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr1w5-0006kM-90 for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 09:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr1vz-0000rG-8R for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 09:06:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr1vz-0000rC-4b; Sun, 10 Sep 2017 09:05:59 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=35274 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dr1vy-0005iP-La; Sun, 10 Sep 2017 09:05:59 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [PATCH] gnu: Add os-prober. References: <20170909171635.7968-1-arunisaac@systemreboot.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 10 Sep 2017 15:05:55 +0200 In-Reply-To: (Arun Isaac's message of "Sat, 09 Sep 2017 22:54:27 +0530") Message-ID: <874lsa900c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Heya, Arun Isaac skribis: > Here's an updated patch. > >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (define (find-files-non-recursive directory) >> + (find-files directory >> + (lambda (file stat) >> + (string-match (string-append "^" directory= "/[^/]*$") >> + file)) >> + #:directories? #t)) > > Do you think it would be a good idea to add a #:recursive? keyword > argument to `find-files' in (guix build utils), instead of creating this > `find-files-non-recursive-function' here? Hmm I didn=E2=80=99t understand that it *had* to be non-recursive. Does it really make a difference? If it does, then =E2=80=98scandir=E2=80=99 from (ice-9 ftw) would be the th= ing. Sorry if I led you in the wrong direction. :-/ >> + (let* ((out (assoc-ref outputs "out")) >> + (bin (string-append out "/bin")) >> + (lib (string-append out "/lib")) >> + (share (string-append out "/share"))) >> + (for-each (cut install-file <> bin) >> + (list "linux-boot-prober" "os-prober")) >> + (install-file "newns" (string-append lib "/os-prober")) >> + (install-file "common.sh" (string-append share "/os-prob= er")) >> + (install-file "os-probes/mounted/powerpc/20macosx" >> + (string-append lib "/os-probes/mounted")) >> + (for-each >> + (lambda (directory) >> + (for-each >> + (lambda (file) >> + (let ((destination (string-append lib "/" directory >> + "/" (basename fi= le)))) >> + (mkdir-p (dirname destination)) >> + (copy-recursively file destination))) >> + (append (find-files-non-recursive (string-append dir= ectory "/common")) >> + (find-files-non-recursive (string-append dir= ectory "/x86"))))) >> + (list "os-probes" "os-probes/mounted" "os-probes/init" >> + "linux-boot-probes" "linux-boot-probes/mounted")) >> + #t)))))) > > I have used `find-files' instead of `ftw', as you suggested. The install > procedure is clearer now. but still remains quite messy. It is not > simple enough to separate the "candidate-files" and "install-file" > logic. > > WDYT? Will the above code do? Sure. I mean, we should try our best to make things clearer, while not losing our hairs on it. Sometimes it just has to be messy. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 12:03:32 2017 Received: (at 28281) by debbugs.gnu.org; 10 Sep 2017 16:03:32 +0000 Received: from localhost ([127.0.0.1]:59526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr4hn-0002hG-U1 for submit@debbugs.gnu.org; Sun, 10 Sep 2017 12:03:32 -0400 Received: from o125.p8.mailjet.com ([87.253.233.125]:37842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr4hl-0002h6-M7 for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 12:03:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=59r0ys80Woh1vKvtlbkCnRwntl40m3T0D+EeoKVqCTk=; b=XVxPg8W39qHY1HSHXpFarrNXT3rFJOFRDshNAmFMoM2UhOddFQ069u9Ye zED0X3Kg+AQobz9EubRQ3k66sZxDfqaopvBLJcYGt4T4aeaPWTu9iSs5UAEe v4lMuTEzwHY8QJBe+IgRF//k4ylq2P1KZ8nIlcFIJI7cELR7SPKhfE= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: =?UTF-8?q?Ludovic_Court=C3=A8s?= Subject: Re: [PATCH] gnu: Add os-prober. Date: Sun, 10 Sep 2017 21:32:19 +0530 In-reply-to: <874lsa900c.fsf@gnu.org> References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: ADkAAC_e-_EAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtWITtFbJ_FQ6Ssq_tx03ryJxVAAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >>> + (replace 'install >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (define (find-files-non-recursive directory) >>> + (find-files directory >>> + (lambda (file stat) >>> + (string-match (string-append "^" directory "/[^/]*$") >>> + file)) >>> + #:directories? #t)) >> >> Do you think it would be a good idea to add a #:recursive? keyword >> argument to `find-files' in (guix build utils), instead of creating this >> `find-files-non-recursive-function' here? > > Hmm I didn’t understand that it *had* to be non-recursive. Does it > really make a difference? I am trying to do cp -r /some/directory/* destination To do this, I used `find-files-non-recursive' to get all files in /some/directory/ and applied `copy-recursively' on each one of them. Do you have a better way of doing this in mind? > If it does, then ‘scandir’ from (ice-9 ftw) would be the thing. Sorry > if I led you in the wrong direction. :-/ Yes, scandir could be used. But, it also returns "." and "..", and I'll have to filter them out. So code length, or clarity-wise, it won't be much of an improvement. That is why I thought adding a #:recursive? argument to `find-files' would be nice. >>> + (let* ((out (assoc-ref outputs "out")) >>> + (bin (string-append out "/bin")) >>> + (lib (string-append out "/lib")) >>> + (share (string-append out "/share"))) >>> + (for-each (cut install-file <> bin) >>> + (list "linux-boot-prober" "os-prober")) >>> + (install-file "newns" (string-append lib "/os-prober")) >>> + (install-file "common.sh" (string-append share "/os-prober")) >>> + (install-file "os-probes/mounted/powerpc/20macosx" >>> + (string-append lib "/os-probes/mounted")) >>> + (for-each >>> + (lambda (directory) >>> + (for-each >>> + (lambda (file) >>> + (let ((destination (string-append lib "/" directory >>> + "/" (basename file)))) >>> + (mkdir-p (dirname destination)) >>> + (copy-recursively file destination))) >>> + (append (find-files-non-recursive (string-append directory "/common")) >>> + (find-files-non-recursive (string-append directory "/x86"))))) >>> + (list "os-probes" "os-probes/mounted" "os-probes/init" >>> + "linux-boot-probes" "linux-boot-probes/mounted")) >>> + #t)))))) From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 16:41:47 2017 Received: (at 28281) by debbugs.gnu.org; 10 Sep 2017 20:41:47 +0000 Received: from localhost ([127.0.0.1]:59776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr935-0000m7-Fb for submit@debbugs.gnu.org; Sun, 10 Sep 2017 16:41:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr933-0000lv-UT for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 16:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr92x-0000LF-U5 for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 16:41:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr92x-0000L9-R1; Sun, 10 Sep 2017 16:41:39 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=35598 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dr92x-0001IH-9K; Sun, 10 Sep 2017 16:41:39 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [PATCH] gnu: Add os-prober. References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 10 Sep 2017 22:41:37 +0200 In-Reply-To: <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> (Arun Isaac's message of "Sun, 10 Sep 2017 21:32:19 +0530") Message-ID: <87k2165lry.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: >>>> + (replace 'install >>>> + (lambda* (#:key outputs #:allow-other-keys) >>>> + (define (find-files-non-recursive directory) >>>> + (find-files directory >>>> + (lambda (file stat) >>>> + (string-match (string-append "^" directo= ry "/[^/]*$") >>>> + file)) >>>> + #:directories? #t)) >>> >>> Do you think it would be a good idea to add a #:recursive? keyword >>> argument to `find-files' in (guix build utils), instead of creating this >>> `find-files-non-recursive-function' here? >> >> Hmm I didn=E2=80=99t understand that it *had* to be non-recursive. Does= it >> really make a difference? > > I am trying to do > > cp -r /some/directory/* destination > > To do this, I used `find-files-non-recursive' to get all files in > /some/directory/ and applied `copy-recursively' on each one of them. > > Do you have a better way of doing this in mind? Would (copy-recursively "/some/directory" destination) work for you? >> If it does, then =E2=80=98scandir=E2=80=99 from (ice-9 ftw) would be the= thing. Sorry >> if I led you in the wrong direction. :-/ > > Yes, scandir could be used. But, it also returns "." and "..", and I'll > have to filter them out. So code length, or clarity-wise, it won't be > much of an improvement. That is why I thought adding a #:recursive? > argument to `find-files' would be nice. Yeah, looks like none of the options is a perfect match. HTH, LUdo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 19:36:18 2017 Received: (at 28281) by debbugs.gnu.org; 10 Sep 2017 23:36:18 +0000 Received: from localhost ([127.0.0.1]:59969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drBly-00054H-5W for submit@debbugs.gnu.org; Sun, 10 Sep 2017 19:36:18 -0400 Received: from o137.p8.mailjet.com ([87.253.233.137]:51733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <24e1529f.AEAAPzHdNuUAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtcxv@bnc3.mailjet.com>) id 1drBlw-000548-TS for 28281@debbugs.gnu.org; Sun, 10 Sep 2017 19:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=tr/SirSHnWfnpc88ZSy76rY2x6zX0QcUvwjvTY9HAFk=; b=CN1AZ6qCHqp1vNXDb+56LnzmPpI6oNhI08L/FZJ4xwWHja49JKeM6aIX1 MB+blPfbyo27ByltcJI0rYtr/5cXIG3zljbunME8q1AB3/4U6Tplw/houU4Z fRHdMCSLlhPcOGvo5zhx32WjXNi+x3Tty329Gw8vDTTBc231tY9C58= Message-Id: <24e1529f.AEAAPzHdNuUAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Ludovic =?iso-8859-1?q?Court=E8s?= Subject: Re: [PATCH] gnu: Add os-prober. Date: Mon, 11 Sep 2017 05:05:54 +0530 In-reply-to: <87k2165lry.fsf@gnu.org> References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> <87k2165lry.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAPzHdNuUAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtcxvNmsTsf4KROS5-ZLNVSOaxAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> I am trying to do >> >> cp -r /some/directory/* destination >> >> To do this, I used `find-files-non-recursive' to get all files in >> /some/directory/ and applied `copy-recursively' on each one of them. >> >> Do you have a better way of doing this in mind? > > Would (copy-recursively "/some/directory" destination) work for you? No, it wouldn't. That would recreate /some/directory at the destination. I only want the files inside /some/directory to be copied, not /some/directory itself. = From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 03:28:43 2017 Received: (at 28281) by debbugs.gnu.org; 11 Sep 2017 07:28:43 +0000 Received: from localhost ([127.0.0.1]:60369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drJ98-0000zO-Js for submit@debbugs.gnu.org; Mon, 11 Sep 2017 03:28:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drJ96-0000zB-IM for 28281@debbugs.gnu.org; Mon, 11 Sep 2017 03:28:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drJ8y-0004GP-Au for 28281@debbugs.gnu.org; Mon, 11 Sep 2017 03:28:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drJ8y-0004GJ-74; Mon, 11 Sep 2017 03:28:32 -0400 Received: from [193.50.110.231] (port=35436 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1drJ8x-0003lu-Of; Mon, 11 Sep 2017 03:28:32 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [PATCH] gnu: Add os-prober. References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> <87k2165lry.fsf@gnu.org> <5dc91a20.AEAAPzHdNuYAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 11 Sep 2017 09:28:30 +0200 In-Reply-To: <5dc91a20.AEAAPzHdNuYAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> (Arun Isaac's message of "Mon, 11 Sep 2017 05:05:54 +0530") Message-ID: <87shftelsx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Arun, Arun Isaac skribis: >>> I am trying to do >>> >>> cp -r /some/directory/* destination >>> >>> To do this, I used `find-files-non-recursive' to get all files in >>> /some/directory/ and applied `copy-recursively' on each one of them. >>> >>> Do you have a better way of doing this in mind? >> >> Would (copy-recursively "/some/directory" destination) work for you? > > No, it wouldn't. That would recreate /some/directory at the > destination. I only want the files inside /some/directory to be copied, > not /some/directory itself. Ah sorry. Then yeah, either =E2=80=98scandir=E2=80=99 or =E2=80=98find-fil= es=E2=80=99, whichever you find is the least cumbersome. Feel free to push something along these lines! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 13:23:16 2017 Received: (at 28281) by debbugs.gnu.org; 11 Sep 2017 17:23:16 +0000 Received: from localhost ([127.0.0.1]:33917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drSQW-0000g5-1L for submit@debbugs.gnu.org; Mon, 11 Sep 2017 13:23:16 -0400 Received: from o126.p8.mailjet.com ([87.253.233.126]:39739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <5955a67b.AEAAP2Xyu20AAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtsaB@bnc3.mailjet.com>) id 1drSQU-0000fx-VQ for 28281@debbugs.gnu.org; Mon, 11 Sep 2017 13:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=12V/iyAjH6MGO2JZzM4YCwx3A/XtDqiZwhrAfTBIcyQ=; b=En5u7/MZCEPotKrh22QM5RHAqXsGh30QDzc1I/RBA6zQP7q1gjhj3Q0ZI ALP1x6etqaCzRbkIXoCyYlSCT5rCwXaiISdyLHddyvwKrpgTk3XKvvqM4JHo U29H1pt02wxd/if3H6PWuBK9a2GpmHfjB3wR7sVUnTAj0TuiqFBbcc= Message-Id: <5955a67b.AEAAP2Xyu20AAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtsaB@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Ludovic =?iso-8859-1?q?Court=E8s?= Subject: Re: [PATCH] gnu: Add os-prober. Date: Mon, 11 Sep 2017 22:53:03 +0530 In-reply-to: <87shftelsx.fsf@gnu.org> References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> <87k2165lry.fsf@gnu.org> <5dc91a20.AEAAPzHdNuYAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> <87shftelsx.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAP2Xyu20AAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZtsaBslnO3CV2Siybh8aUi-fB-AAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Would (copy-recursively "/some/directory" destination) work for you? >> >> No, it wouldn't. That would recreate /some/directory at the >> destination. I only want the files inside /some/directory to be copied, >> not /some/directory itself. > > Ah sorry. Then yeah, either ‘scandir’ or ‘find-files’, whichever you > find is the least cumbersome. > > Feel free to push something along these lines! Not sure I follow you. Should I 1. push the patch I sent most recently OR 2. or add a #:recursive? argument to `find-files', and push a patch which uses this new `find-files'? IMO, approach 2 is a better idea, though it could be that we are adding too many keyword arguments to `find-files'. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 16:21:14 2017 Received: (at 28281) by debbugs.gnu.org; 11 Sep 2017 20:21:14 +0000 Received: from localhost ([127.0.0.1]:34120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drVCk-0004wE-CF for submit@debbugs.gnu.org; Mon, 11 Sep 2017 16:21:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drVCj-0004w2-78 for 28281@debbugs.gnu.org; Mon, 11 Sep 2017 16:21:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drVCY-0007Nf-9V for 28281@debbugs.gnu.org; Mon, 11 Sep 2017 16:21:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVCY-0007NY-5t; Mon, 11 Sep 2017 16:21:02 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=40144 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1drVCX-0000vK-Lc; Mon, 11 Sep 2017 16:21:02 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: [PATCH] gnu: Add os-prober. References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> <87k2165lry.fsf@gnu.org> <5dc91a20.AEAAPzHdNuYAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> <87shftelsx.fsf@gnu.org> <207deec4.AEAAP2Xyu24AAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtsaB@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 11 Sep 2017 22:20:59 +0200 In-Reply-To: <207deec4.AEAAP2Xyu24AAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtsaB@mailjet.com> (Arun Isaac's message of "Mon, 11 Sep 2017 22:53:03 +0530") Message-ID: <87a821aswk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28281 Cc: 28281@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: >>>> Would (copy-recursively "/some/directory" destination) work for you? >>> >>> No, it wouldn't. That would recreate /some/directory at the >>> destination. I only want the files inside /some/directory to be copied, >>> not /some/directory itself. >> >> Ah sorry. Then yeah, either =E2=80=98scandir=E2=80=99 or =E2=80=98find-= files=E2=80=99, whichever you >> find is the least cumbersome. >> >> Feel free to push something along these lines! > > Not sure I follow you. Should I > > 1. push the patch I sent most recently > > OR > > 2. or add a #:recursive? argument to `find-files', and push a patch > which uses this new `find-files'? > > IMO, approach 2 is a better idea, though it could be that we are adding > too many keyword arguments to `find-files'. > > WDYT? I=E2=80=99m for approach #1, go for it! :-) Approach #2 would take a full rebuild, and it would make =E2=80=98find-file= s=E2=80=99 equivalent to =E2=80=98scandir=E2=80=99, so not worth it IMO. Sorry for being unclear! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 13 19:22:45 2017 Received: (at 28281-done) by debbugs.gnu.org; 13 Sep 2017 23:22:45 +0000 Received: from localhost ([127.0.0.1]:39069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsGzV-0008CD-6t for submit@debbugs.gnu.org; Wed, 13 Sep 2017 19:22:45 -0400 Received: from o174.p8.mailjet.com ([87.253.233.174]:56427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <4809643e.AEAAP-oSfhoAAAAAAAAAAAPrGxQAAAACwQwAAAAAAAW9WABZub3B@bnc3.mailjet.com>) id 1dsGzS-0008C5-R0 for 28281-done@debbugs.gnu.org; Wed, 13 Sep 2017 19:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=kvlIfz5OWouc5eza2WkeMN6+UmQueD2sADmroBxlr1o=; b=QtAoMoFw3qIYEEXZIiQ2or9c89+YssUwC7fYH1hj1bkza9dHPLqKBiUTP uQ0QHB8EYBDDzgrgrb6Xj/1Ot/XU9m7sp4XCW/mUtjcrVCih7L0+eAUUARBC YEvA8zirZjYWb76KAicY1PyXTJypSwy4yk2hrVxjC1oTaYp7pGUk6A= Message-Id: <4809643e.AEAAP-oSfhoAAAAAAAAAAAPrGxQAAAACwQwAAAAAAAW9WABZub3B@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 28281-done@debbugs.gnu.org Subject: Re: [PATCH] gnu: Add os-prober. Date: Thu, 14 Sep 2017 04:52:30 +0530 In-reply-to: <87a821aswk.fsf@gnu.org> References: <20170909171635.7968-1-arunisaac@systemreboot.net> <874lsa900c.fsf@gnu.org> <403302d1.ADkAAC_e-_IAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtWIT@mailjet.com> <87k2165lry.fsf@gnu.org> <5dc91a20.AEAAPzHdNuYAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtcxv@mailjet.com> <87shftelsx.fsf@gnu.org> <207deec4.AEAAP2Xyu24AAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZtsaB@mailjet.com> <87a821aswk.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAP-oSfhoAAAAAAAAAAAPrGxQAAAACwQwAAAAAAAW9WABZub3BGOswcH8FRIWHqK1rm4XgJAAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 28281-done Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) >> Should I >> >> 1. push the patch I sent most recently >> >> OR >> >> 2. or add a #:recursive? argument to `find-files', and push a patch >> which uses this new `find-files'? >> >> IMO, approach 2 is a better idea, though it could be that we are adding >> too many keyword arguments to `find-files'. >> >> WDYT? > > I’m for approach #1, go for it! :-) Ok, pushed! From unknown Fri Jun 20 18:16:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Oct 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator