GNU bug report logs - #28274
[PATCH] gnu: Add fold-packages-in-modules.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28274 <at> debbugs.gnu.org
Subject: [bug#28274] [PATCH] gnu: Add fold-packages-in-modules.
Date: Fri, 1 Sep 2017 19:20:26 +0100

[Message part 1 (text/plain, inline)]

On Fri, 01 Sep 2017 11:08:56 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > On Thu, 31 Aug 2017 15:20:55 +0200
> > ludo <at> gnu.org (Ludovic Courtès) wrote:
> >  
> >> Instead of introducing a new procedure, what about simply:
> >> 
> >> 
> >> diff --git a/gnu/packages.scm b/gnu/packages.scm
> >> index 562906178..b4ac6661c 100644
> >> --- a/gnu/packages.scm
> >> +++ b/gnu/packages.scm
> >> @@ -140,17 +140,19 @@ for system '~a'")
> >>                directory))
> >>          %load-path)))
> >>  
> >> -(define (fold-packages proc init)
> >> -  "Call (PROC PACKAGE RESULT) for each available package, using
> >> INIT as -the initial value of RESULT.  It is guaranteed to never
> >> traverse the -same package twice."
> >> +(define* (fold-packages proc init
> >> +                        #:optional
> >> +                        (modules (all-modules
> >> (%package-module-path))))
> >> +  "Call (PROC PACKAGE RESULT) for each available package defined
> >> in one of +MODULES, using INIT as the initial value of RESULT.  It
> >> is guaranteed to never +traverse the same package twice."
> >>    (fold-module-public-variables (lambda (object result)
> >>                                    (if (and (package? object)
> >>                                             (not (hidden-package?
> >> object))) (proc object result)
> >>                                        result))
> >>                                  init
> >> -                                (all-modules
> >> (%package-module-path))))
> >> +                                modules))
> >>  
> >>  (define find-packages-by-name
> >>    (let ((packages (delay
> >> 
> >> 
> >> ?  
> >
> > This looks great. Are you set to push it up, or shall I?  
> 
> Pushed, thanks!

Awesome, thanks Ludo :)

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.