From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 15:48:00 2017 Received: (at submit) by debbugs.gnu.org; 28 Aug 2017 19:48:00 +0000 Received: from localhost ([127.0.0.1]:59709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmQ0s-0000NP-Ga for submit@debbugs.gnu.org; Mon, 28 Aug 2017 15:47:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmQ0r-0000NB-7d for submit@debbugs.gnu.org; Mon, 28 Aug 2017 15:47:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmQ0l-0000ZJ-8i for submit@debbugs.gnu.org; Mon, 28 Aug 2017 15:47:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmQ0l-0000ZA-4T for submit@debbugs.gnu.org; Mon, 28 Aug 2017 15:47:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmQ0j-0001fI-Su for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 15:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmQ0j-0000Xl-0W for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 15:47:49 -0400 Received: from mail-qk0-x22e.google.com ([2607:f8b0:400d:c09::22e]:37629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmQ0i-0000WF-QW for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 15:47:48 -0400 Received: by mail-qk0-x22e.google.com with SMTP id k126so6875224qkb.4 for ; Mon, 28 Aug 2017 12:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=KoVWqyaDFJBm44aVJq91N7oaybXNAltf2IqiOFaYFb0=; b=GpQrTMfFCKpD1LESEA4Bo9hvI+5e8guFjdPlPFWwxGZJKFCUvDyi4RSX2miMUwWDIu 3MU6NXFoGkbkROrpKDx3rR+FmIhUgY+FMFQACHxjqcPFHdV2OzxOFSe0C1zNVqOVcevY Y99xCrQU7pbLGZqZQhq5AexaGEltmwU9/ohpjntH54QCVUEg0ICxOSgpDqB2wkPbR6Z0 hjqMH8GjmJofdrzrjYxHp2qBa101/ijjYJE+huUWcdAQgZ6KrurMd23Dx7r8BfPpHHHM VdWRn+j+DTi1xpTbcjklu8M2gfQwG9hn+D11mrwjAtKXoZj9ulvlB0NC2tDb7GSIql/7 fV3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=KoVWqyaDFJBm44aVJq91N7oaybXNAltf2IqiOFaYFb0=; b=r7AN7rrxkcbAAz5ymrrNGRvdfW0GpBLP3FllhT98M7ULCXe1ND3FWxenfIL2XTkBYb +yOGHG9Sy9Bsaj8swwgCSE5b1IxTXwm8R8muhrXcJ4azez/lEVyxJYqDY27OcKiRgD0z cgZERp9hyCCAjfOa+dBw+j5qx+R8YtVOy8J3dBCKpPP0FICfKRoWB7CGYszyZ+CzqCRL wa0NSvtBkjoq3nspNYrmi0Gm+XXiaoslx4vmqUXaQDBRHbJdjHkC7iG9aDEhGPhHYtVy HikUD1NemBqpD3oeZiXN7OUUoY5ypHB5tjWHdFroDNyLoEzVmXuDPPwQ/gy6epPECU2x 6aww== X-Gm-Message-State: AHYfb5iJitZ1SeglDeasWsOwE6c1BS+B5kHNDzxFAehYxcBgLJ75mpgy D+Y9tKP3/AXPTSEA X-Received: by 10.55.154.138 with SMTP id c132mr2265306qke.135.1503949664999; Mon, 28 Aug 2017 12:47:44 -0700 (PDT) Received: from Sam-laptop ([2001:470:1f07:57:1523:fc47:d9a:f47f]) by smtp.gmail.com with ESMTPSA id p64sm725538qkd.94.2017.08.28.12.47.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Aug 2017 12:47:41 -0700 (PDT) From: Samuel Bronson To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Perhaps `semantic-format-tag-custom-list' should use `function-item' types? Date: Mon, 28 Aug 2017 15:47:13 -0400 Message-ID: <877exnxyny.fsf@Sam-laptop> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain So, I was customizing the `speedbar' group, and I happened to notice that the entries for `semantic-sb-button-format-tag-function' and `semantic-sb-info-format-tag-function' offered extremely little in the way of documentation, and while the docstrings for those variables could do a better job of describing the contexts to which they are relevant, the main difficulty is in knowing what the various choices mean. A quick look in the vicinity of the functions' definitions revealed the variable `semantic-format-tag-custom-list', which turns out to be where the :type for those two settings comes from. It is defined as follows: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline Content-Transfer-Encoding: quoted-printable (defvar semantic-format-tag-custom-list (append '(radio) (mapcar (lambda (f) (list 'const f)) semantic-format-tag-functions) '(function)) "A List used by customizable variables to choose a tag to text function. Use this variable in the :type field of a customizable variable.") --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It turns out that the documentation for `radio' types explicitly mentions what we probably want here: ,---- | =E2=80=98(radio ELEMENT-TYPES...)=E2=80=99 | This is similar to =E2=80=98choice=E2=80=99, except that the choices= are displayed | using radio buttons rather than a menu. This has the advantage of | displaying documentation for the choices when applicable and so is | often a good choice for a choice between constant functions | (=E2=80=98function-item=E2=80=99 customization types). `---- So it looks like we want to change the definition to: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline Content-Transfer-Encoding: quoted-printable (defvar semantic-format-tag-custom-list (append '(radio) (mapcar (lambda (f) (list 'function-item f)) semantic-format-tag-functions) '(function)) "A List used by customizable variables to choose a tag to text function. Use this variable in the :type field of a customizable variable.") --=-=-= Content-Type: text/plain Or, in patch form, --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: Patch --- a/lisp/cedet/semantic/format.el +++ b/lisp/cedet/semantic/format.el @@ -67,7 +67,7 @@ (defvar semantic-format-tag-custom-list (append '(radio) - (mapcar (lambda (f) (list 'const f)) + (mapcar (lambda (f) (list 'function-item f)) semantic-format-tag-functions) '(function)) "A List used by customizable variables to choose a tag to text function. Diff finished. Mon Aug 28 15:42:17 2017 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 15 07:42:50 2019 Received: (at 28267) by debbugs.gnu.org; 15 Jul 2019 11:42:50 +0000 Received: from localhost ([127.0.0.1]:46718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmzNZ-0008M5-V5 for submit@debbugs.gnu.org; Mon, 15 Jul 2019 07:42:50 -0400 Received: from quimby.gnus.org ([80.91.231.51]:41310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmzNY-0008Lw-K2 for 28267@debbugs.gnu.org; Mon, 15 Jul 2019 07:42:48 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmzNU-0006Pq-Iy; Mon, 15 Jul 2019 13:42:46 +0200 From: Lars Ingebrigtsen To: Samuel Bronson Subject: Re: bug#28267: 26.0.50; Perhaps `semantic-format-tag-custom-list' should use `function-item' types? References: <877exnxyny.fsf@Sam-laptop> Date: Mon, 15 Jul 2019 13:42:44 +0200 In-Reply-To: <877exnxyny.fsf@Sam-laptop> (Samuel Bronson's message of "Mon, 28 Aug 2017 15:47:13 -0400") Message-ID: <878sszcymj.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Samuel Bronson writes: > (defvar semantic-format-tag-custom-list > (append '(radio) > - (mapcar (lambda (f) (list 'const f)) > + (mapcar (lambda (f) (list 'function-item f)) > semantic-format-tag-functions) > '(function)) > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28267 Cc: 28267@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Samuel Bronson writes: > (defvar semantic-format-tag-custom-list > (append '(radio) > - (mapcar (lambda (f) (list 'const f)) > + (mapcar (lambda (f) (list 'function-item f)) > semantic-format-tag-functions) > '(function)) > "A List used by customizable variables to choose a tag to text function. Thanks; makes sense. I've now applied it to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 15 07:43:31 2019 Received: (at control) by debbugs.gnu.org; 15 Jul 2019 11:43:31 +0000 Received: from localhost ([127.0.0.1]:46722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmzOF-0008NK-8Z for submit@debbugs.gnu.org; Mon, 15 Jul 2019 07:43:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:41330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmzOD-0008ND-IE for control@debbugs.gnu.org; Mon, 15 Jul 2019 07:43:29 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmzOA-0006Q3-VN for control@debbugs.gnu.org; Mon, 15 Jul 2019 13:43:28 +0200 Date: Mon, 15 Jul 2019 13:43:26 +0200 Message-Id: <877e8jcyld.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #28267 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 28267 fixed close 28267 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 28267 fixed close 28267 27.1 quit From unknown Wed Sep 10 20:08:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 13 Aug 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator